From patchwork Fri Aug 10 17:05:13 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rob Herring X-Patchwork-Id: 143950 Delivered-To: patch@linaro.org Received: by 2002:a2e:9754:0:0:0:0:0 with SMTP id f20-v6csp191063ljj; Fri, 10 Aug 2018 10:05:18 -0700 (PDT) X-Google-Smtp-Source: AA+uWPwCWSL/K6X8y+NO5JT2v2V1Bqg/Ek5amdUn9tw55KBzvlug/lb3JoNuQEsNyBaGcLHsCk4G X-Received: by 2002:a62:6cc7:: with SMTP id h190-v6mr7926387pfc.113.1533920718513; Fri, 10 Aug 2018 10:05:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533920718; cv=none; d=google.com; s=arc-20160816; b=SizhdE2LevEBVVFuRuGrgkp2c9bADEdwMMHuj9gZ5sQHA0fVITkPzej59uA+nX7+1Z Xn3MRM99jjt9CSshZE18ELEeuk9JpEFpPJWzBHxq3NwYfgf0GYohxnzyQo5P/Eush+bH jOs2KUSYfeyIWKenHMJvGarJ0uvk0HMmZgnjsQ0nSzR3Ckcviw3xaFBriZCnlq5AOU2l JSEYlWxoFNYz9IQPkVw6+WPZXmxA3u/NBSL5GVUeQT0542/Jp52wS4WaprSrDWosmheU Z19ExTimO9LIxcSNZ0NgSfNtqugsgQlbuQ+VH7/njIVI36j9SI5tE5nQz26nlCH7ed6O hOCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=X0eRFU4tLLKJ8DmW3ZsuHf2IqvnzKp8H4GzaKdW6xKs=; b=Bm76GIu2DbkW2uiTbIN8dwFVs9m8Mu8FJjA2TgsO2Jn2i2JpCmofiWwUQuYF7Vh3+3 6IVOm4eZMYDvfaSf9HSXFoCmpWboanGGaUFONqnzZumlaNp+dT4jaraNCkUdR7XaW5pN wEPEheE3CO5GL0h/0Ii+hd7hXSnq6MuQOn5+iPsRKv482yie3HfbxLsQS4QFpWGpitFk 9eImvLMrfO2QgvmTDvZYSgOfceKYL/n/wG0S9uRkUySck8yd6DQNgBgf+mOMc8ZVu5e4 +Fyjev0T0dd1RQd6lV0BP64dlyXZcnO3R6e0LJ8YmWflWi1RdQgPgUivAAC4Ygh+wmsW zIXQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i4-v6si9333784pgd.657.2018.08.10.10.05.18; Fri, 10 Aug 2018 10:05:18 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728376AbeHJTf5 (ORCPT + 31 others); Fri, 10 Aug 2018 15:35:57 -0400 Received: from mail-io0-f194.google.com ([209.85.223.194]:40230 "EHLO mail-io0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727381AbeHJTf5 (ORCPT ); Fri, 10 Aug 2018 15:35:57 -0400 Received: by mail-io0-f194.google.com with SMTP id l14-v6so8226353iob.7 for ; Fri, 10 Aug 2018 10:05:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=X0eRFU4tLLKJ8DmW3ZsuHf2IqvnzKp8H4GzaKdW6xKs=; b=mDkjUSQAt/Mrj25KYhLaFulFwzGfnI4nvl5rrFYseVGlV1p7avjm0Y6uq2WCqahLyC jtKtOvYF8ODE0JD0LCsJwCtOe2+D2d22XO4HUOe4mcV6CDagzv6RS9vDAJIwLRLH1NhV bDWpxNu3pl9yQdqdWoIs8R3oCil4NcLW+/v1Tav2M1XzMwJndOkYEi1kcKF3nG26YhAb arAkAAS4MFeSMc/iPyH5t2c5Z2R+jcT3oNpqa+7bisRP/f8H6VtbD3oL9nqx8sFvS8Dj 0WWJX0Wj52GUeRJCiT/zXv+YhwT6Eat4yggN8lM3KW98qP4vOHeZKGv4saIZ2jK1SDsd GLWw== X-Gm-Message-State: AOUpUlFwrbkiGx11fLNfJGeyxAdauIdpZe60rtZ0kV4aSHPc7blBT+Ah Ae9e2CxfbEYJmebddj796DoQ8MU= X-Received: by 2002:a6b:ec0f:: with SMTP id c15-v6mr6219418ioh.18.1533920715296; Fri, 10 Aug 2018 10:05:15 -0700 (PDT) Received: from localhost.localdomain ([24.51.61.72]) by smtp.googlemail.com with ESMTPSA id z195-v6sm7294096ioe.38.2018.08.10.10.05.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 10 Aug 2018 10:05:14 -0700 (PDT) From: Rob Herring To: Joe Perches Cc: linux-kernel@vger.kernel.org, Andrew Morton , Andy Whitcroft Subject: [PATCH v2] checkpatch: DT bindings should be a separate patch Date: Fri, 10 Aug 2018 11:05:13 -0600 Message-Id: <20180810170513.26284-1-robh@kernel.org> X-Mailer: git-send-email 2.17.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Devicetree bindings should be their own patch as documented in Documentation/devicetree/bindings/submitting-patches.txt section I.1. This is because bindings are logically independent from a driver implementation, they have a different maintainer (even though they often are applied via the same tree), and it makes for a cleaner history in the DT only tree created with git-filter-branch. Cc: Andy Whitcroft Cc: Joe Perches Signed-off-by: Rob Herring --- v2: - Add doc pointer to warning - Simplify logic Joe, this makes $is_binding_patch an empty value when the regex doesn't match rather than 0 which would be more logical IMO. It seems to work fine, but I'm not sure if there's a better way to do it. scripts/checkpatch.pl | 14 ++++++++++++++ 1 file changed, 14 insertions(+) -- 2.17.1 diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index a9c05506e325..f9aba4bc41ce 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2236,6 +2236,7 @@ sub process { our $clean = 1; my $signoff = 0; my $is_patch = 0; + my $is_binding_patch = -1; my $in_header_lines = $file ? 0 : 1; my $in_commit_log = 0; #Scanning lines before patch my $has_commit_log = 0; #Encountered lines before patch @@ -2485,6 +2486,19 @@ sub process { $check = $check_orig; } $checklicenseline = 1; + + if ($realfile !~ /^MAINTAINERS/) { + my $last_binding_patch = $is_binding_patch; + + $is_binding_patch = ($realfile =~ m@^(?:Documentation/devicetree/|include/dt-bindings/)@); + + if (($last_binding_patch != -1) && + ($last_binding_patch ^ $is_binding_patch)) { + WARN("DT_SPLIT_BINDING_PATCH", + "DT binding docs and includes should be a separate patch. See: Documentation/devicetree/bindings/submitting-patches.txt"); + } + } + next; }