From patchwork Mon Aug 13 10:29:21 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Nuno_Gon=C3=A7alves?= X-Patchwork-Id: 144022 Delivered-To: patch@linaro.org Received: by 2002:a2e:9754:0:0:0:0:0 with SMTP id f20-v6csp2957396ljj; Mon, 13 Aug 2018 04:13:07 -0700 (PDT) X-Google-Smtp-Source: AA+uWPwS+1OCmue45K9c4olwDI3ZnRaVLDwBNVTM2ublRLo/o25YIaQ4zvvkCWZ3/MN1TQjCQwYH X-Received: by 2002:aa7:d2cd:: with SMTP id k13-v6mr22040186edr.311.1534158787359; Mon, 13 Aug 2018 04:13:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1534158787; cv=none; d=google.com; s=arc-20160816; b=hlF/RydJ9A4DGdMz77So2QjFTLfPKSFecFXZkD8AcjRXGlvoyCu49PSOD8K8F8nzOm M2XYcPUlx7ah80DtK0IyaMKxBFeWhSuvW/ixsR3SQw2Tx04XvY7vWtf8vcR8Q2Dv1w36 Kic3T73Lc5Vap4ijGv+MB28M8LW8x/ya04WQzdPRPY9Bpv1pThdf2peS+G2nhkjpm6GA NZpDk96EWUEg/Hl67FMC+p5BkeW0vxpzgpBXkLrb8peZqUnhDVmNFdUrlQiOopFfRyzj mQXxCg9wC0UE13w75I9ee4xdGk2uoMXEx5IuWAGeabRoxtPJLj3780cJdC78lGrR/+aI bFsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :to:message-id:date:from:mime-version:dkim-signature :arc-authentication-results; bh=P7O0xJAb0cblVHfNga6JV2vcevPOeeCtjFLKKrFQVzg=; b=NS7R5xoJob51TCzlp7JODo4jOiA/kU9LnK6J4t1gWrR/np4aNXlA6Oa53frJg9aXTw CjJROcZGKJzvqxfZMzIjrshQbVEsj2rX6TrtR0nef+o0fGhZ9OS/psknzs4n8VbjT9dm yt8O+0hLovkhDH/FjXVHvPgxw2zLizXpHARFpN3sePXbI1LcQy5NRJQOorYNvIn0VpEU HyA0jxOrN/vhc/K19l7AQPsJ3rNGrHkM/KPBauVZA6nRvEV9lMNqmUDpbcK8+alPtdqW a92A+PtLIh9LLOm4NtCVffyLD5OVmS6jebyTjf8K7gXbMH4+WErlvlDlT9NcFN8zDIwG j8aQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=d04VU1qr; spf=pass (google.com: best guess record for domain of u-boot-bounces@lists.denx.de designates 81.169.180.215 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from lists.denx.de (dione.denx.de. [81.169.180.215]) by mx.google.com with ESMTP id j58-v6si1067392ede.10.2018.08.13.04.13.07; Mon, 13 Aug 2018 04:13:07 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of u-boot-bounces@lists.denx.de designates 81.169.180.215 as permitted sender) client-ip=81.169.180.215; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=d04VU1qr; spf=pass (google.com: best guess record for domain of u-boot-bounces@lists.denx.de designates 81.169.180.215 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: by lists.denx.de (Postfix, from userid 105) id EF0E4C21E30; Mon, 13 Aug 2018 11:12:18 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=FREEMAIL_FROM, RCVD_IN_MSPIKE_H2, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id E1434C21E12; Mon, 13 Aug 2018 11:11:21 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id B99D6C21DFD; Mon, 13 Aug 2018 10:29:36 +0000 (UTC) Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by lists.denx.de (Postfix) with ESMTPS id 42B77C21E96 for ; Mon, 13 Aug 2018 10:29:34 +0000 (UTC) Received: by mail-wr1-f68.google.com with SMTP id u12-v6so13800636wrr.4 for ; Mon, 13 Aug 2018 03:29:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=5KjBrrTw7k/l0rpo1QU/VgUzvCaxT5Ip9kkYkHR8IM8=; b=d04VU1qrNWZ2kYH6WGu+PlJXc3a/Q7Us0A25uWwisUGDMLBhESwdPKCWhpyMmunG7p 88pwdU6esLJs5Uxaewz0M0Sd9sG+dXo1S0EhI3BpUdwnH1uLkjvB5Bxa9Xh4VoVEiuRl fDIju6rT+n4v47ah2f94zgoa6FNgb8PoFHFosMokBmwG4MW7MMguuELEoiEn1MzJNKVY bFMY0wKzPbXznbUbDGRQ1LpJssTO/B33v4PLih3t1MV6H6gGXEyZ6GkqntktL5lm9II+ byK/LE8a7pKi23XcwWsySl3MAacB2GK2bneRSEw0Jff31kbPwgzCVs8/4u1/ykzgOnRK fcCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=5KjBrrTw7k/l0rpo1QU/VgUzvCaxT5Ip9kkYkHR8IM8=; b=XRKzUP4pGQ79N7PiPwzpPGP08ciAIILTvKvH517R0jr3VwqSwK8VCtJqRClEwC3VYx 9ZTG/hGYM/7wv7nGXJEUryzqkGq5vGtpI78P7DWvdmWLQTyd3RadCz0Ll0Izn30do4/7 SJYOBV+4tc9uebxpb4EfQBAXKpij/ZqyzVa/dG5w2aw/QLqq8JurGihAs4bfBLuCaRw4 PPT8RLdr5lXc1aPkx/yPrkKWCTlhhAtXm7UlqfchY+gl9NVj4blKUVe+Gr+wkz6rONGT uuo1OCLI27QdxRfW2ZGz/HW1LGFUygM67e0DZBWMm4achldrT8QIwKNZi9jmy6JOEHvg ZcCg== X-Gm-Message-State: AOUpUlF6MMqF4RbqRIQ+fh+6+Xq/L9Pc3uQjiIt1Ng+vV4UUf/SBkVr/ BFWyXEKkmF474gwaabCKMTtCoMo6PxMBk12mpW3rYpOl X-Received: by 2002:adf:806d:: with SMTP id 100-v6mr10411879wrk.23.1534156173539; Mon, 13 Aug 2018 03:29:33 -0700 (PDT) MIME-Version: 1.0 From: =?utf-8?q?Nuno_Gon=C3=A7alves?= Date: Mon, 13 Aug 2018 12:29:21 +0200 Message-ID: To: u-boot@lists.denx.de, jagan@amarulasolutions.com X-Mailman-Approved-At: Mon, 13 Aug 2018 11:11:17 +0000 X-Content-Filtered-By: Mailman/MimeDel 2.1.18 Subject: [U-Boot] sunxi: USB gadget does not work on H2+ after 92a30692b2b18f45aae6fdaae38d67ed03dd2d11 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" After this commit usb gadget does not work anymore for me on the Orange Pi Zero (H2+). Thanks, Nuno commit 92a30692b2b18f45aae6fdaae38d67ed03dd2d11 Author: Jagan Teki Date: Fri Jul 20 12:34:20 2018 +0530 phy: sun4i-usb: Call phy_passby even for PHY#0 On newer Allwinner SoC, there is a pair of EHCI/OHCI USB hosts for OTG host mode. USB PHY passby must be configured for its corresponding PHY. so we can call for PHY#0. on the other hand in past usb-phy code the same thing can be restricted for Lower SoC's, other than H3/H5/A64. Now there is no need to restrict usb passby since the phy driver is DT enabled, and the respective phy calls will trigger based DT information initiated by the drivers. Signed-off-by: Jagan Teki Tested-by: Jagan Teki diff --git a/drivers/phy/allwinner/phy-sun4i-usb.c b/drivers/phy/allwinner/phy-sun4i-usb.c index 2b3cf48025..01f585a283 100644 --- a/drivers/phy/allwinner/phy-sun4i-usb.c +++ b/drivers/phy/allwinner/phy-sun4i-usb.c @@ -300,8 +300,7 @@ static int sun4i_usb_phy_init(struct phy *phy) data->cfg->disc_thresh, PHY_DISCON_TH_LEN); } - if (usb_phy->id != 0) - sun4i_usb_phy_passby(phy, true); + sun4i_usb_phy_passby(phy, true); sun4i_usb_phy0_reroute(data, true);