From patchwork Tue Aug 14 14:25:39 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Brown X-Patchwork-Id: 144173 Delivered-To: patch@linaro.org Received: by 2002:a2e:9754:0:0:0:0:0 with SMTP id f20-v6csp4429666ljj; Tue, 14 Aug 2018 07:25:48 -0700 (PDT) X-Google-Smtp-Source: AA+uWPwhIPqLMbo5RJfpGzGFAuPgmtscD4C3Juy5oreiAwj59DvzXFZlc9D53LIdaPkrqIlvo45C X-Received: by 2002:adf:820a:: with SMTP id 10-v6mr13977304wrb.144.1534256748302; Tue, 14 Aug 2018 07:25:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1534256748; cv=none; d=google.com; s=arc-20160816; b=HxdLSJaXFTVfyVMHouq70Y9Fvx1spc+EN6aRu+NpQ7czG+kTOM8KaB9mD05fL84vUO zSPyC6dQHCL3c/M9nTWPVVMftudaSXG+oM12tYY16F9uivKgfsrKr8/7xOCcv4v1vXWK JURG5X1ogtR7+NaphMiyy8eu5nmGuNKXaXFAk9dXaqpX5eo0IXNH1V3gAP73lsy5ObXi cccfTygLJxlETW2eS4PA8c4RU2UaYexQ4InQRIvQL7i2kEvORIbuY9Enma4pI2tF0eZa F/7xTEVS5Ri7ZGn06kWmpI9xed6hHbQ/O3MZN696e4TswnzzDfcDc/ch8xa7RIvwawTh 3D+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:cc:date:message-id:in-reply-to:to:from :dkim-signature:delivered-to:arc-authentication-results; bh=7V76ndc6b8fZoeIsh7syUmPKWoQoMwU36QsbtT4fhFE=; b=aR+nuEq4qKRgtQHrVdWtDzZlWco+g5lIeoxQNF+Brrdtua8n912f50c/9i7SKQCGHj nPFBpvJwPDaOQXZZX+3OrpJOzYJZHbnAhFP3Kyp4Pik+BAZgcrEWQS8mD/RIsQKsc9vA wOZ5n8wzDHC3QAzpCBvtGDTR0QDCIRurqnuAw+XjceR68RTpmkPmupusQErD5VKf7hQq xrc8tOYh69QA7/r/n3xciI1JiCXk3chmjVEGfrVn2EK8PFf49oz7xxEI5te975Lxu+uB dBTvMDN4KmVoKzbv9U17OYtU2xQRXOGDh2hqP8z4osc1KW16+kk6MwYiHXJbNNFKD5kd Th6A== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=ARMl6YK3; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from alsa0.perex.cz (alsa0.perex.cz. [77.48.224.243]) by mx.google.com with ESMTP id x10-v6si13395083wro.438.2018.08.14.07.25.48; Tue, 14 Aug 2018 07:25:48 -0700 (PDT) Received-SPF: pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) client-ip=77.48.224.243; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=ARMl6YK3; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 34B0326782B; Tue, 14 Aug 2018 16:25:46 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id C109B26781F; Tue, 14 Aug 2018 16:25:43 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail1.perex.cz X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=disabled version=3.4.0 Received: from heliosphere.sirena.org.uk (heliosphere.sirena.org.uk [172.104.155.198]) by alsa0.perex.cz (Postfix) with ESMTP id C8E6126781F for ; Tue, 14 Aug 2018 16:25:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=Date:Message-Id:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner: List-Archive; bh=jBuZFo8Qjzvljr7SNUm1rKC3OqRyDIGOkAM3lOXMZ4k=; b=ARMl6YK3p0CX Jspx493b3h8cS+NCc6ukHXOUxFS4+I8I7vBkd7tEwLNYEokwB8pfZeopuiakS95Gzh/gVOtWuQ5nY K+J6QOiLfiIr8U587umrE2pTJZ4sb0IPIeZAhCijq4flSe9VV2qeqk6GYTvJGzdy+i198miFz67eR Cmrks=; Received: from cpc102320-sgyl38-2-0-cust46.18-2.cable.virginm.net ([82.37.168.47] helo=debutante.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpa (Exim 4.89) (envelope-from ) id 1fpaGS-0000sv-5H; Tue, 14 Aug 2018 14:25:40 +0000 Received: by debutante.sirena.org.uk (Postfix, from userid 1000) id DADB41124449; Tue, 14 Aug 2018 15:25:39 +0100 (BST) From: Mark Brown To: Robert Rosengren In-Reply-To: <20180813073359.3374-1-robertr@axis.com> Message-Id: <20180814142539.DADB41124449@debutante.sirena.org.uk> Date: Tue, 14 Aug 2018 15:25:39 +0100 (BST) Cc: Mark Brown , Lars-Peter Clausen , Robert Rosengren , Liam Girdwood , alsa-devel@alsa-project.org Subject: [alsa-devel] Applied "ASoC: adau17x1: Unused exported functions changed to internal" to the asoc tree X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org The patch ASoC: adau17x1: Unused exported functions changed to internal has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From 164c0f6454186d1b0e22c27dfe3d3d59fc80f979 Mon Sep 17 00:00:00 2001 From: Robert Rosengren Date: Mon, 13 Aug 2018 09:33:58 +0200 Subject: [PATCH] ASoC: adau17x1: Unused exported functions changed to internal adau17x1_setup_firmware and adau17x1_has_dsp is only used internally, so making them static instead of exported. Change-Id: I4882513ab457966b0371ac2c1024550ca6edbe0c Signed-off-by: Robert Rosengren Acked-by: Lars-Peter Clausen Signed-off-by: Mark Brown --- sound/soc/codecs/adau17x1.c | 9 +++++---- sound/soc/codecs/adau17x1.h | 4 ---- 2 files changed, 5 insertions(+), 8 deletions(-) -- 2.18.0 _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel diff --git a/sound/soc/codecs/adau17x1.c b/sound/soc/codecs/adau17x1.c index 57169b8ff14e..2f2afb4c0c88 100644 --- a/sound/soc/codecs/adau17x1.c +++ b/sound/soc/codecs/adau17x1.c @@ -60,6 +60,9 @@ static const struct snd_kcontrol_new adau17x1_controls[] = { SOC_ENUM("Mic Bias Mode", adau17x1_mic_bias_mode_enum), }; +static int adau17x1_setup_firmware(struct snd_soc_component *component, + unsigned int rate); + static int adau17x1_pll_event(struct snd_soc_dapm_widget *w, struct snd_kcontrol *kcontrol, int event) { @@ -313,7 +316,7 @@ static const struct snd_soc_dapm_route adau17x1_no_dsp_dapm_routes[] = { { "Capture", NULL, "Right Decimator" }, }; -bool adau17x1_has_dsp(struct adau *adau) +static bool adau17x1_has_dsp(struct adau *adau) { switch (adau->type) { case ADAU1761: @@ -324,7 +327,6 @@ bool adau17x1_has_dsp(struct adau *adau) return false; } } -EXPORT_SYMBOL_GPL(adau17x1_has_dsp); static int adau17x1_set_dai_pll(struct snd_soc_dai *dai, int pll_id, int source, unsigned int freq_in, unsigned int freq_out) @@ -836,7 +838,7 @@ bool adau17x1_volatile_register(struct device *dev, unsigned int reg) } EXPORT_SYMBOL_GPL(adau17x1_volatile_register); -int adau17x1_setup_firmware(struct snd_soc_component *component, +static int adau17x1_setup_firmware(struct snd_soc_component *component, unsigned int rate) { int ret; @@ -880,7 +882,6 @@ int adau17x1_setup_firmware(struct snd_soc_component *component, return ret; } -EXPORT_SYMBOL_GPL(adau17x1_setup_firmware); int adau17x1_add_widgets(struct snd_soc_component *component) { diff --git a/sound/soc/codecs/adau17x1.h b/sound/soc/codecs/adau17x1.h index e6fe87beec07..98a3b6f5bc96 100644 --- a/sound/soc/codecs/adau17x1.h +++ b/sound/soc/codecs/adau17x1.h @@ -68,10 +68,6 @@ int adau17x1_resume(struct snd_soc_component *component); extern const struct snd_soc_dai_ops adau17x1_dai_ops; -int adau17x1_setup_firmware(struct snd_soc_component *component, - unsigned int rate); -bool adau17x1_has_dsp(struct adau *adau); - #define ADAU17X1_CLOCK_CONTROL 0x4000 #define ADAU17X1_PLL_CONTROL 0x4002 #define ADAU17X1_REC_POWER_MGMT 0x4009