From patchwork Fri Jun 25 23:49:03 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Andersson X-Patchwork-Id: 467070 Delivered-To: patch@linaro.org Received: by 2002:a02:c94a:0:0:0:0:0 with SMTP id u10csp1964151jao; Fri, 25 Jun 2021 16:50:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw74thHK97Cjqbe4pHr9GXnAoc3EYnpuHzb0e52bTYbCI5gn0AKTvfNAhm2RyAuqkIt5Y+d X-Received: by 2002:aa7:c2d8:: with SMTP id m24mr18236467edp.65.1624665015589; Fri, 25 Jun 2021 16:50:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624665015; cv=none; d=google.com; s=arc-20160816; b=RtCy6LYtEM5TAjVN0+FGh4g/4zDyEonN83wFcL4PFu2Z5WHhMOB9LtB+I5hgIkOfgQ O4RuuqNdy7mRjFuLuvnvi6kB2FiVZY985kp7wnN+XYTpkB8wQEZolZmW5IvbIRgj+vpc /IrB9JLk7Xl0UmDiAhZ5JCWNoAIdOL86VBVnAcHozhrmXhF9Benc+wrmOpwu5bXLVs1l jkBZhF58fTZq8z3cuWXeVKMuEeVAfSHElzJPkOQv/CtEGhwlWSLnVt7AQaXvxeDcQHrq +CKRuDMJ9jejR7eAEvdUt0QCch7NqrDsQhMR4/Gid15b8aoobG2gzN3ohory6IoCbC6O lOfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=I34DkDhLMaQ/IyLbrDClxn0QZlzBHTfOEHBz/yqlVfc=; b=ZPQ4y4aMOq0FMpc9LtmPoVk1A7qImqIpkJH83djxmxa2Mp84fBw+vE8ziXdleKf9H+ apd+7RmXKS1NO+E2spxQ+JJ0j2VIikcwM8iMuMmU36NADuYWQzB6c0/4uEDZvFCEQ/dz 5FWql38bN3wphk9JdQt0gcOpm91Co0Nn3fU7nf2VeB5k7T2Xyc9eJGH87Os0EEftHfz6 ARq86CG09+ApLQp0qKEE+vNCJOE8fczi+jGwWR0xN4Hj1nZb1hl8ywfmYZ/sLy2g5Apc igzVqQzTRDEY0DwJvN83c74MNIyEGVAOGUce+J7eSI1ZbHhgTk7VYuQItRkdGxQipAFa Kj+w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="wfjj0O/B"; spf=pass (google.com: domain of linux-pm-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-pm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z96si7676580ede.577.2021.06.25.16.50.15; Fri, 25 Jun 2021 16:50:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-pm-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="wfjj0O/B"; spf=pass (google.com: domain of linux-pm-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-pm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229864AbhFYXwf (ORCPT + 8 others); Fri, 25 Jun 2021 19:52:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40902 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229844AbhFYXwf (ORCPT ); Fri, 25 Jun 2021 19:52:35 -0400 Received: from mail-ot1-x329.google.com (mail-ot1-x329.google.com [IPv6:2607:f8b0:4864:20::329]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 41D61C061574 for ; Fri, 25 Jun 2021 16:50:13 -0700 (PDT) Received: by mail-ot1-x329.google.com with SMTP id i12-20020a05683033ecb02903346fa0f74dso11134295otu.10 for ; Fri, 25 Jun 2021 16:50:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=I34DkDhLMaQ/IyLbrDClxn0QZlzBHTfOEHBz/yqlVfc=; b=wfjj0O/BibC4pWY5gur3PvLflfcyoYaAOeM3UxN6Xisgx/cH6d2jktONw480QDdXUI M8qqhGDOFzE3l2kMi64/+1mtfaYabD7j4LGtbShPO9Zv8nt5+/nauNCnRmpyu2TSsc8I ZLwydVAWCbE6hqgfzg+ZqKZhr2zLykmHdtvE61I7a1FngDJvu6zkUNnSExnSEqbR58Dy jE+j6vrnpw8YYCDY2xYOGKByZmzviYoBTizD5CbPtuxb2gsTDaRz2V27Q/sNbddt5//Z yp1kOjzkMYIGvFxJjCrrqTOOJ2cmbtGZmhJ6fmuttGFzdGiRlufIlyiI4tGMSunbG2fs Yw2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=I34DkDhLMaQ/IyLbrDClxn0QZlzBHTfOEHBz/yqlVfc=; b=gmdIGYaf4sCWNp/zo5zuYB/nWI5JkI9TU6rShPPMR+R+ZXsYrMt23DpUMg0agI+XSa gmQ8IXkTua0C6wH0dlx5cLOBA2pRng2eOUbDI8Ges95B5iO2BAgrjWW35abq0EulGNGL WVAPkIWRnC5iOGoc+pbTUifkWnj0IHFFAsCMMkhHSFzr5TCF8R1eYrozeDpYO6uw1qCP WlNhGa5rjP04+qn/tJipJ+pEihD+xbPDoIMXC4hFHZ2hi60U9A50RKqLM4gJ2TCz2Vvt Y8BghAS0hcSWa7OS1WQcKJPjNOdHEWVSGMlgbZ1KXFIjqPW2cXl66JQRvjAU+QyoPvNV l/1w== X-Gm-Message-State: AOAM533YBonB1FDPzDrJW3hPv8f4kKtK+ZU9z5pSuwy0XweeG5vjnwn+ rqSjXlRZ+gkMgmtJgOENCYgfPA== X-Received: by 2002:a05:6830:2112:: with SMTP id i18mr8342838otc.332.1624665012671; Fri, 25 Jun 2021 16:50:12 -0700 (PDT) Received: from localhost.localdomain (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id c205sm1654814oib.20.2021.06.25.16.50.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Jun 2021 16:50:12 -0700 (PDT) From: Bjorn Andersson To: Georgi Djakov Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] interconnect: Sanity check that node isn't already on list Date: Fri, 25 Jun 2021 16:49:03 -0700 Message-Id: <20210625234903.1324755-1-bjorn.andersson@linaro.org> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Broken interconnect providers might add the same node multiple times or in multiple providers, which causes strange errors as the provider's node list is later traversed. Detect that a node already has an associated provider, complain and reject the addition of the node, to aid the developer. Signed-off-by: Bjorn Andersson --- drivers/interconnect/core.c | 3 +++ 1 file changed, 3 insertions(+) -- 2.29.2 diff --git a/drivers/interconnect/core.c b/drivers/interconnect/core.c index 8a1e70e00876..fcb5d8eefb51 100644 --- a/drivers/interconnect/core.c +++ b/drivers/interconnect/core.c @@ -959,6 +959,9 @@ EXPORT_SYMBOL_GPL(icc_link_destroy); */ void icc_node_add(struct icc_node *node, struct icc_provider *provider) { + if (WARN_ON(node->provider)) + return; + mutex_lock(&icc_lock); node->provider = provider;