From patchwork Wed Jun 30 09:31:00 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: thermal-bot for Lad Prabhakar X-Patchwork-Id: 469350 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0BAFC11F6B for ; Wed, 30 Jun 2021 09:31:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C2E3961D08 for ; Wed, 30 Jun 2021 09:31:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233832AbhF3Jde (ORCPT ); Wed, 30 Jun 2021 05:33:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44342 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233817AbhF3Jdd (ORCPT ); Wed, 30 Jun 2021 05:33:33 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 46544C061767 for ; Wed, 30 Jun 2021 02:31:05 -0700 (PDT) Date: Wed, 30 Jun 2021 09:31:00 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1625045461; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=h7Q9CAvGmqUWgXJ9aYGCkmWJSGteWblCZnFQbFQf9bg=; b=vg+e9OxY4GFPEShvyIVljDZzwvx6NS21VxHn/URy0+/vwBbDIOuJLH5GyuUwmeHm8VNrSx Cwy5Sjw1y6X7RqtQ08nQCD5SWxVEmzkZbctAV3xTa8hXhMDch7/4g7MqwmiMy81H0ukko8 eAtYd/TaPLn9t+/bL9AOI5tCygC2donBoSAiqrpzQ6fHjvnFx80V4l18BkUtAKt539YJho ZldyxT2PExoR0P4YdsEhIh4InKtQmDcZj05vh1QIYKKLxhZbUkxgO9QyrGmE9+6fsrlnuQ sjlA9WnBzAb5aEyOctIy0Ao1Aj+l12hzkUoolevywFjgQxQmOAS0Qk8nWTltPA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1625045461; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=h7Q9CAvGmqUWgXJ9aYGCkmWJSGteWblCZnFQbFQf9bg=; b=0SWrg6V3sBaBDvqpJPiV0xTjAgba4EhrdK0Eb//DGi8lknVC81+b/7hVmYVrIO2LhnEH7z ofZ4pHkLZAqBrDCA== From: "thermal-bot for Srinivas Pandruvada" Sender: tip-bot2@linutronix.de Reply-to: linux-pm@vger.kernel.org To: linux-pm@vger.kernel.org Subject: [thermal: thermal/next] thermal/drivers/int340x/processor_thermal: Fix warning for return value Cc: kernel test robot , Srinivas Pandruvada , Daniel Lezcano , rui.zhang@intel.com, amitk@kernel.org In-Reply-To: <20210628183232.62877-1-srinivas.pandruvada@linux.intel.com> References: <20210628183232.62877-1-srinivas.pandruvada@linux.intel.com> MIME-Version: 1.0 Message-ID: <162504546099.395.17438393398806195157.tip-bot2@tip-bot2> Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org The following commit has been merged into the thermal/next branch of thermal: Commit-ID: 447acc9decdc177f353fa13fb26208a89612d49c Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/thermal/linux.git//447acc9decdc177f353fa13fb26208a89612d49c Author: Srinivas Pandruvada AuthorDate: Mon, 28 Jun 2021 11:32:32 -07:00 Committer: Daniel Lezcano CommitterDate: Tue, 29 Jun 2021 01:24:28 +02:00 thermal/drivers/int340x/processor_thermal: Fix warning for return value Fix smatch warnings: drivers/thermal/intel/int340x_thermal/processor_thermal_device_pci.c:258 proc_thermal_pci_probe() warn: missing error code 'ret' Use PTR_ERR to return failure of thermal_zone_device_register(). Reported-by: kernel test robot Signed-off-by: Srinivas Pandruvada Signed-off-by: Daniel Lezcano Link: https://lore.kernel.org/r/20210628183232.62877-1-srinivas.pandruvada@linux.intel.com --- drivers/thermal/intel/int340x_thermal/processor_thermal_device_pci.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/thermal/intel/int340x_thermal/processor_thermal_device_pci.c b/drivers/thermal/intel/int340x_thermal/processor_thermal_device_pci.c index ad7e2e3..11dd2e8 100644 --- a/drivers/thermal/intel/int340x_thermal/processor_thermal_device_pci.c +++ b/drivers/thermal/intel/int340x_thermal/processor_thermal_device_pci.c @@ -254,8 +254,10 @@ static int proc_thermal_pci_probe(struct pci_dev *pdev, const struct pci_device_ pci_info->tzone = thermal_zone_device_register("TCPU_PCI", 1, 1, pci_info, &tzone_ops, &tzone_params, 0, 0); - if (IS_ERR(pci_info->tzone)) + if (IS_ERR(pci_info->tzone)) { + ret = PTR_ERR(pci_info->tzone); goto err_ret_mmio; + } /* request and enable interrupt */ ret = pci_alloc_irq_vectors(pdev, 1, 1, PCI_IRQ_ALL_TYPES);