From patchwork Wed Aug 29 07:57:15 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Niklas Cassel X-Patchwork-Id: 145395 Delivered-To: patch@linaro.org Received: by 2002:a2e:1648:0:0:0:0:0 with SMTP id 8-v6csp379561ljw; Wed, 29 Aug 2018 00:57:33 -0700 (PDT) X-Google-Smtp-Source: ANB0VdYGA7VlZA96aNmSjqNFMxmPjckPnZu5hIYKKRh0AVnVHmzKrMasi5Go/yA75MhkvTcGopzz X-Received: by 2002:a17:902:6f16:: with SMTP id w22-v6mr4929095plk.127.1535529453644; Wed, 29 Aug 2018 00:57:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1535529453; cv=none; d=google.com; s=arc-20160816; b=0TeDJfCbKriU1LnsoxEi8h4tMdx0gOU0oTR3TkUj9WPFO8VQRc1LT0KyIIK3V6jJhW ZJJ8RWiEerJdBi89mtgutWmr89NNvkyJ9A5KpVz7AZXdtq/kNFpcSGERib/X5kHKG/Md NfeUbBIaNSWnoMBh5uxO2XfQzRUC+ijZN/z7VtQuOikYZh+LSsl9sCyt0meRsQQuVBy8 JDGMh6rRhx8gQ0+E8b0jMjq4NwvuaCCxqB7U+PWAdAQnaeHS4STA5wjXLEEJsu7u7/kb nYvfFxYkSbjncZs1eprwgRm8uI0seFl8JQ4CgvlL4npqpLVpy397PgyMbcIhOq13Qiyk lKPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=h90+3ReY06e+iLNerRK9K1XsVHAVsoADC481ssK4+Co=; b=wk5bJ8JgVWpblm4T8EYmD/OeqIrpgTGMMQnl1vFrRb6X11FKAPtRPq/+m+y4U6Qc8e 5omNQ54SdwQfLC3r5pQPtcLC9HgIHWtwkBC0lJ8vknwbnPGHKfx84sDfsfNtv7h7iHU7 d7Gdo1Yh9M1yLYiayxiGgeHr/0PoRpmkrOk9nYnxFjcc/qGGgkYqkfih6E+3YTW8iJ4S xQJHIuR4hPo46RR27eO8KWsiGJNXS/DMNO++zSathXWkB/5hMzasqKct5PKjyoxKYwyM F3wGPXkOewrFdmHri3BO0hebe/di2b5wJRSFREYQ8Fo5+sHOSKYzmc/8pSF/rNYiBNLw YsHw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=eMaZZlIi; spf=pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a64-v6si3332181pfb.224.2018.08.29.00.57.33; Wed, 29 Aug 2018 00:57:33 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=eMaZZlIi; spf=pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727595AbeH2LxI (ORCPT + 13 others); Wed, 29 Aug 2018 07:53:08 -0400 Received: from mail-lj1-f195.google.com ([209.85.208.195]:35656 "EHLO mail-lj1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727312AbeH2LxH (ORCPT ); Wed, 29 Aug 2018 07:53:07 -0400 Received: by mail-lj1-f195.google.com with SMTP id p10-v6so3593299ljg.2 for ; Wed, 29 Aug 2018 00:57:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=h90+3ReY06e+iLNerRK9K1XsVHAVsoADC481ssK4+Co=; b=eMaZZlIi8Tdxk3NSYyzVxvx4iPYAHUvG6b1xPMfFl7xEzxc2ZRSfF7b9YEHlObQySL 6F38glQYuSH4W6Dr7+4w7c2K1st2PnG8ZfSbxUaEmHGg4N03rW4odmmHYmRaHW3Q8eZA ZNE0IL9va18UVzPrOdFV0AjQaro1ey8aijFA4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=h90+3ReY06e+iLNerRK9K1XsVHAVsoADC481ssK4+Co=; b=ZLdBgoATEok9H7fbfx2+vpym+cLce0QktQZnwqkhypqSDwS6wW8LsAWD2wQ8eQ4iCW XvjwKyf6nvQmDJSjpYa+86dM50YGj/E55ZbDgWUx0TTKDeoqk/Tygjd5MYAdn6ykeZ1r ixUSWNu8+b+R+5HM1Gam309ZhFLd3HfEDTavI+1u4/uHvbZT4oiovofkTk62E+xG/iSC DcyyhC+RidLk8dg/thLicd/G7HPpbBu8ojYTfKGsOnj42uJh68I6kp7TWJRUrwg0rW/K MPfAfHSO+cGgW/KxsaxpOYxrDPsTcf0JN0YJKQF3lV9xZKbP96qyI5hyZYbjmQ+uKyAG DqLA== X-Gm-Message-State: APzg51Ah4PehdN6bTLPH5KW9Ww4SKTgaIHbGvh3YbqXhML71WLqWVoA/ InquoV+5z6dORk1d60vjY78XjA== X-Received: by 2002:a2e:9095:: with SMTP id l21-v6mr3623796ljg.15.1535529448741; Wed, 29 Aug 2018 00:57:28 -0700 (PDT) Received: from centauri.ideon.se ([85.235.10.227]) by smtp.gmail.com with ESMTPSA id u19-v6sm596232lje.51.2018.08.29.00.57.27 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 29 Aug 2018 00:57:28 -0700 (PDT) From: Niklas Cassel To: Andy Gross , David Brown Cc: Niklas Cassel , linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v6 1/9] soc: qcom: smem: Add missing include of sizes.h Date: Wed, 29 Aug 2018 09:57:15 +0200 Message-Id: <20180829075724.9095-2-niklas.cassel@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180829075724.9095-1-niklas.cassel@linaro.org> References: <20180829075724.9095-1-niklas.cassel@linaro.org> MIME-Version: 1.0 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Add missing include of sizes.h. drivers/soc/qcom/smem.c: In function ‘qcom_smem_get_ptable’: drivers/soc/qcom/smem.c:666:64: error: ‘SZ_4K’ undeclared ptable = smem->regions[0].virt_base + smem->regions[0].size - SZ_4K; ^~~~~ Signed-off-by: Niklas Cassel Reviewed-by: Vivek Gautam Reviewed-by: Vinod Koul --- drivers/soc/qcom/smem.c | 1 + 1 file changed, 1 insertion(+) -- 2.17.1 diff --git a/drivers/soc/qcom/smem.c b/drivers/soc/qcom/smem.c index bf4bd71ab53f..b77573eed596 100644 --- a/drivers/soc/qcom/smem.c +++ b/drivers/soc/qcom/smem.c @@ -18,6 +18,7 @@ #include #include #include +#include #include #include From patchwork Wed Aug 29 07:57:17 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Niklas Cassel X-Patchwork-Id: 145397 Delivered-To: patch@linaro.org Received: by 2002:a2e:1648:0:0:0:0:0 with SMTP id 8-v6csp379769ljw; Wed, 29 Aug 2018 00:57:48 -0700 (PDT) X-Google-Smtp-Source: ANB0VdYRoT41xBorho6MQkJnKzKLuqa5JjHd5yaB5MbYIuAegyKzO92J6T3Bcos5JpjnVzxpxP5f X-Received: by 2002:a17:902:9a8a:: with SMTP id w10-v6mr4799388plp.14.1535529468763; Wed, 29 Aug 2018 00:57:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1535529468; cv=none; d=google.com; s=arc-20160816; b=z+BmGXRPtzH7VXLsJRDwD7v2JV/WQfwiENFP2kSpj0IkpuLuEsOLDPnQdMipoeR0RG UGHeZhpiLV5HuTcpreq2DrcpDvx5XOSu945UljmXayL9MbECS27BkpZHa0OK+0dApbuj KXEAzI1CxujiFHa/cfhK0eB7NYpDKoHbnDZ9sCQlyOLx7+LLlmL6h3WfM1I+HntIyxRC 4jIEvri/sIZ/hf9PN+kFkTBMVailU0g3UORJq9Ha0TtRafUaLDnbtVf5eTDMkqsp/0gp Nm5T8qC+TEb10BDZCgk1GH6Kia2u9jRkznx/f0ygjbjm8u8bW4yJ6gIR+ylZqXtjuuli XdqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=qtQHnawV6159KrNcAB+r9rRijDPcx3eyatNOzc6jgxU=; b=HTVDKeNgKHstA35TyioYU1TKRCdqydINw18jvUrDJ+DrjL679Y5SpSoX16s9HCvUTd 1AktRXCBDww09NWascLtQYhpo/YtVdkfXJ1xaq95G8X17nhEyVvivqugi5X+UkVZPMRP Rn2MGOpHwJPX/g9XFf3hV20L6EPzmtohn9bt4MkIdd/Hm8nb13OJbYGk7AGDLqqAdzsP 9BCxM/IQS/NQ+oryhmt3nQ8WKZTRaR6ure2XKNv7eHzjI6WGYwx4nhH5a8sIspt3IVSY lEVF6iZ/rDTkVS3L7ZHPY2hTyPluLOvoO/X/OFDAz+8F5ztgovLrCqJhEdZZWIgkuAlo 6L1Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=hD7jWFvK; spf=pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u20-v6si3285439pgj.443.2018.08.29.00.57.48; Wed, 29 Aug 2018 00:57:48 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=hD7jWFvK; spf=pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727590AbeH2LxY (ORCPT + 13 others); Wed, 29 Aug 2018 07:53:24 -0400 Received: from mail-lf1-f65.google.com ([209.85.167.65]:46115 "EHLO mail-lf1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727236AbeH2LxY (ORCPT ); Wed, 29 Aug 2018 07:53:24 -0400 Received: by mail-lf1-f65.google.com with SMTP id e23-v6so3499117lfc.13 for ; Wed, 29 Aug 2018 00:57:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=qtQHnawV6159KrNcAB+r9rRijDPcx3eyatNOzc6jgxU=; b=hD7jWFvKOXG2bg6p3bUZsSm22Yihut5Ra1DrW+Y7vyZhxq4N3kKO96yEZdxK6TSlEY srg4ndvygCf5Aqt6V8oKmBaDZeBC/3rfcVeAL/haKDrLwgw8jUvbnCE+3171rdva2bAU uE4ZgU0p/s/1cGu6OwPOCSXnbh/dh5ZYZKccQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=qtQHnawV6159KrNcAB+r9rRijDPcx3eyatNOzc6jgxU=; b=lXs9kuOeZn0Jy7931dv9ncYfeZEebY5jIucPHkNsxaswstubUiS1Led+ICYr/Q5p2c 9i0SofC7FU8z3x+uvLx0of8QSH4+tzIGx+z0335hIb9PgaLhSD4ACBCUUcPe08yvmVwa +15iqLjcgyRca8g17fjhFg/el7IJPaj0DIu9c09NmMTSzHJVWsrftowNnJ5UsJaq85u8 LYbL+zXpGgEKdGDgBGuL0fv8laG+9p/4rUVPTa73Zyb/jJGmX4iFHVKc2fJBkTzyLvaM 7MKVpsvCq7m6D8Kdwj4R/E24XIUPPrkcytqzGowWgqII1Xnr5OP6evLorX3hhjlB+Uk5 PQeQ== X-Gm-Message-State: APzg51CNS9CmR8dfHKcb+v1PK9ih/ZfmTeEds6EZ02WZ22CQy2fa+/7L VQo05YxF/Z01vjv8kufcGBPDhA== X-Received: by 2002:a19:eb10:: with SMTP id j16-v6mr3623820lfh.23.1535529465847; Wed, 29 Aug 2018 00:57:45 -0700 (PDT) Received: from centauri.ideon.se ([85.235.10.227]) by smtp.gmail.com with ESMTPSA id f7-v6sm613386lfc.4.2018.08.29.00.57.45 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 29 Aug 2018 00:57:45 -0700 (PDT) From: Niklas Cassel To: Andy Gross , David Brown Cc: Niklas Cassel , linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v6 3/9] soc: qcom: smp2p: Add select IRQ_DOMAIN Date: Wed, 29 Aug 2018 09:57:17 +0200 Message-Id: <20180829075724.9095-4-niklas.cassel@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180829075724.9095-1-niklas.cassel@linaro.org> References: <20180829075724.9095-1-niklas.cassel@linaro.org> MIME-Version: 1.0 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Since we are using irq_domain_add_linear(), add a select on IRQ_DOMAIN. This is needed in order to be able to remove the depends on ARCH_QCOM. drivers/soc/qcom/smp2p.c: In function ‘qcom_smp2p_inbound_entry’: drivers/soc/qcom/smp2p.c:317:18: error: implicit declaration of function ‘irq_domain_add_linear’ entry->domain = irq_domain_add_linear(node, 32, &smp2p_irq_ops, entry); ^~~~~~~~~~~~~~~~~~~~~ Signed-off-by: Niklas Cassel Reviewed-by: Vivek Gautam Reviewed-by: Vinod Koul --- drivers/soc/qcom/Kconfig | 1 + 1 file changed, 1 insertion(+) -- 2.17.1 diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig index ba79b609aca2..6e063202ad0b 100644 --- a/drivers/soc/qcom/Kconfig +++ b/drivers/soc/qcom/Kconfig @@ -134,6 +134,7 @@ config QCOM_SMP2P depends on MAILBOX depends on QCOM_SMEM select QCOM_SMEM_STATE + select IRQ_DOMAIN help Say yes here to support the Qualcomm Shared Memory Point to Point protocol. From patchwork Wed Aug 29 07:57:18 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Niklas Cassel X-Patchwork-Id: 145398 Delivered-To: patch@linaro.org Received: by 2002:a2e:1648:0:0:0:0:0 with SMTP id 8-v6csp379809ljw; Wed, 29 Aug 2018 00:57:51 -0700 (PDT) X-Google-Smtp-Source: ANB0VdZTBbEAHp6FEIS1QlVGox12BR1jk/iI0t/TuXSLNvCGTo+SP+8Ya0QIcE/hNlCKvql9zufA X-Received: by 2002:a63:ea49:: with SMTP id l9-v6mr4629725pgk.427.1535529471182; Wed, 29 Aug 2018 00:57:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1535529471; cv=none; d=google.com; s=arc-20160816; b=WmXAdlYoflFwo6uXfpFVeHsguCVCdvbkY+d1LdQK3O+KqvZs5EpDTTPjr8VqLTeeUi elhNY7SJF5uSW38PyWrNbXsfanuyFCV+lQ4vtcnoBDJ65oms/EriO431umO+bnYg9YJd DbaVnDGRxMCrM4iOVGV07rejJaPhlVwUn62uu2Atj21YIF+gVExM265TOBJpL1gHE8IC hlkvV4KOzSFN+R6GSgqWKuzncUz/okIr6U1E4lU12hOfIALzgiBzKo/sugnjcc3J7mZr jWtrLzzQFD81dn8lQ7EUmq0GoceGfMS7U0bGetQXx7RbDiudBNE6XpduWc+0B99SxLG3 wuuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=IW7gPFbp3Cs/xxYQ78q60NQhn2rxDLB3vVZCg9hJpfg=; b=b9O5zBi3rsWLf0pLBaEQrEtgJgzHhKIgudcOWwNyhfsKQuZ7tlwVsBNEu1L2XC4EHg jkwo5L3rRxXIIJBN3Q4uq2LA1FYdQkt2FfNg6Hue5+WlZaoeKs8eMam7K00n8j0wa7Z9 M1CLm/wvOe+131kMk/5wysniUMUjzfedYclbdQQbwgkSxWe9cLF4nKG/jg97DeqHDB0C uqW8sXyAzzXXrUNpjBXDDR5Ghi/jBbMA0CABWWf7L5bOEAnfweVGeU+GKal49TMwubnv ZqPqucnIEb2QqRVBi1lU/azgQkksEustGA1VBaBQ/sBJcttGktsW8v09ASLvc/K70D6x qtvg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="kg/F2SZM"; spf=pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x1-v6si3308840plb.135.2018.08.29.00.57.50; Wed, 29 Aug 2018 00:57:51 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="kg/F2SZM"; spf=pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727962AbeH2Lx0 (ORCPT + 13 others); Wed, 29 Aug 2018 07:53:26 -0400 Received: from mail-lf1-f66.google.com ([209.85.167.66]:40778 "EHLO mail-lf1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727286AbeH2LxZ (ORCPT ); Wed, 29 Aug 2018 07:53:25 -0400 Received: by mail-lf1-f66.google.com with SMTP id x26-v6so3520195lfi.7 for ; Wed, 29 Aug 2018 00:57:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=IW7gPFbp3Cs/xxYQ78q60NQhn2rxDLB3vVZCg9hJpfg=; b=kg/F2SZML7WBuqEBtFfwjdEToBm5pPLV9BztrAqylqmdk3608H21CbMLwoQecSARRo 3g9Ru/ZUloD71YYuEuRhftTZN+/h8RBxWmYpgHqhZEfFkMkwUPrA2BbmfkkTTY8nKvtS 9vFEHLKzSKFtI8XRgSWvs94KKe4zgxGHZe4Mg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=IW7gPFbp3Cs/xxYQ78q60NQhn2rxDLB3vVZCg9hJpfg=; b=kH0vZ6BeZPfC3+KSeZh8FJZ8M6eiHzcJlfqCC4UibcFMu6vmZC500BadPNvvQ47BGW A0OvnvBtCJLey3kAm2QkSU/YMxtImhzKVF4uEsn5Gi+EMdiC3x/enV45w4ubBotT7b5J hLLw7CelE3pATafxtIW56fO3NA+r00KSs0knAFCbaPXJrs4fb6IGpgiLJ9RjzHur6Mtj ZKaJ4FO9B+Pufmk+JVYZyjcObxliPWTNkHi4ngW8Z38Z26kH46JPOQ0MbCQRGEbfCQPu 2j7Xu537vL93gsCMNu7oEaYKc0EEk4AsD/HXz+Y1jBXWrDYpEbKc933WYT0Eoi6n1MFN 7fXw== X-Gm-Message-State: APzg51A41uUQA7wWJsNo61uZu7CewzzTmQlXhiVg48kY42KY/QwkQ5cb yD6hBZ12YhiQKnWY0mxhqixmFQ== X-Received: by 2002:a19:6d12:: with SMTP id i18-v6mr3370552lfc.72.1535529467079; Wed, 29 Aug 2018 00:57:47 -0700 (PDT) Received: from centauri.ideon.se ([85.235.10.227]) by smtp.gmail.com with ESMTPSA id f7-v6sm613386lfc.4.2018.08.29.00.57.46 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 29 Aug 2018 00:57:46 -0700 (PDT) From: Niklas Cassel To: Andy Gross , David Brown Cc: Niklas Cassel , linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v6 4/9] soc: qcom: smsm: Add select IRQ_DOMAIN Date: Wed, 29 Aug 2018 09:57:18 +0200 Message-Id: <20180829075724.9095-5-niklas.cassel@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180829075724.9095-1-niklas.cassel@linaro.org> References: <20180829075724.9095-1-niklas.cassel@linaro.org> MIME-Version: 1.0 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Since we are using irq_domain_add_linear(), add a select on IRQ_DOMAIN. This is needed in order to be able to remove the depends on ARCH_QCOM. drivers/soc/qcom/smsm.c: In function ‘smsm_inbound_entry’: drivers/soc/qcom/smsm.c:411:18: error: implicit declaration of function ‘irq_domain_add_linear’ entry->domain = irq_domain_add_linear(node, 32, &smsm_irq_ops, entry); ^~~~~~~~~~~~~~~~~~~~~ Signed-off-by: Niklas Cassel Reviewed-by: Vivek Gautam Reviewed-by: Vinod Koul --- drivers/soc/qcom/Kconfig | 1 + 1 file changed, 1 insertion(+) -- 2.17.1 diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig index 6e063202ad0b..7da6e67c7ea1 100644 --- a/drivers/soc/qcom/Kconfig +++ b/drivers/soc/qcom/Kconfig @@ -143,6 +143,7 @@ config QCOM_SMSM tristate "Qualcomm Shared Memory State Machine" depends on QCOM_SMEM select QCOM_SMEM_STATE + select IRQ_DOMAIN help Say yes here to support the Qualcomm Shared Memory State Machine. The state machine is represented by bits in shared memory. From patchwork Wed Aug 29 07:57:21 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Niklas Cassel X-Patchwork-Id: 145400 Delivered-To: patch@linaro.org Received: by 2002:a2e:1648:0:0:0:0:0 with SMTP id 8-v6csp380045ljw; Wed, 29 Aug 2018 00:58:08 -0700 (PDT) X-Google-Smtp-Source: ANB0Vdag8pfaTIpzgyCSPk00Dm0pjA++tQHAOMtaj2yzjn7J6e0ixfGQY8FaB9QuR5DLFuKcbKwG X-Received: by 2002:a17:902:7102:: with SMTP id a2-v6mr4863584pll.217.1535529488111; Wed, 29 Aug 2018 00:58:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1535529488; cv=none; d=google.com; s=arc-20160816; b=bCJvw2xbrEbGkcxwKt8bYoU10PgnyDjQzZV5vyQJDJACZ6MifT+n8Ro4GkUVb2HSz6 sWMkjAcpjvABlsbD5FVECLzETR71us1QdZQXuADrFEBdwkXnOHJQPG5k7sdI7u21Bd2N VqTHuxNHrTN9hd4PRzrOEUymCcluPYE3JPinokUyZmda9R8h4jSkdqysh0CqQ7goPBTr nN71pXf2+OJrd6jmUSNvi+qAowhjVx8v+ATnokbcc9pW/bmNtcg41UBtXKJnNn7kI466 80SotjCKANvWCYzS4LqH23PtSbI5EqRvv0X8gEYMEAIE7JpHv/pVb3h4B0+XyWzTY9gC FVJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=n5N7rzo2Yz6ToBgcoJnkbL1OiPAx5DE6sy5tATHXNvo=; b=BKDpFWI/AgXjT/zu7clII+2cx+x2CWzrTC2q7zzH56nmSt74G1EdpaoYcFuzSciKkz DDTuomOavzbHufM8GQ5dmF+Fabnqd1tzwXMArzw4IOrsqORGy0u1piHpGzeb8g28kyCh uflbfzg4P1uCRL108Kfp9ff3ygERZs+uZhNVxxwGSl1mm9DCH6MkN1ACYhAp4Zs0momx mWS2gLPrkz2DmHKTjF6AzMKSy+nEtVN7zHtNnZEUxykiVX25nHu/uIugODWcuAW/AOVw ldN/c9pQ4mLL7CZ7UKWr0972O6MHCV4xTeX+fVAPcgwMDXSAMLFKRIOfoj5elxYJIDAX U7Sw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ZiPY7gA7; spf=pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w7-v6si3347997plq.198.2018.08.29.00.58.07; Wed, 29 Aug 2018 00:58:08 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ZiPY7gA7; spf=pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728039AbeH2Lxn (ORCPT + 13 others); Wed, 29 Aug 2018 07:53:43 -0400 Received: from mail-lf1-f67.google.com ([209.85.167.67]:34322 "EHLO mail-lf1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728023AbeH2Lxn (ORCPT ); Wed, 29 Aug 2018 07:53:43 -0400 Received: by mail-lf1-f67.google.com with SMTP id g9-v6so3533750lfh.1 for ; Wed, 29 Aug 2018 00:58:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=n5N7rzo2Yz6ToBgcoJnkbL1OiPAx5DE6sy5tATHXNvo=; b=ZiPY7gA7J17PKABvvERsIGACUT9ycbQk2koUQRQauwaRddCew4S4x2tgVFCDLveVQV v2Ch4TRSQRXa/LbP1LDqpYFCPtmyRpx+27sAp02/nC2WtpJED7y5JAzd7s6poancIZf6 owWVvwdR8w15N7PTsFemdubA4Vd5eQGaUwke4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=n5N7rzo2Yz6ToBgcoJnkbL1OiPAx5DE6sy5tATHXNvo=; b=teRx1s5TrbTphgWbxVR19jMXOdJO5+UIdIdQWCQWyka0vZgP2GsTmAR6OIbKGiEh73 7aTGaf83BwPGmguZbFAxw/o17gG6Veq0J9VmaFLl6JqWid2K4q+KZ7b2YEr1yhp1njTY +5Hbemr0bMO5Af8b6aAKmJNxv/Np7x5lSoDvnvFBqy9MJNEm217F/SjZYdeLtN4v2X/w oj+i+qSn/PBkunkplre0/uZrZGrweIJk9XrRzWVm4WQg5InQh6CanNkfhlIHyC1U4ye9 YxZDzl/ayHoJLSu1Is9Z11pi3SoVvkHB1wuZROY91/5T2VR6PkbEgG1iWyszGZti2krO zbqw== X-Gm-Message-State: APzg51CA3b2RGJh9LBWNtJZJhZ0PoUjqPNHFNZUj2vCA2Q4vzuAQt9WO 8NEYDkX9InnTxudshEZa3fwBMQ== X-Received: by 2002:a19:9355:: with SMTP id v82-v6mr3418687lfd.134.1535529485106; Wed, 29 Aug 2018 00:58:05 -0700 (PDT) Received: from centauri.ideon.se ([85.235.10.227]) by smtp.gmail.com with ESMTPSA id j9-v6sm592303ljh.40.2018.08.29.00.58.04 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 29 Aug 2018 00:58:04 -0700 (PDT) From: Niklas Cassel To: Andy Gross , David Brown Cc: Niklas Cassel , linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v6 7/9] soc: qcom: wcnss_ctrl: Avoid string overflow Date: Wed, 29 Aug 2018 09:57:21 +0200 Message-Id: <20180829075724.9095-8-niklas.cassel@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180829075724.9095-1-niklas.cassel@linaro.org> References: <20180829075724.9095-1-niklas.cassel@linaro.org> Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org 'chinfo.name' is used as a NUL-terminated string, but using strncpy() with the length equal to the buffer size may result in lack of the termination: drivers//soc/qcom/wcnss_ctrl.c: In function 'qcom_wcnss_open_channel': drivers//soc/qcom/wcnss_ctrl.c:284:2: warning: 'strncpy' specified bound 32 equals destination size [-Wstringop-truncation] strncpy(chinfo.name, name, sizeof(chinfo.name)); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ This changes it to use the safer strscpy() instead. Signed-off-by: Niklas Cassel --- drivers/soc/qcom/wcnss_ctrl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.17.1 Reviewed-by: Bjorn Andersson diff --git a/drivers/soc/qcom/wcnss_ctrl.c b/drivers/soc/qcom/wcnss_ctrl.c index df3ccb30bc2d..373400dd816d 100644 --- a/drivers/soc/qcom/wcnss_ctrl.c +++ b/drivers/soc/qcom/wcnss_ctrl.c @@ -281,7 +281,7 @@ struct rpmsg_endpoint *qcom_wcnss_open_channel(void *wcnss, const char *name, rp struct rpmsg_channel_info chinfo; struct wcnss_ctrl *_wcnss = wcnss; - strncpy(chinfo.name, name, sizeof(chinfo.name)); + strscpy(chinfo.name, name, sizeof(chinfo.name)); chinfo.src = RPMSG_ADDR_ANY; chinfo.dst = RPMSG_ADDR_ANY; From patchwork Wed Aug 29 07:57:22 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Niklas Cassel X-Patchwork-Id: 145402 Delivered-To: patch@linaro.org Received: by 2002:a2e:1648:0:0:0:0:0 with SMTP id 8-v6csp380096ljw; Wed, 29 Aug 2018 00:58:10 -0700 (PDT) X-Google-Smtp-Source: ANB0VdYN7sQCardG53hiFSRRaiJ+2HVi/9ZvHxVvt0bQTXvxV/Pc1T8+WnHUKBbij6E36iBCbcXf X-Received: by 2002:a63:a309:: with SMTP id s9-v6mr4558534pge.90.1535529490344; Wed, 29 Aug 2018 00:58:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1535529490; cv=none; d=google.com; s=arc-20160816; b=Ap4y2tCBAxRLwTxiaT3jKJxubNRkHSHdRzy9E8ZTGuJI8Z2FIkQkTm6o1/VXcCrmq2 qVs/qVnKjxAeyXVS3R0I0XF8P/7YRIIPvfIXo5Hs71E3/5N73LOJ5aJ7vZmfhImHLLnf otNc5DfTBxGK4ynsUgkNpd8PPvLcDfSoxmA0GGVOOn/QCzwJ+pRiMFEQdfTY2r7KEatd ZtFoM/laoaG1Bp/K72+cQaJHXPnn2IVLa9hzlHFC1zLELRux0h6De8/cG6NMbAr2/4s7 XtaGS83n8N78QO+Y3u/oFhM0oWKoNwSti6ixGIMtEJACJ+QSYAdjlBY5Sz7ZgizJW+hE RP7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=WGcGxBYbMR3lYiFeso6+j/q0sgMwNMyzkoeytqhrrrw=; b=tQmlwCwJSVoYP6D2xnc17B1/hP5mz9BZ77ThrTB3V8NDln2cXQTY9VwyndXuHtb2WX 9nnAd9NpPhLEoJHjWhuquBTef1oBfDUswUnYrZniTl9vMCmMV2aL0Vxu/lpz5NJ+nwXA rk0m6192BLmJZBScL9UtjqSFwgpW3CF6aBXU+7cVDJFOc6AY2oyEXIUMED9TCyAoAVEd JbHB3dCZD4iHDQ78D8/mj51dIBp4JUwcjbtOc5OtDzPH3qalgqqP56gtzKfv53ppSpnG 1DuC86cy2HTCeGl6vUeYs5E0+t26pwJYnaiN2K+k2LNsmXdj/KhsvZtqiXArJ7Wg2STC +i2A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=WPxuH4FE; spf=pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v1-v6si3333304plb.387.2018.08.29.00.58.10; Wed, 29 Aug 2018 00:58:10 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=WPxuH4FE; spf=pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728024AbeH2Lxp (ORCPT + 13 others); Wed, 29 Aug 2018 07:53:45 -0400 Received: from mail-lf1-f67.google.com ([209.85.167.67]:45446 "EHLO mail-lf1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727668AbeH2Lxo (ORCPT ); Wed, 29 Aug 2018 07:53:44 -0400 Received: by mail-lf1-f67.google.com with SMTP id r4-v6so3502358lff.12 for ; Wed, 29 Aug 2018 00:58:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=WGcGxBYbMR3lYiFeso6+j/q0sgMwNMyzkoeytqhrrrw=; b=WPxuH4FEJqGnE517ARbt1uzfFsPp8ytr1oMwjBDUNHNo5fmIpTQAAm9y3sI9brHI6A tdqnUm2Ed0vS+hZ9vrptewg9I8ejvYK6kQd+oAq107kuxp5OJ7qNkfC9fwYNgCNdxNoM OhtlFc4FsSCXYJ5lABPkWmE/YP03pcxk6Y4lE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=WGcGxBYbMR3lYiFeso6+j/q0sgMwNMyzkoeytqhrrrw=; b=GqzuRc7h7Kdf3lLujdnCJ4WsHXGFTQYI0mMBi+IqA63E1eIX48gljyMYN+XeQgcnbB bKJvQuV5ekTxoNKDyagaEEkNSftAPeDUwnNquFkKibHEsZKlfVRenNIGY+rW4ZxMdDva soW5ZB4sRzh4i/I3T2qYnIj13qC0T1npgC3rplgo9m/cGpDnIk2v/NIT0saUQT5PndTC vIRqBQiS2L9uR7VYvs7c2nUreAsOlxFv1nWl654XZDBr4g4qdzB+NSF12Y+SQsbmPUt1 /CYuf1RqYXlSdEunTqVy/4vnEDMitG8mm7pnhXe0RIP/Qmd2UbN3xm3FSnp5+8N4hq+2 eDkg== X-Gm-Message-State: APzg51Bm4Ac0meTEX9N+M7Mhh5NMNDBtI0HXTgk+gNbBS8GAWYA1xvca ZJWCWXR/oDekxHWEp7KDsCM8qw== X-Received: by 2002:a19:be55:: with SMTP id o82-v6mr3353559lff.58.1535529486221; Wed, 29 Aug 2018 00:58:06 -0700 (PDT) Received: from centauri.ideon.se ([85.235.10.227]) by smtp.gmail.com with ESMTPSA id j9-v6sm592303ljh.40.2018.08.29.00.58.05 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 29 Aug 2018 00:58:05 -0700 (PDT) From: Niklas Cassel To: Andy Gross , David Brown Cc: Niklas Cassel , linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v6 8/9] soc: qcom: apr: Avoid string overflow Date: Wed, 29 Aug 2018 09:57:22 +0200 Message-Id: <20180829075724.9095-9-niklas.cassel@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180829075724.9095-1-niklas.cassel@linaro.org> References: <20180829075724.9095-1-niklas.cassel@linaro.org> Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org 'adev->name' is used as a NUL-terminated string, but using strncpy() with the length equal to the buffer size may result in lack of the termination: In function 'apr_add_device', inlined from 'of_register_apr_devices' at drivers//soc/qcom/apr.c:264:7, inlined from 'apr_probe' at drivers//soc/qcom/apr.c:290:2: drivers//soc/qcom/apr.c:222:3: warning: 'strncpy' specified bound 32 equals destination size [-Wstringop-truncation] strncpy(adev->name, np->name, APR_NAME_SIZE); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ This changes it to use the safer strscpy() instead. Signed-off-by: Niklas Cassel --- drivers/soc/qcom/apr.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.17.1 Reviewed-by: Bjorn Andersson diff --git a/drivers/soc/qcom/apr.c b/drivers/soc/qcom/apr.c index 57af8a537332..ee9197f5aae9 100644 --- a/drivers/soc/qcom/apr.c +++ b/drivers/soc/qcom/apr.c @@ -219,9 +219,9 @@ static int apr_add_device(struct device *dev, struct device_node *np, adev->domain_id = id->domain_id; adev->version = id->svc_version; if (np) - strncpy(adev->name, np->name, APR_NAME_SIZE); + strscpy(adev->name, np->name, APR_NAME_SIZE); else - strncpy(adev->name, id->name, APR_NAME_SIZE); + strscpy(adev->name, id->name, APR_NAME_SIZE); dev_set_name(&adev->dev, "aprsvc:%s:%x:%x", adev->name, id->domain_id, id->svc_id);