From patchwork Wed Sep 5 11:00:02 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [v2,1/5] validation: time: fix c&p error X-Patchwork-Submitter: Github ODP bot X-Patchwork-Id: 145988 Message-Id: <1536145206-9205-2-git-send-email-odpbot@yandex.ru> To: lng-odp@lists.linaro.org Date: Wed, 5 Sep 2018 11:00:02 +0000 From: Github ODP bot List-Id: "The OpenDataPlane \(ODP\) List" From: Dmitry Eremin-Solenikov Signed-off-by: Dmitry Eremin-Solenikov --- /** Email created from pull request 694 (lumag:timer) ** https://github.com/Linaro/odp/pull/694 ** Patch: https://github.com/Linaro/odp/pull/694.patch ** Base sha: 0a5d67beda902557056d5b5146d8cbe86e5001b0 ** Merge commit sha: dc2fc3943e99a8bb113f9e34a27d9bf1b521ed5b **/ test/validation/api/time/time.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/validation/api/time/time.c b/test/validation/api/time/time.c index e24012285..27ddc97fd 100644 --- a/test/validation/api/time/time.c +++ b/test/validation/api/time/time.c @@ -413,7 +413,7 @@ static void time_test_wait_ns(void) if (odp_time_cmp(diff, upper_limit) > 0) { fprintf(stderr, "Exceed upper limit: " "diff is %" PRIu64 ", upper_limit %" PRIu64 "\n", - odp_time_to_ns(diff), odp_time_to_ns(lower_limit)); + odp_time_to_ns(diff), odp_time_to_ns(upper_limit)); CU_FAIL("Exceed upper limit\n"); } } From patchwork Wed Sep 5 11:00:03 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [v2, 2/5] validation: scheduler: print debug diagnostics on test_wait failure X-Patchwork-Submitter: Github ODP bot X-Patchwork-Id: 145991 Message-Id: <1536145206-9205-3-git-send-email-odpbot@yandex.ru> To: lng-odp@lists.linaro.org Date: Wed, 5 Sep 2018 11:00:03 +0000 From: Github ODP bot List-Id: "The OpenDataPlane \(ODP\) List" From: Dmitry Eremin-Solenikov Signed-off-by: Dmitry Eremin-Solenikov --- /** Email created from pull request 694 (lumag:timer) ** https://github.com/Linaro/odp/pull/694 ** Patch: https://github.com/Linaro/odp/pull/694.patch ** Base sha: 0a5d67beda902557056d5b5146d8cbe86e5001b0 ** Merge commit sha: dc2fc3943e99a8bb113f9e34a27d9bf1b521ed5b **/ test/validation/api/scheduler/scheduler.c | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/test/validation/api/scheduler/scheduler.c b/test/validation/api/scheduler/scheduler.c index 2e44d3248..069220393 100644 --- a/test/validation/api/scheduler/scheduler.c +++ b/test/validation/api/scheduler/scheduler.c @@ -185,8 +185,19 @@ static void scheduler_test_wait_time(void) upper_limit = odp_time_local_from_ns(5 * ODP_TIME_SEC_IN_NS + ODP_WAIT_TOLERANCE); - CU_ASSERT(odp_time_cmp(diff, lower_limit) >= 0); - CU_ASSERT(odp_time_cmp(diff, upper_limit) <= 0); + if (odp_time_cmp(diff, lower_limit) <= 0) { + fprintf(stderr, "Exceed lower limit: " + "diff is %" PRIu64 ", lower_limit %" PRIu64 "\n", + odp_time_to_ns(diff), odp_time_to_ns(lower_limit)); + CU_FAIL("Exceed lower limit\n"); + } + + if (odp_time_cmp(diff, upper_limit) >= 0) { + fprintf(stderr, "Exceed upper limit: " + "diff is %" PRIu64 ", upper_limit %" PRIu64 "\n", + odp_time_to_ns(diff), odp_time_to_ns(upper_limit)); + CU_FAIL("Exceed upper limit\n"); + } CU_ASSERT_FATAL(odp_queue_destroy(queue) == 0); } From patchwork Wed Sep 5 11:00:04 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [v2,3/5] validation: time: be more tolerant wrt delays X-Patchwork-Submitter: Github ODP bot X-Patchwork-Id: 145989 Message-Id: <1536145206-9205-4-git-send-email-odpbot@yandex.ru> To: lng-odp@lists.linaro.org Date: Wed, 5 Sep 2018 11:00:04 +0000 From: Github ODP bot List-Id: "The OpenDataPlane \(ODP\) List" From: Dmitry Eremin-Solenikov Signed-off-by: Dmitry Eremin-Solenikov --- /** Email created from pull request 694 (lumag:timer) ** https://github.com/Linaro/odp/pull/694 ** Patch: https://github.com/Linaro/odp/pull/694.patch ** Base sha: 0a5d67beda902557056d5b5146d8cbe86e5001b0 ** Merge commit sha: dc2fc3943e99a8bb113f9e34a27d9bf1b521ed5b **/ test/validation/api/time/time.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/validation/api/time/time.c b/test/validation/api/time/time.c index 27ddc97fd..38c0906ba 100644 --- a/test/validation/api/time/time.c +++ b/test/validation/api/time/time.c @@ -14,7 +14,7 @@ #define BUSY_LOOP_CNT_LONG 6000000000 /* used for t > 4 sec */ #define MIN_TIME_RATE 32000 #define MAX_TIME_RATE 15000000000 -#define DELAY_TOLERANCE 20000000 /* deviation for delay */ +#define DELAY_TOLERANCE 40000000 /* deviation for delay */ #define WAIT_SECONDS 3 static uint64_t local_res; From patchwork Wed Sep 5 11:00:05 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [v2,4/5] validation: timer: be more tolerant wrt delays X-Patchwork-Submitter: Github ODP bot X-Patchwork-Id: 145990 Message-Id: <1536145206-9205-5-git-send-email-odpbot@yandex.ru> To: lng-odp@lists.linaro.org Date: Wed, 5 Sep 2018 11:00:05 +0000 From: Github ODP bot List-Id: "The OpenDataPlane \(ODP\) List" From: Dmitry Eremin-Solenikov Signed-off-by: Dmitry Eremin-Solenikov --- /** Email created from pull request 694 (lumag:timer) ** https://github.com/Linaro/odp/pull/694 ** Patch: https://github.com/Linaro/odp/pull/694.patch ** Base sha: 0a5d67beda902557056d5b5146d8cbe86e5001b0 ** Merge commit sha: dc2fc3943e99a8bb113f9e34a27d9bf1b521ed5b **/ test/validation/api/timer/timer.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/validation/api/timer/timer.c b/test/validation/api/timer/timer.c index e0f068823..b1b760dce 100644 --- a/test/validation/api/timer/timer.c +++ b/test/validation/api/timer/timer.c @@ -334,8 +334,8 @@ static void timer_test_queue_type(odp_queue_type_t queue_type) tim = odp_timeout_timer(tmo); tick = odp_timeout_tick(tmo); - CU_ASSERT(diff_period > (period_ns - (4 * res_ns))); - CU_ASSERT(diff_period < (period_ns + (4 * res_ns))); + CU_ASSERT(diff_period > (period_ns - (5 * res_ns))); + CU_ASSERT(diff_period < (period_ns + (5 * res_ns))); LOG_DBG("timeout tick %" PRIu64 ", " "timeout period %" PRIu64 "\n", From patchwork Wed Sep 5 11:00:06 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [v2, 5/5] validation: scheduler: increase wait tolerance timeout to 150 msec X-Patchwork-Submitter: Github ODP bot X-Patchwork-Id: 145992 Message-Id: <1536145206-9205-6-git-send-email-odpbot@yandex.ru> To: lng-odp@lists.linaro.org Date: Wed, 5 Sep 2018 11:00:06 +0000 From: Github ODP bot List-Id: "The OpenDataPlane \(ODP\) List" From: Dmitry Eremin-Solenikov Signed-off-by: Dmitry Eremin-Solenikov --- /** Email created from pull request 694 (lumag:timer) ** https://github.com/Linaro/odp/pull/694 ** Patch: https://github.com/Linaro/odp/pull/694.patch ** Base sha: 0a5d67beda902557056d5b5146d8cbe86e5001b0 ** Merge commit sha: dc2fc3943e99a8bb113f9e34a27d9bf1b521ed5b **/ test/validation/api/scheduler/scheduler.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/validation/api/scheduler/scheduler.c b/test/validation/api/scheduler/scheduler.c index 069220393..0e7e6c578 100644 --- a/test/validation/api/scheduler/scheduler.c +++ b/test/validation/api/scheduler/scheduler.c @@ -47,7 +47,7 @@ #define CHAOS_PTR_TO_NDX(p) ((uint64_t)(uint32_t)(uintptr_t)p) #define CHAOS_NDX_TO_PTR(n) ((void *)(uintptr_t)n) -#define ODP_WAIT_TOLERANCE (60 * ODP_TIME_MSEC_IN_NS) +#define ODP_WAIT_TOLERANCE (150 * ODP_TIME_MSEC_IN_NS) /* Test global variables */ typedef struct {