From patchwork Wed Jul 21 15:24:59 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 483315 Delivered-To: patch@linaro.org Received: by 2002:a02:c94a:0:0:0:0:0 with SMTP id u10csp6300001jao; Wed, 21 Jul 2021 08:25:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy0+TxVYtUVDH3sdDPboKEjWkLbpSQLuDGo2mLJNal64uxQAsF6iDsQD1JZw13HD69OEp1L X-Received: by 2002:a17:906:5a98:: with SMTP id l24mr39416232ejq.90.1626881130995; Wed, 21 Jul 2021 08:25:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626881130; cv=none; d=google.com; s=arc-20160816; b=sHkeI8jPxCVJDCoNHYU2pvhZjvikFfcFeHDeybVe2JXii8I8Ek+pQxWcNhvOT+/lcI h7HF45iz98bDkn8vW7s017ydAgIBwr9GvomI5bH74GjU8lVFrFTMD7+spA3hud6Lu/qH IqCSV9e9vf18MP5oI7FQjQ7bcK87sSP80XdufMFqUJ52mZ6pVVwVEHz6G5+TVz1QHHFm s02iuLT5gX3MN1f5qwMZkE9lgooh+WN+gx6Ja6rh2ePlDT9jDktGVvMUZ23mYjGtbFec xR0Emnf9EB5nRq1MeGmtKdPWFm1e6eBVmZJb4uq2rKk5Gy9apBYQxAqVofGmzP9clvzu 2AhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=tSmr9FyFEwsQBp9r9e/UzyRLVe82Ric95JEe2yftIk0=; b=nGeT3/gvoU/erAkgdCX4mtxsolCNsfcF0ASMO7KLwHFzhapRAsi/Z+cP4TPaaCjvru N1HH4kj6ChT6h0lyaEqdylM0M85Y5B9SC1R2bg+Deh6WOhIdBQZcvD6PUGruXGdqqiNQ qF1M2p5/rm2wpfDBAvN1MCvNGU2WCfooQXoMpEeBaTbttS1nuvZMx3jZAcB5/uqVt0P8 u8s3t7k7xgIvcTD3jcaVnP7HAuXr4kBB23S1b0cls2E1ThNFxmP+XmMi7sVyXB5FxzdC sk7kaW/+JC0lSz6/pNen5kl+kOQBRI2USEeZjU99HeaJSowERzje4aFx+LjFfqHglj87 8Rdw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=EjUc+ZGi; spf=pass (google.com: domain of linux-media-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-media-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id qc12si16865935ejb.51.2021.07.21.08.25.30; Wed, 21 Jul 2021 08:25:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-media-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=EjUc+ZGi; spf=pass (google.com: domain of linux-media-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-media-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239797AbhGUOou (ORCPT + 4 others); Wed, 21 Jul 2021 10:44:50 -0400 Received: from mail.kernel.org ([198.145.29.99]:35192 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237983AbhGUOou (ORCPT ); Wed, 21 Jul 2021 10:44:50 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 0E8D761019; Wed, 21 Jul 2021 15:25:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1626881126; bh=q0qmFKoQHFOjKVXrivEKxEo8pwCPzGuiEq0fkOew1ws=; h=From:To:Cc:Subject:Date:From; b=EjUc+ZGi3vqpbw+zT5T1m6aYf2iKBQFXxnlst/1u7eRlQnHjnt3I5D7fSw9w1cWm7 f/70hlkaPSDXZ42nJ0qhDut6Vki3N9K27omo53aMnRlIREGXIP2ot8XNIzRVzjfwXj Fe/qyHukrmqOOM+rFW6BMwCZpIYovAC5oVRTq/o2LjhjMKaGfbn0uQVsXJkkcDbkUb vvR5dHqbmKtnWyQH6qAHbrlPnoOiIq3AYxA3CQh/TsL8pJjM2l0xSP9ytIvPCiqN3i MU9mqXgruNBb2Waan88gGgI2QvAGaVNuEN3U54lOm72wCx81wqRyIg/keo7StpD4Ey 2vtpeczphi3fw== From: Arnd Bergmann To: Mauro Carvalho Chehab Cc: niklas.soderlund+renesas@ragnatech.se, geert+renesas@glider.be, prabhakar.mahadev-lad.rj@bp.renesas.com, Arnd Bergmann , Hans Verkuil , Alexandre Courbot , Laurent Pinchart , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] media: rcar_drif: select CONFIG_V4L2_ASYNC Date: Wed, 21 Jul 2021 17:24:59 +0200 Message-Id: <20210721152522.2928952-1-arnd@kernel.org> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org From: Arnd Bergmann Without this, I see a randconfig link failure: aarch64-linux-ld: drivers/media/platform/rcar_drif.o: in function `rcar_drif_remove': rcar_drif.c:(.text+0x2a8): undefined reference to `v4l2_async_notifier_unregister' aarch64-linux-ld: rcar_drif.c:(.text+0x2b0): undefined reference to `v4l2_async_notifier_cleanup' aarch64-linux-ld: drivers/media/platform/rcar_drif.o: in function `rcar_drif_sdr_probe': rcar_drif.c:(.text+0x1444): undefined reference to `v4l2_async_notifier_init' aarch64-linux-ld: rcar_drif.c:(.text+0x14a0): undefined reference to `v4l2_async_notifier_register' aarch64-linux-ld: rcar_drif.c:(.text+0x14d8): undefined reference to `v4l2_async_notifier_cleanup' aarch64-linux-ld: rcar_drif.c:(.text+0x15a8): undefined reference to `__v4l2_async_notifier_add_fwnode_subdev' I could not easily figure out when this was introduced, as this code has not changed in a while but I only saw the problem recently. Signed-off-by: Arnd Bergmann --- drivers/media/platform/Kconfig | 1 + 1 file changed, 1 insertion(+) -- 2.29.2 Reviewed-by: Niklas Söderlund diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig index 157c924686e4..c5d1c83bd582 100644 --- a/drivers/media/platform/Kconfig +++ b/drivers/media/platform/Kconfig @@ -635,6 +635,7 @@ config VIDEO_RCAR_DRIF depends on VIDEO_V4L2 depends on ARCH_RENESAS || COMPILE_TEST select VIDEOBUF2_VMALLOC + select V4L2_ASYNC help Say Y if you want to enable R-Car Gen3 DRIF support. DRIF is Digital Radio Interface that interfaces with an RF front end chip. It is a