From patchwork Thu May 18 13:29:23 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gilad Ben-Yossef X-Patchwork-Id: 100099 Delivered-To: patch@linaro.org Received: by 10.140.96.100 with SMTP id j91csp721416qge; Thu, 18 May 2017 06:29:53 -0700 (PDT) X-Received: by 10.98.130.201 with SMTP id w192mr4683850pfd.34.1495114193109; Thu, 18 May 2017 06:29:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1495114193; cv=none; d=google.com; s=arc-20160816; b=RJ45y0FW5dopbsEdXi1z13C5UdImebAF2bwU/pz6PIhQgyzntHjDorw6BfdTdTvvqQ ry/xZ6XTSpLaKm9nls+VQbjwdj2vrT3EnKC4vyDLw5jAYjjyG56rbjTUj7KCSGYoADST VWMsZVrfBs6URS5EOQelGWoD/2wRudWvxgEKJNDnXmjG7kEoTMBZ7yzscAeRXDJ6oAJ+ ZXcqduMDhnhsAo4ih8I/WeyyNEIggfSHjq34H6Py/1Q5nx9K75sZMR1pnLBj0Ao4G8dm sp2n9hmBuSzcpyuHmWTBO7gqCMSKJmvbMAsyzem2ExcE32SnZKPn/wkf9D67M7W5mT7l aacg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=I15hSdpXKDpVO53ZJZBWV4xmQKgjfnzzvk+hUA2InRM=; b=xrmgZsqKC5/5TIkDtPT+Uo9jsPduPEQkT89RpjahrgGc7IfgrJJSYNxM5YnDEu/viC BFzi8FmgJq/uxa/k3S8vrKttDndVFZsQA5uIc5Yri1fzNi67Uq3KvKT6726toDi1oBTF LEbbQO7IRDUiRH8USdjnZF3p49SEVExtLAfmGYRfm7/UwWfDqfWPnMVnebJi7ja8kY+S 8QlSfHXxOkpJ4cSXnJcFng33l+SEf8zVq0NYjKXXEImAf5Brz9YUzwom0Z3K8lvi+79j JnROUk8tl9fJ+e8lxlNOebCYa+0VfdkwudSGhrc5cIrB1Gb/D+93LN1xHydANTYMU+0i DkXw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 71si5189047pfc.124.2017.05.18.06.29.52; Thu, 18 May 2017 06:29:53 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934379AbdERN3q (ORCPT + 6 others); Thu, 18 May 2017 09:29:46 -0400 Received: from foss.arm.com ([217.140.101.70]:60112 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932250AbdERN3n (ORCPT ); Thu, 18 May 2017 09:29:43 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1180915A2; Thu, 18 May 2017 06:29:38 -0700 (PDT) Received: from gby.emea.arm.com (usa-sjc-mx-foss1.foss.arm.com [217.140.101.70]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 252EA3F3E1; Thu, 18 May 2017 06:29:35 -0700 (PDT) From: Gilad Ben-Yossef To: Herbert Xu , "David S. Miller" , Jonathan Corbet , David Howells Cc: Ofir Drang , stable@vger.kernel.org, linux-crypto@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, keyrings@vger.kernel.org Subject: [PATCH v2 1/4] crypto: handle EBUSY due to backlog correctly Date: Thu, 18 May 2017 16:29:23 +0300 Message-Id: <1495114167-3073-2-git-send-email-gilad@benyossef.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1495114167-3073-1-git-send-email-gilad@benyossef.com> References: <1495114167-3073-1-git-send-email-gilad@benyossef.com> Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org public_key_verify_signature() was passing the CRYPTO_TFM_REQ_MAY_BACKLOG flag to akcipher_request_set_callback() but was not handling correctly the case where a -EBUSY error could be returned from the call to crypto_akcipher_verify() if backlog was used, possibly casuing data corruption due to use-after-free of buffers. Resolve this by handling -EBUSY correctly. Signed-off-by: Gilad Ben-Yossef CC: stable@vger.kernel.org --- crypto/asymmetric_keys/public_key.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.1.4 diff --git a/crypto/asymmetric_keys/public_key.c b/crypto/asymmetric_keys/public_key.c index d3a989e..3cd6e12 100644 --- a/crypto/asymmetric_keys/public_key.c +++ b/crypto/asymmetric_keys/public_key.c @@ -141,7 +141,7 @@ int public_key_verify_signature(const struct public_key *pkey, * signature and returns that to us. */ ret = crypto_akcipher_verify(req); - if (ret == -EINPROGRESS) { + if ((ret == -EINPROGRESS) || (ret == -EBUSY)) { wait_for_completion(&compl.completion); ret = compl.err; }