From patchwork Thu May 18 20:21:40 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 100132 Delivered-To: patch@linaro.org Received: by 10.140.96.100 with SMTP id j91csp8151qge; Thu, 18 May 2017 13:23:08 -0700 (PDT) X-Received: by 10.98.194.66 with SMTP id l63mr6476416pfg.234.1495138988706; Thu, 18 May 2017 13:23:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1495138988; cv=none; d=google.com; s=arc-20160816; b=PYfF0KbNkkAXOJCAmkoNpUhNSNC/G4cGqAT6I3qlZCtO9mDnxeXs3WoQDtJPmy1MwW ABK6ALoOXAmmrjwKxyi6DuBv0uHrfy7brCglOsGeYlng9237KXqnFtPfTSdFH2VM4kQz 19CmuEYn3bt5lguettUPph1SzSpUwIGDbGcDg7nVEFMPw4IRVBGUA8RDbQDJCEf3t3WY 9ZeQbQtCPwtWWZMoNgJeTa8lWuUTecvLRHnVKyxFEghvpqG0c64dPKtqwXq7TKg+frQn jfc94ZbAK68yH4YP9GbRwaoWDy1NwqqrSSgeWnghx+02Fe2gM37WsOPS1s+cHVeiJ7L5 Uk/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=kHgdh3FVMcHl7LeULJBWI5/GWOGSSdMW5TYV3o/H6nA=; b=Pc4ipU/PYrB+YibyYshNo2g9xk1/I6WH1fLuY6E9trn7flbNiSTsSqYjPyNQTBVSGo wMjhvUt1i+xvJASyjFZbw38spwYNlPjbC95TKQLjB+r686jpk0uID4Z1bG5oLEJjR24m Pcedl9Mz75aRCy7l5Wj/KWk+jHX0/XoFsljf6/S73sSJh27148TbD0WPgcR/ch4kz29X CpC8z2efnI5MfVNtsQhpPLhy4sv+tBVGrgqeH+cLDkRul8mHWQdg7A0d0RF3TqSUC+25 dboeLO3w+lXuSKjVpUxO72ZDz7UpaM9Z9Jet9MPBvaMK8xG5Waedw1e25SK1dacZcqU5 LFBw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-input-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-input-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l33si6172718pld.320.2017.05.18.13.23.08 for ; Thu, 18 May 2017 13:23:08 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-input-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-input-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-input-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755314AbdERUWw (ORCPT ); Thu, 18 May 2017 16:22:52 -0400 Received: from mout.kundenserver.de ([212.227.126.133]:60358 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755384AbdERUWr (ORCPT ); Thu, 18 May 2017 16:22:47 -0400 Received: from wuerfel.lan ([78.42.17.5]) by mrelayeu.kundenserver.de (mreue002 [212.227.15.129]) with ESMTPA (Nemesis) id 0MU9sv-1dcEAW1MP3-00Qj7P; Thu, 18 May 2017 22:22:29 +0200 From: Arnd Bergmann To: Srinivas Pandruvada , Jiri Kosina Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, arnd@arndb.de Subject: [PATCH v2 1/5] HID: intel_ish-hid: fix potential uninitialized data usage Date: Thu, 18 May 2017 22:21:40 +0200 Message-Id: <20170518202144.3482304-2-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 In-Reply-To: <20170518202144.3482304-1-arnd@arndb.de> References: <20170518202144.3482304-1-arnd@arndb.de> X-Provags-ID: V03:K0:JJk82XbVBVDrpf6it6urzSyvm1tT6Y94aVEB155MXiW5GSptAHu c6cAsx6D90ILl1ixTkAHUebWz8b/lHKY4D2iKrR31NPQxHAxhm5R8I7p6Kz/EjgjemNEcjY QlXt7i7c+E1l9on2H+pnlRzv2/x88qPhQ++7PrD9vWUaeCtRJA2fyHFVWmmbdsplTPUCWR7 xNxN9KsJWPp8ssS6S1zRQ== X-UI-Out-Filterresults: notjunk:1; V01:K0:gjT/O9ww4Eg=:BocJOxim9pDXrj4Y7bG/wX CrY9/kFNUiR+vqcCKrLLNNjDi5iAQvB02Gy4J3Js6jnvrw1asHFeHvAApp58/tRbt+7Bu+iK1 56Ga3WwrSWsJJY4vguxxKpZuDZ5RVG5bOkCJhIUZpGu8w0W9TEkJAQRNQ9Wzi2MxeAlAsIzvU nEHkD1lswLwicm3aGSq5ZOTKkbRz9JOHGhJbtmISinavRN3dNBtbkjn+27YnfZnqeLpPYmpKQ fI/GUoIgI/BeszAObfO67lFQ8QDoxPkI/F7z5xGNTLWNCLYJckv7O7XJopbfXVJbbs8N0n290 0z9pl610PRAXZsqB0QUg+UczSuGZPlIFjDrNu0JoNveCeOM+nx2PmWNPPUlby2zt+WSgA0+7a zrSYg3zpoMvm1vnOQT3cof768tt/rKEkznqZDLt0Aa8PXtINarj1rlANW7v/xMXjDlOJhGQRn s2NuBhLdbwfRLnP6HhKMwbbMVnWy3rq2bBmvVLv3c18jEXw6DdpMeSQyyl2KupSXmWsDggDuw HrDiQcW7uA+rC8XNSAGnP7OV5UjgYE+sgqAKwqSUAmTlohimIeOai8BZYhNuOw4oPIMysv70C A+XK+NUTFVM23nGkZ6+1GFvAQQXHHXGjMxGMhdC+MwBbJS8a3XwMkD88kOo7JvpzAEOWPjuFA Dsc3JyfiQxMIdFHKO79DnBttQarpUMK16goJEcTo2Zg7LLgmOEiIPQ8kdvDV/9uu0zL8= Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org gcc points out an uninialized pointer dereference that could happen if we ever get to recv_ishtp_cl_msg_dma() or recv_ishtp_cl_msg() with an empty &dev->read_list: drivers/hid/intel-ish-hid/ishtp/client.c: In function 'recv_ishtp_cl_msg_dma': drivers/hid/intel-ish-hid/ishtp/client.c:1049:3: error: 'cl' may be used uninitialized in this function [-Werror=maybe-uninitialized] The warning only appeared in very few randconfig builds, as the spinlocks tend to prevent gcc from tracing the variables. I only saw it in configurations that had neither SMP nor LOCKDEP enabled. As we can see, we only enter the case if 'complete_rb' is non-NULL, and then 'cl' is known to point to complete_rb->cl. Adding another initialization to the same pointer is harmless here and makes it clear to the compiler that the behavior is well-defined. Signed-off-by: Arnd Bergmann --- drivers/hid/intel-ish-hid/ishtp/client.c | 2 ++ 1 file changed, 2 insertions(+) -- 2.9.0 -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/hid/intel-ish-hid/ishtp/client.c b/drivers/hid/intel-ish-hid/ishtp/client.c index aad61328f282..78d393e616a4 100644 --- a/drivers/hid/intel-ish-hid/ishtp/client.c +++ b/drivers/hid/intel-ish-hid/ishtp/client.c @@ -925,6 +925,7 @@ void recv_ishtp_cl_msg(struct ishtp_device *dev, } if (complete_rb) { + cl = complete_rb->cl; getnstimeofday(&cl->ts_rx); ++cl->recv_msg_cnt_ipc; ishtp_cl_read_complete(complete_rb); @@ -1045,6 +1046,7 @@ void recv_ishtp_cl_msg_dma(struct ishtp_device *dev, void *msg, } if (complete_rb) { + cl = complete_rb->cl; getnstimeofday(&cl->ts_rx); ++cl->recv_msg_cnt_dma; ishtp_cl_read_complete(complete_rb); From patchwork Thu May 18 20:21:43 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 100133 Delivered-To: patch@linaro.org Received: by 10.140.96.100 with SMTP id j91csp8364qge; Thu, 18 May 2017 13:23:47 -0700 (PDT) X-Received: by 10.84.217.206 with SMTP id d14mr7158154plj.140.1495139027389; Thu, 18 May 2017 13:23:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1495139027; cv=none; d=google.com; s=arc-20160816; b=y9BYbKITQH+sCXaSFx9gA46dgfcE9eNnezy/N5aIFOVQcIMI7GJ8ECMwEdpBEEFD5W Qsd1mtcxPQ/ttOq6V972dSuGKRRGkvQTfs7JVzfEtDOq+I7EJJ93loWYMe8+yQ17+4Hc 475ZcqyLMPaHt+cvaVTg8WVBpFFOnLHemiqOM/B5lpO2EF7hOEDeIpQHv4MQrZu5+yED gELoHwU7D5G4/w4/TEDYELN8hFiwZ3WJNKvktTJQmmja+aYqBpsBNypcdhr1aOjuPsS7 EIE22iTXdPqDDviyUrd5XYbhTp6Pcf6g7no4cz0czBdbDQZ4AsAzfCapBGcT1ypAEns5 A4hw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=sPseHWdpcGVtgZZJJiH8rONIt0kmU9Lf2EOcA5Uv1DM=; b=tP7DSbz4jk9CrT8VgbfrtZd5mLU7tB5RCqlqN0rrN5jvm8UrcOe5C7NuSGid91+ayl bSSS8e0JFb4rbZMRdOoegbK49NHdDA2qdLEsRbyBLhEAnp+kHdSkrays0/aSsO6Q+0PM TABI26ZUBALU1AFnM5pR8Xvjv5Chj/WjIKGGPxxKwzFNKnY/sCGtZqp1M3evN6cWMNKl l3/56HArb4On8Sw5T9e2cAPncqqiqGGnCqhUfWxcBRXeqIJL/OuP432hinp7I3fSjP3r sSROpGOpptDD3fXnjSGhaIOXXRA9HdLq65klsB4FUplQbA5lh54t86F3eYQADmVOyAzP BCig== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-input-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-input-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g13si6211045plk.247.2017.05.18.13.23.47 for ; Thu, 18 May 2017 13:23:47 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-input-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-input-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-input-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753965AbdERUXa (ORCPT ); Thu, 18 May 2017 16:23:30 -0400 Received: from mout.kundenserver.de ([212.227.126.134]:58492 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754053AbdERUWi (ORCPT ); Thu, 18 May 2017 16:22:38 -0400 Received: from wuerfel.lan ([78.42.17.5]) by mrelayeu.kundenserver.de (mreue002 [212.227.15.129]) with ESMTPA (Nemesis) id 0LhGOe-1dpEgQ0H1k-00mdl0; Thu, 18 May 2017 22:22:30 +0200 From: Arnd Bergmann To: Srinivas Pandruvada , Jiri Kosina Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, arnd@arndb.de Subject: [PATCH v2 4/5] HID: intel_ish-hid: fix format string for size_t Date: Thu, 18 May 2017 22:21:43 +0200 Message-Id: <20170518202144.3482304-5-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 In-Reply-To: <20170518202144.3482304-1-arnd@arndb.de> References: <20170518202144.3482304-1-arnd@arndb.de> X-Provags-ID: V03:K0:+xuMthQhX+dBShQwirP5TmOS9l3pL8l2MaTD5tRH0Eudb1r9RN2 Fewdu3Yb3bPDuebwK6P4MhB9vTiPdO4BDN4YkhC3Xfgl7NQHMpi5DWwTakE/T3+NLVKg8z5 7iBLXAz19w6rhnuziLXYCGLzUJbzrQiN4F/j/K7NfwgRgm8dHGO5cVkj4ncigSJmmSMXaZN lR9vquwN/w7kiDNTMdrfA== X-UI-Out-Filterresults: notjunk:1; V01:K0:dkVFRKlA8pQ=:ZWnDS2v7zKWnmdEU6tikTr XCJ55QP4+koimU4vwve7LLY0h1bpcM3w2YBGG1+865jy+4g3YP62TEOa4fuhO8j/NBh6EKOrd Nrm62D/JTFx2H6+dE2qomY6a2jT4iIriZaoUJf9EvBMsIEGFgzauwdwUJagOddSTcjVW82ps8 A3MKxRXukqVHOBuiU7Ib/0rnIJLRBjBC5Q/r5olyC/JGbmDfXHIfhcFQdY5oD3V27UOLk/wHP efz3q1oZRDK7D/VbbcdLX1yFvQfzpyJHk+2ZXO+o0XjUYJYTeQzFoCzhHznZ5FwiJjj3lmKpE Zw/URXEvN8nOUzWc/aJ7hHIRxyyIhQYzUA55Il/qeuJ7vMCTtH9k3DoMfRoOvATdCPwFvjgKi f0bjz/wHD6njNyKrW9nS9/Hvbrf9stowys4S5UIjoOZTmAgkWGssNQwdojjaoSnnJiybxWWpx Uk3DMhfy3Iq0EkzeUr0tNeXyRHQX1bzlR8MZ8uWcK4QpGltZ1prCWt3RDI117vWHuso2bSspZ eDucz/WCAHWWY6oJWhHkL1tijHAEYzgygkscivbXV3ljjA2hNIU7sCxQxear5Xq0vxLXD0zAZ Z9NqO5KPPy/GFBKED6Dshsp9d0uouhO+fyj/J90oDw0wRxxJz6OB+IvDWZa3R/E/WmVluce1K 8miutOUuMr8gA6VZfm8EhtgsdLTQuRBE6/dhLHYvCyso4HiSDUJ7ZbCI8vmsid9iO+ys= Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org When building for 32-bit architectures, we get a harmless warning: intel-ish-hid/ishtp-hid-client.c: In function 'process_recv': intel-ish-hid/ishtp-hid-client.c:139:7: error: format '%lu' expects argument of type 'long unsigned int', but argument 3 has type 'unsigned int' [-Werror=format=] This changes the format string to print size_t variables using %zu instead. Signed-off-by: Arnd Bergmann --- drivers/hid/intel-ish-hid/ishtp-hid-client.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) -- 2.9.0 -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/hid/intel-ish-hid/ishtp-hid-client.c b/drivers/hid/intel-ish-hid/ishtp-hid-client.c index 5c643d7a07b2..157b44aacdff 100644 --- a/drivers/hid/intel-ish-hid/ishtp-hid-client.c +++ b/drivers/hid/intel-ish-hid/ishtp-hid-client.c @@ -136,10 +136,9 @@ static void process_recv(struct ishtp_cl *hid_ishtp_cl, void *recv_buf, if (1 + sizeof(struct device_info) * i >= payload_len) { dev_err(&client_data->cl_device->dev, - "[hid-ish]: [ENUM_DEVICES]: content size %lu is bigger than payload_len %u\n", + "[hid-ish]: [ENUM_DEVICES]: content size %zu is bigger than payload_len %zu\n", 1 + sizeof(struct device_info) - * i, - (unsigned int)payload_len); + * i, payload_len); } if (1 + sizeof(struct device_info) * i >= From patchwork Thu May 18 20:21:44 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 100130 Delivered-To: patch@linaro.org Received: by 10.140.96.100 with SMTP id j91csp7975qge; Thu, 18 May 2017 13:22:41 -0700 (PDT) X-Received: by 10.84.174.197 with SMTP id r63mr7021310plb.67.1495138961245; Thu, 18 May 2017 13:22:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1495138961; cv=none; d=google.com; s=arc-20160816; b=cKkVsuRrfdmggYAUDCdTKZSxb2c9npMiwMMa/zA5y0JxtsQgKGoCTYk70vMDLKXJpm Th3GLhjTihaKLTv8PYTMazzBtAfifszORv5LYHgaf/42i8BdyOAEV6R+8JQwKH6mqHqB z/T7AiyGOBBwa1doKT6PqwyHamDq5+gXKRCR+wLz7uyhR52qfYlf2wlWY6fPyypet/x4 SNuWA/mu3f60leRJ1e7BbZ4qkd7S3AqKRMDBzYUMBRZZdSsBUoDMpaqlw/ij7/u0fDA6 jTzMqMPqXrbNtgQRS1XLLj2dgUZEevpXS9gh9RqLMZwuvi8UIfXxVxU3JlXrRYe97Aw/ WIEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=z6FKTPhz6tK6/uwUxBf8XUlEWg/2odRCNvAjXtzUHr0=; b=TsIOrz/BxcOO+yoqXUz4vZLRzivq9kPM3kxy+7J9BATS+PIl0RmD5ZsXU846kvtIyJ kyw0y3bTJWJhKxBS62Mxg2fJl77mT8xYWXSzAqbDg/RIXBZjS4uEWnzDCycGdO01GEW8 LGqy5UxLT+U0GS7z0lNsSs9rH+Zyp802eCMsqEcU5yGOr7+ZXN7zHp/ypx223kd2t5P4 vpYdw7dH8yWCEOXwHNRBqahr/TmsPpL2TYoP05R6dUOxnk4K0wWduNtootSZw1i5Izms uu21tmxuKFGfimYDmA+xlyUo+6+Ec7ydtmnjHkkAF77YCWf0k5hY/N1svHUMHT602CDr ZsyQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-input-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-input-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u26si6159799pgn.124.2017.05.18.13.22.41 for ; Thu, 18 May 2017 13:22:41 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-input-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-input-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-input-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754288AbdERUWi (ORCPT ); Thu, 18 May 2017 16:22:38 -0400 Received: from mout.kundenserver.de ([212.227.126.135]:51952 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751200AbdERUWh (ORCPT ); Thu, 18 May 2017 16:22:37 -0400 Received: from wuerfel.lan ([78.42.17.5]) by mrelayeu.kundenserver.de (mreue002 [212.227.15.129]) with ESMTPA (Nemesis) id 0MEfH7-1dDzBv1ZZx-00FmuV; Thu, 18 May 2017 22:22:30 +0200 From: Arnd Bergmann To: Srinivas Pandruvada , Jiri Kosina Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, arnd@arndb.de Subject: [PATCH v2 5/5] HID: intel_ish-hid: enable compile testing Date: Thu, 18 May 2017 22:21:44 +0200 Message-Id: <20170518202144.3482304-6-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 In-Reply-To: <20170518202144.3482304-1-arnd@arndb.de> References: <20170518202144.3482304-1-arnd@arndb.de> X-Provags-ID: V03:K0:GTDNxOKCyYbtpz1KyJaouifrSSjDhAKYRNP36/qdNTmn70ftqlN Ol9WU+t6CYeNpcQ9dSLeplKDUTW67vXVhoYAK+SrdOUhg1voZVcQud5gT5ALUFFVcow3lLX 7u/4CNO/5r9M8dS1Yo/YfUs2dWWCb+0p5LL+igAyoJzR7q68lxz0L2XSO+VuqEuPwKMSOUY wifcZQNTzKOyonA4yDbtA== X-UI-Out-Filterresults: notjunk:1; V01:K0:bjq8Zv89r1g=:l9Ra04J+qZtfgbCvf5YgVV JyMUYbIuFWRzLt/7wrigshCyd9X9L/Dg9o/1CC1d990W1Spphb2CrOc31RkN0hBYCyEqHAVcY knrjGhUWtOkZfA4AzGxcdp6oMP/aPJ2QIodqlHnX0n4E50V6AuAkGO76kZ2Ek7ECzH3aM1VsB nPcqaIJdz/tyD4Pb0GPz1RJPe4oe4NsxZifz5MB6Vwb/Vc22aL3/q2IMJa7NOypvIkhwb58YK d6fCF1GpT/NepCBhkIgAXbThzXCz5FxyRmHezdCQ8brM7yYUHYu8np/ZW2u7QRu1wG+3fXydh fi2jlhi3aJgAy7wVm7RWycPSdSi0iacF9oZGS+6fSu7XqYH83gdmQRqCd6N44pVdAcVMvhsEc tyCglhi2baFDcu7hlndQUS6FI94OXCaV5IRornVwfSidUMze7TqTFRJi6Z/NBWarhd+5/spK6 hZGnWgS+nsK8xY7xeKL7Kj5hn0FTVas8MjZNHx+Ikmbh/qj6KZQ8WUkpvAr6IJ7UhYAVIHkRG 5PAVJB+A65gCsjSq6wwqjFUEdbo7cOG+zVnEim4QqMvIhu68PLg8wPw4ccZ0g3xTPU7UXFXgH 6c6+EKQ+oyPwyAB4QYMVB1zGPiVmpA36nCQYYw60A6+uxSwo9FNoZEWjdidDJXyYPY9wHCSuQ wZJfo4MfdhPtxvT4jN8I+9Yrky6cM1ihml3TMAb05J2Xvnz4bpzvDjCyyLpBrG/7xXyk= Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org To increase build coverage, drivers should generally be allowed to build on other architectures even if they are only used on one of them. Signed-off-by: Arnd Bergmann --- drivers/hid/intel-ish-hid/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.9.0 -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/hid/intel-ish-hid/Kconfig b/drivers/hid/intel-ish-hid/Kconfig index ea065b3684a2..519e4c8b53c4 100644 --- a/drivers/hid/intel-ish-hid/Kconfig +++ b/drivers/hid/intel-ish-hid/Kconfig @@ -1,5 +1,5 @@ menu "Intel ISH HID support" - depends on X86_64 && PCI + depends on (X86_64 || COMPILE_TEST) && PCI config INTEL_ISH_HID tristate "Intel Integrated Sensor Hub"