From patchwork Thu Aug 12 08:23:51 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Petko Manolov X-Patchwork-Id: 496466 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D540DC4320A for ; Thu, 12 Aug 2021 08:24:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B340C60F21 for ; Thu, 12 Aug 2021 08:24:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235155AbhHLIZE (ORCPT ); Thu, 12 Aug 2021 04:25:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48428 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233921AbhHLIZD (ORCPT ); Thu, 12 Aug 2021 04:25:03 -0400 Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9A18CC0613D3 for ; Thu, 12 Aug 2021 01:24:38 -0700 (PDT) Received: by mail-ej1-x632.google.com with SMTP id w5so9963075ejq.2 for ; Thu, 12 Aug 2021 01:24:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=0E/vbwx7PnVTaW/i9W1bqAmgVUxQr9vmSffqRRom5h4=; b=YvQptj8iwTiInbVdLjaaVHuPtyEgdWVuDMTPSl7EL4ULf7svk8NAsRSoyDNEuDo0yQ kJUw9O6jzigriZzrrsKqrocXLiPJVTYoxPVfI6/ahPWcg54jojukzBqHvdI7d//rJGEI UQS/xQS6yU2H0Izss+vjW8uu8uANCtJ1RnH2s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=0E/vbwx7PnVTaW/i9W1bqAmgVUxQr9vmSffqRRom5h4=; b=hPxwEYIQlP+fiDQD/MxvVrVAFxcqJvgLTXRIcCVEWE1iVVzcdwwDbRxNcydkjzfBfK XRLdARgQmeeRfLWI+pgxeMCLSJZR8rZSqvZdi8DtQjo5k8WpWXeSTnBIq4lKocbMJjnw GJ/+S44n9btoElNj79DQarYrb09pkvv0x37l6KHSh3YhiRX+hLFlf300oqnai4u05nhz Z1YVoX6/dQPGAF8/hB1E9JjmidL30lmStMDvS76el27d1LFKvgfZD/gGKC2UM87lw8Bg uG/ohlBdyfMU3RVH1srvfE51fB4yDmXs/tUfBtBrTrDejfhiKkeSneShWK+piWX83FhG oKoA== X-Gm-Message-State: AOAM531LcPjGfL2nBvAk8oFXiM1FoA87kIkA6jKnYtJq8klRAoGFq6sj 6NNmHAJtxb1f3g7LnYUx06EUksCMVVjXFQ== X-Google-Smtp-Source: ABdhPJwYqBxHMVhEkSUleMSRb0fugm6fyfTgh++akaCC7gnKWpZdesPZjDN8zrZpliyfPmpuPRhvsw== X-Received: by 2002:a17:906:5909:: with SMTP id h9mr2469624ejq.329.1628756676958; Thu, 12 Aug 2021 01:24:36 -0700 (PDT) Received: from taos.k.g (lan.nucleusys.com. [92.247.61.126]) by smtp.gmail.com with ESMTPSA id v24sm783165edt.41.2021.08.12.01.24.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Aug 2021 01:24:36 -0700 (PDT) From: Petko Manolov To: netdev@vger.kernel.org Cc: paskripkin@gmail.com, stable@vger.kernel.org, davem@davemloft.net, Petko Manolov Subject: [PATCH] net: usb: pegasus: ignore the return value from set_registers(); Date: Thu, 12 Aug 2021 11:23:51 +0300 Message-Id: <20210812082351.37966-1-petko.manolov@konsulko.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The return value need to be either ignored or acted upon, otherwise 'deadstore' clang check would yell at us. I think it's better to just ignore what this particular call of set_registers() returns. The adapter defaults are sane and it would be operational even if the register write fail. Signed-off-by: Petko Manolov --- drivers/net/usb/pegasus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/usb/pegasus.c b/drivers/net/usb/pegasus.c index 652e9fcf0b77..49cfc720d78f 100644 --- a/drivers/net/usb/pegasus.c +++ b/drivers/net/usb/pegasus.c @@ -433,7 +433,7 @@ static int enable_net_traffic(struct net_device *dev, struct usb_device *usb) data[2] = loopback ? 0x09 : 0x01; memcpy(pegasus->eth_regs, data, sizeof(data)); - ret = set_registers(pegasus, EthCtrl0, 3, data); + set_registers(pegasus, EthCtrl0, 3, data); if (usb_dev_id[pegasus->dev_index].vendor == VENDOR_LINKSYS || usb_dev_id[pegasus->dev_index].vendor == VENDOR_LINKSYS2 ||