From patchwork Tue Oct 2 21:02:49 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 148019 Delivered-To: patch@linaro.org Received: by 2002:a2e:8595:0:0:0:0:0 with SMTP id b21-v6csp5633792lji; Tue, 2 Oct 2018 14:04:58 -0700 (PDT) X-Google-Smtp-Source: ACcGV63Otz+mkMYO5z5NbjAMoIAn73khj2gDn69MBhOLdI+g4gqNm3+FyMP1sUlHZGl3975F8CKh X-Received: by 2002:a63:a309:: with SMTP id s9-v6mr15918092pge.106.1538514298680; Tue, 02 Oct 2018 14:04:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538514298; cv=none; d=google.com; s=arc-20160816; b=mqylgQdY1Wo6mJHvXSYi/8Ue9sYtJRlX7K2tLvgBK+tP6SbEaTV0hRhoAodDLVocjb 2bhgI5C6vC16C9AfZW+yD/HCDWTAouhF+9ch32e6/45bxD9AX0R1MzcjIOli27aN5ctf hjNOUrob3EK2yFzul4e79e9m0UQLwEEseXG4d/aV5/jxn2NW/BWhl5WC2TOEa8/C0pnB iO5dJr+yPpBfGkSf4/1p9wVoS3hkJsgpnoTyDAggVPvzZEJF3z4Hcp48d6ZTG2fr/b0v LvmRnqTvuMIppnVx2B2XvuCBxa9C0v4iMzQlGaHnFgOz+KSqOyKYNPX97+OWG35GmL2F Vx/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from; bh=M54tUDuDZdHXCxA4J9XKFux5Z1EVeXS06BLbF1eJpmM=; b=VMO4CBusKow5UX64QRbQi1rse8XCR5b4k+S9b62Qz0oIFomGGikgy98EmFMTAIVlBv VAYJCd1UJUIXRyQC1SIPaTSeY8obscPN+cqv2eGm9sO9dIXMnG4G1zeWK7+/D5ZAWqrS D7n4X3TRpSSP/I33VwhysLtW+7phMovGJrULzC574BVboWAlqQ2Pgk/5BWmVv9UOYiHv /IDLuYh4TZ1XuVQh83uqKXyWtASgIoQ5XJm0nAUiHh2ir5Oz8ra55Y8UJ651L1jqQWdP KV6Y7pfo9o+VZ8iXyk3CKOslXvMragm+kLcwXu4mbrUUj0rxBGg9XdvUc0w2pmW5A7Um /MRQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of dmaengine-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=dmaengine-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c13-v6si15767635pfb.153.2018.10.02.14.04.58; Tue, 02 Oct 2018 14:04:58 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of dmaengine-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of dmaengine-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=dmaengine-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726679AbeJCDuN (ORCPT + 3 others); Tue, 2 Oct 2018 23:50:13 -0400 Received: from mout.kundenserver.de ([212.227.126.187]:46753 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726274AbeJCDuM (ORCPT ); Tue, 2 Oct 2018 23:50:12 -0400 Received: from wuerfel.lan ([109.193.40.16]) by mrelayeu.kundenserver.de (mreue011 [212.227.15.129]) with ESMTPA (Nemesis) id 1Mq33i-1fKNqf2Gpe-00n9xG; Tue, 02 Oct 2018 23:04:31 +0200 Received: from wuerfel.lan ([109.193.40.16]) by mrelayeu.kundenserver.de (mreue011 [212.227.15.129]) with ESMTPA (Nemesis) id 1Mq33i-1fKNqf2Gpe-00n9xG; Tue, 02 Oct 2018 23:04:31 +0200 From: Arnd Bergmann To: Bjorn Helgaas Cc: Arnd Bergmann , Oza Pawandeep , Jeff Kirsher , "David S. Miller" , Solarflare linux maintainers , Edward Cree , Jacob Keller , Amritha Nambiar , Alan Brady , Alexander Duyck , Shannon Nelson , Jesper Dangaard Brouer , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org Subject: [PATCH] XXX PCI/AER: remove unused variables Date: Tue, 2 Oct 2018 23:02:49 +0200 Message-Id: <20181002210426.2447078-1-arnd@arndb.de> X-Mailer: git-send-email 2.18.0 X-Provags-ID: V03:K1:TUaN67X+02X+EMKP+hSGNGkckQwTSrG1GZm1Rp8wzdVRgJ0/msV +Lqs2e2/fzCFdbuoTP96rWq7TfSecHVEmIVKvVBn8nDwdtOQWNY0HCoMUqMUlWjfYNrX80S 06R7zyF9gV4K+CbolRuboeiGMwT9fbHJmoSUgLiHSxn8aI0wrBnwqT7NwUYJYOLv3nA+pO5 C6DiC/NXMmSuAgtBSA2ag== X-UI-Out-Filterresults: notjunk:1; V01:K0:KKWO7N0/Hl0=:pqjrm2NPGvnf+wEoqC0x7b cul3KaqJ9/98//C6V8WF1anZXr+lin8S+3usOg4BmiAucy9LK9Ga9wR9sEcv7y9utl9k3Bbi1 NQCi5qJjSiTyFET2pcT5srVBbJuY5d1eoUEGLmwdRL93xzLFf8bRZWFUTs2NT3CnFWWPrRAIT GTWd+73I7G2vVHGpn8YdYdlbNEUUehfj1qjOxdXtg/qdSgWTJ8yxJyscntBYX5qagBMEUnMgg VV68K3tZ/bW4u76ZH7HeRr5IBKWrdwm2KLCPECVetLjNw8Qne2okxDX1CfCf0R8Hfqhnr1kgW eZfeA994zaiqkG8lnnKNK0EXhlhyET+sBZkYQOjvhdHV1/6WEcKShyzLZWYNdbeoGsL2dY+if dSSwXgp5eL9zeeruGOr81dDpl+ybmrTdTkJXLOzpdRt6SJxXcuIRrVNyBdOSJjdLPFWrD+SnD vTzMaz08eXDPHFVEit99Ru2EYq/qB2p844U+5x0y1sxOx25vy8xEY7JKx/C3BgTOM0Ui2Asvx 0cx4Ca6sdPXsmnt3466oQmnAAJ6VYMMQZ7HO0uq9j360WqFMFGe6XOcdqUwon59wK1AoE7aoO 4/eVxcvtV1PVyB/rtRwVu4NGQ4XqMHp1CMw2isJNdBPj0DodfXOzemgwlmv/SyLOMPuP7Y1Tg 7X3rJR+PDGy4OH4NYUD3xzOYQT3HEfC11/0xsUxQ2oy2T0YVFS0v3NOmqOz6JxGtXUkU= Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org A couple of files now contain a function with a return code variable that is no longer used: drivers/net/ethernet/sfc/efx.c: In function 'efx_io_slot_reset': drivers/net/ethernet/sfc/efx.c:3824:6: error: unused variable 'rc' [-Werror=unused-variable] int rc; ^~ drivers/net/ethernet/sfc/falcon/efx.c: In function 'ef4_io_slot_reset': Oza Pawandeep drivers/net/ethernet/sfc/falcon/efx.c:3163:6: error: unused variable 'rc' [-Werror=unused-variable] int rc; ^~ drivers/net/ethernet/intel/ixgbe/ixgbe_main.c: In function 'ixgbe_io_slot_reset': drivers/net/ethernet/intel/ixgbe/ixgbe_main.c:11143:6: error: unused variable 'err' [-Werror=unused-variable] int err; ^~~ drivers/net/ethernet/intel/i40e/i40e_main.c: In function 'i40e_pci_error_slot_reset': drivers/net/ethernet/intel/i40e/i40e_main.c:14555:6: error: unused variable 'err' [-Werror=unused-variable] int err; drivers/dma/ioat/init.c: In function 'ioat_pcie_error_slot_reset': drivers/dma/ioat/init.c:1255:6: error: unused variable 'err' [-Werror=unused-variable] int err; This removes all the ones I found during randconfig build testing. Fixes: 6dcde3e574b2 ("XXX PCI/AER: Remove pci_cleanup_aer_uncorrect_error_status() calls") Cc: Oza Pawandeep Cc: Bjorn Helgaas Signed-off-by: Arnd Bergmann --- drivers/dma/ioat/init.c | 1 - drivers/net/ethernet/intel/i40e/i40e_main.c | 1 - drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 1 - drivers/net/ethernet/sfc/efx.c | 1 - drivers/net/ethernet/sfc/falcon/efx.c | 1 - 5 files changed, 5 deletions(-) -- 2.18.0 Acked-by: Vinod Koul diff --git a/drivers/dma/ioat/init.c b/drivers/dma/ioat/init.c index 80c475fb8ede..bd8db5c99597 100644 --- a/drivers/dma/ioat/init.c +++ b/drivers/dma/ioat/init.c @@ -1252,7 +1252,6 @@ static pci_ers_result_t ioat_pcie_error_detected(struct pci_dev *pdev, static pci_ers_result_t ioat_pcie_error_slot_reset(struct pci_dev *pdev) { pci_ers_result_t result = PCI_ERS_RESULT_RECOVERED; - int err; dev_dbg(&pdev->dev, "%s post reset handling\n", DRV_NAME); diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c index 4654ac69dfb6..bc71a21c1dc2 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_main.c +++ b/drivers/net/ethernet/intel/i40e/i40e_main.c @@ -14552,7 +14552,6 @@ static pci_ers_result_t i40e_pci_error_slot_reset(struct pci_dev *pdev) { struct i40e_pf *pf = pci_get_drvdata(pdev); pci_ers_result_t result; - int err; u32 reg; dev_dbg(&pdev->dev, "%s\n", __func__); diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c index 9bee51d900ac..0a2b9cad4b1c 100644 --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c @@ -11140,7 +11140,6 @@ static pci_ers_result_t ixgbe_io_slot_reset(struct pci_dev *pdev) { struct ixgbe_adapter *adapter = pci_get_drvdata(pdev); pci_ers_result_t result; - int err; if (pci_enable_device_mem(pdev)) { e_err(probe, "Cannot re-enable PCI device after reset.\n"); diff --git a/drivers/net/ethernet/sfc/efx.c b/drivers/net/ethernet/sfc/efx.c index ec941ca967b3..98fe7e762e17 100644 --- a/drivers/net/ethernet/sfc/efx.c +++ b/drivers/net/ethernet/sfc/efx.c @@ -3821,7 +3821,6 @@ static pci_ers_result_t efx_io_slot_reset(struct pci_dev *pdev) { struct efx_nic *efx = pci_get_drvdata(pdev); pci_ers_result_t status = PCI_ERS_RESULT_RECOVERED; - int rc; if (pci_enable_device(pdev)) { netif_err(efx, hw, efx->net_dev, diff --git a/drivers/net/ethernet/sfc/falcon/efx.c b/drivers/net/ethernet/sfc/falcon/efx.c index 9b728efd71a4..8b1f94d7a6c5 100644 --- a/drivers/net/ethernet/sfc/falcon/efx.c +++ b/drivers/net/ethernet/sfc/falcon/efx.c @@ -3160,7 +3160,6 @@ static pci_ers_result_t ef4_io_slot_reset(struct pci_dev *pdev) { struct ef4_nic *efx = pci_get_drvdata(pdev); pci_ers_result_t status = PCI_ERS_RESULT_RECOVERED; - int rc; if (pci_enable_device(pdev)) { netif_err(efx, hw, efx->net_dev,