From patchwork Wed Sep 1 09:11:55 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 505007 Delivered-To: patch@linaro.org Received: by 2002:a02:8629:0:0:0:0:0 with SMTP id e38csp67907jai; Wed, 1 Sep 2021 02:12:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwuohnDevlVD/HsyhClMSUYspxBrO+7Rs3QliuoV3hs+FCC9fsFeytmY0uPr57PLaLecOaC X-Received: by 2002:a02:9542:: with SMTP id y60mr6775508jah.87.1630487533017; Wed, 01 Sep 2021 02:12:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1630487533; cv=none; d=google.com; s=arc-20160816; b=m8oWvSYNdxzrgg2zIDeJ2Wj0xhPwfeayf5AKMNuS0wvjxoHnAah99ECX8F+HQvQIzu YEVGXfMQbJmctJXcfQiMdVMOD4ZLhwCVpLjkPWRMoOL9EoN5QVMWVn7lrX6JpYU31o9d NuWTvkMQzh71WDLCXj2we41XUVAd21cJc9eVz9ubx34S808BdG3pbuEfD0arfx3S4Zc7 TXGruJ4f1QlFG6qpDgsXpbUJSlQDn0n/IRkz9WpEbfkWDO4gBP1apsnkih2exqboXUH0 1hMbVNjQ5T/GLPi9aCaPylSFVG6eepyLb4n69c6mOPf4WIIGupDutzVpB6UB9SxOTN6U kIyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=gWah+IetMQ7aNpxLyaztsF0WudYoMWYnrUia/FiXZFE=; b=tRcX7edlbBScZ9UlaYKyQhgtYn1ex/H3dIF7u3EA0aYX4ZN57z02CxYh6eUcUwJaAL b5d4tQWyf4qpEzs46bdP3qDvh0lvSF70YxvPf58Op52Litn5XTzb6Zi6siPEzNqauKez wd9jM2QDdBG4DplHJ0VcMKLr9nhCJWWbWQ0U+0KuupNR+lNg6JLHI6+Cgxp9L4FjFD15 oKmzcl9ME9f0vnLl07FifzWTYeB6iyn9423xe0idnTxNjUnoguW67TNpvybRDIi/1hSq JO//laS2lgezEDa3yVxBN9zeBrY2Ex1iNcM1SnmR+Hkauvl3MEYjXHsZ6uB3C8zb78Oe nE4g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=aazJOhw6; spf=pass (google.com: domain of linux-pm-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-pm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x11si21248562ion.51.2021.09.01.02.12.12; Wed, 01 Sep 2021 02:12:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-pm-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=aazJOhw6; spf=pass (google.com: domain of linux-pm-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-pm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243438AbhIAJNI (ORCPT + 7 others); Wed, 1 Sep 2021 05:13:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39882 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243434AbhIAJNH (ORCPT ); Wed, 1 Sep 2021 05:13:07 -0400 Received: from mail-pf1-x429.google.com (mail-pf1-x429.google.com [IPv6:2607:f8b0:4864:20::429]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1204DC061575 for ; Wed, 1 Sep 2021 02:12:11 -0700 (PDT) Received: by mail-pf1-x429.google.com with SMTP id 2so1527344pfo.8 for ; Wed, 01 Sep 2021 02:12:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gWah+IetMQ7aNpxLyaztsF0WudYoMWYnrUia/FiXZFE=; b=aazJOhw6HmE6zAcrZkuwG0M7/uRCKODFPzfpvRHRaD6cLUQwpOsG1cDMogCOJZysEb Q4F2+2YU/y3IVyGuj9Bcx66RAX+frBRLcM9vPPd4HFo+COp6uOq4fZCZXtHSSMqMeSzE bGJpPBzsntnWAZcje8IrxGaXJYDH1LLwYVEU2fNh3Xisv1pezDu3TOCxa7Nhlo1VdR39 WERAywUyhhAP02r07m8yqwp5VinT2c5wCAerCFHgkDo4p9v6GlS39o3fuXdA72QBeivf hfzQWQSJ2UkxwnJ4OHS2J1HvjLMHe1OsIrm4VlI3Zx6kUfFdU/i1ZGq96Phb1JJ8Qmo7 UMvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gWah+IetMQ7aNpxLyaztsF0WudYoMWYnrUia/FiXZFE=; b=lM6+Nw07Dn14v3dAAoBgsYiTI7vxcx1+IfKjMF6k6itUuvwx9lcXnghyjycmpw80O9 R+Fq33pp/D0tIb+tpIsqD2b8OGeDgIOHOAMAhWbXUYO9DhDCzw9zCT2QqYqPAmsoCHNd ydd6BtE2In72oN46AhM9D/Ob1WRzJ7aLJ0v6/4DHhVN1fI1TmHRd128sUQYwfFXfynRV TdFJb4EW8zQDo1BGZXfVU5AuzSM7zS2YrxMwoeOMWIBHDFz1U1dgXv7XKNlymj0F3ftG jje1rBv9QK3LziauuiTZ2H6h43E7M4mE07+YwtbpXbLcXptsqORi9ZmDtxAsK2vgrMUm gjTg== X-Gm-Message-State: AOAM530hUITtn4otVdAUxta4I8VgAOp1p3SIeEIklpPPXlAuYpnd3bSr Jmty4IKU3/4xv1QpS5dEiWv+Cw== X-Received: by 2002:a63:8f4a:: with SMTP id r10mr31328737pgn.337.1630487530535; Wed, 01 Sep 2021 02:12:10 -0700 (PDT) Received: from localhost ([122.172.201.85]) by smtp.gmail.com with ESMTPSA id g141sm1062034pfb.128.2021.09.01.02.12.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Sep 2021 02:12:10 -0700 (PDT) From: Viresh Kumar To: Rafael Wysocki , Viresh Kumar Cc: linux-pm@vger.kernel.org, Vincent Guittot , linux-kernel@vger.kernel.org Subject: [PATCH 1/3] cpufreq: acpi: Remove acpi_cpufreq_cpu_ready() Date: Wed, 1 Sep 2021 14:41:55 +0530 Message-Id: X-Mailer: git-send-email 2.31.1.272.g89b43f80a514 In-Reply-To: References: MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org The ready() callback was implemented earlier for acpi-cpufreq driver as we wanted to use policy->cpuinfo.max_freq for which the policy was required to be verified. That is no longer the case and we can do the pr_warn() right from ->init() callback now. Remove acpi_cpufreq_cpu_ready(). Signed-off-by: Viresh Kumar --- drivers/cpufreq/acpi-cpufreq.c | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) -- 2.31.1.272.g89b43f80a514 diff --git a/drivers/cpufreq/acpi-cpufreq.c b/drivers/cpufreq/acpi-cpufreq.c index b49612895c78..28467d83c745 100644 --- a/drivers/cpufreq/acpi-cpufreq.c +++ b/drivers/cpufreq/acpi-cpufreq.c @@ -889,6 +889,9 @@ static int acpi_cpufreq_cpu_init(struct cpufreq_policy *policy) policy->fast_switch_possible = !acpi_pstate_strict && !(policy_is_shared(policy) && policy->shared_type != CPUFREQ_SHARED_TYPE_ANY); + if (perf->states[0].core_frequency * 1000 != freq_table[0].frequency) + pr_warn(FW_WARN "P-state 0 is not max freq\n"); + return result; err_unreg: @@ -918,16 +921,6 @@ static int acpi_cpufreq_cpu_exit(struct cpufreq_policy *policy) return 0; } -static void acpi_cpufreq_cpu_ready(struct cpufreq_policy *policy) -{ - struct acpi_processor_performance *perf = per_cpu_ptr(acpi_perf_data, - policy->cpu); - unsigned int freq = policy->freq_table[0].frequency; - - if (perf->states[0].core_frequency * 1000 != freq) - pr_warn(FW_WARN "P-state 0 is not max freq\n"); -} - static int acpi_cpufreq_resume(struct cpufreq_policy *policy) { struct acpi_cpufreq_data *data = policy->driver_data; @@ -955,7 +948,6 @@ static struct cpufreq_driver acpi_cpufreq_driver = { .bios_limit = acpi_processor_get_bios_limit, .init = acpi_cpufreq_cpu_init, .exit = acpi_cpufreq_cpu_exit, - .ready = acpi_cpufreq_cpu_ready, .resume = acpi_cpufreq_resume, .name = "acpi-cpufreq", .attr = acpi_cpufreq_attr, From patchwork Wed Sep 1 09:11:56 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 505008 Delivered-To: patch@linaro.org Received: by 2002:a02:8629:0:0:0:0:0 with SMTP id e38csp67954jai; Wed, 1 Sep 2021 02:12:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJynCxUarYxXqvEb97D06tqPOo1bBxvIeSQ84wY3nuiti++mVv1VVVSm8lyZvx41zRGo3SAt X-Received: by 2002:a92:1304:: with SMTP id 4mr20694976ilt.196.1630487537844; Wed, 01 Sep 2021 02:12:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1630487537; cv=none; d=google.com; s=arc-20160816; b=Wse7Ek2uuf7d8xiSP/GwURxthMK0Xc6+2MT5lvIwacIi0t9sPsFeUY+BO2YlIVF9Kv xgI8Tsdwek8XdH3dE5QX3K+w9TFOdTjs2DYnnBthdpYVPv2swrhggcJUJZ4e2cyHAJtn Wax3GUtFCiCFT7NcIP3Z/ABiJAaoJBQTmQL8BtUEx7HMusHBWqgEhQ5aSZBNKfO7pzKR Xgmqt9YUYGCZY3cfhS8lsgAgmQuS/EeXLS/6YJO8ssNZsIekK1rL53uzis+6s6EMEDn+ b1YGt4JctlXluETa/iDUt3flIwT0QmD4TFwNDmdPebajNPeRPMp7jZk2PbBeHdLXISYS XC7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=9awTdNZXeyUkH/oFOCLr7e4LdyXBILhh3s1aaJszUyk=; b=dcZnh2nVEy3lbKizUewFEUKHg19LhGdBc1EKjTmL0/2cVNwdCzag4NsaJdUp08s2es 9KqpMlKpLzGXmKgzmSFcfd9GPTQcex3GGotBn7u2roiYjnKGjw3+BFTOM1+DxAYwxNMt ndFrWyoCr+KgliBCwxeLTZYc3KrPMEcJiB1rtoJbFfqPK65f4EiFQIHtiMy9w1ES/PWv ktCgsdUcMC+HAVMhzbNdBE76p5wurYYA8IxBlBlIW4x9dIa/UCCImxusVOCXitS6x5tz 7XAmiNY0rAkMIFL1atwS8xwAy/wxqVpNxX8FOpa7ty9o1fP+engoHvw7d/fpvwX84ktm i3DQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ihEuaUER; spf=pass (google.com: domain of linux-pm-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-pm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f18si72033ilq.43.2021.09.01.02.12.17; Wed, 01 Sep 2021 02:12:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-pm-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ihEuaUER; spf=pass (google.com: domain of linux-pm-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-pm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243453AbhIAJNL (ORCPT + 7 others); Wed, 1 Sep 2021 05:13:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39898 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243445AbhIAJNK (ORCPT ); Wed, 1 Sep 2021 05:13:10 -0400 Received: from mail-pf1-x430.google.com (mail-pf1-x430.google.com [IPv6:2607:f8b0:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1CA7BC061575 for ; Wed, 1 Sep 2021 02:12:14 -0700 (PDT) Received: by mail-pf1-x430.google.com with SMTP id m26so1547977pff.3 for ; Wed, 01 Sep 2021 02:12:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=9awTdNZXeyUkH/oFOCLr7e4LdyXBILhh3s1aaJszUyk=; b=ihEuaUERWeKow9ehEulv8jzIYo4APivhosmQp5knPz8bLu9qf2kiJ526U48rO2uRnL p2gR9SCalooNAenTmIRj30SJOyHBuPevEvt2DN+UFuSBw6SLeP7SRC1deAzXrIFHEoFN XqzPr7bevLHVks7G+mZXpn71JI+0nbgN8MKVAJ2NKpyRnNoLOQWzEhIlQ2HmOVXgmGdh zMranfIMmYNrrKN60W3XQuBEd0HVgzTBXqnhpVpJ0CZq8YX6YjY+TF7imRJADHn9/lvm sJB0d5CW9cwyNYBI8M7w4vDbjdl/mxv3hhgTE0u1CRw5HvpoYnRQKCV5mlR5y6B8Pt8i q8pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=9awTdNZXeyUkH/oFOCLr7e4LdyXBILhh3s1aaJszUyk=; b=lTDHKmbppQYMDv0YAL7qDmWhQ3gynhYKOzI8eLLdCkvtvryZCouxs/rjiBvzOmEC+o avFSvHpJFx5PyJALmZJzrqDgcSQhfRylGKRM2WDyGIx1fSdT9NJghE5ryIT4Z5jmSEmz tkfI7XNmjzUT2YDnaygCbS0HqntTr3z5IP4NbE1D261CLQpsO5zanrt5CORBqZRx4jZy 5qkNAuPt//+ot3WWkGdvFLCK73BrqzgOHlZKMKF2TmVbXNDSIHBjQLXiONyigjiRWSfS vCrXIrE9tKytUXnQq2mc2sGia93rOKohraXmkpcjV9SdftuZ6LrtXV4R+GDRBsmxiJjl /UKQ== X-Gm-Message-State: AOAM532SpaXNDqXPviJ/YmNch69nan8hye+KRYIiVFxBzYmMyg4qzfI/ ++HpQqC10pdAdxdSIA3n5VTEcw== X-Received: by 2002:a63:444c:: with SMTP id t12mr31095067pgk.212.1630487533654; Wed, 01 Sep 2021 02:12:13 -0700 (PDT) Received: from localhost ([122.172.201.85]) by smtp.gmail.com with ESMTPSA id k190sm12341642pgc.11.2021.09.01.02.12.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Sep 2021 02:12:13 -0700 (PDT) From: Viresh Kumar To: Rafael Wysocki , Viresh Kumar Cc: linux-pm@vger.kernel.org, Vincent Guittot , linux-kernel@vger.kernel.org Subject: [PATCH 2/3] cpufreq: sh: Remove sh_cpufreq_cpu_ready() Date: Wed, 1 Sep 2021 14:41:56 +0530 Message-Id: <2c81cd66e09dccb9189221d39f0871d9fc7192d3.1630487322.git.viresh.kumar@linaro.org> X-Mailer: git-send-email 2.31.1.272.g89b43f80a514 In-Reply-To: References: MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org The ->ready() callback is going away and since we don't do any important stuff in sh_cpufreq_cpu_ready(), remove it. Signed-off-by: Viresh Kumar --- drivers/cpufreq/sh-cpufreq.c | 11 ----------- 1 file changed, 11 deletions(-) -- 2.31.1.272.g89b43f80a514 diff --git a/drivers/cpufreq/sh-cpufreq.c b/drivers/cpufreq/sh-cpufreq.c index 1a251e635ebd..b8704232c27b 100644 --- a/drivers/cpufreq/sh-cpufreq.c +++ b/drivers/cpufreq/sh-cpufreq.c @@ -145,16 +145,6 @@ static int sh_cpufreq_cpu_exit(struct cpufreq_policy *policy) return 0; } -static void sh_cpufreq_cpu_ready(struct cpufreq_policy *policy) -{ - struct device *dev = get_cpu_device(policy->cpu); - - dev_info(dev, "CPU Frequencies - Minimum %u.%03u MHz, " - "Maximum %u.%03u MHz.\n", - policy->min / 1000, policy->min % 1000, - policy->max / 1000, policy->max % 1000); -} - static struct cpufreq_driver sh_cpufreq_driver = { .name = "sh", .flags = CPUFREQ_NO_AUTO_DYNAMIC_SWITCHING, @@ -163,7 +153,6 @@ static struct cpufreq_driver sh_cpufreq_driver = { .verify = sh_cpufreq_verify, .init = sh_cpufreq_cpu_init, .exit = sh_cpufreq_cpu_exit, - .ready = sh_cpufreq_cpu_ready, .attr = cpufreq_generic_attr, }; From patchwork Wed Sep 1 09:11:57 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 505009 Delivered-To: patch@linaro.org Received: by 2002:a02:8629:0:0:0:0:0 with SMTP id e38csp68143jai; Wed, 1 Sep 2021 02:12:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwdYlQsnF0ouP7sWtNZPBwpxuvL53KwCihWn10AGcUEwnagGqbqH6Kyygmhu5E57sVN7eq2 X-Received: by 2002:a05:6e02:503:: with SMTP id d3mr23777834ils.107.1630487551378; Wed, 01 Sep 2021 02:12:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1630487551; cv=none; d=google.com; s=arc-20160816; b=sQ3K2YxWiH43k+SPK0eB32cTEPGGjSiVRRZJZREMr9LfRq7Pq5PosNCaLLd6AYwMeR cDCin1aiMoCRdbYScrAPl4d5q0JdwsJJZIPijGbpzTy4eqXh78y4hNk1GSYNOmu0mXVl hccHLUBMDrbMSxMd5Y1vQCi5uZet4Iyjq0/q9eOl2kaPSxtRsoHjzLG7QtfIt3XIYM3o ImMwzWVtHsqLzk1N26sDwgBhIPUYOaZeRrta92x/8AHpvSUbPWN2N0p+sC1cUewp6j8Q jHWKaaaViuS+Aq2PAhxzL7ypDhV2rMgF+9ZCMNnP6KNbzpFuZYnmuqc7bHe5YB5UE+4M 4hSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=rSLnBv6HzrzRT2E+OrtX7br/e1aM+QCsCVPYd1HLzdc=; b=iSvL0SGZztcIMwlKdM5jppRNluRiZlth//U8zjteveH//Oq3j44lMYGQm/VjSV4l3A MIhy1w9EkyhnczkehrpGbLkAKT0/vkozVL7i/M28dWiUtladYPL1uHSeHAcKSAdA1ZYy 9L2kyw1+FxKlWHsh28je1fawSVGec72CdNQ7BhAyYf70Uw8f+6Gd/tHedo+leV27xEq5 cpgyYhkewNPoGe3PdlFI0prRVZj6RDC93kulBxvolvCb9wIXxEjlaHUhYravPV0xCgtM ropnGkAwCdPcglPNgol6o1CsBN4u/S5UKD43Wc/cS1nojAJgoQ8YBhIN8aR+FFY/+mGS tX6A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=gamJq1iY; spf=pass (google.com: domain of linux-pm-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-pm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r20si21098555jad.61.2021.09.01.02.12.30; Wed, 01 Sep 2021 02:12:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-pm-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=gamJq1iY; spf=pass (google.com: domain of linux-pm-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-pm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243336AbhIAJNX (ORCPT + 7 others); Wed, 1 Sep 2021 05:13:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39926 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243452AbhIAJNO (ORCPT ); Wed, 1 Sep 2021 05:13:14 -0400 Received: from mail-pg1-x52d.google.com (mail-pg1-x52d.google.com [IPv6:2607:f8b0:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DFBDFC0613D9 for ; Wed, 1 Sep 2021 02:12:17 -0700 (PDT) Received: by mail-pg1-x52d.google.com with SMTP id k24so2096314pgh.8 for ; Wed, 01 Sep 2021 02:12:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=rSLnBv6HzrzRT2E+OrtX7br/e1aM+QCsCVPYd1HLzdc=; b=gamJq1iYdnzqTJXSjm+5RkT6COhyrD+KFLc/YuFGGAyOn10TEbeOJ+VJJ/PMMkbAbb X8TVF4KZGYZKD2YBT1ll8KLrV6NMxqEdNpP27Hfce9FAbTSmzKiVRXIa6h1SdrK5/3oS QgcGhCmBL9ANHdpdCml7SSM8VwC53T7fEDYi3DwyXO8n7sPg7VgW8CdDoL828KmOZwiO uY7q60iFvh7y5e6/kpwIG6tXxZrvbUQNYj+7afblhj1EWFnXxAclrcdHvUq4SHeOWTba YRNchczQ0me0e6DJrm9o87wVIEpn9ad82xPYPIPQ98xjHX/J2eE0hkeCFp7YR9YTgeMb blUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=rSLnBv6HzrzRT2E+OrtX7br/e1aM+QCsCVPYd1HLzdc=; b=aQlX+l+AsHpPZS40BbYAp/zlqjcEm4eXEMvDKMgLQM8GqapJ8+5JpCSdgYHhyATW/b 8r5MBmTs9SWXXsPy+vAxd+I0wb35/ZsxBZA1+AHQK/IYCYQnXHRXLsjDHDrK/2lf+TFC A5+0Vo4vF8vu2+PYiY7qKaOigDHMyWHnYSZ6f14FIN6zje9LqNHW1ZAl3fMlZXTIH4Qm e55e4DJNDlWxtgxnJX6DTT6aSa4TNY4U/24j8/KdJLYpPYOwACQ/M9F42ml2Ct4xpTpl Yw09nm91fyMPRCWjflWGLP4XEMyE11TWr2P35BTfYN9HMsSPpX0tr+mzUvpnO2q/jden nhpg== X-Gm-Message-State: AOAM532mLsxGecaXrdf/PagwV5UciHOtsYtxxTsEEDuU2L6EI7c87Yfh 79SnXjkppNCEg3nuoFAMirj9Xg== X-Received: by 2002:a65:648b:: with SMTP id e11mr30941505pgv.138.1630487537479; Wed, 01 Sep 2021 02:12:17 -0700 (PDT) Received: from localhost ([122.172.201.85]) by smtp.gmail.com with ESMTPSA id o15sm4900093pjr.0.2021.09.01.02.12.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Sep 2021 02:12:17 -0700 (PDT) From: Viresh Kumar To: Rafael Wysocki , Viresh Kumar , Jonathan Corbet , Alex Shi Cc: linux-pm@vger.kernel.org, Vincent Guittot , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/3] cpufreq: Remove ready() callback Date: Wed, 1 Sep 2021 14:41:57 +0530 Message-Id: <9c2435b18039fe50328b8f443dcd4dbb009f4618.1630487322.git.viresh.kumar@linaro.org> X-Mailer: git-send-email 2.31.1.272.g89b43f80a514 In-Reply-To: References: MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org This isn't used anymore, get rid of it. Signed-off-by: Viresh Kumar --- Documentation/cpu-freq/cpu-drivers.rst | 3 --- Documentation/translations/zh_CN/cpu-freq/cpu-drivers.rst | 2 -- drivers/cpufreq/cpufreq.c | 4 ---- include/linux/cpufreq.h | 3 --- 4 files changed, 12 deletions(-) -- 2.31.1.272.g89b43f80a514 diff --git a/Documentation/cpu-freq/cpu-drivers.rst b/Documentation/cpu-freq/cpu-drivers.rst index d84ededb66f9..3b32336a7803 100644 --- a/Documentation/cpu-freq/cpu-drivers.rst +++ b/Documentation/cpu-freq/cpu-drivers.rst @@ -75,9 +75,6 @@ And optionally .resume - A pointer to a per-policy resume function which is called with interrupts disabled and _before_ the governor is started again. - .ready - A pointer to a per-policy ready function which is called after - the policy is fully initialized. - .attr - A pointer to a NULL-terminated list of "struct freq_attr" which allow to export values to sysfs. diff --git a/Documentation/translations/zh_CN/cpu-freq/cpu-drivers.rst b/Documentation/translations/zh_CN/cpu-freq/cpu-drivers.rst index 5ae9cfa2ec55..334f30ae198b 100644 --- a/Documentation/translations/zh_CN/cpu-freq/cpu-drivers.rst +++ b/Documentation/translations/zh_CN/cpu-freq/cpu-drivers.rst @@ -80,8 +80,6 @@ 并且可选择 .resume - 一个指向per-policy恢复函数的指针，该函数在关中断且在调节器再一次开始前被 调用。 - .ready - 一个指向per-policy准备函数的指针，该函数在策略完全初始化之后被调用。 - .attr - 一个指向NULL结尾的"struct freq_attr"列表的指针，该函数允许导出值到 sysfs。 diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c index 7d5f170ecad1..5782b15a8caa 100644 --- a/drivers/cpufreq/cpufreq.c +++ b/drivers/cpufreq/cpufreq.c @@ -1517,10 +1517,6 @@ static int cpufreq_online(unsigned int cpu) kobject_uevent(&policy->kobj, KOBJ_ADD); - /* Callback for handling stuff after policy is ready */ - if (cpufreq_driver->ready) - cpufreq_driver->ready(policy); - if (cpufreq_thermal_control_enabled(cpufreq_driver)) policy->cdev = of_cpufreq_cooling_register(policy); diff --git a/include/linux/cpufreq.h b/include/linux/cpufreq.h index c65a1d7385f8..fe6acc04e5e5 100644 --- a/include/linux/cpufreq.h +++ b/include/linux/cpufreq.h @@ -367,9 +367,6 @@ struct cpufreq_driver { int (*suspend)(struct cpufreq_policy *policy); int (*resume)(struct cpufreq_policy *policy); - /* Will be called after the driver is fully initialized */ - void (*ready)(struct cpufreq_policy *policy); - struct freq_attr **attr; /* platform specific boost support code */