From patchwork Thu Sep 2 02:55:26 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Saravana Kannan X-Patchwork-Id: 505883 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-26.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4AF8C43214 for ; Thu, 2 Sep 2021 02:55:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 895A2603E9 for ; Thu, 2 Sep 2021 02:55:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243331AbhIBC4d (ORCPT ); Wed, 1 Sep 2021 22:56:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60390 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243307AbhIBC4c (ORCPT ); Wed, 1 Sep 2021 22:56:32 -0400 Received: from mail-yb1-xb4a.google.com (mail-yb1-xb4a.google.com [IPv6:2607:f8b0:4864:20::b4a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 00EB7C061575 for ; Wed, 1 Sep 2021 19:55:35 -0700 (PDT) Received: by mail-yb1-xb4a.google.com with SMTP id z15-20020a25868f000000b0059c56f47e94so676939ybk.21 for ; Wed, 01 Sep 2021 19:55:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=g9pSyOxnjCOWosqjO3t3a4imI5grRUjzERw2nKICPFM=; b=Uz60v/HepgsdIMq6/b3xr9Y15p3q+GlRpCsECJtXu9BUJf8fX2QdSSEjlPkokaZaLP WFIqenWncZy6Rj5d/Ww/Lq72NR33+mAVdOkiQQlmniBSXvPL5bSaMRu8ifVYTD6c3DZI hKi9p+pPjhdIq3b0LQtFH81X9PqHj0GAzvoTmd9orzBSiDvnQrel9kR6B/4tmyH3714N clMneMSFs318vpYkFjcMTZh9VKAHeCQA6DmhvMqjjqOM2SiDTkRwqt5N2+T2FqYGYGsF 4GajYutwb5iJAy7Y4Ay8NIkICWlwu8HUr3zIB9oKZFdognEeQbgk9cAUjx7oKmYfEvts gYJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=g9pSyOxnjCOWosqjO3t3a4imI5grRUjzERw2nKICPFM=; b=Z1eG3rxSvffFQN1aYG4n0luYlX68ehZhKzxDH6M1077DQNij8iRU3z/QXgZIazE/mk IQlyehoW5hGHT/45hlGypfy6x1lnpBNOaANuXRXheojtYN7vTUza+VMN2yF6FTapYyRx CmbudfsUtFA6jEC1qvGypFntcWrtJ/dWXbJxmxc9P/HI2E1Xx7cBtkDXnGW3T1iXpdjJ oI2r6Qg3halsOzCzuasqAqqvxr0ZSKdXnmQawWlDqc0yZev+Lp9GMdUzaEifsZ84c9Zi ueXfozH0XP9c20G69XzVINtBMR9g2dsBrOvOAd1xJ1y3Jin4Pur5U3cMvDc6RS0VPVqL wdzA== X-Gm-Message-State: AOAM531h/kB/+vsqcYO6VBu9GR3uPuutxds6sV9p82Ks7xvmTsw7HMWs R3WN8sMn5r4iEfcCppCgr0ftDRCVK+rvbMk= X-Google-Smtp-Source: ABdhPJyRB5mf+UxJSXvDkK4JLboJqCYcys9YaGzUBC7l8K4y81wcdm3OOQ8B/BqapBpkqtg7BloRSVCGz7fw4tg= X-Received: from saravanak.san.corp.google.com ([2620:15c:2d:3:17e:f0b7:5862:e47d]) (user=saravanak job=sendgmr) by 2002:a25:becd:: with SMTP id k13mr1429669ybm.198.1630551334262; Wed, 01 Sep 2021 19:55:34 -0700 (PDT) Date: Wed, 1 Sep 2021 19:55:26 -0700 In-Reply-To: <20210902025528.1017391-1-saravanak@google.com> Message-Id: <20210902025528.1017391-2-saravanak@google.com> Mime-Version: 1.0 References: <20210902025528.1017391-1-saravanak@google.com> X-Mailer: git-send-email 2.33.0.259.gc128427fd7-goog Subject: [PATCH v1 1/2] driver core: Add support for FWNODE_FLAG_NEVER_PROBES From: Saravana Kannan To: Greg Kroah-Hartman , "Rafael J. Wysocki" , Rob Herring , Frank Rowand , Len Brown Cc: Saravana Kannan , Ulf Hansson , kernel-team@android.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-acpi@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Add a fwnode flag to mark a device as one that will never be probed even though it's added to a bus. Signed-off-by: Saravana Kannan --- drivers/base/core.c | 8 ++++++++ include/linux/fwnode.h | 8 +++++--- 2 files changed, 13 insertions(+), 3 deletions(-) diff --git a/drivers/base/core.c b/drivers/base/core.c index f6360490a4a3..5d14897a53e6 100644 --- a/drivers/base/core.c +++ b/drivers/base/core.c @@ -1719,6 +1719,14 @@ static int fw_devlink_create_devlink(struct device *con, struct device *sup_dev; int ret = 0; + /* + * If the consumer or supplier is a device that'll never be probed, + * don't create devices link for it. + */ + if (con->fwnode->flags & FWNODE_FLAG_NEVER_PROBES || + sup_handle->flags & FWNODE_FLAG_NEVER_PROBES) + return -EINVAL; + sup_dev = get_dev_from_fwnode(sup_handle); if (sup_dev) { /* diff --git a/include/linux/fwnode.h b/include/linux/fwnode.h index 59828516ebaf..3ad667ae97d8 100644 --- a/include/linux/fwnode.h +++ b/include/linux/fwnode.h @@ -19,13 +19,15 @@ struct device; /* * fwnode link flags * - * LINKS_ADDED: The fwnode has already be parsed to add fwnode links. - * NOT_DEVICE: The fwnode will never be populated as a struct device. - * INITIALIZED: The hardware corresponding to fwnode has been initialized. + * LINKS_ADDED: The fwnode has already be parsed to add fwnode links. + * NOT_DEVICE: The fwnode will never be populated as a struct device. + * INITIALIZED: The hardware corresponding to fwnode has been initialized. + * NEVER_PROBES: The device that corresponds to this fwnode will never probe. */ #define FWNODE_FLAG_LINKS_ADDED BIT(0) #define FWNODE_FLAG_NOT_DEVICE BIT(1) #define FWNODE_FLAG_INITIALIZED BIT(2) +#define FWNODE_FLAG_NEVER_PROBES BIT(3) struct fwnode_handle { struct fwnode_handle *secondary; From patchwork Thu Sep 2 02:55:27 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Saravana Kannan X-Patchwork-Id: 506758 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-26.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEF5FC432BE for ; Thu, 2 Sep 2021 02:55:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B4956610A4 for ; Thu, 2 Sep 2021 02:55:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243311AbhIBC4g (ORCPT ); Wed, 1 Sep 2021 22:56:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60420 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243373AbhIBC4f (ORCPT ); Wed, 1 Sep 2021 22:56:35 -0400 Received: from mail-yb1-xb49.google.com (mail-yb1-xb49.google.com [IPv6:2607:f8b0:4864:20::b49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ACDB9C061760 for ; Wed, 1 Sep 2021 19:55:37 -0700 (PDT) Received: by mail-yb1-xb49.google.com with SMTP id 63-20020a250d42000000b0059dc43162c9so667173ybn.23 for ; Wed, 01 Sep 2021 19:55:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=tjSyGojTOT8uYCifLvLdr4amA8l8CDhQi4qAmFSjHg8=; b=NUaF4WJ6oZa5lpk/IiiIJ0R3QbFs2N3ApjmoemgvLZkF2vVGNK1ttkWqATbJVTg2R3 1dR7jf0TtWVEkcENrRJqt2NFC3IYu4Uufevgq2aM1OzOtkhKjbpj62a59O19dplK+5NL r8tQw626ubHYPXeRUJafN9ubJQYNkXglCC/UgrWI/SE8fzmhwKoLS5o6AZQ4JUv6cjX8 Ax4/og6p55XQKqEb2zj76gPWC/xfNSvaXugCuG4CtquiuhC2axyCuVlAlwElb3bJRqBd ciqf8Li7nDtv+42zKvi40yvQ6W3Ar2obFSY4LUhptC/stQU1TfsLAGg2FtBrUgFFX0QN HWcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=tjSyGojTOT8uYCifLvLdr4amA8l8CDhQi4qAmFSjHg8=; b=AvwqhMG9Isa/eilPdbhE8RffdWgKHJ15jC4zNPVKx/juk35JysnSJPjQEYTZlDxBOw tNoh/PPkdWnFFo1YkDPhBvJ1wRFBsiwCYdNW2aJxesHZCu+M2jbOey+Dk7M5U8D/w4y9 qJnUPuN0xuV6vTLZr8I6CWqh8ZqeIadMGcDQpG6y0MoqQORTR83wTVgymFDFpBQNXVZl 1wAF+rrSS1XPh8f1tl+5g4WCaMjgg/Uth3Ds744zf126iFLjUCbPsNpu1wmVB+vg0oMs a7UrmNcE+LpHlDoRuwofh9T6bVYYVFb8iY4uXul4tmQu6wpopeBAzpKg5iBuWSRCMtiS Dwkg== X-Gm-Message-State: AOAM533zzZsvUyRiTd0Gxk+o98NkxtJaKukxYD/4I+Xo154hmDJD87+M vx9ANCcbhs25i30c9uWAGgcuBFBakuzim9g= X-Google-Smtp-Source: ABdhPJyc1/FZExAbR1nIydLj5ad1RBb0+ykfyYU2JXEXQOtJcQqi7SJtFMPOeSkQkh9TiI23NXiJ6yeOth8BWIk= X-Received: from saravanak.san.corp.google.com ([2620:15c:2d:3:17e:f0b7:5862:e47d]) (user=saravanak job=sendgmr) by 2002:a25:2142:: with SMTP id h63mr1586569ybh.70.1630551336984; Wed, 01 Sep 2021 19:55:36 -0700 (PDT) Date: Wed, 1 Sep 2021 19:55:27 -0700 In-Reply-To: <20210902025528.1017391-1-saravanak@google.com> Message-Id: <20210902025528.1017391-3-saravanak@google.com> Mime-Version: 1.0 References: <20210902025528.1017391-1-saravanak@google.com> X-Mailer: git-send-email 2.33.0.259.gc128427fd7-goog Subject: [PATCH v1 2/2] of: platform: Mark bus devices nodes with FWNODE_FLAG_NEVER_PROBES From: Saravana Kannan To: Greg Kroah-Hartman , "Rafael J. Wysocki" , Rob Herring , Frank Rowand , Len Brown Cc: Saravana Kannan , Ulf Hansson , kernel-team@android.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-acpi@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org We don't want fw_devlink creating device links for bus devices as they'll never probe. So mark those device node with this flag. Signed-off-by: Saravana Kannan --- drivers/of/platform.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/drivers/of/platform.c b/drivers/of/platform.c index 74afbb7a4f5e..42b3936d204a 100644 --- a/drivers/of/platform.c +++ b/drivers/of/platform.c @@ -392,6 +392,22 @@ static int of_platform_bus_create(struct device_node *bus, if (!dev || !of_match_node(matches, bus)) return 0; + /* + * If the bus node has only one compatible string value and it has + * matched as a bus node, it's never going to get probed by a device + * driver. So flag it as such so that fw_devlink knows not to create + * device links with this device. + * + * This doesn't catch all devices that'll never probe, but this is good + * enough for now. + * + * This doesn't really work for PPC because of how it uses + * of_platform_bus_probe() to add normal devices. So ignore PPC cases. + */ + if (!IS_ENABLED(CONFIG_PPC) && + of_property_count_strings(bus, "compatible") == 1) + bus->fwnode.flags |= FWNODE_FLAG_NOT_DEVICE; + for_each_child_of_node(bus, child) { pr_debug(" create child: %pOF\n", child); rc = of_platform_bus_create(child, matches, lookup, &dev->dev, strict);