From patchwork Mon Sep 27 09:51:44 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 514671 Delivered-To: patch@linaro.org Received: by 2002:a02:c816:0:0:0:0:0 with SMTP id p22csp3946040jao; Mon, 27 Sep 2021 02:51:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJymHglzHFraiMSb/4zamrsr/cdsJ6c70SEnC0TNaqfVUFwK07kAKErFGjsXUmZY0bfC+E7R X-Received: by 2002:a62:ab07:0:b0:440:3c5b:ae7c with SMTP id p7-20020a62ab07000000b004403c5bae7cmr22635379pff.49.1632736315841; Mon, 27 Sep 2021 02:51:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1632736315; cv=none; d=google.com; s=arc-20160816; b=H/PJHS/BPujzjVBHTwrql52SGPKu51chmWP+fnorIdKbBfzT/jkeAmPhJ+gXByzLuk Tc7mPOlAhAxVgM01YiRQfB4DoGhIwqgJ/zADcbrQ/kPq3M8/acE7CbkF68Mg81iVetcG U9sTNcmfjk8D8kQ2/Q2cBCf42mgUDYqAdICVdLyxUkveI0DLiPErHdnBF/jD6EnJLsR9 ILyCMYfDQg6EoXXCKoe4D+Rd2nnNDkDDxHV0fnZ4333xiwZyhl4OQ/91nbdeC5y+Z9N+ JyJ+vw1cEqkAWFzlsPqSJ6VinYXddHgnRvoqjsFCKr0b9DWu7+A/CYy8BcEEAGxJyX1j 4W7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=dTibgFxPcSfUsezcNiKHaEBMPDbB/YQ8fm/2eyAiUk0=; b=H7TMEmdG2bv2ZWcTvY/LL+zbTCy2gmU8AbhvMnC85FJtxipo+EFmimgA462046LUY8 4vvPiPv898w4EnsqUijaIQ9imiKbCJm4ju89IBFntu1YBPCVSFl1Fghc9q1KgP32Klji 9lNYtGqVGyEsvRlkNu39GC3sq5+hEshXIAVvzeVv27m/jpwvcSnP64RxKBJBzxGhBEvW xVHXmCO1dvNGIoR6XbX4WSxRoKA3OOxyNP5mE1h/InN1utSZXl4G4K6R3X9t+Zq+yySl ylHwmdyfc6j8hT2UuctZLRbtSSjyeaIODp2EV3LJBMKIFoH2wYouQeyvTwl5acOYyRcF nSFQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=W8PXnhQr; spf=pass (google.com: domain of linux-samsung-soc-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-samsung-soc-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o11si26171580pjm.56.2021.09.27.02.51.55; Mon, 27 Sep 2021 02:51:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-samsung-soc-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=W8PXnhQr; spf=pass (google.com: domain of linux-samsung-soc-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-samsung-soc-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233760AbhI0Jxc (ORCPT + 4 others); Mon, 27 Sep 2021 05:53:32 -0400 Received: from mail.kernel.org ([198.145.29.99]:52396 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233685AbhI0Jxc (ORCPT ); Mon, 27 Sep 2021 05:53:32 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id EA975600EF; Mon, 27 Sep 2021 09:51:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1632736314; bh=euDAn8QrdLy6aBu3eAQGzTKso/i73eEHDM14y55fAE0=; h=From:To:Cc:Subject:Date:From; b=W8PXnhQrvX224HksE/K58bchshcna7UHoYaosUrKvh/wqqGxGTQpVOs6BMX9slA8d R28g9mygpMuq7SJAnuEPBjNNKvLdHbEYtAkLBz3sFA0mVtdVZHGQXZw2sXKeu5ltTN laJiEqUlvoFEYihvfvGmV9bYlwC9/8ctMlI4FQDs72aKJLEeXDgGS0bqMQ5S0ezK7B p9t3OCc2doBvkYHHpRiPzw+3dkwGXKDk4/+1AeZsU+UjHzXz5RRrOJS/dgQ8LGqEhs zC+PpzQMpAmDD6r8VOy5u3Nav2nXXkLtM4GNoeDP2LmMIe9lnEg1JG3rbanF1SRj8Z 4q8e9ToGYLbIQ== From: Arnd Bergmann To: Krzysztof Kozlowski , "Rafael J. Wysocki" , Viresh Kumar Cc: Arnd Bergmann , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] cpufreq: s3c244x: add fallthrough comments for switch Date: Mon, 27 Sep 2021 11:51:44 +0200 Message-Id: <20210927095150.944127-1-arnd@kernel.org> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org From: Arnd Bergmann Apparently nobody has so far caught this warning, I hit it in randconfig build testing: drivers/cpufreq/s3c2440-cpufreq.c: In function 's3c2440_cpufreq_setdivs': drivers/cpufreq/s3c2440-cpufreq.c:175:10: error: this statement may fall through [-Werror=implicit-fallthrough=] camdiv |= S3C2440_CAMDIVN_HCLK3_HALF; ^ drivers/cpufreq/s3c2440-cpufreq.c:176:2: note: here case 3: ^~~~ drivers/cpufreq/s3c2440-cpufreq.c:181:10: error: this statement may fall through [-Werror=implicit-fallthrough=] camdiv |= S3C2440_CAMDIVN_HCLK4_HALF; ^ drivers/cpufreq/s3c2440-cpufreq.c:182:2: note: here case 4: ^~~~ Both look like the fallthrough is intentional, so add the new "fallthrough;" keyword. Signed-off-by: Arnd Bergmann --- drivers/cpufreq/s3c2440-cpufreq.c | 2 ++ 1 file changed, 2 insertions(+) -- 2.29.2 Acked-by: Krzysztof Kozlowski diff --git a/drivers/cpufreq/s3c2440-cpufreq.c b/drivers/cpufreq/s3c2440-cpufreq.c index 148e8aedefa9..2011fb9c03a4 100644 --- a/drivers/cpufreq/s3c2440-cpufreq.c +++ b/drivers/cpufreq/s3c2440-cpufreq.c @@ -173,12 +173,14 @@ static void s3c2440_cpufreq_setdivs(struct s3c_cpufreq_config *cfg) case 6: camdiv |= S3C2440_CAMDIVN_HCLK3_HALF; + fallthrough; case 3: clkdiv |= S3C2440_CLKDIVN_HDIVN_3_6; break; case 8: camdiv |= S3C2440_CAMDIVN_HCLK4_HALF; + fallthrough; case 4: clkdiv |= S3C2440_CLKDIVN_HDIVN_4_8; break;