From patchwork Tue Nov 6 17:20:02 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Richard Earnshaw \(lists\)" X-Patchwork-Id: 150284 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp4151236ljp; Tue, 6 Nov 2018 09:20:21 -0800 (PST) X-Google-Smtp-Source: AJdET5fOdTNVzaHE5W0fxNUgCrqXwqFdbycnwwGIFfYpz7PrU9WI92hcbxhxzXmN4D2wUsgpdXWL X-Received: by 2002:a63:b30f:: with SMTP id i15mr17236241pgf.240.1541524821587; Tue, 06 Nov 2018 09:20:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1541524821; cv=none; d=google.com; s=arc-20160816; b=DZJQX0w2giP2AFjaZgYlKMJJh0tQcZX04e/bV3uXi+umubgljjwh3KJYy+KszfwDz0 1ga8ZOwErycn3oVLW+Gl5rxJf2v0U5ro6Klv37Hjrwud41w1VZ03knDAUfxUeXRB5U9I RDJ92HteEbzq4ljW3EUN0k9ZYGLsK4eBXvPy3Z9mPR/I5BwobhGik0u1MZKyvViswO5Y oO3Hb7fbusng3kjXsyqUFheplshnFWPQbhgP9ecGsG2gAyuPUzZpkYR/fj1flvHr/25P 2FVSE2LS4gLKR6znO3jlSwGLKvd1NJvIMRWwQAh9jS4Zb7UPYB++ocRXPNEV3Uz/4HI8 T39w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:user-agent:date:message-id:openpgp:subject:from:to :delivered-to:sender:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:mailing-list:dkim-signature :domainkey-signature; bh=ds0fdTCnYMyozVXDJjagmCbcXY/YDLUYPtgUg7LIu+o=; b=hsLK0U6vLVVJMVUbl7skGGlD/VhrlCExbsTqPlQvpjPTXYrTtO+NkUAos28wfFGE4y 5w3CGChG93HMvYIqxmKLZsbdwPLm0YaUL6saZkZ/2T3+ywvkbdjDa0buwL0jbOdJnf3Z c8DRXlv94YOHvfNlUHf0swXjhaMVwB8RaBJkZhlFRtbJoIMFZVlk0fQiGPPTqkHGXlI6 Hl0cUwP9sV9aLPQr481mFkRZzunTQvUFc/Gb9ojQvgxUQlXDYJnloFNS74uaRbTdPa3E iGIqSV0kiRNCVl6MFVuVYlTojl51f0rs0RPIF52NXOEOfR7IsVGgMJ6CIk6fu7/uyl7H PxUA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=CjBssjOF; spf=pass (google.com: domain of gcc-patches-return-489174-patch=linaro.org@gcc.gnu.org designates 209.132.180.131 as permitted sender) smtp.mailfrom="gcc-patches-return-489174-patch=linaro.org@gcc.gnu.org" Return-Path: Received: from sourceware.org (server1.sourceware.org. [209.132.180.131]) by mx.google.com with ESMTPS id s144-v6si39072489pfc.149.2018.11.06.09.20.21 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Nov 2018 09:20:21 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-return-489174-patch=linaro.org@gcc.gnu.org designates 209.132.180.131 as permitted sender) client-ip=209.132.180.131; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=CjBssjOF; spf=pass (google.com: domain of gcc-patches-return-489174-patch=linaro.org@gcc.gnu.org designates 209.132.180.131 as permitted sender) smtp.mailfrom="gcc-patches-return-489174-patch=linaro.org@gcc.gnu.org" DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:to :from:subject:message-id:date:mime-version:content-type; q=dns; s=default; b=tLoA3YF9q07+GP0BNZcLnPsLDlhBAZLEQ42x/itet3uPZEGng0 E1yyH3thJAolYreYUNHkJ6VOLWICbdGvSqKwRGDrQjUF+G5bVBHhPP35ikRQ3qqd /4yVaByR0d5mZE+O2HmJVyXUZE+PesMaXKXWkgp3ObQ4wUXmxkThaWypM= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:to :from:subject:message-id:date:mime-version:content-type; s= default; bh=1IHNWJ28bV1yqrEjTCAWEEZZcPE=; b=CjBssjOFsQo6JpWG9KP1 BkWvbAKpWcsWGttycki+vNqbcVUy0MoRVL2GqpVHHPXorrAWOa3Bwvs6NP5+IAG+ 13EovffZ9pMyPxIPRDJ2gh/gEnQsMJ+VXz2IWSy5tdtApgAycXjMYqC1lLD9xJUs TPl6APYNCsqaxcp749WYcnE= Received: (qmail 81826 invoked by alias); 6 Nov 2018 17:20:09 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 81796 invoked by uid 89); 6 Nov 2018 17:20:07 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, SPF_PASS autolearn=ham version=3.3.2 spammy=sk:specula X-HELO: foss.arm.com Received: from usa-sjc-mx-foss1.foss.arm.com (HELO foss.arm.com) (217.140.101.70) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 06 Nov 2018 17:20:06 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 725A9A78; Tue, 6 Nov 2018 09:20:04 -0800 (PST) Received: from e120077-lin.cambridge.arm.com (e120077-lin.cambridge.arm.com [10.2.206.194]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id F145B3F5C0; Tue, 6 Nov 2018 09:20:03 -0800 (PST) To: gcc-patches From: "Richard Earnshaw (lists)" Subject: aarch64 - Set the mode for the unspec in speculation_tracker insn. Openpgp: preference=signencrypt Message-ID: <98dfc446-2ee4-bf08-a722-20460d825a26@arm.com> Date: Tue, 6 Nov 2018 17:20:02 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 The speculation tracker insn in my recent patch set for CVE-2017-5753 was missing a mode on the UNSPEC. Although this didn't break the build, it did cause an unnecessary warning from the MD parsing mechanism that I missed at the time. It's a trivial fix, as follows: * config/aarch64/aarch64.md (speculation_tracker): Set the mode for the UNSPEC. Committed to trunk. diff --git a/gcc/config/aarch64/aarch64.md b/gcc/config/aarch64/aarch64.md index ada623bb6f1..82af4d47f78 100644 --- a/gcc/config/aarch64/aarch64.md +++ b/gcc/config/aarch64/aarch64.md @@ -6687,7 +6687,7 @@ (define_expand "doloop_end" ;; SPECULATION_TRACKER_REGNUM is reserved for this purpose when necessary. (define_insn "speculation_tracker" [(set (reg:DI SPECULATION_TRACKER_REGNUM) - (unspec [(reg:DI SPECULATION_TRACKER_REGNUM) (match_operand 0)] + (unspec:DI [(reg:DI SPECULATION_TRACKER_REGNUM) (match_operand 0)] UNSPEC_SPECULATION_TRACKER))] "" {