From patchwork Wed Nov 24 00:52:05 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bart Van Assche X-Patchwork-Id: 518686 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82684C433F5 for ; Wed, 24 Nov 2021 00:52:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231833AbhKXAzf (ORCPT ); Tue, 23 Nov 2021 19:55:35 -0500 Received: from mail-pj1-f46.google.com ([209.85.216.46]:34777 "EHLO mail-pj1-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229681AbhKXAzf (ORCPT ); Tue, 23 Nov 2021 19:55:35 -0500 Received: by mail-pj1-f46.google.com with SMTP id j5-20020a17090a318500b001a6c749e697so3128600pjb.1 for ; Tue, 23 Nov 2021 16:52:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=spXTifj5M9HBJDRM6qGu3Iug+LkX07oPsHn9kJIHw6o=; b=iWimV/0G7EM6vJXS4J+6R1JoVjwoJH1hbOFtxsnFemjVclr5eYq7IO2XqgIbdgWxEA Sh4MNy/CNQI/HTqOOIKq6KtewHxD7R0T9JDhmw+EdaEf606/EUUm2uTlhaZyH0TJZ4Nu Nf52BfFquualDSrVYGfpKdGkRbcvAeh7HJKKsjYjtByD0Poczao53bP2+Gza2X6VvCOY 1r4XJsbjhPJWCuZSbK3SfEtTbPW3/Gyyo/bl5EgzCt3w+iTrducw1OmKYuExRNUQDD+Z xgCVVyWe4JPP6FicuaUsAc7VqP6+wajHvdMiSf8GnGa5oNKJdV1WM8cEfsDVuJacZylE WpDQ== X-Gm-Message-State: AOAM530nXCSmjCDEv7Pz3DdtfUOnOxu3tzmu5ksRjD+e1HXigk4pffOl 6msw5NNp4HyIfTIyijq1sWc= X-Google-Smtp-Source: ABdhPJwc4phSTHOlBM3z3jN/35c1p7osb8Y18RHNAi1FYjFTMN1s0YSAb3AUau16pRT61zkYdTdpJA== X-Received: by 2002:a17:90a:ec05:: with SMTP id l5mr2615970pjy.68.1637715146290; Tue, 23 Nov 2021 16:52:26 -0800 (PST) Received: from bvanassche-linux.mtv.corp.google.com ([2620:15c:211:201:58e8:6593:938:2bea]) by smtp.gmail.com with ESMTPSA id x33sm14210387pfh.133.2021.11.23.16.52.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Nov 2021 16:52:25 -0800 (PST) From: Bart Van Assche To: "Martin K . Petersen" Cc: Jaegeuk Kim , linux-scsi@vger.kernel.org, Bart Van Assche , Stephen Rothwell , "James E.J. Bottomley" Subject: [PATCH 01/13] scsi: core: Suppress a kernel-doc warning Date: Tue, 23 Nov 2021 16:52:05 -0800 Message-Id: <20211124005217.2300458-2-bvanassche@acm.org> X-Mailer: git-send-email 2.34.0.rc2.393.gf8c9666880-goog In-Reply-To: <20211124005217.2300458-1-bvanassche@acm.org> References: <20211124005217.2300458-1-bvanassche@acm.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Suppress the following kernel-doc warning: drivers/scsi/scsi_scan.c:129: warning: Function parameter or member 'dev' not described in 'scsi_enable_async_suspend' Fixes: a19a93e4c6a9 ("scsi: core: pm: Rely on the device driver core for async power management") Reported-by: Stephen Rothwell Signed-off-by: Bart Van Assche --- drivers/scsi/scsi_scan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c index 23e1c0acdeae..2f80509fa036 100644 --- a/drivers/scsi/scsi_scan.c +++ b/drivers/scsi/scsi_scan.c @@ -122,7 +122,7 @@ struct async_scan_data { struct completion prev_finished; }; -/** +/* * scsi_enable_async_suspend - Enable async suspend and resume */ void scsi_enable_async_suspend(struct device *dev) From patchwork Wed Nov 24 00:52:07 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bart Van Assche X-Patchwork-Id: 518685 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 348F6C433EF for ; Wed, 24 Nov 2021 00:52:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231922AbhKXAzi (ORCPT ); Tue, 23 Nov 2021 19:55:38 -0500 Received: from mail-pf1-f182.google.com ([209.85.210.182]:45039 "EHLO mail-pf1-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229681AbhKXAzh (ORCPT ); Tue, 23 Nov 2021 19:55:37 -0500 Received: by mail-pf1-f182.google.com with SMTP id b68so913055pfg.11 for ; Tue, 23 Nov 2021 16:52:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=2eowHEMEaomOtvfvRCh+rFzyDDZg9uyicwuaqpBFZK8=; b=02E2lZWvlnzFUHrOhJNp8x/6ovBM51GTahzRVFgm6dXZRybI6vnpn6UrFIfgJbMvZU RsvttS+gcbWxor+RIqhgK7nL131H7tWMWhGhXFvpv6/63OAbgydnJMzO6JC67a6vAFhe U8pfO+lJ+aZyXiwbts3gFdZze9M2arXCZiXjMUEM8i0l/voOaVS1w+C8zb1mVenFAEp/ JbtNa3hRb9Tzic9MlfPyeAGx27Q5we9lZkuTVN7oSNrnt2qd4HOfi2u3RwfYw7DMqzzO n7608tVLQUEAG6aSOZAt5yBL5zaTsKS2eTsiDF3l6ZbHYIfHhIBUE4lzky/nBxFej3jQ qL/Q== X-Gm-Message-State: AOAM530VzccsLzXZZgy7PY3RaoY5sKQR3s0dcHOT5haj33pOwcK5bqSg azBbKQi5m1DxbP7JfTqnf8M= X-Google-Smtp-Source: ABdhPJz9FG+NOpW61LczZhUzQk8idPw4tWJxCJ3IRRu8j2RlF25WGDPCJrnfF7CWU56lQGQJ3nMEtw== X-Received: by 2002:a63:f110:: with SMTP id f16mr6960554pgi.136.1637715148885; Tue, 23 Nov 2021 16:52:28 -0800 (PST) Received: from bvanassche-linux.mtv.corp.google.com ([2620:15c:211:201:58e8:6593:938:2bea]) by smtp.gmail.com with ESMTPSA id x33sm14210387pfh.133.2021.11.23.16.52.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Nov 2021 16:52:28 -0800 (PST) From: Bart Van Assche To: "Martin K . Petersen" Cc: Jaegeuk Kim , linux-scsi@vger.kernel.org, Bart Van Assche , "James E.J. Bottomley" , Ming Lei , Hannes Reinecke , Paolo Bonzini Subject: [PATCH 03/13] scsi: core: Show SCMD_LAST in text form Date: Tue, 23 Nov 2021 16:52:07 -0800 Message-Id: <20211124005217.2300458-4-bvanassche@acm.org> X-Mailer: git-send-email 2.34.0.rc2.393.gf8c9666880-goog In-Reply-To: <20211124005217.2300458-1-bvanassche@acm.org> References: <20211124005217.2300458-1-bvanassche@acm.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org The SCSI debugfs code supports showing information about pending commands, including translating SCSI command flags from numeric into text format. Also convert the SCMD_LAST flag from numeric into text form. Fixes: 8930a6c20791 ("scsi: core: add support for request batching") Signed-off-by: Bart Van Assche --- drivers/scsi/scsi_debugfs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/scsi_debugfs.c b/drivers/scsi/scsi_debugfs.c index d9109771f274..db8517f1a485 100644 --- a/drivers/scsi/scsi_debugfs.c +++ b/drivers/scsi/scsi_debugfs.c @@ -9,6 +9,7 @@ static const char *const scsi_cmd_flags[] = { SCSI_CMD_FLAG_NAME(TAGGED), SCSI_CMD_FLAG_NAME(INITIALIZED), + SCSI_CMD_FLAG_NAME(LAST), }; #undef SCSI_CMD_FLAG_NAME From patchwork Wed Nov 24 00:52:09 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bart Van Assche X-Patchwork-Id: 518684 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4ED2C433FE for ; Wed, 24 Nov 2021 00:52:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232065AbhKXAzm (ORCPT ); Tue, 23 Nov 2021 19:55:42 -0500 Received: from mail-pl1-f170.google.com ([209.85.214.170]:34553 "EHLO mail-pl1-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231947AbhKXAzl (ORCPT ); Tue, 23 Nov 2021 19:55:41 -0500 Received: by mail-pl1-f170.google.com with SMTP id y8so482537plg.1 for ; Tue, 23 Nov 2021 16:52:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=R/LLURik7fKfMotWvRqagyl6sN9/7ruv7Q10p87e034=; b=o1Rx731GRKyFHjhP8Eo0y0yDJFlKQOXRvpOVwJQK7HBpDKVaw5v2Su6e29ebvDbXLI tn8SzqyaRZ+Q4NcaIhqJJRTL10GDFSETvQI4bL7A5qlKTwr427aZy29eFUV1XkdGuFRQ UCcbNRnCpAvroDreA+lmfNts6AVntZ+SnV7HK1Pof+5cim0IjY4KXhpA6vOv2t/413q8 IwBOWPL4at8cd6VO0o3N5zqJ/hDubt3PQ/z7Yy71iolsrRAIsVvk5momBvhEeWLMBXwZ uwxl3Mk6LGDhd9duzS/cCm7Ji3lbBiuCo5Aza8Wk4m26gM8ghKLjQSno15xCgQa0uhWM kccg== X-Gm-Message-State: AOAM533u3jTVWl5vHDrAuXC2ImmBklsaqOEEZBTZ5Z2u0yVOvqspWpTD 8PjWKOIKA9CJ0/xdNdD4ZMc= X-Google-Smtp-Source: ABdhPJzt7qbvX4JQZa4ttYQ7Aery8mC91UvW3D/Jhru8Sa0qumu/NHphumTJzxfbcIqbeF1wAMWfVw== X-Received: by 2002:a17:90a:c286:: with SMTP id f6mr2512435pjt.45.1637715152354; Tue, 23 Nov 2021 16:52:32 -0800 (PST) Received: from bvanassche-linux.mtv.corp.google.com ([2620:15c:211:201:58e8:6593:938:2bea]) by smtp.gmail.com with ESMTPSA id x33sm14210387pfh.133.2021.11.23.16.52.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Nov 2021 16:52:31 -0800 (PST) From: Bart Van Assche To: "Martin K . Petersen" Cc: Jaegeuk Kim , linux-scsi@vger.kernel.org, Bart Van Assche , kernel test robot , Damien Le Moal Subject: [PATCH 05/13] scsi: ata: Declare 'ata_ncq_sdev_attrs' static Date: Tue, 23 Nov 2021 16:52:09 -0800 Message-Id: <20211124005217.2300458-6-bvanassche@acm.org> X-Mailer: git-send-email 2.34.0.rc2.393.gf8c9666880-goog In-Reply-To: <20211124005217.2300458-1-bvanassche@acm.org> References: <20211124005217.2300458-1-bvanassche@acm.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fix the following kernel-doc warning: 'ata_ncq_sdev_attrs' is only used in one source file. Hence declare this array static. Fixes: c3f69c7f629f ("scsi: ata: Switch to attribute groups") Reported-by: kernel test robot Signed-off-by: Bart Van Assche --- drivers/ata/libata-sata.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ata/libata-sata.c b/drivers/ata/libata-sata.c index 4e88597aa9df..5b78e86e3459 100644 --- a/drivers/ata/libata-sata.c +++ b/drivers/ata/libata-sata.c @@ -922,7 +922,7 @@ DEVICE_ATTR(ncq_prio_enable, S_IRUGO | S_IWUSR, ata_ncq_prio_enable_show, ata_ncq_prio_enable_store); EXPORT_SYMBOL_GPL(dev_attr_ncq_prio_enable); -struct attribute *ata_ncq_sdev_attrs[] = { +static struct attribute *ata_ncq_sdev_attrs[] = { &dev_attr_unload_heads.attr, &dev_attr_ncq_prio_enable.attr, &dev_attr_ncq_prio_supported.attr, From patchwork Wed Nov 24 00:52:11 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bart Van Assche X-Patchwork-Id: 518683 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 661BAC433F5 for ; Wed, 24 Nov 2021 00:52:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232103AbhKXAzo (ORCPT ); Tue, 23 Nov 2021 19:55:44 -0500 Received: from mail-pg1-f180.google.com ([209.85.215.180]:33327 "EHLO mail-pg1-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232078AbhKXAzo (ORCPT ); Tue, 23 Nov 2021 19:55:44 -0500 Received: by mail-pg1-f180.google.com with SMTP id f65so610789pgc.0 for ; Tue, 23 Nov 2021 16:52:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=qhobAcdyo1e28tDZZU6//79J1mh/4UC8Q7hU3IoeFhQ=; b=GzocJxqOZBmMd3cZ9m9To+CBc8d5IYGWC+IYQlCDDUiCzZ6d21FWcIyg3s85ixSFE4 ujHrSmIgyjWPvpx9l0NSjLvo3Z/b57J5hyHp0Nxz1mwgNe+QEEAn2Ad5HiexVtRXVOSJ EBLfuU+XNyZZ9IHfOZXTuT3GzB3GFduFN+63nVB0nNzgRNd3k3JHY73mGX8MxY3LEebI 1V7ZOiVwOsmRxOU3cSPuq3pDT8dwyLZJ/fyfng/GbDc4mwCFZma4i51M0F8BNh0qYzip 6jfgD06Bg3mBBMGathglK5bdrE4SUtwKpVJY4sWIW4KBo2a6bFfhvbgGVkpFA13G7GpB qU2Q== X-Gm-Message-State: AOAM533FWRwkf0RSFUfLchln1s2AtgsilkdB0EQfrmpt2qybAwRGSoD9 +NbVjQm9x9Ua+DAKqmQYJYw= X-Google-Smtp-Source: ABdhPJyVd9E3WKmA4hSU4c+r1pmVoWMdt9BYIiyh2CXlXwKDa4HGI2JIG4RujxnNo+XsiUFBpZxVlQ== X-Received: by 2002:a63:920b:: with SMTP id o11mr6996786pgd.314.1637715155058; Tue, 23 Nov 2021 16:52:35 -0800 (PST) Received: from bvanassche-linux.mtv.corp.google.com ([2620:15c:211:201:58e8:6593:938:2bea]) by smtp.gmail.com with ESMTPSA id x33sm14210387pfh.133.2021.11.23.16.52.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Nov 2021 16:52:34 -0800 (PST) From: Bart Van Assche To: "Martin K . Petersen" Cc: Jaegeuk Kim , linux-scsi@vger.kernel.org, Bart Van Assche , kernel test robot , Anil Gurumurthy , Sudarsana Kalluru , "James E.J. Bottomley" Subject: [PATCH 07/13] scsi: bfa: Declare 'bfad_im_vport_attrs' static Date: Tue, 23 Nov 2021 16:52:11 -0800 Message-Id: <20211124005217.2300458-8-bvanassche@acm.org> X-Mailer: git-send-email 2.34.0.rc2.393.gf8c9666880-goog In-Reply-To: <20211124005217.2300458-1-bvanassche@acm.org> References: <20211124005217.2300458-1-bvanassche@acm.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fix the following kernel-doc warning: 'bfad_im_vport_attrs' is only used in one source file. Hence declare this array static. Fixes: e73af234a1a2 ("scsi: bfa: Switch to attribute groups") Reported-by: kernel test robot Signed-off-by: Bart Van Assche --- drivers/scsi/bfa/bfad_attr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/bfa/bfad_attr.c b/drivers/scsi/bfa/bfad_attr.c index c8b947c16069..f46989bd083c 100644 --- a/drivers/scsi/bfa/bfad_attr.c +++ b/drivers/scsi/bfa/bfad_attr.c @@ -981,7 +981,7 @@ const struct attribute_group *bfad_im_host_groups[] = { NULL }; -struct attribute *bfad_im_vport_attrs[] = { +static struct attribute *bfad_im_vport_attrs[] = { &dev_attr_serial_number.attr, &dev_attr_model.attr, &dev_attr_model_description.attr, From patchwork Wed Nov 24 00:52:13 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bart Van Assche X-Patchwork-Id: 518682 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72266C433EF for ; Wed, 24 Nov 2021 00:52:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232137AbhKXAzr (ORCPT ); Tue, 23 Nov 2021 19:55:47 -0500 Received: from mail-pg1-f171.google.com ([209.85.215.171]:43703 "EHLO mail-pg1-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231947AbhKXAzq (ORCPT ); Tue, 23 Nov 2021 19:55:46 -0500 Received: by mail-pg1-f171.google.com with SMTP id q16so559561pgq.10 for ; Tue, 23 Nov 2021 16:52:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=nmSr4aGAqiYob5EbKWRQg54NwSmiITSVXf9eYWzcg/A=; b=36WR2RpJx7x9VwWlxi3lgAXKH+dSOWpZLoJkKMi32mwSYmKKaJJz7xF5fELT+d6a73 YMMYkY4tr82x9BScZ/Hi8nk+00R6pfAXJOxQR2VtohWgMjP0A1TQG7UesDzQyHIX1u9z P/qpNtBssIdPksLlAtWH2KCkhHdrg5tUGrhELm3TT31h+N4xnlNIPUyXJcl3HWTDioX5 E7nUZ9JGkuNnMkmUKsAmlpkHKv81opIhwS1+WvBXulvJ8q5afmeFXgWuklTt6W6aTpAg 81NEqIx5soL01wqw3F9x1LiNCX0nL2d8WStYKYrtDci0wHdr5n4gfT7wYZHqYHB5XpcD 4RxQ== X-Gm-Message-State: AOAM531ifjpNurf0MEd/O75BgD22fqsCwhbEQkcYh/rRHVPpuOtabPDy 3Bo5mcYu16ieDnms9nqzbIaYLshcQBBTxQ== X-Google-Smtp-Source: ABdhPJwK1gnKKnmwVWFIXW6lzodY+uXcgVxHuRDzNXOgcVCkChygsWc44hl6EUXPIVBX5NrTsWiS2Q== X-Received: by 2002:a65:4548:: with SMTP id x8mr6876778pgr.469.1637715157741; Tue, 23 Nov 2021 16:52:37 -0800 (PST) Received: from bvanassche-linux.mtv.corp.google.com ([2620:15c:211:201:58e8:6593:938:2bea]) by smtp.gmail.com with ESMTPSA id x33sm14210387pfh.133.2021.11.23.16.52.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Nov 2021 16:52:37 -0800 (PST) From: Bart Van Assche To: "Martin K . Petersen" Cc: Jaegeuk Kim , linux-scsi@vger.kernel.org, Bart Van Assche , "James E.J. Bottomley" Subject: [PATCH 09/13] scsi: initio: Fix a kernel-doc warning Date: Tue, 23 Nov 2021 16:52:13 -0800 Message-Id: <20211124005217.2300458-10-bvanassche@acm.org> X-Mailer: git-send-email 2.34.0.rc2.393.gf8c9666880-goog In-Reply-To: <20211124005217.2300458-1-bvanassche@acm.org> References: <20211124005217.2300458-1-bvanassche@acm.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fix the following kernel-doc warning: drivers/scsi/initio.c:2613: warning: Excess function parameter 'done' description in 'i91u_queuecommand_lck' Fixes: af049dfd0b10 ("scsi: core: Remove the 'done' argument from SCSI queuecommand_lck functions") Signed-off-by: Bart Van Assche --- drivers/scsi/initio.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/scsi/initio.c b/drivers/scsi/initio.c index fd6da96bc51a..9cdee38f5ba3 100644 --- a/drivers/scsi/initio.c +++ b/drivers/scsi/initio.c @@ -2602,13 +2602,11 @@ static void initio_build_scb(struct initio_host * host, struct scsi_ctrl_blk * c /** * i91u_queuecommand_lck - Queue a new command if possible * @cmd: SCSI command block from the mid layer - * @done: Completion handler * * Attempts to queue a new command with the host adapter. Will return * zero if successful or indicate a host busy condition if not (which * will cause the mid layer to call us again later with the command) */ - static int i91u_queuecommand_lck(struct scsi_cmnd *cmd) { struct initio_host *host = (struct initio_host *) cmd->device->host->hostdata; From patchwork Wed Nov 24 00:52:15 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bart Van Assche X-Patchwork-Id: 518681 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC153C433FE for ; Wed, 24 Nov 2021 00:52:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232311AbhKXAzv (ORCPT ); Tue, 23 Nov 2021 19:55:51 -0500 Received: from mail-pg1-f174.google.com ([209.85.215.174]:42912 "EHLO mail-pg1-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232191AbhKXAzt (ORCPT ); Tue, 23 Nov 2021 19:55:49 -0500 Received: by mail-pg1-f174.google.com with SMTP id t4so561179pgn.9 for ; Tue, 23 Nov 2021 16:52:40 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=k3aRkXwcHbUrav//xi729orhtu49BIZsPxsJGGDFykc=; b=ABQ/X/yyiy9/Mab5d9+3ScYVcI2GEkDdJGAAT9Ry7dOfM6CUO29RrXvdBfYZELJGBt QKR3wjW70JE1TwPEo9q6VMaO/ko2M8ngw8I64pEN50TFFCfHB/QjZkQtuJdXs0DqQMQp awUIXPAea4H0e9RBw19g8pO2fET93cs71iYVKkm+icNaxXXEtM96HPssEgLszFSt6IgD nquqP2bv8aNeviOxUYxClDq+PUmdNHQm0zdQpd0UlejjYVaGpBgGdyvRgnWUXgl6go5F Ovd6QilQaUV2suziKb9zZEWCVJQ3l/Ofww2UrbTMU1QUeiPhQGVZ0tpuJI1uox8kvj+X kdVw== X-Gm-Message-State: AOAM531c7tBxuww/P2cD5oObDnRySXfg+/g8yuI1E4GkfJjfztd/Qcj4 koNy3jNg99OI9Wfo9cNC5FPQhixMzHYnlQ== X-Google-Smtp-Source: ABdhPJy2iS7whgsCywhlN1n1bvDkree+ItJH2YEBnR337BmHGIrhH0Uu5sDHjALlIyqAwgSo1Ooc5Q== X-Received: by 2002:aa7:8109:0:b0:4a2:a98e:9020 with SMTP id b9-20020aa78109000000b004a2a98e9020mr1763842pfi.61.1637715160333; Tue, 23 Nov 2021 16:52:40 -0800 (PST) Received: from bvanassche-linux.mtv.corp.google.com ([2620:15c:211:201:58e8:6593:938:2bea]) by smtp.gmail.com with ESMTPSA id x33sm14210387pfh.133.2021.11.23.16.52.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Nov 2021 16:52:39 -0800 (PST) From: Bart Van Assche To: "Martin K . Petersen" Cc: Jaegeuk Kim , linux-scsi@vger.kernel.org, Bart Van Assche , Jack Wang , "James E.J. Bottomley" , Ashokkumar N , kernel test robot , Radha Ramachandran , Viswas G Subject: [PATCH 11/13] scsi: pm8001: Fix kernel-doc warnings Date: Tue, 23 Nov 2021 16:52:15 -0800 Message-Id: <20211124005217.2300458-12-bvanassche@acm.org> X-Mailer: git-send-email 2.34.0.rc2.393.gf8c9666880-goog In-Reply-To: <20211124005217.2300458-1-bvanassche@acm.org> References: <20211124005217.2300458-1-bvanassche@acm.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fix the following kernel-doc warnings: drivers/scsi/pm8001/pm8001_ctl.c:900: warning: cannot understand function prototype: 'const char *const mpiStateText[] = ' drivers/scsi/pm8001/pm8001_ctl.c:930: warning: Function parameter or member 'attr' not described in 'ctl_hmi_error_show' drivers/scsi/pm8001/pm8001_ctl.c:951: warning: Function parameter or member 'attr' not described in 'ctl_raae_count_show' drivers/scsi/pm8001/pm8001_ctl.c:972: warning: Function parameter or member 'attr' not described in 'ctl_iop0_count_show' drivers/scsi/pm8001/pm8001_ctl.c:993: warning: Function parameter or member 'attr' not described in 'ctl_iop1_count_show' Fixes: 4ddbea1b6f51 ("scsi: pm80xx: Add sysfs attribute to check MPI state") Signed-off-by: Bart Van Assche --- drivers/scsi/pm8001/pm8001_ctl.c | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/scsi/pm8001/pm8001_ctl.c b/drivers/scsi/pm8001/pm8001_ctl.c index 397eb9f6a1dd..41a63c9b719b 100644 --- a/drivers/scsi/pm8001/pm8001_ctl.c +++ b/drivers/scsi/pm8001/pm8001_ctl.c @@ -889,14 +889,6 @@ static ssize_t pm8001_show_update_fw(struct device *cdev, static DEVICE_ATTR(update_fw, S_IRUGO|S_IWUSR|S_IWGRP, pm8001_show_update_fw, pm8001_store_update_fw); -/** - * ctl_mpi_state_show - controller MPI state check - * @cdev: pointer to embedded class device - * @buf: the buffer returned - * - * A sysfs 'read-only' shost attribute. - */ - static const char *const mpiStateText[] = { "MPI is not initialized", "MPI is successfully initialized", @@ -904,6 +896,14 @@ static const char *const mpiStateText[] = { "MPI initialization failed with error in [31:16]" }; +/** + * ctl_mpi_state_show - controller MPI state check + * @cdev: pointer to embedded class device + * @attr: device attribute (unused) + * @buf: the buffer returned + * + * A sysfs 'read-only' shost attribute. + */ static ssize_t ctl_mpi_state_show(struct device *cdev, struct device_attribute *attr, char *buf) { @@ -920,11 +920,11 @@ static DEVICE_ATTR_RO(ctl_mpi_state); /** * ctl_hmi_error_show - controller MPI initialization fails * @cdev: pointer to embedded class device + * @attr: device attribute (unused) * @buf: the buffer returned * * A sysfs 'read-only' shost attribute. */ - static ssize_t ctl_hmi_error_show(struct device *cdev, struct device_attribute *attr, char *buf) { @@ -941,11 +941,11 @@ static DEVICE_ATTR_RO(ctl_hmi_error); /** * ctl_raae_count_show - controller raae count check * @cdev: pointer to embedded class device + * @attr: device attribute (unused) * @buf: the buffer returned * * A sysfs 'read-only' shost attribute. */ - static ssize_t ctl_raae_count_show(struct device *cdev, struct device_attribute *attr, char *buf) { @@ -962,11 +962,11 @@ static DEVICE_ATTR_RO(ctl_raae_count); /** * ctl_iop0_count_show - controller iop0 count check * @cdev: pointer to embedded class device + * @attr: device attribute (unused) * @buf: the buffer returned * * A sysfs 'read-only' shost attribute. */ - static ssize_t ctl_iop0_count_show(struct device *cdev, struct device_attribute *attr, char *buf) { @@ -983,11 +983,11 @@ static DEVICE_ATTR_RO(ctl_iop0_count); /** * ctl_iop1_count_show - controller iop1 count check * @cdev: pointer to embedded class device + * @attr: device attribute (unused) * @buf: the buffer returned * * A sysfs 'read-only' shost attribute. */ - static ssize_t ctl_iop1_count_show(struct device *cdev, struct device_attribute *attr, char *buf) { From patchwork Wed Nov 24 00:52:17 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bart Van Assche X-Patchwork-Id: 518680 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA389C433F5 for ; Wed, 24 Nov 2021 00:52:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231215AbhKXA4G (ORCPT ); Tue, 23 Nov 2021 19:56:06 -0500 Received: from mail-pj1-f41.google.com ([209.85.216.41]:46797 "EHLO mail-pj1-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232252AbhKXA4F (ORCPT ); Tue, 23 Nov 2021 19:56:05 -0500 Received: by mail-pj1-f41.google.com with SMTP id np6-20020a17090b4c4600b001a90b011e06so913294pjb.5 for ; Tue, 23 Nov 2021 16:52:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=iv1XeNcDXoHZ906hRTP3lSCQfXZfMWb9FlKnZa6cB8c=; b=b0xCbXkFPDvMEyIjBJXoum1nYjyK+0AYcMo6Ofi6rXVH7DU8bM06Qg6Z8ZJGMXp3JN mB0Lkf2IeCz7KcbxQxwi2m8ovH3aIqjWXRlRRBo4hFqOEYy0emlqT49T/ecZQ/QFWJ1j kQSXokSYILc0HEGyuf2k1LTTmh6KAN80aj/u8vRUgxLLF2DgxEyaKAAtK8FHEOqzuqFI 4yGSqwtNN0vbOmBaz+OF/c5wlevIZMYmY6B5XUXMmpmXJGEHHdmoyHpZAnRO5h2rAn1i uBFbpuqEC8W1KTytWDlWB/khOOLCQKnZXqzWaZWQ9JCStRC0sl4FcnbaGl8CrLdvhOmg zmTQ== X-Gm-Message-State: AOAM531xpLZ093yN1xS6LJJsGeObu4cCwNCws4YBxsdJT4HMa8hXSFan tMH9+U5uwDyt9fOiHqKN4aU3Sz67SiaKow== X-Google-Smtp-Source: ABdhPJz1GZrqCwROxoOnfse4rJ/rJuHWHIrrMaoCGnTVfL6vVW6CoMgOacCSqa/apXxigff2bwtoiA== X-Received: by 2002:a17:90b:4b86:: with SMTP id lr6mr2522125pjb.98.1637715176783; Tue, 23 Nov 2021 16:52:56 -0800 (PST) Received: from bvanassche-linux.mtv.corp.google.com ([2620:15c:211:201:58e8:6593:938:2bea]) by smtp.gmail.com with ESMTPSA id x33sm14210387pfh.133.2021.11.23.16.52.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Nov 2021 16:52:56 -0800 (PST) From: Bart Van Assche To: "Martin K . Petersen" Cc: Jaegeuk Kim , linux-scsi@vger.kernel.org, Bart Van Assche , John Garry , "James E.J. Bottomley" , Luo Jiaxing , Jason Yan , "Gustavo A. R. Silva" , Avri Altman , Daejun Park , Bean Huo , Keoseong Park Subject: [PATCH 13/13] scsi: Remove superfluous #include directives Date: Tue, 23 Nov 2021 16:52:17 -0800 Message-Id: <20211124005217.2300458-14-bvanassche@acm.org> X-Mailer: git-send-email 2.34.0.rc2.393.gf8c9666880-goog In-Reply-To: <20211124005217.2300458-1-bvanassche@acm.org> References: <20211124005217.2300458-1-bvanassche@acm.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Remove this include directive from code that does not use any functionality from kernel/async.c. Signed-off-by: Bart Van Assche --- drivers/scsi/hisi_sas/hisi_sas.h | 1 - drivers/scsi/libsas/sas_discover.c | 1 - drivers/scsi/scsi.c | 1 - drivers/scsi/scsi_pm.c | 1 - drivers/scsi/scsi_priv.h | 1 - drivers/scsi/sd.c | 1 - drivers/scsi/ufs/ufshpb.c | 1 - 7 files changed, 7 deletions(-) diff --git a/drivers/scsi/hisi_sas/hisi_sas.h b/drivers/scsi/hisi_sas/hisi_sas.h index 2213a91923a5..ed9419643235 100644 --- a/drivers/scsi/hisi_sas/hisi_sas.h +++ b/drivers/scsi/hisi_sas/hisi_sas.h @@ -8,7 +8,6 @@ #define _HISI_SAS_H_ #include -#include #include #include #include diff --git a/drivers/scsi/libsas/sas_discover.c b/drivers/scsi/libsas/sas_discover.c index 12e1e36d7c04..758213694091 100644 --- a/drivers/scsi/libsas/sas_discover.c +++ b/drivers/scsi/libsas/sas_discover.c @@ -8,7 +8,6 @@ #include #include -#include #include #include #include "sas_internal.h" diff --git a/drivers/scsi/scsi.c b/drivers/scsi/scsi.c index f6af1562cba4..dee4d9c6046d 100644 --- a/drivers/scsi/scsi.c +++ b/drivers/scsi/scsi.c @@ -55,7 +55,6 @@ #include #include #include -#include #include #include diff --git a/drivers/scsi/scsi_pm.c b/drivers/scsi/scsi_pm.c index b5a858c29488..0e841e8761c5 100644 --- a/drivers/scsi/scsi_pm.c +++ b/drivers/scsi/scsi_pm.c @@ -8,7 +8,6 @@ #include #include -#include #include #include diff --git a/drivers/scsi/scsi_priv.h b/drivers/scsi/scsi_priv.h index 0f5743f4769b..5c4786310a31 100644 --- a/drivers/scsi/scsi_priv.h +++ b/drivers/scsi/scsi_priv.h @@ -3,7 +3,6 @@ #define _SCSI_PRIV_H #include -#include #include #include diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c index 65875a598d62..2a50a840a00c 100644 --- a/drivers/scsi/sd.c +++ b/drivers/scsi/sd.c @@ -51,7 +51,6 @@ #include #include #include -#include #include #include #include diff --git a/drivers/scsi/ufs/ufshpb.c b/drivers/scsi/ufs/ufshpb.c index 2e31e1413826..9778d4fd03cc 100644 --- a/drivers/scsi/ufs/ufshpb.c +++ b/drivers/scsi/ufs/ufshpb.c @@ -10,7 +10,6 @@ */ #include -#include #include "ufshcd.h" #include "ufshpb.h"