From patchwork Tue Nov 23 20:57:23 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 519340 Delivered-To: patch@linaro.org Received: by 2002:ac0:c605:0:0:0:0:0 with SMTP id p5csp9240496imj; Tue, 23 Nov 2021 13:02:15 -0800 (PST) X-Google-Smtp-Source: ABdhPJy2c5cRu8XJD3VeCQIJ9Znuauvuuj04QG0okPIek8ophmRypiXzNy60JUXkOKG4AmPFWRyj X-Received: by 2002:a05:622a:20e:: with SMTP id b14mr508235qtx.288.1637701335851; Tue, 23 Nov 2021 13:02:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1637701335; cv=none; d=google.com; s=arc-20160816; b=Jge9J25pjaH3nSV9WHhgzna/Gk7nUtfYxxAI+8J34Zb0pMWwTCC8LBtfANW4Kip9rj 79JtfQFx53MngLfRr2DmZdY6vz0DKgA4EFp62DWn6HatnJHDF/rI0u1poiVjODx8/d4Z kMCQSKyE0dT0fjHdPl//Yq6mIu42CbXziEfurumqrIFbuMRH28C4PWzXlQ8wi28YvzpY 8Xhtk/1RKGYFcCbUzJJdVA7nrB1r+Liv8tymbtB0gAhpEbwdUFuQZCpIf50Tra+N0+Zf eKkw5P5V442us7lRC25Ws0j+PcGCAIRNA1o9WV/fIt0wpMLKsbZnWCldzRUOZxE8tL08 KCcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=+CtME3cCcCTfQNWLUjavY+LyZs3nohyg9oUPT9ltWGo=; b=sPQMajKzlHDkVGFHwRi8vvbkIuV/pO4HGXGEucUGr+GYT3Z/ZGA4prLbFtfq1Vyb9N F0HErTgQqakPdg0SD3rrs0CXILor2nOLcmfFmGll6clzVXHnKq1WGme9nsn59I1oY5fM KhOaka8dDeB2P0zn+6X01QetSy9TgAxsIeY3wX9YqVPS7gMGy8Geo2IpmREi33UIXAxB z2cBvbz+tJIqpIyJen0KjetkHLR93D4EKjsyi4ODLWgqaTk2ooMUFf/pqKbbCuHN0vLB 6mdINIIWjRh0HbNKZQimDSMeSYmHiQh3SSOrf4v8/6+G3/6L4TsRL7CFAjFj00tbqJK7 0aAw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=CXIpHZEU; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id c7si26147823qkp.181.2021.11.23.13.02.15 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 23 Nov 2021 13:02:15 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=CXIpHZEU; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:40336 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mpcvf-0007Rq-AV for patch@linaro.org; Tue, 23 Nov 2021 16:02:15 -0500 Received: from eggs.gnu.org ([209.51.188.92]:40558) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mpcrB-0001wD-FT for qemu-devel@nongnu.org; Tue, 23 Nov 2021 15:57:37 -0500 Received: from [2a00:1450:4864:20::42b] (port=35618 helo=mail-wr1-x42b.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mpcrA-0006Lj-1d for qemu-devel@nongnu.org; Tue, 23 Nov 2021 15:57:37 -0500 Received: by mail-wr1-x42b.google.com with SMTP id i5so222326wrb.2 for ; Tue, 23 Nov 2021 12:57:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+CtME3cCcCTfQNWLUjavY+LyZs3nohyg9oUPT9ltWGo=; b=CXIpHZEUyJu+7lRwYOkaIBK+PO4JwS3fDfZLL5wryj7f4qc/1xTdo3PnQvMkO6a0jb IJBzmd2v/MaJh75hsSN/VxaJsGgKfvbIMfCDt9xkN0lUpxtE5bBhS2rF+yhLe8LDEh4X 9s1fAYBy4SaDMFG5bE1niVsbsHqGShD+QyaXqvmTZWIyRgXkz8b5703qP7dtLiKW23ua FwWIevwxgXlWTeXwzwhRslLKd0EgLJuL2By3Idex3jz4cfkI18eqwfcOoGdlx8+XjODD If8RnpvQ3KGtR1eru950wzblldmXLoYNiT257oQFgIHyGMxHukNYubM5pSCMrxLnwjwa YvSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+CtME3cCcCTfQNWLUjavY+LyZs3nohyg9oUPT9ltWGo=; b=dx8zcNBvBa7ZbE+upJdxAiCiq9s/pXZK0bfw2cKWrVkaVDoAkGpwTHQYBIYN/s9KAv XPGdSvHLxwxkaqZvsBTw5cJx+JxH0Z0ZBbgkI8dM7hvplfekbIS6gCvEWGIHh40vPAaI uTJAw5rnOwt49IvIbcSppYVrwy3u4t5ejM/fX/D7Pco05cwe/BXon4aX4JvbmJy7/879 DfkIZZYz54iRiKCVTltTFPsnByL/zysjuU5R00DmYU8ApUG+QIjVWb/ChsPdajNJnkth S05OPvYK2wde55LEcA3cMA4spUz0t2ptK7jsoMhTXk9ufQkzMc4NDkc/eASpvueK39xG y3WA== X-Gm-Message-State: AOAM533i1M5eB54b5baN1HC4IdpbdJh5Ep3tCLQE5QPZc++WZLEqa7np eo/A0DECClqCIrIh/vRM10wKHA== X-Received: by 2002:a5d:4523:: with SMTP id j3mr11650367wra.185.1637701054095; Tue, 23 Nov 2021 12:57:34 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id m7sm2034505wml.38.2021.11.23.12.57.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Nov 2021 12:57:30 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 3EBBA1FF98; Tue, 23 Nov 2021 20:57:29 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Subject: [PATCH v1 1/7] softmmu: fix watchpoint-interrupt races Date: Tue, 23 Nov 2021 20:57:23 +0000 Message-Id: <20211123205729.2205806-2-alex.bennee@linaro.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20211123205729.2205806-1-alex.bennee@linaro.org> References: <20211123205729.2205806-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::42b (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::42b; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x42b.google.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: fam@euphon.net, berrange@redhat.com, David Hildenbrand , Richard Henderson , f4bug@amsat.org, stefanha@redhat.com, crosa@redhat.com, pbonzini@redhat.com, Pavel Dovgalyuk , =?utf-8?q?Alex_Benn=C3=A9e?= , aurelien@aurel32.net Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Pavel Dovgalyuk Watchpoint may be processed in two phases. First one is detecting the instruction with target memory access. And the second one is executing only one instruction and setting the debug interrupt flag. Hardware interrupts can break this sequence when they happen after the first watchpoint phase. This patch postpones the interrupt request until watchpoint is processed. Signed-off-by: Pavel Dovgalyuk Reviewed-by: Alex Bennée Reviewed-by: David Hildenbrand Message-Id: <163662451431.125458.14945698834107669531.stgit@pasha-ThinkPad-X280> Signed-off-by: Alex Bennée --- accel/tcg/cpu-exec.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/accel/tcg/cpu-exec.c b/accel/tcg/cpu-exec.c index 2d14d02f6c..9cb892e326 100644 --- a/accel/tcg/cpu-exec.c +++ b/accel/tcg/cpu-exec.c @@ -742,6 +742,11 @@ static inline bool cpu_handle_interrupt(CPUState *cpu, qemu_mutex_unlock_iothread(); return true; } + /* Process watchpoints first, or interrupts will ruin everything */ + if (cpu->watchpoint_hit) { + qemu_mutex_unlock_iothread(); + return false; + } #if !defined(CONFIG_USER_ONLY) if (replay_mode == REPLAY_MODE_PLAY && !replay_has_interrupt()) { /* Do nothing */ From patchwork Tue Nov 23 20:57:24 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 519338 Delivered-To: patch@linaro.org Received: by 2002:ac0:c605:0:0:0:0:0 with SMTP id p5csp9235628imj; Tue, 23 Nov 2021 12:58:23 -0800 (PST) X-Google-Smtp-Source: ABdhPJwKOpFdViNkoCeVd6KYBgCb9KLAURrIWX9Q5oj6yXBsPdAeCIPh0kiTxOiGqAe9PaAAE2qf X-Received: by 2002:a67:b643:: with SMTP id e3mr12976167vsm.33.1637701103387; Tue, 23 Nov 2021 12:58:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1637701103; cv=none; d=google.com; s=arc-20160816; b=QuW51qfmgQnIpEYLmLNOPDwvk9lkLa2kRzGEn+Jh2XGqIvA7qCZATH9GR463nknJpS LXmD2s2a/zAyERTJoW8efs07mOFkwRVGavylo4DXXiwBSAjsPCfIbm9sitngB2WgAy9U MQgnHKZ9PECh4GLkXHnSW+nq5VqUGmfKNbslKRt8DLhItIGmAyA1q1Umi5JFt8I3fynQ Q3QdGEhguRPOS9yWBFlDpMuIKMLjFJK7DBUnYop4SXB1KEP418wo0k8CykGV7nhqFZTE EKh/VY5P8CmtNo0rEzSE+kUewMr7yKgd/Mq72vg5zUhNvzJjoA0bGpmZ7KeOSlrxQr6Z ZjvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=kYpaKzAArYGilOIi+XPhEtI4zXEl1Bkmm+GbL7na2Ng=; b=w++lM0nRrWBQVZjxWKpl23YHqdmt0PgGqAdpYRgDwKXTlBT1Iuu69em8huwhQRrGOD 12A09xske1b+KxzsV42dICGPskmfeE7Rphl/PYlN/vQges1n4j3IfuoBbSyaWjUY/217 3/p3huz35+S+P/UkvOjcjwRU+0uDi0rnu+EPz5Wdk6kGtnmDg4c1sVVV4KS9IWJOyCUg UA/m83s+KxB+zy3t83gjlgGB4ycmKX9flr9y4n2FbYwYYigPydIWH4rqr7msRSnt2pvS IcByrhSJV9/r7sN1E8cZ4Efv5WyeBSIcBzxXdIFdk3WGMwsYAzGQAjfwsU2Kj/efu46X PonA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=ZqUV0jPW; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id h12si37808815vsj.198.2021.11.23.12.58.23 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 23 Nov 2021 12:58:23 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=ZqUV0jPW; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:60518 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mpcru-000255-Po for patch@linaro.org; Tue, 23 Nov 2021 15:58:22 -0500 Received: from eggs.gnu.org ([209.51.188.92]:40574) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mpcrD-0001zY-61 for qemu-devel@nongnu.org; Tue, 23 Nov 2021 15:57:39 -0500 Received: from [2a00:1450:4864:20::431] (port=43859 helo=mail-wr1-x431.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mpcrA-0006Mb-DX for qemu-devel@nongnu.org; Tue, 23 Nov 2021 15:57:38 -0500 Received: by mail-wr1-x431.google.com with SMTP id v11so164270wrw.10 for ; Tue, 23 Nov 2021 12:57:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=kYpaKzAArYGilOIi+XPhEtI4zXEl1Bkmm+GbL7na2Ng=; b=ZqUV0jPW3EWGWO8rhnFWveZO57PcmH6O8pHaxEqI1S+GqX1Ijj8CpvJ9PYXKpk2WmM Xiog2joRtpBofXixQNPIe6F94ebYT++STKs1ca3e2Gya9Unr2ddUqgFHDSMNppuzCbay gt6HhEMIFU14yuzqDUSeYWHSwQAUkqPB2qOheaTRblJsvMlmcZfNj9EkqjtS4ap7u6lC b9nDtjymIVVXsJAPhsWnsjPZMAdNvAvBql/h2wdxoj6VZspaZz1ruO9H7kVayUAOFmXh HSkYJmYbcHno3JAHUHUeB7g6yba+nR9tGVZ/V+xiDfIcmAL/iz0T6Arx1coiJBO+l9o7 adJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=kYpaKzAArYGilOIi+XPhEtI4zXEl1Bkmm+GbL7na2Ng=; b=RIcH3KW/TsPgVxxNgmwWZ8Zq3NN2M0AObUgEdmAKrk+l5YlSVrjrLAOkleazqiKsw9 b/Js/g9j6q9PCdp1my76rYtWbrsHeKz1TlGV76qGOh2V6HGaTnrEvaB0aOCGcUOUjwQO 52/v5QVjKRwfJBkc8JjEWjQiQnv3TMK9VuRJAL5ABxtNu82gHRKuYuNy4u67ywF1EQfd bFGBMuyFwgF0G11NGZohH9zgT+9n9i18mCaKfTraecZsI461M5txVT2RT5xPUbqasoPZ dFsc/KZnQJRPIsWacxMzC+caOHuLbeeylJtLAb84kJTPu0aCukYTWengJ4KoLIfSNtpH 9p/w== X-Gm-Message-State: AOAM53252/ABAvIAY81ksZtUz1uGmyT2G2Q24Li5wMQO9DQ5lySJJqFx CLWE2fgm53ufsgpQyep95+Wo+w== X-Received: by 2002:adf:8008:: with SMTP id 8mr10895564wrk.188.1637701055078; Tue, 23 Nov 2021 12:57:35 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id m14sm17750665wrp.28.2021.11.23.12.57.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Nov 2021 12:57:30 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 4E73F1FF99; Tue, 23 Nov 2021 20:57:29 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Subject: [PATCH v1 2/7] accel/tcg: suppress IRQ check for special TBs Date: Tue, 23 Nov 2021 20:57:24 +0000 Message-Id: <20211123205729.2205806-3-alex.bennee@linaro.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20211123205729.2205806-1-alex.bennee@linaro.org> References: <20211123205729.2205806-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::431 (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::431; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x431.google.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: fam@euphon.net, berrange@redhat.com, Richard Henderson , f4bug@amsat.org, stefanha@redhat.com, crosa@redhat.com, pbonzini@redhat.com, Pavel Dovgalyuk , =?utf-8?q?Alex_Benn=C3=A9e?= , aurelien@aurel32.net Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Generally when we set cpu->cflags_next_tb it is because we want to carefully control the execution of the next TB. Currently there is a race that causes cflags_next_tb to get ignored if an IRQ is processed before we execute any actual instructions. To avoid this we introduce a new compiler flag: CF_NOIRQ to suppress this check in the generated code so we know we will definitely execute the next block. Signed-off-by: Alex Bennée Cc: Pavel Dovgalyuk Fixes: https://gitlab.com/qemu-project/qemu/-/issues/245 --- include/exec/exec-all.h | 1 + include/exec/gen-icount.h | 21 +++++++++++++++++---- accel/tcg/cpu-exec.c | 14 ++++++++++++++ 3 files changed, 32 insertions(+), 4 deletions(-) diff --git a/include/exec/exec-all.h b/include/exec/exec-all.h index 6bb2a0f7ec..35d8e93976 100644 --- a/include/exec/exec-all.h +++ b/include/exec/exec-all.h @@ -503,6 +503,7 @@ struct TranslationBlock { #define CF_USE_ICOUNT 0x00020000 #define CF_INVALID 0x00040000 /* TB is stale. Set with @jmp_lock held */ #define CF_PARALLEL 0x00080000 /* Generate code for a parallel context */ +#define CF_NOIRQ 0x00100000 /* Generate an uninterruptible TB */ #define CF_CLUSTER_MASK 0xff000000 /* Top 8 bits are cluster ID */ #define CF_CLUSTER_SHIFT 24 diff --git a/include/exec/gen-icount.h b/include/exec/gen-icount.h index 610cba58fe..c57204ddad 100644 --- a/include/exec/gen-icount.h +++ b/include/exec/gen-icount.h @@ -21,7 +21,6 @@ static inline void gen_tb_start(const TranslationBlock *tb) { TCGv_i32 count; - tcg_ctx->exitreq_label = gen_new_label(); if (tb_cflags(tb) & CF_USE_ICOUNT) { count = tcg_temp_local_new_i32(); } else { @@ -42,7 +41,19 @@ static inline void gen_tb_start(const TranslationBlock *tb) icount_start_insn = tcg_last_op(); } - tcg_gen_brcondi_i32(TCG_COND_LT, count, 0, tcg_ctx->exitreq_label); + /* + * Emit the check against icount_decr.u32 to see if we should exit + * unless we suppress the check with CF_NOIRQ. If we are using + * icount and have suppressed interruption the higher level code + * should have ensured we don't run more instructions than the + * budget. + */ + if (tb_cflags(tb) & CF_NOIRQ) { + tcg_ctx->exitreq_label = NULL; + } else { + tcg_ctx->exitreq_label = gen_new_label(); + tcg_gen_brcondi_i32(TCG_COND_LT, count, 0, tcg_ctx->exitreq_label); + } if (tb_cflags(tb) & CF_USE_ICOUNT) { tcg_gen_st16_i32(count, cpu_env, @@ -74,8 +85,10 @@ static inline void gen_tb_end(const TranslationBlock *tb, int num_insns) tcgv_i32_arg(tcg_constant_i32(num_insns))); } - gen_set_label(tcg_ctx->exitreq_label); - tcg_gen_exit_tb(tb, TB_EXIT_REQUESTED); + if (tcg_ctx->exitreq_label) { + gen_set_label(tcg_ctx->exitreq_label); + tcg_gen_exit_tb(tb, TB_EXIT_REQUESTED); + } } #endif diff --git a/accel/tcg/cpu-exec.c b/accel/tcg/cpu-exec.c index 9cb892e326..9e3ed42ceb 100644 --- a/accel/tcg/cpu-exec.c +++ b/accel/tcg/cpu-exec.c @@ -721,6 +721,15 @@ static inline bool need_replay_interrupt(int interrupt_request) static inline bool cpu_handle_interrupt(CPUState *cpu, TranslationBlock **last_tb) { + /* + * If we have special cflags lets not get distracted with IRQs. We + * shall exit the loop as soon as the next TB completes what it + * needs to do. + */ + if (cpu->cflags_next_tb != -1) { + return false; + } + /* Clear the interrupt flag now since we're processing * cpu->interrupt_request and cpu->exit_request. * Ensure zeroing happens before reading cpu->exit_request or @@ -954,11 +963,16 @@ int cpu_exec(CPUState *cpu) * after-access watchpoints. Since this request should never * have CF_INVALID set, -1 is a convenient invalid value that * does not require tcg headers for cpu_common_reset. + * + * As we don't want this special TB being interrupted by + * some sort of asynchronous event we apply CF_NOIRQ to + * disable the usual event checking. */ cflags = cpu->cflags_next_tb; if (cflags == -1) { cflags = curr_cflags(cpu); } else { + cflags |= CF_NOIRQ; cpu->cflags_next_tb = -1; } From patchwork Tue Nov 23 20:57:25 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 519343 Delivered-To: patch@linaro.org Received: by 2002:ac0:c605:0:0:0:0:0 with SMTP id p5csp9243456imj; Tue, 23 Nov 2021 13:04:15 -0800 (PST) X-Google-Smtp-Source: ABdhPJzmKpxcGc4O955g4foSDWs/KalWSsWjcaAmLqQjgeSKw9HEWzSdsrmtQRAmQyC66mQnEE0Y X-Received: by 2002:a37:ac17:: with SMTP id e23mr387874qkm.287.1637701455769; Tue, 23 Nov 2021 13:04:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1637701455; cv=none; d=google.com; s=arc-20160816; b=Krpq8AuKeHOydaBdi9naGD2vIZD0LIhLD4OEXo29YH1yJkT39bJJZiVsGYFyItBc78 bwTeCz6hGyfMKem7kGjOek6+yKGrpqFakHVwKDrRRZn0KaZK1ann2gXja81Ys8dqSP3w QiGHtEVIMV5T1R71GrVeq/4etXoHmgZdGoc7IBYsBwL8Dqa3RKr/4mqfeCdqUkMxb9bx JByrFdG4mHCzeOzh10zffBRJ1AmpMj8E5aG5VbayxxnncV5ksn0HWP9w4xI9FCFw5aVH GMxox656kf6/aIdosApmyPCZThxd8oiiYicEtVLLs4HTo/Sd28Onf+x5n3+eFACXAMgB cgXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=005IHjqRWRJJaQave6epZYUIKBv/Z2a1tVz3K5hRNcs=; b=I2Ec+6WUgub2UYmbcqullr3JfVgx+huwYtSqXBi4Kp9rIly8JxrfUQtpzwKQFXY7wU ySfxMFBEy9r6rhA87KlhD8fLBmMZLkHlUVyfhENmlTw+zi20Ce71Bir89BkkGoaTdvH7 ieP86Zr2n8Jx1nG3ygo7pGjeuDdJNP4xP5sFuj3sRzZie+VVfs0Ala3H7XOxrIdQcR09 +pvFrzeu+pD6O4dCvCmy7DAD7t8OH+W/nG9oqBgP/NlsQjBBDUv3b9G4fbMfwXT9NC7L pRJ0ev94Fur7aU83V4bP1v6SJvH1o5EVE3bledPluCGe846aiQTWLXPPLnfHnyyasrXy Vbdw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=c5+qjBgp; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id x13si22147016qtw.411.2021.11.23.13.04.15 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 23 Nov 2021 13:04:15 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=c5+qjBgp; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:47050 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mpcxb-0003at-8W for patch@linaro.org; Tue, 23 Nov 2021 16:04:15 -0500 Received: from eggs.gnu.org ([209.51.188.92]:40578) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mpcrD-00020o-H8 for qemu-devel@nongnu.org; Tue, 23 Nov 2021 15:57:39 -0500 Received: from [2a00:1450:4864:20::429] (port=39928 helo=mail-wr1-x429.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mpcrC-0006NV-4O for qemu-devel@nongnu.org; Tue, 23 Nov 2021 15:57:39 -0500 Received: by mail-wr1-x429.google.com with SMTP id a18so193593wrn.6 for ; Tue, 23 Nov 2021 12:57:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=005IHjqRWRJJaQave6epZYUIKBv/Z2a1tVz3K5hRNcs=; b=c5+qjBgp/zfDS1P6GO9Fi9ryK0mupmn6f9SqtQWDNJa/g7MgbiQGl1PHxu+GpBVXdn gXvUC+ADiE2xawH+2J8UZj4TvoDgbd5ZIBpNFGfsEkcl28J/nj5OggGPImOjSZTEicsa gu7dS5VjQaQbHup23MIATaU4gwYKcVcM2iQ3+XdPVSPB1WBKjZvTYtSpWfzQa4G0ADha 58GTnABO7BGWQQl2awt3rYDbLbGh9hNrycEhjFYkRpquoAFPyaeNPOWSupXi/bcckobY +qam/Cn2oSjnm6OFclEJ6ufBep3gU2h/JN0fnUwpGZ0sDV8JKJBLLamiFZgURWg7NFSd fkcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=005IHjqRWRJJaQave6epZYUIKBv/Z2a1tVz3K5hRNcs=; b=Y+jRvO64qcwJVh/BgIsEAX+WBisY75NAqtE+AhpEJFzSSUdRG/Wtz9IbZ/8d5k49d9 aXO0CH22ORdDkngrKZb/KJFD4bnjd844XbpQvgNiW/zDSR35kV3pzESXI+ATMpYsF6HU Hw8cNGidE4rIWe20mieUhY8qsZflz1KKdxD24W7lo92DdwJET361pDoEpoh746liPE0L o/pNGbn/5xxZgHONr9K/MLlFjq7WUhI/HiqyMAUAavuK0Shvp43baVoDS6ZqOj1Zzu+W dR7uFgupzYDi+9+m2QtbvxCptrQiADB+6oYy3QSxIE8lDzehHStUuoZqXFM28fOyBS+E iviQ== X-Gm-Message-State: AOAM530NgsK2kah5RfaSDTSKg1Iq7uYzU7y7r6KU+sR34osV/tByTLQr xGk+W+JLZZUJfW2PqAXlMyUuow== X-Received: by 2002:a5d:47c7:: with SMTP id o7mr11809126wrc.204.1637701056896; Tue, 23 Nov 2021 12:57:36 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id h7sm12498573wrt.64.2021.11.23.12.57.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Nov 2021 12:57:30 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 643441FF9A; Tue, 23 Nov 2021 20:57:29 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Subject: [PATCH v1 3/7] tests/avocado: fix tcg_plugin mem access count test Date: Tue, 23 Nov 2021 20:57:25 +0000 Message-Id: <20211123205729.2205806-4-alex.bennee@linaro.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20211123205729.2205806-1-alex.bennee@linaro.org> References: <20211123205729.2205806-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::429 (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::429; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x429.google.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: fam@euphon.net, berrange@redhat.com, Beraldo Leal , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , f4bug@amsat.org, Wainer dos Santos Moschetta , stefanha@redhat.com, crosa@redhat.com, pbonzini@redhat.com, Mahmoud Mandour , Alexandre Iooss , =?utf-8?q?Alex_Benn=C3=A9e?= , aurelien@aurel32.net Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" When we cleaned up argument handling the test was missed. Fixes: 5ae589faad ("tests/plugins/mem: introduce "track" arg and make args not positional") Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- tests/avocado/tcg_plugins.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/avocado/tcg_plugins.py b/tests/avocado/tcg_plugins.py index 9ca1515c3b..642d2e49e3 100644 --- a/tests/avocado/tcg_plugins.py +++ b/tests/avocado/tcg_plugins.py @@ -131,7 +131,7 @@ def test_aarch64_virt_mem_icount(self): suffix=".log") self.run_vm(kernel_path, kernel_command_line, - "tests/plugin/libmem.so,arg=both", plugin_log.name, + "tests/plugin/libmem.so,inline=true,callback=true", plugin_log.name, console_pattern, args=('-icount', 'shift=1')) From patchwork Tue Nov 23 20:57:26 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 519337 Delivered-To: patch@linaro.org Received: by 2002:ac0:c605:0:0:0:0:0 with SMTP id p5csp9235599imj; Tue, 23 Nov 2021 12:58:21 -0800 (PST) X-Google-Smtp-Source: ABdhPJxd4gsAathG7sMM8t8rsoaEFY6rikMlAJ1UpkSOHiIBVucHghOKO8Xyy4tpeOHZQLkbzRhp X-Received: by 2002:a67:d58f:: with SMTP id m15mr14085977vsj.34.1637701101850; Tue, 23 Nov 2021 12:58:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1637701101; cv=none; d=google.com; s=arc-20160816; b=FsgLyC/bxljue8CCdVahrmxkVe5oghIgYu0PvxvH4qcR5BBQbAtOyWJuA6bpuPSZGr V8dR1vrkWoeN2gVPsmfdkDJVj6O9gFTYYS0s1xDjDzmJnS6yfxIClylUq1dRKxmqmE3G bCKYdjTprJVNhIIuXtXdHEDPKLx/OczDOTMqwaDTKOS5zwldsjS8QCOMG5tU6Be7DVWo 1GNrqobsI6detvlnEa/6IXZlAYMDOsnp6gBYmqxN43H+PPF8E5mYX2qKBwhUi+tKpLhE atfiQ5ZNcfWHIDXOZnO5hKElwFDa92BCPaSDDaQATQ3usqAt47QnW0rp2xNOiSklqFCN R3aA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=YmANYK88aPtNwGm4O/0eNlrDR7OUnbvfD2pP6xbhw2g=; b=fELApKJ+p/dyVRNMg9klhWn72+kjHSRnb7jNEUfbh3SoCUB+o0PwlMWf6h1zsVH20v rLJW1DjS4JojpSMFozIQ5TS/j4Yl9KJTnIRwudgcDExfqm8/ntQIDg8q7gUxWhyWv+CE K2Z7+e1xCaJ8LJ2s8W+Sc2M97txe7Qt5GLonTyzJiKixml63Iptx2PkF3d+s4oxRxn+d EOSFD49iSl+jHENK6btfc8kmbcO2MefpFUlenmhoz5AMdgifd0WLVdiWyGDUmFsHa1s7 vGW7qmgzRgIASJVIPk2EgDfkJyQocPcL7d0NVAs/Gk0e1W5ag24NIyOcMwNJkTHhVqrd rr6Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b="VfB/tJuw"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id i41si29273727vkr.41.2021.11.23.12.58.21 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 23 Nov 2021 12:58:21 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b="VfB/tJuw"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:60324 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mpcrt-0001xB-Bc for patch@linaro.org; Tue, 23 Nov 2021 15:58:21 -0500 Received: from eggs.gnu.org ([209.51.188.92]:40526) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mpcr9-0001up-RI for qemu-devel@nongnu.org; Tue, 23 Nov 2021 15:57:35 -0500 Received: from [2a00:1450:4864:20::32a] (port=46596 helo=mail-wm1-x32a.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mpcr7-0006LM-LF for qemu-devel@nongnu.org; Tue, 23 Nov 2021 15:57:35 -0500 Received: by mail-wm1-x32a.google.com with SMTP id c6-20020a05600c0ac600b0033c3aedd30aso244088wmr.5 for ; Tue, 23 Nov 2021 12:57:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=YmANYK88aPtNwGm4O/0eNlrDR7OUnbvfD2pP6xbhw2g=; b=VfB/tJuwYmg2pfvAon0sRPac9bt2MqUyzl6ij/tMXSfuaCcC79AU67a838nZFMh9/x 5f4YMx4d8SmhfsIPv77fzSmrPTvpPMDoEAtPv6Biu3Ep/kjGWMa7VTx+r0nAhOkp5nZ+ 5p3ci0UENAPJcVLYXxOQEPZ4KeyYC9tONzqZTOaKm4f3NknWOs4EGl3bxDOU1li1/1Co zpnYbnLeJJsA2X84oowlN8aGMd0kjQyxYOkDMau1cEfBKxi9ocUOuiUkyXZ+cD5kDE2L cMPvsXi+1dmUuTB+LLfNdNX+UHiNmJYMUtGO3BiufDaAZcrE2iTTnBfnXZEcfiWs4qVR BOhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=YmANYK88aPtNwGm4O/0eNlrDR7OUnbvfD2pP6xbhw2g=; b=SzM4JPt6uMtO+sHaDdV/C6o5kTMceyfKFQQiGExJBadKdG2CYIa+N/uDhrWf7v1oVU g82y7Y3RqfU389rbdH8oWCOocnQwiXhBL5Q61KO/gYDMEYzzYtiPXRrR9YaxeXFBHOkl VnjVKkRQsyy6l8c/JOfeejsbwS0t3E2wHOIxonv7PUvG/C0PzTG43hcWst3DxIt6Nvc9 jXWYChsx3FRAtbP41bGElwE9ICmV5F0oPO3/1xaqf9bKCMOVI2L9/j4LvQ126Zb7Ucr0 RheADGxxIBeCFUMciLxLJMAlWuQfqiK8WN2J/EPtnC6YNEyfPutPkwEWQwtaSK1rRS2y AS2A== X-Gm-Message-State: AOAM533cYsgP2C89d6xQzUoA5vl+wNTncvjNjVWeID8qUy+oLzV1xdip d+nZza0k1iRdSod78/1E0mP/+A== X-Received: by 2002:a7b:c207:: with SMTP id x7mr7255368wmi.108.1637701052131; Tue, 23 Nov 2021 12:57:32 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id t8sm2778157wmq.32.2021.11.23.12.57.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Nov 2021 12:57:30 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 6F8AD1FF9B; Tue, 23 Nov 2021 20:57:29 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Subject: [PATCH v1 4/7] plugins/meson.build: fix linker issue with weird paths Date: Tue, 23 Nov 2021 20:57:26 +0000 Message-Id: <20211123205729.2205806-5-alex.bennee@linaro.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20211123205729.2205806-1-alex.bennee@linaro.org> References: <20211123205729.2205806-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::32a (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::32a; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x32a.google.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: fam@euphon.net, berrange@redhat.com, Stefan Weil , f4bug@amsat.org, stefanha@redhat.com, crosa@redhat.com, pbonzini@redhat.com, Mahmoud Mandour , Alexandre Iooss , =?utf-8?q?Alex_Benn=C3=A9e?= , aurelien@aurel32.net Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Signed-off-by: Alex Bennée Tested-by: Stefan Weil Fixes: https://gitlab.com/qemu-project/qemu/-/issues/712 Reviewed-by: Philippe Mathieu-Daudé --- plugins/meson.build | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/plugins/meson.build b/plugins/meson.build index aeb386ebae..b3de57853b 100644 --- a/plugins/meson.build +++ b/plugins/meson.build @@ -2,9 +2,9 @@ plugin_ldflags = [] # Modules need more symbols than just those in plugins/qemu-plugins.symbols if not enable_modules if 'CONFIG_HAS_LD_DYNAMIC_LIST' in config_host - plugin_ldflags = ['-Wl,--dynamic-list=' + (meson.project_build_root() / 'qemu-plugins-ld.symbols')] + plugin_ldflags = ['-Wl,--dynamic-list=qemu-plugins-ld.symbols'] elif 'CONFIG_HAS_LD_EXPORTED_SYMBOLS_LIST' in config_host - plugin_ldflags = ['-Wl,-exported_symbols_list,' + (meson.project_build_root() / 'qemu-plugins-ld64.symbols')] + plugin_ldflags = ['-Wl,-exported_symbols_list,qemu-plugins-ld64.symbols'] endif endif From patchwork Tue Nov 23 20:57:27 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 519341 Delivered-To: patch@linaro.org Received: by 2002:ac0:c605:0:0:0:0:0 with SMTP id p5csp9240556imj; Tue, 23 Nov 2021 13:02:16 -0800 (PST) X-Google-Smtp-Source: ABdhPJwlbwbK1L1cW8T+XBLPM0CFo7iI5eRKwOt1s3koy+mfpZiNt3WlHTaE3SiRFGW/Sd8cMJd8 X-Received: by 2002:a05:6000:12d2:: with SMTP id l18mr11402562wrx.289.1637701336753; Tue, 23 Nov 2021 13:02:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1637701336; cv=none; d=google.com; s=arc-20160816; b=HM8T8AbHeJ1mq6yQF/jXQq05p1IDkesVEUgW62WKXd/r0zhZw67GTVP/jxAM5qLmeU zTWiGifUElDBpBA5Icnn7YVlh/zRr59EFtpvbe1tjcYl8EL3usax/st5TsW109TwSdAx ilUJm+g6Sp/z+YXAhLjCD3PAk8ezqcYSDs4vXYV2wN/S3mWQHwTk0JqzgbLrrHt+Fhwa nK9veTEAiQTRFclir5lOrxkiPM56k02jVTAnaE6gDyest/LyzHIeSN7gCHe1S7uuDlea DXBWqDjgIFJCn1WJjxcA+1ZPh6RsL5M7Kqrqiy4V5tKs8kdF90NR2ycc69JKk6u6RHW8 d3yw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=SycTkjrDr+1oRjBfcTSdUKJyzjeYOYHJsQB5AU6b3cM=; b=vEQFqU4lirHAi+OlLjiWSLf3EmeLBUY6UORKF0hSzM5R3S1SXmM6whe5LLXbhFGcFq 070isZOpPlgdobqj+8cpFkK3nM/XCse2Y8V0kIQwxZBJ6N640483eFQbhszxh4YLRLUm rUdFPx3XZ+p0R6p7aYUyX2FNmqtFd9H7yhNTpuvMs9ysUM65DNloqiO47HFqoUOOo6/Y ogvNaa11G0kUGjN12odZmq5unHnmLOOI1cIdRCV+Lhcv/zkYJa7v7fiYff+pNzjQaFZn HRj/XwpipbkTMNaGI4jWbvtl5k33nj4asZj8Q6W1t7LJNpRPaBI5GxYZLh737hyL1auT LueA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=h6VheffY; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id l13si25556742wrq.255.2021.11.23.13.02.16 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 23 Nov 2021 13:02:16 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=h6VheffY; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:40308 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mpcvf-0007R8-P9 for patch@linaro.org; Tue, 23 Nov 2021 16:02:15 -0500 Received: from eggs.gnu.org ([209.51.188.92]:40606) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mpcrF-00026f-ER for qemu-devel@nongnu.org; Tue, 23 Nov 2021 15:57:41 -0500 Received: from [2a00:1450:4864:20::32a] (port=42993 helo=mail-wm1-x32a.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mpcrD-0006Nf-Qp for qemu-devel@nongnu.org; Tue, 23 Nov 2021 15:57:41 -0500 Received: by mail-wm1-x32a.google.com with SMTP id d72-20020a1c1d4b000000b00331140f3dc8so265820wmd.1 for ; Tue, 23 Nov 2021 12:57:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=SycTkjrDr+1oRjBfcTSdUKJyzjeYOYHJsQB5AU6b3cM=; b=h6VheffYOdocYdpTShecWBrRrd7pMGlluzqm+ZXYEBpryShPP58HEc2sLEB+kzx3gm f2Ch1tPIa2G54ZU+j8iB0ntA7OQCv1of8x25YGjKVhnMnk1xhjt6XJcuNPzlXBN4/TbZ eKzy6g1BFkyFicJR64/iz/kqZK7m/uxMhJ+qv1sHUz1u5aGo/is0AgiqWU2ChikvyulU yU/3VwAYcpxrOIW7bCKRRzUPkKogCJNva0rhqO9S1x7IiOuqt3UCJuqDLMF6z+xPAeeE lWPHepy263DUyToI4fo2m9CcxVc8y/CL5hJCpoT8ni+U5IRkvFt4NyUa4FoBIrVm2pv4 QM9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=SycTkjrDr+1oRjBfcTSdUKJyzjeYOYHJsQB5AU6b3cM=; b=QozlJEeYBwAUHRLWY8A6QYKRMhKBgbT7BINhblfrS/tgFFu6u2/PB5XdoGfCDqfv87 C8DRCiedV5YX8Z2+B4VYRI1/Un+pzr5j7DWJ2OrZfcFnDbNNfvo0GYvTe8Mfnx8DGTp6 h7AkuGuBTg212R0WPBb2nKktCDmBza8Lm+9syCy7nmmqUeIqd3YN24tT4PG+JOXpTNL0 SdDtwXR61lNUxg8J7eymhe4ARUszOzk1TWb6BumHtusF6l5p84mAoBnXa8IGf4Z9egj4 Pd8eK1kjyJ/SSvkLI4SorPRHJnHgoMXv4ZzTfSqsccXAIdBbNP8/D9J2FWNUUYBtAi7C fLRw== X-Gm-Message-State: AOAM5334hgfjSgxE7sFYEKL87ejlh+rQs0gZPIiR43Qb/bykKrBdjAkW m4QYMBgSbdnX1noT6r7fXKPWrA== X-Received: by 2002:a05:600c:4f55:: with SMTP id m21mr7354997wmq.68.1637701058555; Tue, 23 Nov 2021 12:57:38 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id k8sm12651400wrn.91.2021.11.23.12.57.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Nov 2021 12:57:37 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 851C41FF9C; Tue, 23 Nov 2021 20:57:29 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Subject: [PATCH v1 5/7] gdbstub: handle a potentially racing TaskState Date: Tue, 23 Nov 2021 20:57:27 +0000 Message-Id: <20211123205729.2205806-6-alex.bennee@linaro.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20211123205729.2205806-1-alex.bennee@linaro.org> References: <20211123205729.2205806-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::32a (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::32a; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x32a.google.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: fam@euphon.net, berrange@redhat.com, =?utf-8?q?Philippe_Mathieu-Daud?= =?utf-8?q?=C3=A9?= , Richard Henderson , f4bug@amsat.org, stefanha@redhat.com, crosa@redhat.com, pbonzini@redhat.com, =?utf-8?q?Alex_?= =?utf-8?q?Benn=C3=A9e?= , aurelien@aurel32.net Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" When dealing with multi-threaded userspace programs there is a race condition with the addition of cpu->opaque (aka TaskState). This is due to cpu_copy calling cpu_create which updates the global vCPU list. However the task state isn't set until later. This shouldn't be a problem because the new thread can't have executed anything yet but the gdbstub code does liberally iterate through the CPU list in various places. This sticking plaster ensure the not yet fully realized vCPU is given an pid of -1 which should be enough to ensure it doesn't show up anywhere else. In the longer term I think the code that manages the association between vCPUs and attached GDB processes could do with a clean-up and re-factor. Signed-off-by: Alex Bennée Tested-by: Richard Henderson Reviewed-by: Richard Henderson Cc: Richard Henderson Resolves: https://gitlab.com/qemu-project/qemu/-/issues/730 --- gdbstub.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdbstub.c b/gdbstub.c index 23baaef40e..141d7bc4ec 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -94,7 +94,7 @@ static inline int cpu_gdb_index(CPUState *cpu) { #if defined(CONFIG_USER_ONLY) TaskState *ts = (TaskState *) cpu->opaque; - return ts->ts_tid; + return ts ? ts->ts_tid : -1; #else return cpu->cpu_index + 1; #endif From patchwork Tue Nov 23 20:57:28 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 519339 Delivered-To: patch@linaro.org Received: by 2002:ac0:c605:0:0:0:0:0 with SMTP id p5csp9236141imj; Tue, 23 Nov 2021 12:58:51 -0800 (PST) X-Google-Smtp-Source: ABdhPJyzm9ajBMMn6sLqTOKC1vMsSzwadYBvvKZ7ut3OHnlGB4RA50W2fDxHiYK7p79b6JfM1WoI X-Received: by 2002:a05:6102:3166:: with SMTP id l6mr13416447vsm.51.1637701131827; Tue, 23 Nov 2021 12:58:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1637701131; cv=none; d=google.com; s=arc-20160816; b=W9/kvUxlrf+uCpcmDmVpc/yuQnKoJ7a8Tu0LAIDuCb9z9RLemBKFrXatYnXqUn1mBv Fdb+G3zq+Hd75JHolhr7CHjBgrsFyayLwqdZLkdEzev62RL14QFc840H0sH4kwWsEnfC JVE3LyxvioOmB1MmrRAVIk2OTaRVPmM1ToOx6ncCNoRTp34RfrE8Wxpw1CjPL+f+K2FP UcXt9nd6eC2u1qW3hBqL62pCC4OnmDVhtFFWF1LuMoeQFFwDLzYYQVa+DJT8RlBsidvE pGalZgSp39UiyqmNXoqp/dKJtWVsrAivfkDjua16rpm6PtOoGL/e7Xj3CywUVVRf1Hdq 300Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=tVBYX0xCVJBO6/TWHd6rZqnYoCc7L/iFtDi/gZndAeI=; b=j3hQraDGhcWjlSfnGVL7fby5AUkEgfDZeg4MftjGaizXAsXaZcdKRdu8Cx7Ly3oBzD f9oETM14cuyGHrG0p/EEzrR83C38CX5+7sB+hP8jYbDD6IGueIs6kLZpNSvMB8DI16FS aD7p+YENpXxAQNgdlzSTd0aoEYBvXuj7lCqeG+kghzKzRwyGQ9RejrJCwlcwn5fItdCO JKOFWEnrxdawGzBI5JKwjPgAlO+xxPXk0DxJqwL1OK/mjjSQuIFRARwCF16753TQeqoH cGXAklwCJMiLH3rf9R0mO+OL4gKVlwsPQhhk+JUoUDgyT3XAa+cPnikLgfbi0MmaLypO ygow== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=K2rd8A+F; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id a29si43940141vsj.327.2021.11.23.12.58.51 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 23 Nov 2021 12:58:51 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=K2rd8A+F; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:32820 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mpcsN-0002QR-9e for patch@linaro.org; Tue, 23 Nov 2021 15:58:51 -0500 Received: from eggs.gnu.org ([209.51.188.92]:40626) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mpcrI-0002Je-V9 for qemu-devel@nongnu.org; Tue, 23 Nov 2021 15:57:44 -0500 Received: from [2a00:1450:4864:20::42b] (port=42617 helo=mail-wr1-x42b.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mpcrG-0006OE-T2 for qemu-devel@nongnu.org; Tue, 23 Nov 2021 15:57:44 -0500 Received: by mail-wr1-x42b.google.com with SMTP id c4so173794wrd.9 for ; Tue, 23 Nov 2021 12:57:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=tVBYX0xCVJBO6/TWHd6rZqnYoCc7L/iFtDi/gZndAeI=; b=K2rd8A+Fy4kiHDbFxPcg44AivZnyFa0NI+yCg+1qEyLBwoMoBvMi8X/6wuEz/8dMI7 RBZea6gSQBOdtnELgEpA+mREH7wvlpDrvzO0n+cRnBgFCa7Fi1ZjGHejmXMydnfPInt+ CVF17/2jg6VhR210d1yTLvpzskO5JQQ8z530AYzFopEGbzOn6wRDCRQTXtcu4mJwEIPD ChJ53FwFiSnTL1l6jyfLAOUpyfnwMbpbTUIrEqN8+MQnOf+eXyfjLRkN8FJcRPZ8Jege DXo9kIJX5JUURd+1ZJuTSALYiklwd7nW57Kmv1AbCGzoCk92mSWA1oajeIFScAobIPmw T2ig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=tVBYX0xCVJBO6/TWHd6rZqnYoCc7L/iFtDi/gZndAeI=; b=6tA29arcll9hcyYQiQto/m6EVWlZ6MsY9t2H1iEVKxtNwW14E2DO4l35t2/Q7xo4bY jVPaR0YV/J70juLt+z60qBusntb5i32ESb6JVj+ou5IsrYRWqevBcGCS7x+Mw93EzKJK xLzWuai834M6V0PUkP9AJzcmOOx8LQY4y4rYhyvVP0ghk5tdB6sKCt0DIKNwMi4CATP5 Mo6UodX9wDhRNuhopge4OIRRH8D0eeJrWV6EMJ4i1f2PA/pG/BqnYJLsUpDQ8ur1cDNF cCmXxRHXJHgJkPy+gjOMZZ+93wS9IMh1UGBqWwzSo1u0dQ1JbDZbIatVdauAfh9pV9xP 4jWQ== X-Gm-Message-State: AOAM5331s2mvCb8nkVKL+xrIKuZE7NNe/hAaqjMSoGpcD5Po6ubrA3Ii a6ej3vh61/kGdpE4roDtoS+NvQ== X-Received: by 2002:a5d:5850:: with SMTP id i16mr10906620wrf.197.1637701061607; Tue, 23 Nov 2021 12:57:41 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id y6sm2187526wma.37.2021.11.23.12.57.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Nov 2021 12:57:37 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 8FB861FF9D; Tue, 23 Nov 2021 20:57:29 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Subject: [PATCH v1 6/7] MAINTAINERS: Remove me as a reviewer for the build and test/avocado Date: Tue, 23 Nov 2021 20:57:28 +0000 Message-Id: <20211123205729.2205806-7-alex.bennee@linaro.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20211123205729.2205806-1-alex.bennee@linaro.org> References: <20211123205729.2205806-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::42b (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::42b; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x42b.google.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: fam@euphon.net, berrange@redhat.com, Beraldo Leal , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , f4bug@amsat.org, Willian Rampazzo , stefanha@redhat.com, crosa@redhat.com, pbonzini@redhat.com, =?utf-8?q?Alex_Benn=C3=A9e?= , aurelien@aurel32.net Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Willian Rampazzo Remove me as a reviewer for the Build and test automation and the Integration Testing with the Avocado Framework and add Beraldo Leal. Signed-off-by: Willian Rampazzo Reviewed-by: Beraldo Leal Message-Id: <20211122191124.31620-1-willianr@redhat.com> Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé --- MAINTAINERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index d3879aa3c1..8f5156bfa7 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3469,7 +3469,7 @@ M: Alex Bennée M: Philippe Mathieu-Daudé M: Thomas Huth R: Wainer dos Santos Moschetta -R: Willian Rampazzo +R: Beraldo Leal S: Maintained F: .github/lockdown.yml F: .gitlab-ci.yml @@ -3507,7 +3507,7 @@ W: https://trello.com/b/6Qi1pxVn/avocado-qemu R: Cleber Rosa R: Philippe Mathieu-Daudé R: Wainer dos Santos Moschetta -R: Willian Rampazzo +R: Beraldo Leal S: Odd Fixes F: tests/avocado/ From patchwork Tue Nov 23 20:57:29 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 519342 Delivered-To: patch@linaro.org Received: by 2002:ac0:c605:0:0:0:0:0 with SMTP id p5csp9240642imj; Tue, 23 Nov 2021 13:02:18 -0800 (PST) X-Google-Smtp-Source: ABdhPJzZ/g3cfGmTyD0Aw+AKHfJqthox16PU8a+vJBi51tabiLsQZxOJ2p+w2vhtsCcb1GC2gfMO X-Received: by 2002:a4a:d9c8:: with SMTP id l8mr5089010oou.81.1637701338096; Tue, 23 Nov 2021 13:02:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1637701337; cv=none; d=google.com; s=arc-20160816; b=ut4vYCyD+KdI1x8C0zXTxWN83fXSnOquiiAbEL218dnctZEv/S35/3/ClCu7Xe36D5 JLheLsWPYYX0yLPrdoRPYcjz+EGTW9y4eCWrcpfJMLTHe6uShe3BegwhJV7PODGtpDvN GKhUIx1GgKZFq1lI0yNteyoPLSgzDDuOk2KvWRfpLuow7g1jRqjwA/MBwP+SaoiFm4IG SuHbrH1dDFw9VLaFIxdOF5AGAVRj2QcqUQ5RcVGBRX6yLULUHoGfwlkWhO4ypa/0THuh xYDW/YYhOst7ISU4JCVeujirjmJk/KMkYenuLFpPyo1lkQAYXwZW7kKFy9WJAsE8KLJ1 E7PQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=uBN1thr4DbsWscceeDNQ1S5QjZOFYsoqFTbRgiy3bvY=; b=KE/2aP1Qe+68oo5SlG+0OlmY6gGTtpZIOhYGbwIBxPkV5vLP3VsuPFLnInt7y7U+Yf qNuDSxFltAFiq9n2RVQx1BbPVzrMP+59tHuotkHibImmhKM2khmKZrLr49Gq1HLGQwEp i9a/mPWObRTWJ3tY2MBrHXUoFhR8xQNLzVjh8kEYlGfrtyqFVJxpyOiFQM3YKaT+GOXr Y9kX+ZSGs7znJo2gPmBihb01dYoOXCdJKlgdOdWLjHSdHqEDlQ5UfsU9tPdvQcZWYaew vZzf8pL4WGP8lxNWqp49H29wMdD220//HynsqWjn57JGd8bAcvQFX2y8p1Gteg4Jx/QR 38fA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b="UlP7ZU/y"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id cz38si48608818vsb.414.2021.11.23.13.02.17 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 23 Nov 2021 13:02:17 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b="UlP7ZU/y"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:40524 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mpcvh-0007Yu-EN for patch@linaro.org; Tue, 23 Nov 2021 16:02:17 -0500 Received: from eggs.gnu.org ([209.51.188.92]:40610) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mpcrG-000296-88 for qemu-devel@nongnu.org; Tue, 23 Nov 2021 15:57:42 -0500 Received: from [2a00:1450:4864:20::435] (port=40868 helo=mail-wr1-x435.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mpcrE-0006Nz-M5 for qemu-devel@nongnu.org; Tue, 23 Nov 2021 15:57:41 -0500 Received: by mail-wr1-x435.google.com with SMTP id r8so187518wra.7 for ; Tue, 23 Nov 2021 12:57:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=uBN1thr4DbsWscceeDNQ1S5QjZOFYsoqFTbRgiy3bvY=; b=UlP7ZU/y+i03eDZtijPjXGrmhtWML1CfJfgROhdb61AYtcBWKoKpiTWoUK3Uns3cSr 6G5rMCLgxT1ksA97MZ0pBprEcHhiO01dqk/+nKbo3VW9fICKbWmEYQyuCftBL2LIip/q /XvSRJBlQb84rkGMfE4MDFLMzhTJg5jR1oHe5Ctkj2BJu5i8rYC3up2T5LEZwuMMKUQh 5tQAdkazx7YGexX/QX1oeozHdXRXzkYwlTO9MRonFx554gLbCTJeXq68Kpk3lQqcg06u dHJUyHTh+HaYce4FBKitbdnCCFTl7s373nab4NSHxwjG9A01D0XSX9voNruboMPBmjto wbGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=uBN1thr4DbsWscceeDNQ1S5QjZOFYsoqFTbRgiy3bvY=; b=BU9OnvHpwoDI/yGDGvQkUBczwyGd8Vpi2qZPt7I7MK6xNPsdtjrdlgcGnZxGcS4RS6 hLDDoraPZGbT9xY6Eh6C9aU5dJd4BICGzGhlIfk91RiiK7LlHxXbzy+boLrsSOCZvRcH PTrlU39ERtweGP9QVsCKXsCZ3IvKxRtCL/9pbWcmCVkSL6VipioV8XMtGZocsMskFOHB FwUAl6Xmp9AGVyAYTQUNNxWDUbnbekaeoZQoBkJYIfEK39o5Gh3UKVXUyKQJpw9e5nUU aa9AIzh0f6vszr4exgETFtZDtF74xmrB+Hd+lgPOEMy4D/I5uiNbYSmKhgdzG3fQEODx /eaA== X-Gm-Message-State: AOAM532AHzS0nCFPhDVatWmNnMFLu3HvQ9DLhy2ogiyLyJkC55+HMd8c C8Q4AktwYuGYFIU6PkDdgce/Sw== X-Received: by 2002:a5d:6085:: with SMTP id w5mr10481928wrt.122.1637701059344; Tue, 23 Nov 2021 12:57:39 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id d7sm12611253wrw.87.2021.11.23.12.57.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Nov 2021 12:57:37 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id A5EC11FF9E; Tue, 23 Nov 2021 20:57:29 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Subject: [PATCH v1 7/7] MAINTAINERS: Add section for Aarch64 GitLab custom runner Date: Tue, 23 Nov 2021 20:57:29 +0000 Message-Id: <20211123205729.2205806-8-alex.bennee@linaro.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20211123205729.2205806-1-alex.bennee@linaro.org> References: <20211123205729.2205806-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::435 (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::435; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x435.google.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: fam@euphon.net, Thomas Huth , berrange@redhat.com, f4bug@amsat.org, stefanha@redhat.com, crosa@redhat.com, pbonzini@redhat.com, =?utf-8?q?Alex_Benn=C3=A9e?= , aurelien@aurel32.net Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Philippe Mathieu-Daudé Add a MAINTAINERS section to cover the GitLab YAML config file containing the jobs run on the custom runner sponsored by the Works On Arm project [*]. [*] https://developer.arm.com/solutions/infrastructure/works-on-arm Suggested-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée Message-Id: <20211116163226.2719320-1-f4bug@amsat.org> --- MAINTAINERS | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 8f5156bfa7..006a2293ba 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3511,6 +3511,12 @@ R: Beraldo Leal S: Odd Fixes F: tests/avocado/ +GitLab custom runner (Works On Arm Sponsored) +M: Alex Bennée +M: Philippe Mathieu-Daudé +S: Maintained +F: .gitlab-ci.d/custom-runners/ubuntu-20.04-aarch64.yml + Documentation ------------- Build system architecture