From patchwork Tue Dec 7 22:56:34 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mathieu Jadin X-Patchwork-Id: 521781 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DD32C433F5 for ; Tue, 7 Dec 2021 22:58:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242387AbhLGXCH (ORCPT ); Tue, 7 Dec 2021 18:02:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54542 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229963AbhLGXCH (ORCPT ); Tue, 7 Dec 2021 18:02:07 -0500 Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [IPv6:2a00:1450:4864:20::52c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 484A8C061574; Tue, 7 Dec 2021 14:58:36 -0800 (PST) Received: by mail-ed1-x52c.google.com with SMTP id t5so2139803edd.0; Tue, 07 Dec 2021 14:58:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=MxRk45QdBqpd7r4GJABVLIOqSe7zvIAt/fvkPaWY7q8=; b=EhcfXH5vpcFz/8Ha1E7u6BWCjYPinzYQLMt3ZCxIj68XKM6Y0TCJmnQuu/wUijED69 0rOOsSd5p4P40rFHOL1XH7mpdo0eoiIZaAdFkQdLemVjQOxWUOV8JPNAvj5DvIsDMRnB 8GuJA7FdEpjAP+jx9D4Z8B2BWuk+1EhJX5NbRp/ePmDOpHgwTSjzJ83XlilsidtWuJjK uLYuY1svpHRM0wtrYDRfc8zFFiYZvyBmi5/YZRslFdbD3RCo5CZLODe3m5UZuOA5yWIz 9CVnq3aYmpcSNMuH1aCHgi8O7a9q8O9rczUfmTUwoxsptZDJEUm43qICP8pNJPToY+st MkOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=MxRk45QdBqpd7r4GJABVLIOqSe7zvIAt/fvkPaWY7q8=; b=v8tlqmSX9wECLNUqUIJceOKyPVZ6N8+ELnluqd86oTzKetYQtwBDRWfuX+J+oKxSIF t8x1A3VzuveCVd18wTWogmSQ1xSKuvOgqha9lWzfO3PDOQZgWxqfpvmyjdTn1wgg7+oU e2ubvvnbVZPmaulxjvtUBK0Zj1tR+aw+hH7YEK/6E/s8GhMC7+lp9PzfJWDGR27EdFPA NTUNeDT4rl3XtQMXp14z6hSd/3v2EzWVmPsGmreuMxXkJegBRl00yHV2WHSLxHGKejOZ YFt+L+z6x7oEvom6sJC2qhfyiqqx4piv/evFUuDrR+fLidnKUATPHsxGby52xklDVPZp QPcg== X-Gm-Message-State: AOAM530YoWNWPJLVTxOgltg5fPZJUpv1+vjofTjzjZHcHWacJC8h4h5V M05sYV7fDlnefXSU+ur2CfrDpITPicpuAA== X-Google-Smtp-Source: ABdhPJzPSNmzkbCtguwdf0pbcwo8gcLTWBVDyc5rqjnH5xdnBWFyg/d2CsGvG1rEHtITNF7BTeBAXA== X-Received: by 2002:a50:d6d9:: with SMTP id l25mr13267842edj.41.1638917914775; Tue, 07 Dec 2021 14:58:34 -0800 (PST) Received: from localhost.localdomain ([2a02:a03f:c062:a800:5f01:482d:95e2:b968]) by smtp.gmail.com with ESMTPSA id q17sm763554edd.10.2021.12.07.14.58.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Dec 2021 14:58:34 -0800 (PST) From: Mathieu Jadin To: bpf@vger.kernel.org Cc: Mathieu Jadin , John Fastabend , Yonghong Song , linux-kselftest@vger.kernel.org, Martin KaFai Lau , netdev@vger.kernel.org, Shuah Khan , KP Singh , Daniel Borkmann , Alexei Starovoitov , Song Liu , Andrii Nakryiko Subject: [PATCH bpf-next v2 2/3] selftests/bpf: Test for IPv6 ext header parsing Date: Tue, 7 Dec 2021 23:56:34 +0100 Message-Id: <20211207225635.113904-2-mathjadin@gmail.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211207225635.113904-1-mathjadin@gmail.com> References: <20211207225635.113904-1-mathjadin@gmail.com> MIME-Version: 1.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1638916158; l=7638; s=20211207; h=from:subject; bh=pfejiEES48KDaCYB5jnr8/AiinivCigFkRea4FdfavA=; b=UEva4CDOTRYm2V7vRN0NmwnvATQhizM+LFNVQ5/n5fLKZdlFfQ3jF+fMrcdjzkvaNzIUAdvmb7B9 bJFLIXw+DoRkEUzOoq0t649TwvBITY0IzmssPuKLTHzQTI/+GKtO X-Developer-Key: i=mathjadin@gmail.com; a=ed25519; pk=LX0wKHMKZralQziQacrPu4w5BceQsC7CocWV714TPRU= Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org This test creates a client and a server exchanging a single byte with a Segment Routing Header and the eBPF program saves the inner segment in a sk_storage. The test program checks that the segment is correct. Signed-off-by: Mathieu Jadin --- .../bpf/prog_tests/tcp_ipv6_exthdr_srh.c | 171 ++++++++++++++++++ .../selftests/bpf/progs/tcp_ipv6_exthdr_srh.c | 78 ++++++++ 2 files changed, 249 insertions(+) create mode 100644 tools/testing/selftests/bpf/prog_tests/tcp_ipv6_exthdr_srh.c create mode 100644 tools/testing/selftests/bpf/progs/tcp_ipv6_exthdr_srh.c diff --git a/tools/testing/selftests/bpf/prog_tests/tcp_ipv6_exthdr_srh.c b/tools/testing/selftests/bpf/prog_tests/tcp_ipv6_exthdr_srh.c new file mode 100644 index 000000000000..70f7ee230975 --- /dev/null +++ b/tools/testing/selftests/bpf/prog_tests/tcp_ipv6_exthdr_srh.c @@ -0,0 +1,171 @@ +// SPDX-License-Identifier: GPL-2.0 +#include +#include +#include "cgroup_helpers.h" +#include "network_helpers.h" + +struct tcp_srh_storage { + struct in6_addr inner_segment; +}; + +static void send_byte(int fd) +{ + char b = 0x55; + + if (CHECK_FAIL(send(fd, &b, sizeof(b), 0) != 1)) + perror("Failed to send single byte"); +} + +static int verify_srh(int map_fd, int server_fd, struct ipv6_sr_hdr *client_srh) +{ + int err = 0; + struct tcp_srh_storage val; + + if (CHECK_FAIL(bpf_map_lookup_elem(map_fd, &server_fd, &val) < 0)) { + perror("Failed to read socket storage"); + return -1; + } + + if (memcmp(&val.inner_segment, &client_srh->segments[1], + sizeof(struct in6_addr))) { + log_err("The inner segment of the received SRH differs from the sent one"); + err++; + } + + return err; +} + +static int run_test(int cgroup_fd, int listen_fd) +{ + struct bpf_prog_load_attr attr = { + .prog_type = BPF_PROG_TYPE_SOCK_OPS, + .file = "./tcp_ipv6_exthdr_srh.o", + .expected_attach_type = BPF_CGROUP_SOCK_OPS, + }; + size_t srh_size = sizeof(struct ipv6_sr_hdr) + + 2 * sizeof(struct in6_addr); + struct ipv6_sr_hdr *client_srh; + struct bpf_object *obj; + struct bpf_map *map; + struct timeval tv; + int client_fd; + int server_fd; + int prog_fd; + int map_fd; + char byte; + int err; + + err = bpf_prog_load_xattr(&attr, &obj, &prog_fd); + if (err) { + log_err("Failed to load BPF object"); + return -1; + } + + map = bpf_object__next_map(obj, NULL); + map_fd = bpf_map__fd(map); + + err = bpf_prog_attach(prog_fd, cgroup_fd, BPF_CGROUP_SOCK_OPS, 0); + if (err) { + log_err("Failed to attach BPF program"); + goto close_bpf_object; + } + + client_fd = connect_to_fd(listen_fd, 0); + if (client_fd < 0) { + err = -1; + goto close_bpf_object; + } + + server_fd = accept(listen_fd, NULL, 0); + if (server_fd < 0) { + err = -1; + goto close_client_fd; + } + + /* Set an SRH with ::1 as an intermediate segment on the client */ + + client_srh = calloc(1, srh_size); + if (!client_srh) { + log_err("Failed to create the SRH to send"); + goto close_server_fd; + } + client_srh->type = IPV6_SRCRT_TYPE_4; + // We do not count the first 8 bytes (RFC 8200 Section 4.4) + client_srh->hdrlen = (2 * sizeof(struct in6_addr)) >> 3; + client_srh->segments_left = 1; + client_srh->first_segment = 1; + // client_srh->segments[0] is set by the kernel + memcpy(&client_srh->segments[1], &in6addr_loopback, + sizeof(struct in6_addr)); + + if (setsockopt(client_fd, SOL_IPV6, IPV6_RTHDR, client_srh, + srh_size)) { + log_err("Failed to set the SRH on the client"); + goto free_srh; + } + + /* Send traffic with this SRH + * and check its parsing on the server side + */ + + tv.tv_sec = 1; + tv.tv_usec = 0; + if (setsockopt(server_fd, SOL_SOCKET, SO_RCVTIMEO, (const char *)&tv, + sizeof(tv))) { + log_err("Failed to set the receive timeout on the server"); + err = -1; + goto free_srh; + } + + send_byte(client_fd); + if (recv(server_fd, &byte, 1, 0) != 1) { + log_err("Failed to get the byte under one second on the server 2"); + err = -1; + goto free_srh; + } + + err += verify_srh(map_fd, server_fd, client_srh); + +free_srh: + free(client_srh); +close_server_fd: + close(server_fd); +close_client_fd: + close(client_fd); +close_bpf_object: + bpf_object__close(obj); + return err; +} + +void test_tcp_ipv6_exthdr_srh(void) +{ + int server_fd, cgroup_fd; + + cgroup_fd = test__join_cgroup("/tcp_ipv6_exthdr_srh"); + if (CHECK_FAIL(cgroup_fd < 0)) + return; + + server_fd = start_server(AF_INET6, SOCK_STREAM, "::1", 0, 0); + if (CHECK_FAIL(server_fd < 0)) + goto close_cgroup_fd; + + if (CHECK_FAIL(system("sysctl net.ipv6.conf.all.seg6_enabled=1"))) + goto close_server; + + if (CHECK_FAIL(system("sysctl net.ipv6.conf.lo.seg6_enabled=1"))) + goto reset_sysctl; + + CHECK_FAIL(run_test(cgroup_fd, server_fd)); + + if (CHECK_FAIL(system("sysctl net.ipv6.conf.lo.seg6_enabled=0"))) + log_err("Cannot reset sysctl net.ipv6.conf.lo.seg6_enabled to 0"); + +reset_sysctl: + if (CHECK_FAIL(system("sysctl net.ipv6.conf.all.seg6_enabled=0"))) + log_err("Cannot reset sysctl net.ipv6.conf.all.seg6_enabled to 0"); + +close_server: + close(server_fd); +close_cgroup_fd: + close(cgroup_fd); +} diff --git a/tools/testing/selftests/bpf/progs/tcp_ipv6_exthdr_srh.c b/tools/testing/selftests/bpf/progs/tcp_ipv6_exthdr_srh.c new file mode 100644 index 000000000000..cb4b4e23e337 --- /dev/null +++ b/tools/testing/selftests/bpf/progs/tcp_ipv6_exthdr_srh.c @@ -0,0 +1,78 @@ +// SPDX-License-Identifier: GPL-2.0 +#include +#include +#include +#include +#include +#include + +char _license[] SEC("license") = "GPL"; + +#define NEXTHDR_ROUTING 43 + +struct tcp_srh_storage { + struct in6_addr inner_segment; +}; + +struct { + __uint(type, BPF_MAP_TYPE_SK_STORAGE); + __uint(map_flags, BPF_F_NO_PREALLOC); + __type(key, int); + __type(value, struct tcp_srh_storage); +} socket_storage_map SEC(".maps"); + +/* Check the header received from the active side */ +static int read_incoming_srh(struct bpf_sock_ops *skops, + struct tcp_srh_storage *storage) +{ + __u32 seg_size = 2 * sizeof(struct in6_addr); + struct ipv6_sr_hdr *srh; + struct ipv6hdr *ip6; + void *seg_list; + int ret = 1; + + ip6 = (struct ipv6hdr *)skops->skb_data; + if (ip6 + 1 <= skops->skb_data_end && ip6->nexthdr == NEXTHDR_ROUTING) { + srh = (struct ipv6_sr_hdr *)(ip6 + 1); + if (srh + 1 <= skops->skb_data_end) { + if (srh->type != IPV6_SRCRT_TYPE_4) + return ret; + + seg_list = (void *)(srh + 1); + if (seg_list + seg_size <= skops->skb_data_end) { + // This is an SRH with at least 2 segments + storage->inner_segment = srh->segments[1]; + ret = 0; + } + } + } + + return ret; +} + +SEC("sockops") +int srh_read(struct bpf_sock_ops *skops) +{ + struct tcp_srh_storage *storage; + int true_val = 1; + + if (!skops->sk) + return 1; + + storage = bpf_sk_storage_get(&socket_storage_map, skops->sk, 0, + BPF_SK_STORAGE_GET_F_CREATE); + if (!storage) + return 1; + + switch (skops->op) { + case BPF_SOCK_OPS_ACTIVE_ESTABLISHED_CB: + case BPF_SOCK_OPS_PASSIVE_ESTABLISHED_CB: + bpf_sock_ops_cb_flags_set(skops, skops->bpf_sock_ops_cb_flags | + BPF_SOCK_OPS_PARSE_IPV6_HDR_CB_FLAG); + break; + case BPF_SOCK_OPS_PARSE_IPV6_HDR_CB: + return read_incoming_srh(skops, storage); + } + + return 0; +} From patchwork Tue Dec 7 22:56:35 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mathieu Jadin X-Patchwork-Id: 522384 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16AC0C433EF for ; Tue, 7 Dec 2021 22:58:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242402AbhLGXCP (ORCPT ); Tue, 7 Dec 2021 18:02:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54572 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229963AbhLGXCP (ORCPT ); Tue, 7 Dec 2021 18:02:15 -0500 Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F07A5C061574; Tue, 7 Dec 2021 14:58:43 -0800 (PST) Received: by mail-ed1-x533.google.com with SMTP id o20so1836009eds.10; Tue, 07 Dec 2021 14:58:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=c1VlJ5BaDFLU6GKPs+r88gkGEdFhDAcYdlu1RVMEMz8=; b=XI2ynPMjMM0f2U7399Q0vhv9PZ9TEyHlYRk8jY4vaJgx/+YF53Hw3q8exx7zqiWB1w WvcIMJRZ/QYdEspjx6mGb2t88nQHx51x3ZhagvuI6Ty/3nF2zEGYh77q88p3QPslfDof dTt74VriftHwuT4lX6iVMqsx8kl2YMlwDXCfIJXihcnUldVseMh4GtyaarVph2Fhm54I olB5LriIRourw7XnaM03X3MiHWGMo4mMg+rKpJXTkykKVLRuAbimH7YdIVrjn5rt2rYy QNdTZxHLRxdvfqdjXISFy2j/oBjU1PyI15gjagDO8nm99dteLQ5rgdveU0sIfOJXhYE7 /U7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=c1VlJ5BaDFLU6GKPs+r88gkGEdFhDAcYdlu1RVMEMz8=; b=ek6KSuaMjhN3QZJ8LjIYOieD6pY+GhucSd/0NAIgyl3eQX0yodoy4xVHNCN9/7mTGy Anqxh6nn/sSG6I80+g4rP3ybG2v8SEbWuASqbCQTLQVy802Kk+xgfBrlLvo6cE26djM3 QAbtFMWkZkFVIhM+9r9lZlRBjMxfXcFbQEc+PiMgYQKGMCiBMUKZs60OzfVDv6hrjrzj aNWpa3lDngfyUCuItyvTI2Y9i4N9Cy6Hh9ZBsxN1N6STc6OVzeCeuJgVjTe2KZkI69O6 O3m/yxQMJ+2n9n7A2mqDgjEdwpUBc8cVEINTqgt7IqZJZTUokeLV61E7wrVA0jx6wqdE kQsw== X-Gm-Message-State: AOAM533HfMG7ONZ6BDMOx6stZq8gSmyCTY5c7nxm6ohc7oux8hOjrbay RAk07R7zMdtGdY6LYkpP9IgSTb2+DC8c/Q== X-Google-Smtp-Source: ABdhPJzXGZrdiaJsNC6byKR2vVcBfh1OBOmO4o1bCVZA52ygD6Bf/61L5QRNcFao2phZKjrPpv1iVQ== X-Received: by 2002:a17:907:86a1:: with SMTP id qa33mr2939017ejc.142.1638917922514; Tue, 07 Dec 2021 14:58:42 -0800 (PST) Received: from localhost.localdomain ([2a02:a03f:c062:a800:5f01:482d:95e2:b968]) by smtp.gmail.com with ESMTPSA id q17sm763554edd.10.2021.12.07.14.58.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Dec 2021 14:58:42 -0800 (PST) From: Mathieu Jadin To: bpf@vger.kernel.org Cc: Mathieu Jadin , Song Liu , linux-kselftest@vger.kernel.org, Dave Marchevsky , Andrii Nakryiko , Shuah Khan , KP Singh , Yonghong Song , Martin KaFai Lau , John Fastabend , netdev@vger.kernel.org, Daniel Borkmann , Alexei Starovoitov Subject: [PATCH bpf-next v2 3/3] selftests/bpf: Improve test tcpbpf_user robustness Date: Tue, 7 Dec 2021 23:56:35 +0100 Message-Id: <20211207225635.113904-3-mathjadin@gmail.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211207225635.113904-1-mathjadin@gmail.com> References: <20211207225635.113904-1-mathjadin@gmail.com> MIME-Version: 1.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1638916174; l=2873; s=20211207; h=from:subject; bh=csM/GdsvGydicVSVF6qxAhH0+IFTIB78Rql0r4MDOVA=; b=oiqiDbULuFbeCim9q1j6+8fPagIfe5GRYXxiFVhg8d39aHWT/9EDXXrssTHkp6coxgxt7aXT+WeR 1uzIsw3/DzYlKuqaq2wavCoXoI8y+FoeXRjGlwOTIqng/af4+ALW X-Developer-Key: i=mathjadin@gmail.com; a=ed25519; pk=LX0wKHMKZralQziQacrPu4w5BceQsC7CocWV714TPRU= Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org Allow the test to support any number of supported callback flags. Provided that BPF_SOCK_OPS_ALL_CB_FLAGS is correctly updated when new flags are added, left shifting it always leads to a non existing flag. Signed-off-by: Mathieu Jadin --- tools/testing/selftests/bpf/prog_tests/tcpbpf_user.c | 4 +++- tools/testing/selftests/bpf/progs/test_tcpbpf_kern.c | 9 +++++++-- 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/tools/testing/selftests/bpf/prog_tests/tcpbpf_user.c b/tools/testing/selftests/bpf/prog_tests/tcpbpf_user.c index 87923d2865b7..56d007bf4011 100644 --- a/tools/testing/selftests/bpf/prog_tests/tcpbpf_user.c +++ b/tools/testing/selftests/bpf/prog_tests/tcpbpf_user.c @@ -12,6 +12,8 @@ static __u32 duration; static void verify_result(struct tcpbpf_globals *result) { + __u32 non_existing_flag = (BPF_SOCK_OPS_ALL_CB_FLAGS << 1) & + ~BPF_SOCK_OPS_ALL_CB_FLAGS; __u32 expected_events = ((1 << BPF_SOCK_OPS_TIMEOUT_INIT) | (1 << BPF_SOCK_OPS_RWND_INIT) | (1 << BPF_SOCK_OPS_TCP_CONNECT_CB) | @@ -30,7 +32,7 @@ static void verify_result(struct tcpbpf_globals *result) ASSERT_EQ(result->bytes_acked, 1002, "bytes_acked"); ASSERT_EQ(result->data_segs_in, 1, "data_segs_in"); ASSERT_EQ(result->data_segs_out, 1, "data_segs_out"); - ASSERT_EQ(result->bad_cb_test_rv, 0x80, "bad_cb_test_rv"); + ASSERT_EQ(result->bad_cb_test_rv, non_existing_flag, "bad_cb_test_rv"); ASSERT_EQ(result->good_cb_test_rv, 0, "good_cb_test_rv"); ASSERT_EQ(result->num_listen, 1, "num_listen"); diff --git a/tools/testing/selftests/bpf/progs/test_tcpbpf_kern.c b/tools/testing/selftests/bpf/progs/test_tcpbpf_kern.c index 3ded05280757..c37ba5940e3d 100644 --- a/tools/testing/selftests/bpf/progs/test_tcpbpf_kern.c +++ b/tools/testing/selftests/bpf/progs/test_tcpbpf_kern.c @@ -43,6 +43,8 @@ SEC("sockops") int bpf_testcb(struct bpf_sock_ops *skops) { char header[sizeof(struct ipv6hdr) + sizeof(struct tcphdr)]; + __u32 non_existing_flag = (BPF_SOCK_OPS_ALL_CB_FLAGS << 1) & + ~BPF_SOCK_OPS_ALL_CB_FLAGS; struct bpf_sock_ops *reuse = skops; struct tcphdr *thdr; int window_clamp = 9216; @@ -104,8 +106,11 @@ int bpf_testcb(struct bpf_sock_ops *skops) global.window_clamp_client = get_tp_window_clamp(skops); break; case BPF_SOCK_OPS_ACTIVE_ESTABLISHED_CB: - /* Test failure to set largest cb flag (assumes not defined) */ - global.bad_cb_test_rv = bpf_sock_ops_cb_flags_set(skops, 0x80); + /* Test failure to set largest cb flag + * (assumes that BPF_SOCK_OPS_ALL_CB_FLAGS masks all cb flags) + */ + global.bad_cb_test_rv = bpf_sock_ops_cb_flags_set(skops, + non_existing_flag); /* Set callback */ global.good_cb_test_rv = bpf_sock_ops_cb_flags_set(skops, BPF_SOCK_OPS_STATE_CB_FLAG);