From patchwork Mon Nov 12 18:18:07 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Garry X-Patchwork-Id: 150874 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp3455356ljp; Mon, 12 Nov 2018 10:16:44 -0800 (PST) X-Google-Smtp-Source: AJdET5ew9a8enp7RnrRW4T8+lS9Jmo6I6I+HmCX4dBGQJ1z0iPI9XaXgpfLzLnIR/TG7cr7tPV+B X-Received: by 2002:a62:1bd6:: with SMTP id b205-v6mr1872681pfb.178.1542046604653; Mon, 12 Nov 2018 10:16:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542046604; cv=none; d=google.com; s=arc-20160816; b=V5eCoXQ2Odw71LLd7CJ/1Y6U7xPBfAGZigSBjRzCbNa06A81nOvi2CBSJ7bvQ0/oYK V87yu32AVQKgOB4w0WrJLcvq3YPIqJutMEY+eM9RxQIUD6is+CI7uXJiInW3EfkUYNuC aAgY+2XYU+LUOTTkK/gzW/ayWS5FWjIssp5hvX3HlL2dqrsRHt1zCOO1a1MOBbuqvDtn tNjNhoPkun4+7GE38pzl5a0zeqkCiSYNfWqJSIdjCQGbuzdnk4v5rHNl28UmyNKy46NO fVH+6hYbvp1EsFfuZF0V0sVs8w+/ZyF7YziyhpuRsf5NWowSRzmZw2bMAroutBp7PVFk +T8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:subject:cc :to:from; bh=BHC49GOvxn8cx6iy2OlTHXmcM24QrZPftzglrDCc7IE=; b=ZBWam5ny3/7GrA6mkxSirMdY95FuLIlkxYiTvS8D5TyFxotWiU/UhOaUjhKG6YIG8P PnXJ1eVon30PG4XFueG08JAEyxvS+ZjMvmxwpM9yQRHKVTFZSqThSD00l41inTEARH61 dprDEJAwjuLOzAe/oWSnchtMS36rmzbfishYuE0a8lK/5+tbKxX1weYJl9HKJZvinsdc IEsqwzQNBY302deRYCE6L6khPWMYw61/8fYm1MxF3HfLfYYUPoAQbSwisoCi1l6fc50X zXVO/vohpOyz/UnO1yuurhf7nlaYmW6wfokBEueEz24V/4cYU17ImuJzd7JcJDKSDAd9 4cRw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-scsi-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a3-v6si16449307pgg.413.2018.11.12.10.16.44; Mon, 12 Nov 2018 10:16:44 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-scsi-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-scsi-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729133AbeKMELF (ORCPT + 1 other); Mon, 12 Nov 2018 23:11:05 -0500 Received: from szxga06-in.huawei.com ([45.249.212.32]:57517 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727247AbeKMELF (ORCPT ); Mon, 12 Nov 2018 23:11:05 -0500 Received: from DGGEMS412-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id E127A5E325BA1; Tue, 13 Nov 2018 02:16:39 +0800 (CST) Received: from localhost.localdomain (10.67.212.75) by DGGEMS412-HUB.china.huawei.com (10.3.19.212) with Microsoft SMTP Server id 14.3.408.0; Tue, 13 Nov 2018 02:16:31 +0800 From: John Garry To: , CC: , , , , John Garry Subject: [PATCH v2] scsi: libsas: Remove pcidev reference Date: Tue, 13 Nov 2018 02:18:07 +0800 Message-ID: <1542046687-221037-1-git-send-email-john.garry@huawei.com> X-Mailer: git-send-email 2.8.1 MIME-Version: 1.0 X-Originating-IP: [10.67.212.75] X-CFilter-Loop: Reflected Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Not all host drivers are PCI drivers - like hisi_sas, which supports a platform driver - so remove reference to "pcidev". In addition, we change the printk() call to pr_warn() which is an appropriate level for this message. Signed-off-by: John Garry --- Change in v1->v2: - change to pr_warn() -- 1.9.1 diff --git a/drivers/scsi/libsas/sas_discover.c b/drivers/scsi/libsas/sas_discover.c index 6b12c67..dd27e9f 100644 --- a/drivers/scsi/libsas/sas_discover.c +++ b/drivers/scsi/libsas/sas_discover.c @@ -186,10 +186,10 @@ int sas_notify_lldd_dev_found(struct domain_device *dev) res = i->dft->lldd_dev_found(dev); if (res) { - printk("sas: driver on pcidev %s cannot handle " - "device %llx, error:%d\n", - dev_name(sas_ha->dev), - SAS_ADDR(dev->sas_addr), res); + pr_warn("sas: driver on host %s cannot handle " + "device %llx, error:%d\n", + dev_name(sas_ha->dev), + SAS_ADDR(dev->sas_addr), res); } set_bit(SAS_DEV_FOUND, &dev->state); kref_get(&dev->kref);