From patchwork Fri Nov 16 10:04:24 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 151314 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp228490ljp; Fri, 16 Nov 2018 02:04:53 -0800 (PST) X-Google-Smtp-Source: AJdET5eKRJMZ2U5gdZJ95EzT85hII2Op8JTPBeg1DdlSjg2OtzyFtthG6uC86PX4kr3Mv4xqsQIu X-Received: by 2002:a63:78cd:: with SMTP id t196mr9352213pgc.62.1542362693809; Fri, 16 Nov 2018 02:04:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542362693; cv=none; d=google.com; s=arc-20160816; b=eQCN5m/eY7i1P6O5ZX5UKmxileP5k5piP9bcW8FQU46haOv9M06tOFHsLnjHU+WQk6 AHAxZwARC+awLbhbBHPAMSFAy76Xfox8CGLusJWxowm+Oj5F9s6FmESMDjHFEzFUyxp3 vmu6EN/KE1VgO9eIpLdKF/dDEHjS4JtT29CO9+K4oEEa8Lu7lTulKLp4dxlacbxWndfM uAEzxsagQj6pvgEEOD+jp3j/C/qbRUwkv0sunv/MDcHsdwS/Epal+QZC4qTIb+kmPs2x obMjxCRH6cSagJeSW7MCg8qyPzlwvn1PH9uingv0Hx9wjD/BzENyJ154HMsUeqdNvaoK 8K0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=6jGnK7p9DNH1VSecCKTpjJESfpN6DrO/lgZIFx1WzcQ=; b=pgrZGinq+nWM9KPnt25XpiYkmnXFJeKuZgr+Qu509NQr2BrO4/8AmLnsS7s8nOkkt8 0SJHnWG5KILrzel6ZVEIuMB4YCkr5olX+s8kTaCe5670XLeFR6HBZgHI51rni8KHld6L aNp7/JwtyCkT6Q7mAI2bXBUmajl6VF+05bPObgZchd+wLvYfj0mRoWold38C/Kigwe5u IEbfo3RHqTULVJqvtsoMBZDWpRhza7CmKyJ99Do48Mtm6FFfTM8CkltCBaG+Sgy3ukYD 46F9eVbxcqd6JOjoYOnKgc2rFOosl9nHlEvO+jBJW6Rt40LhVEVIc/X2rrfBP7/gINIx iJiA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=b1U75Cq6; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j7-v6si30847191plk.51.2018.11.16.02.04.53; Fri, 16 Nov 2018 02:04:53 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=b1U75Cq6; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389500AbeKPUQ3 (ORCPT + 32 others); Fri, 16 Nov 2018 15:16:29 -0500 Received: from mail-pg1-f194.google.com ([209.85.215.194]:36682 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727543AbeKPUQ3 (ORCPT ); Fri, 16 Nov 2018 15:16:29 -0500 Received: by mail-pg1-f194.google.com with SMTP id n2so3226632pgm.3 for ; Fri, 16 Nov 2018 02:04:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=6jGnK7p9DNH1VSecCKTpjJESfpN6DrO/lgZIFx1WzcQ=; b=b1U75Cq6PiWwsh0z0qHVgT8KLwnvoLvx19itx4tR0J7yUo4r7wTyFJrjq1gAnh3+a/ DflgwvN3jgsXHSjLZDgoryYD+QBV8BMllSbKnzhPJK5kO2SY3Qta71boyGvWMduiBi+S W0xdwbuvTG67CAHgbzPvoKWe3XXQUnYY4xs8U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=6jGnK7p9DNH1VSecCKTpjJESfpN6DrO/lgZIFx1WzcQ=; b=VLmwVZjQVJJiLeyX7gp3csT0JlLFdbQzQ0J21fCP8YZCuFuuyBRWm1VcVrHm4oKoQG z2wg+qUlSLg6DHN+r8G9Qg3w8UVEk4yKrTl3aKZ5HdLSqWiKbEPOaR8zSNw5lJlRSb2L Hmjd059dhMG2BHhjQnBmffc75olD9wQgVHUHliiT1oKkCifeohSsDSmgeJ9OnQ7cT2r3 q9+xoXuOoA1JqiD6SA4qBbTlHBhTUWFLmtDAOzGmFJex2mBGEnJC5eWf5H0pOK8a9sag UnFYRcs5QWmOhVIym4bnDQNAX/IagHtNOGkl/H0r0JFUpl0tvFfWhG+FYcznwc8DQk8S t9IA== X-Gm-Message-State: AGRZ1gLGCnW9mLOM8NlnXgDSr3/MLOg75RWsMR2+T5NI5Aq30q9wwtXC TSQduk5LvBaUAvMG8GYgSgK2zQ== X-Received: by 2002:a62:c501:: with SMTP id j1-v6mr5208284pfg.205.1542362691168; Fri, 16 Nov 2018 02:04:51 -0800 (PST) Received: from localhost ([122.172.88.116]) by smtp.gmail.com with ESMTPSA id h7-v6sm51224721pfd.35.2018.11.16.02.04.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 16 Nov 2018 02:04:50 -0800 (PST) From: Viresh Kumar To: Mark Rutland , Rob Herring , arm@kernel.org, Carlo Caione , Kevin Hilman Cc: Viresh Kumar , devicetree@vger.kernel.org, Vincent Guittot , Daniel Lezcano , linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 01/10] ARM64: dts: amlogic: Add all CPUs in cooling maps Date: Fri, 16 Nov 2018 15:34:24 +0530 Message-Id: <2778d0d4813cc56be851719846afecbab5f2e657.1542362530.git.viresh.kumar@linaro.org> X-Mailer: git-send-email 2.19.1.568.g152ad8e3369a In-Reply-To: References: MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Each CPU can (and does) participate in cooling down the system but the DT only captures a handful of them, normally CPU0, in the cooling maps. Things work by chance currently as under normal circumstances its the first CPU of each cluster which is used by the operating systems to probe the cooling devices. But as soon as this CPU ordering changes and any other CPU is used to bring up the cooling device, we will start seeing failures. Also the DT is rather incomplete when we list only one CPU in the cooling maps, as the hardware doesn't have any such limitations. Update cooling maps to include all devices affected by individual trip points. Signed-off-by: Viresh Kumar --- .../dts/amlogic/meson-gxm-khadas-vim2.dts | 22 ++++++++----------- 1 file changed, 9 insertions(+), 13 deletions(-) -- 2.19.1.568.g152ad8e3369a diff --git a/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts b/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts index 313f88f8759e..cfc92d06a28f 100644 --- a/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts +++ b/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts @@ -132,19 +132,15 @@ map1 { trip = <&cpu_alert1>; - cooling-device = <&gpio_fan 2 THERMAL_NO_LIMIT>; - }; - - map2 { - trip = <&cpu_alert1>; - cooling-device = - <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; - }; - - map3 { - trip = <&cpu_alert1>; - cooling-device = - <&cpu4 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; + cooling-device = <&gpio_fan 2 THERMAL_NO_LIMIT>, + <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu2 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu4 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu5 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu6 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu7 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; }; }; }; From patchwork Fri Nov 16 10:04:26 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 151316 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp228662ljp; Fri, 16 Nov 2018 02:05:03 -0800 (PST) X-Google-Smtp-Source: AJdET5cSmXF4x5HXaGTiDfycINQ2/dI/zDqxtai/XQrhXSgt2JHZFCP5Kv0tpNMTNcONmsLG218g X-Received: by 2002:a63:ea4f:: with SMTP id l15mr9146272pgk.102.1542362702968; Fri, 16 Nov 2018 02:05:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542362702; cv=none; d=google.com; s=arc-20160816; b=KJTuqauE8TisZM8WJgTGzV6hkZPecogUQdAeB0AyA3X1aQKwEigiSS+4fFGoRoodvY AX2zfmMpVvBp0LqdFjT4vNcLXJjhIz9/oo3DGYSRT8Gv+lubJXc5e3VYCK0grRaDuQVH p4ovEGS/8B7++TSrw7rAiDD3Nw3UoSwOcV+UiyRf9B7zTtb+GlUO206J1vyVVPvldW6G WNOCqoOqhiivZFj+X01NJOl/RnRj0bALNjh+jC+6PuSlmyp0BbodvMvC1VlUWCt4Dh6w YLq4ZrIWfvepqC2NrhgAhV0CI1bnwYjuH01/yLfK04ObDsae3hqVBBOMyIS8fNdfKmlf r/7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=oskLWY4mMeTJJ9TYoYBq3J1qg+P8pf5LnWRqIcwKGK8=; b=RTkIP7aW8IlwTuMwp5tvhMBfuA93hazL1vVYEnmH1HwgZdVRfBntdxdJAQZsQEsKKs bSyQEnMS8n/BKQL7/3tnnxeYq/XAKwDfGitR+xReAcmX/UhAvJICjZztuZX5df/8KPwA eDGWhhjrEQdR+f0ay+cOl/nw0mt/cDnbKnQr8ydNzeyhy4OwDsNKzkDbit6MWZBmGzMY KV8cQ5BNKn2bzYnvZYpQ4WsCIFg7dyPNkKb7DhzjRpiL9/T2d/yQ0tJRKOpJR2v06mlN AVTZQWsN5EudZgOVeGoQ1QA+Kk0MVe3OKyCsIEvflGPLAJKva+ffU/SIb7EjeqnJSj9v tuEg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ATnBdGjg; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 12-v6si21132818plb.324.2018.11.16.02.05.02; Fri, 16 Nov 2018 02:05:02 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ATnBdGjg; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389545AbeKPUQi (ORCPT + 32 others); Fri, 16 Nov 2018 15:16:38 -0500 Received: from mail-pf1-f193.google.com ([209.85.210.193]:40334 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727543AbeKPUQh (ORCPT ); Fri, 16 Nov 2018 15:16:37 -0500 Received: by mail-pf1-f193.google.com with SMTP id x2-v6so11173015pfm.7 for ; Fri, 16 Nov 2018 02:05:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=oskLWY4mMeTJJ9TYoYBq3J1qg+P8pf5LnWRqIcwKGK8=; b=ATnBdGjgO7zh0Orx+cQY5HgoRJ4l9UbThujztH+bBaMJGHsFpCw1g+uMRsgziODVZb rbecT9tokiUQH9Sxkd6bI6PKhqIioXGKtsSJ80pXMCVb7cLjyKGLCWsapQGglk8SjHYz 3j+FQd43roFL2giLKateOQSrXnm4Je8L7ScME= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=oskLWY4mMeTJJ9TYoYBq3J1qg+P8pf5LnWRqIcwKGK8=; b=P7i5oihBJqiMvZwzlWpRJGMYKPocnFB8cg88Fqks9Qxw2jGTh6eZ7x5HB9YUEhTrw5 tSqL2jwyS05O2asc3RRTDjbmTLZe8/N1flqTmbdL813M+1zfbVUaY9fyjhh+7y8CxGKb SCRVFtICd18cjR++Wfs2F7CzEpRJ03kQ7codCrLcYAG6Y3ZrwRZ5Hq9GJo3EtC7KfWBk yio8UoOU1EwYapCzP7JEuIN3AfTxo6VGSUC7YEvm+QAtyHHl7+e8khpacmM4iOM/2DhM w8J8+EiUXndE3Y/KC0BipvvLAPgjN75zfjM4+a2S9sbGlsiRfOD9a3m/GwtP9XYosKL1 RR9Q== X-Gm-Message-State: AGRZ1gIU5J1ShnCV9t+Q1x2eP/xFu0s62WBRn+p+ZxGBUN4OBjy2TLBp +QjRpNBjuAfoKgVHYp8jx+nff+ggD3U= X-Received: by 2002:a63:7a5b:: with SMTP id j27mr9396597pgn.112.1542362699588; Fri, 16 Nov 2018 02:04:59 -0800 (PST) Received: from localhost ([122.172.88.116]) by smtp.gmail.com with ESMTPSA id r2sm10042207pfh.57.2018.11.16.02.04.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 16 Nov 2018 02:04:59 -0800 (PST) From: Viresh Kumar To: Mark Rutland , Rob Herring , arm@kernel.org, Shawn Guo , Li Yang Cc: Viresh Kumar , devicetree@vger.kernel.org, Vincent Guittot , Daniel Lezcano , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 03/10] ARM64: dts: fsl: Add all CPUs in cooling maps Date: Fri, 16 Nov 2018 15:34:26 +0530 Message-Id: X-Mailer: git-send-email 2.19.1.568.g152ad8e3369a In-Reply-To: References: MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Each CPU can (and does) participate in cooling down the system but the DT only captures a handful of them, normally CPU0, in the cooling maps. Things work by chance currently as under normal circumstances its the first CPU of each cluster which is used by the operating systems to probe the cooling devices. But as soon as this CPU ordering changes and any other CPU is used to bring up the cooling device, we will start seeing failures. Also the DT is rather incomplete when we list only one CPU in the cooling maps, as the hardware doesn't have any such limitations. Update cooling maps to include all devices affected by individual trip points. Signed-off-by: Viresh Kumar --- .../arm64/boot/dts/freescale/fsl-ls1043a.dtsi | 6 ++-- .../arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 6 ++-- .../arm64/boot/dts/freescale/fsl-ls1088a.dtsi | 17 ++++++----- .../arm64/boot/dts/freescale/fsl-ls208xa.dtsi | 28 ++++++------------- 4 files changed, 24 insertions(+), 33 deletions(-) -- 2.19.1.568.g152ad8e3369a diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi index 3fed504b5381..c7224c5bb6cc 100644 --- a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi +++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi @@ -171,8 +171,10 @@ map0 { trip = <&cpu_alert>; cooling-device = - <&cpu0 THERMAL_NO_LIMIT - THERMAL_NO_LIMIT>; + <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu2 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; }; }; }; diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi index 51cbd50012d6..8c94d8279b5e 100644 --- a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi +++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi @@ -140,8 +140,10 @@ map0 { trip = <&cpu_alert>; cooling-device = - <&cpu0 THERMAL_NO_LIMIT - THERMAL_NO_LIMIT>; + <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu2 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; }; }; }; diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi index a07f612ab56b..7faee0d270d2 100644 --- a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi +++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi @@ -152,15 +152,14 @@ map0 { trip = <&cpu_alert>; cooling-device = - <&cpu0 THERMAL_NO_LIMIT - THERMAL_NO_LIMIT>; - }; - - map1 { - trip = <&cpu_alert>; - cooling-device = - <&cpu4 THERMAL_NO_LIMIT - THERMAL_NO_LIMIT>; + <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu2 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu4 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu5 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu6 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu7 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; }; }; }; diff --git a/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi index d188774a36e8..f11187f7465c 100644 --- a/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi +++ b/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi @@ -101,26 +101,14 @@ map0 { trip = <&cpu_alert>; cooling-device = - <&cpu0 THERMAL_NO_LIMIT - THERMAL_NO_LIMIT>; - }; - map1 { - trip = <&cpu_alert>; - cooling-device = - <&cpu2 THERMAL_NO_LIMIT - THERMAL_NO_LIMIT>; - }; - map2 { - trip = <&cpu_alert>; - cooling-device = - <&cpu4 THERMAL_NO_LIMIT - THERMAL_NO_LIMIT>; - }; - map3 { - trip = <&cpu_alert>; - cooling-device = - <&cpu6 THERMAL_NO_LIMIT - THERMAL_NO_LIMIT>; + <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu2 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu4 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu5 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu6 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu7 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; }; }; }; From patchwork Fri Nov 16 10:04:27 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 151317 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp228766ljp; Fri, 16 Nov 2018 02:05:09 -0800 (PST) X-Google-Smtp-Source: AJdET5eLQtNlpvv/a2pAwrHOL7Xf0OHwb4hngxcVYs/127ClI0vTeoi2qET+U1f/UF4b4rZ6OrPt X-Received: by 2002:a63:460a:: with SMTP id t10-v6mr9440691pga.197.1542362709006; Fri, 16 Nov 2018 02:05:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542362709; cv=none; d=google.com; s=arc-20160816; b=kjHZkWK+JcF7wOZYGLa1qbP2YXnvbhUUB3iL3pAmC3a4CtEZdhySNbr21X0jdT/mHN K4g8SJXHlaUf134aksQ8tRqnHGzdShpCtL2OcrjmfuWkmTjxx3ndTnIqmXGQlvwQ6Y7K AQnzUbso3wW98c/0iPaQxmABwWU7UHvolcQA66vhgM+r6+XXZY+CkW9EFpngM+uMhBvf Bemwcj0WudLoGMfzeFQrLHuHKzNhKy5aYiDKxjwFJtGfq+TkoyUjom0uUTbj7h1/IJlh WqNKlN0vSK90+IG9nLgoE84FFkkWVhUVQ1fr+0W8yPs5tqJc2VTFVnhsUZmrSALhpXwo SpsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=HClVvGiwOuWgQ6TjJ14HNKIrS62CNCv2+c1OlYODQLQ=; b=yiCqXrLYdFP2UnE68xqxoBw94r+2tLxMOv4jlRtfmq7il48RtNOpc0XCvVzYsfJuJj D4ziP3/6UCwsh5/PPjpCRcqlmpkV1QX1X8I6EBdR8IVABGYrRKFJdiktdiH8EoP+410/ zySZ0beXFd3SUhq8tmmoe2MQD/+szxHcoZtpyp8aHAxs4xlidCEiDCID1qvG2ApSX0I7 ZBendc6vyZEy/brtIPm+BGES7t8PCgZc0sZlNFN55TpzXwo3+BqjbBRmFNWlZi8wZRUI gk0/VEXlriMeUKVwqxAcShmuDA1RSJtp3KDIQjqBC4UECJj/pjkVsnmxjCB9Tl14X2Es TF8Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="EYgZ6R/G"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h3si30324744pgi.391.2018.11.16.02.05.08; Fri, 16 Nov 2018 02:05:08 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="EYgZ6R/G"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389569AbeKPUQo (ORCPT + 32 others); Fri, 16 Nov 2018 15:16:44 -0500 Received: from mail-pg1-f193.google.com ([209.85.215.193]:46473 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389547AbeKPUQn (ORCPT ); Fri, 16 Nov 2018 15:16:43 -0500 Received: by mail-pg1-f193.google.com with SMTP id w7so10386910pgp.13 for ; Fri, 16 Nov 2018 02:05:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=HClVvGiwOuWgQ6TjJ14HNKIrS62CNCv2+c1OlYODQLQ=; b=EYgZ6R/GukaNgdoqsL+uxEcbK4u50GApx9Jrvrdq5PtjcvbOzdKihSLY8qHyk4JUah JmTUeiVCXXf0NaYEjIQgSxfEqzMrhj2guSYLHqQs7ijcz+wlMZZbhmO5xNnUky32xYNo fr7LO3IgRE/Gm4kOImnuv0ghPrZqulGfKR3WI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=HClVvGiwOuWgQ6TjJ14HNKIrS62CNCv2+c1OlYODQLQ=; b=X/9JP9Q6PdzILX9P/uOIZBqkL+aq9nfZfzBrWcqQHOwqZMW4gd4CA2smbIv2gM/UY5 3WHtYTFTMuxUfECy3lD1ZagW45govbl0cqLJEJX+8vFGtDmrPWdRFqIxx+bW9AjYxSIv HVSe4a7i342gP4FEl52i8Ixa7Aap5RX8TgVpvkXNm/RzwNhURe5rtIrfphB9w9mKUOBA w9maKwJiSRXKiKgNB2ZIyj5rI+oFHHBxrkf2+AQAqAN0+wW9ZP7keCac148+J3cxU7M3 mWeb3+bUCcInR8jvJjxTfTxk/tzSjp36Ubuz8b4HVbDDsIfly40+reWzI6PsVKw3mL1o ZrvA== X-Gm-Message-State: AGRZ1gK2pEPpgRFSodPk6BPFCVRR/Gu0+OH38YoyXzJCbuJqhnhv1jI+ qghvd5fLGttATFrZykpmhtaU9A== X-Received: by 2002:a63:9a52:: with SMTP id e18mr9300065pgo.14.1542362705320; Fri, 16 Nov 2018 02:05:05 -0800 (PST) Received: from localhost ([122.172.88.116]) by smtp.gmail.com with ESMTPSA id y9-v6sm32421519pfe.152.2018.11.16.02.05.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 16 Nov 2018 02:05:04 -0800 (PST) From: Viresh Kumar To: Mark Rutland , Rob Herring , arm@kernel.org, Wei Xu Cc: Viresh Kumar , devicetree@vger.kernel.org, Vincent Guittot , Daniel Lezcano , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 04/10] arm64: dts: hi3660: Add missing cooling device properties for CPUs Date: Fri, 16 Nov 2018 15:34:27 +0530 Message-Id: <042e5e647a7b54f4322024f1b3e286b6b6d69175.1542362530.git.viresh.kumar@linaro.org> X-Mailer: git-send-email 2.19.1.568.g152ad8e3369a In-Reply-To: References: MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The cooling device properties, like "#cooling-cells" and "dynamic-power-coefficient", should either be present for all the CPUs of a cluster or none. If these are present only for a subset of CPUs of a cluster then things will start falling apart as soon as the CPUs are brought online in a different order. For example, this will happen because the operating system looks for such properties in the CPU node it is trying to bring up, so that it can register a cooling device. Add such missing properties. Signed-off-by: Viresh Kumar --- arch/arm64/boot/dts/hisilicon/hi3660.dtsi | 6 ++++++ 1 file changed, 6 insertions(+) -- 2.19.1.568.g152ad8e3369a diff --git a/arch/arm64/boot/dts/hisilicon/hi3660.dtsi b/arch/arm64/boot/dts/hisilicon/hi3660.dtsi index f432b0a88c65..d943a96eedee 100644 --- a/arch/arm64/boot/dts/hisilicon/hi3660.dtsi +++ b/arch/arm64/boot/dts/hisilicon/hi3660.dtsi @@ -79,6 +79,7 @@ capacity-dmips-mhz = <592>; clocks = <&stub_clock HI3660_CLK_STUB_CLUSTER0>; operating-points-v2 = <&cluster0_opp>; + #cooling-cells = <2>; }; cpu2: cpu@2 { @@ -91,6 +92,7 @@ capacity-dmips-mhz = <592>; clocks = <&stub_clock HI3660_CLK_STUB_CLUSTER0>; operating-points-v2 = <&cluster0_opp>; + #cooling-cells = <2>; }; cpu3: cpu@3 { @@ -103,6 +105,7 @@ capacity-dmips-mhz = <592>; clocks = <&stub_clock HI3660_CLK_STUB_CLUSTER0>; operating-points-v2 = <&cluster0_opp>; + #cooling-cells = <2>; }; cpu4: cpu@100 { @@ -129,6 +132,7 @@ capacity-dmips-mhz = <1024>; clocks = <&stub_clock HI3660_CLK_STUB_CLUSTER1>; operating-points-v2 = <&cluster1_opp>; + #cooling-cells = <2>; }; cpu6: cpu@102 { @@ -141,6 +145,7 @@ capacity-dmips-mhz = <1024>; clocks = <&stub_clock HI3660_CLK_STUB_CLUSTER1>; operating-points-v2 = <&cluster1_opp>; + #cooling-cells = <2>; }; cpu7: cpu@103 { @@ -153,6 +158,7 @@ capacity-dmips-mhz = <1024>; clocks = <&stub_clock HI3660_CLK_STUB_CLUSTER1>; operating-points-v2 = <&cluster1_opp>; + #cooling-cells = <2>; }; idle-states { From patchwork Fri Nov 16 10:04:28 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 151318 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp228823ljp; Fri, 16 Nov 2018 02:05:12 -0800 (PST) X-Google-Smtp-Source: AJdET5cawOJ25u5hxH8FBgge8+oJfaLw8To+FZ3jnj3+CZQPH5Wsrcosf1iiYsHDLfPgZjD6kIj7 X-Received: by 2002:a17:902:6b0c:: with SMTP id o12mr10283682plk.291.1542362712513; Fri, 16 Nov 2018 02:05:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542362712; cv=none; d=google.com; s=arc-20160816; b=tjA2/haLX6mrqOIf2pRfEIfLnPEF+0vtGBYjYQzoChW163lRn3iExvqU3gv1qBq32s hdad7oz09prYzG1lBEPThlq7T2Z3NPoBXiz9b1tzLczwnPYCXarSQSBbghbwCFb/IiAG +7y5w8vLl6SLQCR5X887/uTtbVkdg/El3hoOODPkSDDTjnVnJeeVvCs2E4p2mxWJyKqk BQWs8g08twdj1R9AZczyRpHhYE5SZMq7n11HgNmbh/BNzHqOnLYG+EUme4si2IuJmieI B2NGJRhQGVRBK8EjTAX62ySiJbgciCMw1Pg+dsRJYTElvTqxhZ5ybV73Uv/vXEFkI7FT ivaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=QmjHQrzH3LPsysyMlkzh+Qm9rUsTXjJj/VyKPq1LnW8=; b=0cXlL7IRdpTFHZMIwR6Ap9zNJdZF/HMo9RMWFZLEMRwT+Gr43gnUtL6iM7bxPDIsSD P/yUGDxlJp0L6m9RC1nyuWH91LVOpqy6a/U3nyiZ82vowSHEdNQvq0oP6fdg0etJ902B INCMaspbnAa8pngNQ7JrvTQnyueCuw04rOKEfv+rO18ghEyEthj4EX2ro8sOVTLCzGXg AjVKLMtXv+jU9ofiPmoLm2jXdDyG+ONGygSkZcwXwa7Rrvr0iYl5L9ncX0pOMfdUJvAb gpY7D4E5UqThLpYdQuz+btsaogZxTVhdCs2v765PCW9LvlThd472yd9skwyAt+z3ppxp FtzQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=El0fMUQ3; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h3si30324744pgi.391.2018.11.16.02.05.12; Fri, 16 Nov 2018 02:05:12 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=El0fMUQ3; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389583AbeKPUQs (ORCPT + 32 others); Fri, 16 Nov 2018 15:16:48 -0500 Received: from mail-pl1-f195.google.com ([209.85.214.195]:38848 "EHLO mail-pl1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389547AbeKPUQr (ORCPT ); Fri, 16 Nov 2018 15:16:47 -0500 Received: by mail-pl1-f195.google.com with SMTP id e5so916151plb.5 for ; Fri, 16 Nov 2018 02:05:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=QmjHQrzH3LPsysyMlkzh+Qm9rUsTXjJj/VyKPq1LnW8=; b=El0fMUQ3VTzNvHQ+No7yCC641xxRow2h2idrjFaDry9uLyyOekkFxoZPs17XGeLHtg Qr+tx6cU+FPu4OeX1wU737un2FszbXEtLjxKgMbXBLq1kjDeLP+HFFlya1yVbtwXrrXw sExaUXVj7dZcDR6VJ5rZgPdZZ9aqwTbf4gfwM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=QmjHQrzH3LPsysyMlkzh+Qm9rUsTXjJj/VyKPq1LnW8=; b=NVJDriXZpY0j23v2E5NVDyVwDoNBFQV2sSNRD9gJWVZYBMnUQ/MsYJbk5xrl4K6kD8 n06SHMaoKwEqrBDI0EINnyYKAiEPXkQ9pCYq+1HBflr1wrC2+IMt5maTLdnMGumPZHOF 3pfM/0Dh/hbhd/TMteCTjYi/bMHD3LdAVdyCUsm6eky7dsVaxl73Zype/P3Bq6yZOIvu DajaRORkUE6Gv/xv69nfcpfpyBMTVL85Efn0iFQ8JqMhrbrSMyD6IEehF2Ps5v1VbB+u kfHwen9t9nAQKShWAdwI+H63aaIfvEQk2qdTkZt12t2Q/Hm6HEIT4CL4x1RMHqPRCM06 3iRw== X-Gm-Message-State: AGRZ1gLxJ06iPzaNopYTalmLlxS4DlY10EksqpZV3onAR4TYJ9pwuHJl tfo47fNzLWp4KOUlMGyttMQxbh7MsKM= X-Received: by 2002:a17:902:a70b:: with SMTP id w11mr6181411plq.84.1542362709696; Fri, 16 Nov 2018 02:05:09 -0800 (PST) Received: from localhost ([122.172.88.116]) by smtp.gmail.com with ESMTPSA id s22-v6sm56173002pfi.15.2018.11.16.02.05.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 16 Nov 2018 02:05:09 -0800 (PST) From: Viresh Kumar To: Mark Rutland , Rob Herring , arm@kernel.org, Wei Xu Cc: Viresh Kumar , devicetree@vger.kernel.org, Vincent Guittot , Daniel Lezcano , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 05/10] ARM64: dts: hisilicon: Add all CPUs in cooling maps Date: Fri, 16 Nov 2018 15:34:28 +0530 Message-Id: <89bb8c62404aa875d597da89c18852ce81fb9f26.1542362530.git.viresh.kumar@linaro.org> X-Mailer: git-send-email 2.19.1.568.g152ad8e3369a In-Reply-To: References: MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Each CPU can (and does) participate in cooling down the system but the DT only captures a handful of them, normally CPU0, in the cooling maps. Things work by chance currently as under normal circumstances its the first CPU of each cluster which is used by the operating systems to probe the cooling devices. But as soon as this CPU ordering changes and any other CPU is used to bring up the cooling device, we will start seeing failures. Also the DT is rather incomplete when we list only one CPU in the cooling maps, as the hardware doesn't have any such limitations. Update cooling maps to include all devices affected by individual trip points. Signed-off-by: Viresh Kumar --- arch/arm64/boot/dts/hisilicon/hi3660.dtsi | 10 ++++++++-- arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 9 ++++++++- 2 files changed, 16 insertions(+), 3 deletions(-) -- 2.19.1.568.g152ad8e3369a diff --git a/arch/arm64/boot/dts/hisilicon/hi3660.dtsi b/arch/arm64/boot/dts/hisilicon/hi3660.dtsi index d943a96eedee..20ae40df61d5 100644 --- a/arch/arm64/boot/dts/hisilicon/hi3660.dtsi +++ b/arch/arm64/boot/dts/hisilicon/hi3660.dtsi @@ -1118,12 +1118,18 @@ map0 { trip = <&target>; contribution = <1024>; - cooling-device = <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; + cooling-device = <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu2 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; }; map1 { trip = <&target>; contribution = <512>; - cooling-device = <&cpu4 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; + cooling-device = <&cpu4 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu5 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu6 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu7 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; }; }; }; diff --git a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi index 97d5bf2c6ec5..aec9e371c2a7 100644 --- a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi +++ b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi @@ -893,7 +893,14 @@ cooling-maps { map0 { trip = <&target>; - cooling-device = <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; + cooling-device = <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu2 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu4 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu5 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu6 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu7 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; }; }; }; From patchwork Fri Nov 16 10:04:29 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 151319 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp228916ljp; Fri, 16 Nov 2018 02:05:17 -0800 (PST) X-Google-Smtp-Source: AJdET5dzYFRracw309PVPf90s8ZkkC2I1MuJpGArP14y3TRY8luNrUZP7MVwyXp0PjEEVLNYr/nI X-Received: by 2002:a17:902:e08d:: with SMTP id cb13-v6mr6631082plb.196.1542362717359; Fri, 16 Nov 2018 02:05:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542362717; cv=none; d=google.com; s=arc-20160816; b=rrtuF0LfezBC5Yic9s3Kztso0A3zPyk4g770LGLU26vv5rNfQg8rLE4TpjOTTGwT81 oVJ7driSid1iBKOBV6PS8FIC4+EEIM3SRXLcBHqPp8DTwnSs/8bsHKf5vq+ScQfxZATd ZBfiZtKWoON16HlI2DuBUjKvqWR7BgFbMsAOsaI3j3WYkLB2jmFvT1YaMJ3qlOvRNhXm swOixV4ks7AqzZ3Quqt/3njX5TcsT9SpOrGLCwgbzgJyPqb0JR1JioM+KnknRlP1352x jbmvRAuwLSAdRbtzmI5VKsLn1myd8aHq0KA80+A6FVYnvnXXYNFb8Y4J/nirCsQlu+ko 5D9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=RnCIsEGq5MZTTZCkNy8l3CMIA4bwOFY/LPw8vXjcyjo=; b=Ot6f8HXqmKGkQOEh5WyIDhXKw40dce0j5SDRMmmCyG2isOYNOMnVeCRkQylw/3Hl0w c42H2rkfMwrjN9+n/cUjlvAlCW1Icsytt6DqJIE2GSopa68lTCtuPLqwicVParwVh23t Os106tUVt1vN6WsHUnMSofdsz1WNTOV6FW4Xwq0metY5//2vFnroEvE3Imib7mjCdN0F Vvc8EEGHCx4l1gYl4ABIWNM7SzpFnTSNdwqOhFCcNOk9io2usKDImcN6ZurHQoZlAaKR udcUY2mCUxvAm8PZXt1WmOLoSjlIp4j6f5rCU1V89BmudKfytgR4l61oLWJytRIPTPY3 DHqg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=T+iqTvBv; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n7-v6si30266122plp.43.2018.11.16.02.05.16; Fri, 16 Nov 2018 02:05:17 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=T+iqTvBv; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389594AbeKPUQw (ORCPT + 32 others); Fri, 16 Nov 2018 15:16:52 -0500 Received: from mail-pf1-f195.google.com ([209.85.210.195]:46752 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389436AbeKPUQw (ORCPT ); Fri, 16 Nov 2018 15:16:52 -0500 Received: by mail-pf1-f195.google.com with SMTP id s9-v6so11160665pfm.13 for ; Fri, 16 Nov 2018 02:05:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=RnCIsEGq5MZTTZCkNy8l3CMIA4bwOFY/LPw8vXjcyjo=; b=T+iqTvBvTwFjGud//iZpTeH9leHdAkXHiolZPRv3m8YPKwjf2NcPiFwBMBs7pPsl7i R5glNd1K+psMyhUEK1DQEqo7NLCNyyuPWywmWuqlnBOqjjuysRuc+lDVK/lwYT+9t6dK KFeF0TCLS7C54iI2qZj7AIdlKNDijQ52Ooaf8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=RnCIsEGq5MZTTZCkNy8l3CMIA4bwOFY/LPw8vXjcyjo=; b=pAErhGJzE7hLSqFo4SFhcwyJt6vhIEmaxorgmSXmiEXDC53m/PsVS0uTbXkym6lI5K PRONPkCPWZ1J/yaG8WdrjyLTtlj2LJnQLnFOjLyPw5ViIO/xlYij32YrcgtC7mdANeiG rTlY6Y8ooH6GHWKFHuZNHv0I2Belpky1o2ykRMZCfBllbG+hXkP7yyu4BK3CDzjzm33V WQZvJRindDi4JE+mf46cdmsg1RWsob727lBkenXZLKLsoHlrPHUQgVpbMBWC1E/34FHt GXqFxx2lN/K3SGiBwoLx/OMpTO79MwOdAPhtRfoz/xSHIMpqEIlTxJrMml3vph/e4igF ZJtg== X-Gm-Message-State: AGRZ1gIQ6qwqHFHvFkvPqG/5IZxDq95Rxpy7K9atPRXBuNqMrjv/2MXV yxmoJVB6gKSLFEoKt4vW2RBkUQ== X-Received: by 2002:a63:314c:: with SMTP id x73mr9435566pgx.323.1542362714354; Fri, 16 Nov 2018 02:05:14 -0800 (PST) Received: from localhost ([122.172.88.116]) by smtp.gmail.com with ESMTPSA id u76-v6sm41233381pfa.176.2018.11.16.02.05.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 16 Nov 2018 02:05:13 -0800 (PST) From: Viresh Kumar To: Mark Rutland , Rob Herring , arm@kernel.org, Matthias Brugger Cc: Viresh Kumar , devicetree@vger.kernel.org, Vincent Guittot , Daniel Lezcano , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 06/10] ARM64: dts: mediatek: Add all CPUs in cooling maps Date: Fri, 16 Nov 2018 15:34:29 +0530 Message-Id: <3c7c9155ac01a2d745ba5e4434c958820200d088.1542362530.git.viresh.kumar@linaro.org> X-Mailer: git-send-email 2.19.1.568.g152ad8e3369a In-Reply-To: References: MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Each CPU can (and does) participate in cooling down the system but the DT only captures a handful of them, normally CPU0, in the cooling maps. Things work by chance currently as under normal circumstances its the first CPU of each cluster which is used by the operating systems to probe the cooling devices. But as soon as this CPU ordering changes and any other CPU is used to bring up the cooling device, we will start seeing failures. Also the DT is rather incomplete when we list only one CPU in the cooling maps, as the hardware doesn't have any such limitations. Update cooling maps to include all devices affected by individual trip points. Signed-off-by: Viresh Kumar --- arch/arm64/boot/dts/mediatek/mt7622.dtsi | 9 ++++++--- arch/arm64/boot/dts/mediatek/mt8173.dtsi | 6 ++++-- 2 files changed, 10 insertions(+), 5 deletions(-) -- 2.19.1.568.g152ad8e3369a diff --git a/arch/arm64/boot/dts/mediatek/mt7622.dtsi b/arch/arm64/boot/dts/mediatek/mt7622.dtsi index fe0c875f1d95..53e707df98d9 100644 --- a/arch/arm64/boot/dts/mediatek/mt7622.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt7622.dtsi @@ -170,17 +170,20 @@ cooling-maps { map0 { trip = <&cpu_passive>; - cooling-device = <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; + cooling-device = <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; }; map1 { trip = <&cpu_active>; - cooling-device = <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; + cooling-device = <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; }; map2 { trip = <&cpu_hot>; - cooling-device = <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; + cooling-device = <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; }; }; }; diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi index abd2f15a544b..e578f7d18038 100644 --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi @@ -275,12 +275,14 @@ cooling-maps { map@0 { trip = <&target>; - cooling-device = <&cpu0 0 0>; + cooling-device = <&cpu0 0 0>, + <&cpu1 0 0>; contribution = <3072>; }; map@1 { trip = <&target>; - cooling-device = <&cpu2 0 0>; + cooling-device = <&cpu2 0 0>, + <&cpu3 0 0>; contribution = <1024>; }; }; From patchwork Fri Nov 16 10:04:31 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 151321 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp229074ljp; Fri, 16 Nov 2018 02:05:26 -0800 (PST) X-Google-Smtp-Source: AJdET5dvVW9vOxv9xP4+V8rZEP6HW0ZdxgdGYiSN5Oyxk/4J/7p+2Ppp6yElTdsNCmnp2PqbcHnZ X-Received: by 2002:a17:902:be07:: with SMTP id r7-v6mr10103167pls.137.1542362726766; Fri, 16 Nov 2018 02:05:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542362726; cv=none; d=google.com; s=arc-20160816; b=QABpakkcHGVunRmccJzB3zl0aZQCijdBdzZo11WoHLx6Okm5SoPyX5s243tsW16y4b PNZqmm4moYhr14AnH9llUFlWobLTmWTMWEj+9tAsBLjaO0PUlaZ89Fc4j0d7QUg2O88X nlhEsNte02P9SvjWvaW1/5n4zXcXgzZFsF0j8C9uBWJsrJvpFFTalZSTV63mEs5Mvh9i oNlEMck7f58qRNl2kyfX3BXzhbUde8unuXCAjqKsw53s8vtmZ1GRcueqDcWGQQ5vAMGP ROmqSQS+8THik5CzVOCllTaE/bz4BP+/5LSkl1V/y0Xe0N9lX0Kt9wSf6/os6xN11AEg 79fg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=SF62PrzKsc3DFSelUulAf5/CE9NMeGCTdyY77HTuy1c=; b=X7R6F7odvGz5B5vRC4puFZmxSoTXpcxvqjXkrjU7qO3Mrwty6t2BLT+xhaO1RBclk1 kf3sPxhggH5bUdqfp83esxFomEEbOVAtyGbcO+2Z5WMuNT2gNn2KEPV3Ar73BOtZQKXm XTSfbscnezurOamE14/bHTzH/mfRnLU1YgKUsN4pogbD1A9vMvvjHX+Cl6Nl9YQ2h28d TmmSqlAy21LNmRMikp5nmeixYKYIPUUVGbnAhWxYNhZcg3gZ3rHQSqnNl4fQTgszajwA 60paHt3aHCbQELoYviuMAIDaO4MP/5x7pjdNDhxsnqQFJ1/K4wzD9rdIufCIWNTrBHQB yZcw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=PnpCbbhT; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g1si20633442pgj.34.2018.11.16.02.05.26; Fri, 16 Nov 2018 02:05:26 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=PnpCbbhT; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389621AbeKPURC (ORCPT + 32 others); Fri, 16 Nov 2018 15:17:02 -0500 Received: from mail-pl1-f193.google.com ([209.85.214.193]:36770 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389436AbeKPURB (ORCPT ); Fri, 16 Nov 2018 15:17:01 -0500 Received: by mail-pl1-f193.google.com with SMTP id y6-v6so3374821plt.3 for ; Fri, 16 Nov 2018 02:05:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=SF62PrzKsc3DFSelUulAf5/CE9NMeGCTdyY77HTuy1c=; b=PnpCbbhTW06C0H0dmVz2PQDq+LdWEyZzDI+ZgwXXfb6wI7dbqTUiEw94Mwr/E4LoMc V+U3PTjh02eBJW5jd+RWoMOA9XgiSQarp7dTK9y7zpBDVwlGDMm/VLI7DZvtG+RwhvsR VLw1jZupl3w/fHsQbTjVOr0fNbgzu92fqrp3o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=SF62PrzKsc3DFSelUulAf5/CE9NMeGCTdyY77HTuy1c=; b=HiL17cQE6oPEyfoT8zPWv1fekFjyW9++vZcKZFOkQ6jb0XwyblRHbp4uIb/OPwkBOR zv/IziWKfNlUHm4kUMMSTkG3VlCZACzh8Gw/lqsX9IN13W/imaaVby8hQFEDb/v+9yxi vqXh04wVW8fcXIpLMMyrKjTdNcM9rZsEhZnCi/SGnC5XgqJS8S6arW2z2nvYEQsFjPCl bPN32V3HQ+Qm0sz3HkGpMtZitqSXZxQ0b+j5cBRGDbJcWlhwkjZClxdXLEoH/Ii2VRLo RUrlxqCFbd86/JrpGHlhxyMJKQ/PPa+ZCedF4Ts1z+XJECNawM1fNstUdv5udTD8TGj3 pX1Q== X-Gm-Message-State: AGRZ1gKff+0uH53rx86RW0bHHedBepnZjygAlqYzY8BKdIHXkd6yI0vC pG6m8nD34GYwYJEvZ7JfJewHfQ== X-Received: by 2002:a17:902:3143:: with SMTP id w61-v6mr10080122plb.58.1542362723769; Fri, 16 Nov 2018 02:05:23 -0800 (PST) Received: from localhost ([122.172.88.116]) by smtp.gmail.com with ESMTPSA id q145-v6sm97195004pfq.143.2018.11.16.02.05.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 16 Nov 2018 02:05:23 -0800 (PST) From: Viresh Kumar To: Mark Rutland , Rob Herring , arm@kernel.org, Simon Horman , Magnus Damm Cc: Viresh Kumar , devicetree@vger.kernel.org, Vincent Guittot , Daniel Lezcano , linux-arm-kernel@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 08/10] ARM64: dts: renesas: Add all CPUs in cooling maps Date: Fri, 16 Nov 2018 15:34:31 +0530 Message-Id: X-Mailer: git-send-email 2.19.1.568.g152ad8e3369a In-Reply-To: References: MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Each CPU can (and does) participate in cooling down the system but the DT only captures a handful of them, normally CPU0, in the cooling maps. Things work by chance currently as under normal circumstances its the first CPU of each cluster which is used by the operating systems to probe the cooling devices. But as soon as this CPU ordering changes and any other CPU is used to bring up the cooling device, we will start seeing failures. Also the DT is rather incomplete when we list only one CPU in the cooling maps, as the hardware doesn't have any such limitations. Update cooling maps to include all devices affected by individual trip points. Signed-off-by: Viresh Kumar --- arch/arm64/boot/dts/renesas/r8a7795.dtsi | 15 ++++++++++++--- arch/arm64/boot/dts/renesas/r8a7796.dtsi | 6 +++--- 2 files changed, 15 insertions(+), 6 deletions(-) -- 2.19.1.568.g152ad8e3369a diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795.dtsi index a79c8d369e0b..3a662df32143 100644 --- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi +++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi @@ -2878,7 +2878,10 @@ cooling-maps { map0 { trip = <&sensor1_passive>; - cooling-device = <&a57_0 4 4>; + cooling-device = <&a57_0 4 4>, + <&a57_1 4 4>, + <&a57_2 4 4>, + <&a57_3 4 4>; }; }; }; @@ -2904,7 +2907,10 @@ cooling-maps { map0 { trip = <&sensor2_passive>; - cooling-device = <&a57_0 4 4>; + cooling-device = <&a57_0 4 4>, + <&a57_1 4 4>, + <&a57_2 4 4>, + <&a57_3 4 4>; }; }; }; @@ -2930,7 +2936,10 @@ cooling-maps { map0 { trip = <&sensor3_passive>; - cooling-device = <&a57_0 4 4>; + cooling-device = <&a57_0 4 4>, + <&a57_1 4 4>, + <&a57_2 4 4>, + <&a57_3 4 4>; }; }; }; diff --git a/arch/arm64/boot/dts/renesas/r8a7796.dtsi b/arch/arm64/boot/dts/renesas/r8a7796.dtsi index 1ec6aaa520c1..dd95e937f87a 100644 --- a/arch/arm64/boot/dts/renesas/r8a7796.dtsi +++ b/arch/arm64/boot/dts/renesas/r8a7796.dtsi @@ -2526,7 +2526,7 @@ cooling-maps { map0 { trip = <&sensor1_passive>; - cooling-device = <&a57_0 5 5>; + cooling-device = <&a57_0 5 5>, <&a57_1 5 5>; }; }; }; @@ -2552,7 +2552,7 @@ cooling-maps { map0 { trip = <&sensor2_passive>; - cooling-device = <&a57_0 5 5>; + cooling-device = <&a57_0 5 5>, <&a57_1 5 5>; }; }; }; @@ -2578,7 +2578,7 @@ cooling-maps { map0 { trip = <&sensor3_passive>; - cooling-device = <&a57_0 5 5>; + cooling-device = <&a57_0 5 5>, <&a57_1 5 5>; }; }; }; From patchwork Fri Nov 16 10:04:33 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 151323 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp229246ljp; Fri, 16 Nov 2018 02:05:36 -0800 (PST) X-Google-Smtp-Source: AJdET5fdTIvLUgVp/91y+DZoDC8TfNMwnSmUyjzeCTB+U8KDsr64Qi60NG+gQzmyhVj5KgcTn4Sr X-Received: by 2002:a62:29c4:: with SMTP id p187-v6mr10346614pfp.62.1542362736143; Fri, 16 Nov 2018 02:05:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542362736; cv=none; d=google.com; s=arc-20160816; b=u5OAK8XfT2Vamc4rIefBRY2/CKYCS3dCMKocHI7ntT7mlcOADy5Rtt5WkRC0LRX9LA t/ud4bvXRPmrqO6s6tzHVa5jSP2szKr7s3l6yu7w4LO4MrHUWRGKl0F1C9b2UcHDB2Q7 kxR+26n/vNWJglr3gQHkul+Q07SXOvYfTw9W1iV15krtFpn2LsmcZ5lIFOlnaYrNaG9S +E/WWw6XitSJD1ibQEg1hGTfD4GlAfrZdbunFB0bos9S7JMiAftSaBGtfa0Pd3qwKEhn TNtm7pdCTDJ/Cs/JgkJ60po6r8ysRebJWc2KBktiw8JIfvcbdjRE3PACJfXBYjyA8iak cdNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=KuQ2y36Xrogh3AFeo+w7wq6zdpbFBC/erJbwrEPtLJs=; b=sR2kU0ARcswf8j+iD2mI9yvmB5c0m2sx9uwrjZ9IwaQeYzxz/+vAtPd7DNfz7tF4Rh 7oLAeT1yQv7SozHJkTG3g0ulH13AK6Nk84xkMMK5pXvDbsoKHZaV37g3hZuTn7OwUUUu LFtpBGHrGYqM1EEFR9KLU18g3J2bGuhXcc/ey8/YcUVQO/Nwy0dftMhkNR8ZthhBvYd0 TQMgQcD4pPZ61FgAaaJdGrGqnh0myiHrb1c256C+pYqtgKMi/jtfZJ2RnG9rzbC83Wyy RzkPi03/VUcDlwb1IeyOCl1RN2ApOs4oyjRlO+/5ucXoqwCaiKzrGtn36kbylilPKqEe UMRw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=jW92B1Vz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d17si29158781pgl.484.2018.11.16.02.05.35; Fri, 16 Nov 2018 02:05:36 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=jW92B1Vz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389648AbeKPURL (ORCPT + 32 others); Fri, 16 Nov 2018 15:17:11 -0500 Received: from mail-pg1-f195.google.com ([209.85.215.195]:45659 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389504AbeKPURL (ORCPT ); Fri, 16 Nov 2018 15:17:11 -0500 Received: by mail-pg1-f195.google.com with SMTP id y4so10393171pgc.12 for ; Fri, 16 Nov 2018 02:05:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=KuQ2y36Xrogh3AFeo+w7wq6zdpbFBC/erJbwrEPtLJs=; b=jW92B1VzqoIqDzqfecPcu+sFg3tYWXLZGvNmhlicA/IAPUk2KrDwq6Cd/dXpVmP/Ch tc8tdaerC+mPnSf3WEy6lguWwJvNA8r2ShnOFqXsyYp0ajfqyXaQMmd3DuZxDcpGVjul t/MXnPBObHOJLawXqGPkrM4efmpv8szog/bXc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=KuQ2y36Xrogh3AFeo+w7wq6zdpbFBC/erJbwrEPtLJs=; b=E19ppKjgRZW2NZMD0fgCUM33MtUXWRGmC4kqCFw7d/CzNTxI6vDDwuBemvizVyuIL3 MIpVFgEMb6F7ssDkgnqu2LRF0CrGNxFnO4c4hz4LdBvKMngC3sQ7XxRAbndmEl3L3tyi RSCyA5zY7Z+IQNP32jlrHJK64O6OH0Jbi/m7c9VUETHWKTUr9WZpYjjG6zHbd0kEVUov ySHiNwwyx6bR5f6CyJENIKnS7wxqpqp2B5sXCNNml+r3RedYJTNl9WfxG0tPeIBXWIr4 U0Xg1NSbtVvTNDnRtRMMp/W8juo/Fq4snOit04qm0sJkYE2FPvaLakPReNHS3CMhwSmw ARYg== X-Gm-Message-State: AGRZ1gIYerG+WpWYR5QR5QxtieudL4a/VE8OrBhpldAXEH0iuINPZ5oI nijVupvrASMLkjX9IOvxyyxTeg== X-Received: by 2002:a63:5153:: with SMTP id r19mr9270294pgl.281.1542362733085; Fri, 16 Nov 2018 02:05:33 -0800 (PST) Received: from localhost ([122.172.88.116]) by smtp.gmail.com with ESMTPSA id 79sm29801208pge.66.2018.11.16.02.05.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 16 Nov 2018 02:05:32 -0800 (PST) From: Viresh Kumar To: Mark Rutland , Rob Herring , arm@kernel.org, Masahiro Yamada Cc: Viresh Kumar , devicetree@vger.kernel.org, Vincent Guittot , Daniel Lezcano , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 10/10] ARM64: dts: uniphier: Add all CPUs in cooling maps Date: Fri, 16 Nov 2018 15:34:33 +0530 Message-Id: X-Mailer: git-send-email 2.19.1.568.g152ad8e3369a In-Reply-To: References: MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Each CPU can (and does) participate in cooling down the system but the DT only captures a handful of them, normally CPU0, in the cooling maps. Things work by chance currently as under normal circumstances its the first CPU of each cluster which is used by the operating systems to probe the cooling devices. But as soon as this CPU ordering changes and any other CPU is used to bring up the cooling device, we will start seeing failures. Also the DT is rather incomplete when we list only one CPU in the cooling maps, as the hardware doesn't have any such limitations. Update cooling maps to include all devices affected by individual trip points. Signed-off-by: Viresh Kumar --- arch/arm64/boot/dts/socionext/uniphier-ld20.dtsi | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) -- 2.19.1.568.g152ad8e3369a diff --git a/arch/arm64/boot/dts/socionext/uniphier-ld20.dtsi b/arch/arm64/boot/dts/socionext/uniphier-ld20.dtsi index d7e2d8969601..4a0c46cb11cd 100644 --- a/arch/arm64/boot/dts/socionext/uniphier-ld20.dtsi +++ b/arch/arm64/boot/dts/socionext/uniphier-ld20.dtsi @@ -206,13 +206,10 @@ cooling-maps { map0 { trip = <&cpu_alert>; - cooling-device = <&cpu0 - THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; - }; - map1 { - trip = <&cpu_alert>; - cooling-device = <&cpu2 - THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; + cooling-device = <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu2 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; }; }; };