From patchwork Wed Nov 28 10:45:07 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tero Kristo X-Patchwork-Id: 152249 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp924772ljp; Wed, 28 Nov 2018 02:45:36 -0800 (PST) X-Google-Smtp-Source: AFSGD/UE5Ltk521r0+brmXyHTeRsVk+ZkZ4rjFC/j9KTUpl0hBpB+4v44LUT9/7hQvrMDGDuRaxj X-Received: by 2002:a17:902:8507:: with SMTP id bj7-v6mr35675370plb.99.1543401936400; Wed, 28 Nov 2018 02:45:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543401936; cv=none; d=google.com; s=arc-20160816; b=Cn1bb4RK4NK0l9bwGZ3DKkF224/dB5M5QpI3zVBExOag9YCTUvgb8x4OVUfdyTeeg7 ZIjBrZdFddjXXeF7UEwqp06kGa7Yi+0MNRUSe8mhbjY4dlKeuOJdUNlGXtGKmR1e74uF DIp3Uf7NsM8edReE4iBPSJyepLFPK+TFRtreM3UXh5/l813uzetN8+pkngzyDDN0RMLi jEL3k4zXxyTMby5WDLLV4JUASBGyTF/zxcpbKxxIULdN524oAuav+v5fipXKuOoNNAcE 6fML2OEtyoRMAjAChZxLYVF881pjfskMfT9WC2DeRIvU4DW5AjxfgaHORbu6dvQOy6Tm jv/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:subject:cc :to:from; bh=JLqGaknTJz6gOfhz30Kzm4AaTkgHjvOoKhraLiPwSFs=; b=WG+vrYwHi6p3JJ7AkkFtXI/wd1Bv2SRmoYaYEj1P9rY8yVrjkNI5rwb02/JI6t9ycE k4l3oIAKqk8OaAA7QtJA4041+sIdMuL3EOndgc7Tatw9gZvTbKfzsb20IyIc6HxpjRLg 5tTJOToLnn7YZKyJw14Mn6kkCxQG1zfvXt0ZVZ6IyjQ8UaTK9dcLRCe2tVKEbFXN9so/ 2qZ9SuQkJeb9m4+W038zeCGrVM1tUzBPU/M7+YpciKKaOqNxzjuptHAiPlToF2Eop6nj v0mRoo+FeOKgWjXMP2hDycWWLOXylJchhQwHRljxqobo4L0x//58APYUopG0xR7O9zKw +JzQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e11si6939599pgf.450.2018.11.28.02.45.36; Wed, 28 Nov 2018 02:45:36 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727809AbeK1Vqs (ORCPT + 6 others); Wed, 28 Nov 2018 16:46:48 -0500 Received: from fllv0016.ext.ti.com ([198.47.19.142]:38902 "EHLO fllv0016.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727673AbeK1Vqs (ORCPT ); Wed, 28 Nov 2018 16:46:48 -0500 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id wASAjI4J052230; Wed, 28 Nov 2018 04:45:18 -0600 Received: from DLEE103.ent.ti.com (dlee103.ent.ti.com [157.170.170.33]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id wASAjIW1060363 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 28 Nov 2018 04:45:18 -0600 Received: from DLEE111.ent.ti.com (157.170.170.22) by DLEE103.ent.ti.com (157.170.170.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1591.10; Wed, 28 Nov 2018 04:45:17 -0600 Received: from dlep32.itg.ti.com (157.170.170.100) by DLEE111.ent.ti.com (157.170.170.22) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1591.10 via Frontend Transport; Wed, 28 Nov 2018 04:45:17 -0600 Received: from gomoku.home (ileax41-snat.itg.ti.com [10.172.224.153]) by dlep32.itg.ti.com (8.14.3/8.13.8) with ESMTP id wASAjFns003175; Wed, 28 Nov 2018 04:45:16 -0600 From: Tero Kristo To: , CC: , Subject: [PATCH] ARM: dts: dra7: Move the ti, no-idle quirk on proper gmac node Date: Wed, 28 Nov 2018 12:45:07 +0200 Message-ID: <1543401907-14751-1-git-send-email-t-kristo@ti.com> X-Mailer: git-send-email 1.9.1 MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hwmod parses the DT hierarchically from root to search for matching ti,hwmod property. With the introduction of L4 data, we have two nodes with the ti,hwmod = "gmac" declaration, and the hwmod core only matches the first one found, which is the target-module one. This node incorrectly dropped the ti,no-idle flag, which causes number of problems, like ignoring errata i877, and also causing an intermittent boot failure on certain dra7 boards. Fix the issue by moving the ti,no-idle flag to the proper node. Signed-off-by: Tero Kristo Reported-by: Grygorii Strashko --- FYI: The problem is seen in linux-next. arch/arm/boot/dts/dra7-l4.dtsi | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) -- 1.9.1 -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki Reviewed-by: Grygorii Strashko diff --git a/arch/arm/boot/dts/dra7-l4.dtsi b/arch/arm/boot/dts/dra7-l4.dtsi index 7e5c0d4f..6c01ada 100644 --- a/arch/arm/boot/dts/dra7-l4.dtsi +++ b/arch/arm/boot/dts/dra7-l4.dtsi @@ -3021,6 +3021,14 @@ #address-cells = <1>; #size-cells = <1>; ranges = <0x0 0x84000 0x4000>; + /* + * Do not allow gating of cpsw clock as workaround + * for errata i877. Keeping internal clock disabled + * causes the device switching characteristics + * to degrade over time and eventually fail to meet + * the data manual delay time/skew specs. + */ + ti,no-idle; mac: ethernet@0 { compatible = "ti,dra7-cpsw","ti,cpsw"; @@ -3040,15 +3048,6 @@ #size-cells = <1>; /* - * Do not allow gating of cpsw clock as workaround - * for errata i877. Keeping internal clock disabled - * causes the device switching characteristics - * to degrade over time and eventually fail to meet - * the data manual delay time/skew specs. - */ - ti,no-idle; - - /* * rx_thresh_pend * rx_pend * tx_pend