From patchwork Mon Feb 14 18:41:08 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Muhammad Usama Anjum X-Patchwork-Id: 542677 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66F0DC433F5 for ; Mon, 14 Feb 2022 18:42:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234475AbiBNSmn (ORCPT ); Mon, 14 Feb 2022 13:42:43 -0500 Received: from gmail-smtp-in.l.google.com ([23.128.96.19]:55126 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229929AbiBNSmn (ORCPT ); Mon, 14 Feb 2022 13:42:43 -0500 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F1E436A031; Mon, 14 Feb 2022 10:42:28 -0800 (PST) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: usama.anjum) with ESMTPSA id AF6DE1F42D82 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1644864136; bh=W18enxGJ7VHuEUchE3vYqlXRqDM4/g7XY+m9I18XfPg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LkKqKFcaHOg7C4Karxg401kK87AQY/38ozh/h9jHvk0jNc7Y2oI7pYA6hBgUXUafy ur15SFp9BoTv+/nEHm3xXa+hoEFE5IXXw2kii1GMakOOsLXaN2khUmnyeQXvgtkDUe w+lpuqmnfM++Mnu5T3EcNsW9GybJoxWFclWLgfyW2HxC6vGPSFSvJRELnQhxlaEDzQ WaqoWQWBSJ+BN5qSm7mRTQWS2cDZek3jSH5oiIeoNQBrU3jtxvUOIkbeAQ2hYhtHB7 vdQC9xH2FXs5eW+DQAeLz2xBmRYOXdOjaV4episs7eO+X4y0BUe26DuHPcP3xYgJ4A AMuiY8W7K74hA== From: Muhammad Usama Anjum To: Jarkko Sakkinen , Dave Hansen , Shuah Khan , Andy Lutomirski , Jethro Beekman , Borislav Petkov , linux-sgx@vger.kernel.org (open list:INTEL SGX), linux-kselftest@vger.kernel.org (open list:KERNEL SELFTEST FRAMEWORK), linux-kernel@vger.kernel.org (open list), David.Laight@ACULAB.COM Cc: Muhammad Usama Anjum , kernel@collabora.com, kernelci@groups.io, "kernelci.org bot" Subject: [PATCH V2 1/2] selftests: x86: add validity check and allow field splitting Date: Mon, 14 Feb 2022 23:41:08 +0500 Message-Id: <20220214184109.3739179-2-usama.anjum@collabora.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220214184109.3739179-1-usama.anjum@collabora.com> References: <20220214184109.3739179-1-usama.anjum@collabora.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org Add check to test if CC has a string. CC can have multiple sub-strings like "ccache gcc". Erorr pops up if it is treated as single string and double quotes are used around it. This can be fixed by removing the quotes and not treating CC as a single string. Fixes: e9886ace222e ("selftests, x86: Rework x86 target architecture detection") Reported-by: "kernelci.org bot" Signed-off-by: Muhammad Usama Anjum --- Changes in V2: Update if condition to check if CC has a string --- tools/testing/selftests/x86/check_cc.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/x86/check_cc.sh b/tools/testing/selftests/x86/check_cc.sh index 3e2089c8cf549..8c669c0d662ee 100755 --- a/tools/testing/selftests/x86/check_cc.sh +++ b/tools/testing/selftests/x86/check_cc.sh @@ -7,7 +7,7 @@ CC="$1" TESTPROG="$2" shift 2 -if "$CC" -o /dev/null "$TESTPROG" -O0 "$@" 2>/dev/null; then +if [ -n "$CC" ] && $CC -o /dev/null "$TESTPROG" -O0 "$@" 2>/dev/null; then echo 1 else echo 0 From patchwork Mon Feb 14 18:41:09 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Muhammad Usama Anjum X-Patchwork-Id: 542900 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF4DCC4332F for ; Mon, 14 Feb 2022 18:42:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236471AbiBNSmq (ORCPT ); Mon, 14 Feb 2022 13:42:46 -0500 Received: from gmail-smtp-in.l.google.com ([23.128.96.19]:55258 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235969AbiBNSmp (ORCPT ); Mon, 14 Feb 2022 13:42:45 -0500 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 070EB6A03A; Mon, 14 Feb 2022 10:42:30 -0800 (PST) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: usama.anjum) with ESMTPSA id 933581F42D84 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1644864140; bh=w9UAj95XKnPRibc1brD+qtkacXLhUZfQCGbpzMCMPok=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nEyFlAL4xdt6WUN1sUPYXMSk5v2VNbDhrWDjlOy1PIaBfiFd+2ayg2yqwf7rWIiQR XOMbdLVetye+DhWZLEaJX/bgTO58ynwTgpkuLXulIktOk2IfQhJ3QQ5ztsd8xUBbz+ uB8OaVhLvbWrjMGwvJtRfd2oqMPWstchn7AC8wklCK6jTOwgAhOpT2VMiHNckDyxY3 nItAcySVf+2NL84xTPXkAYY6uCPeWvIBJChkey3ia5UylEatqS2Y1PfZsJRQKkQlJd CVKP25/jyNBCxe6m/Li5mMfQ35lqnV/0fkwiq4fZth4Kjy4MAqm63go6bn2u/5cteZ zbdHTyqEZh10w== From: Muhammad Usama Anjum To: Jarkko Sakkinen , Dave Hansen , Shuah Khan , Andy Lutomirski , Jethro Beekman , Borislav Petkov , linux-sgx@vger.kernel.org (open list:INTEL SGX), linux-kselftest@vger.kernel.org (open list:KERNEL SELFTEST FRAMEWORK), linux-kernel@vger.kernel.org (open list), David.Laight@ACULAB.COM Cc: Muhammad Usama Anjum , kernel@collabora.com, kernelci@groups.io, "kernelci.org bot" Subject: [PATCH V2 2/2] selftests: sgx: Treat CC as one argument Date: Mon, 14 Feb 2022 23:41:09 +0500 Message-Id: <20220214184109.3739179-3-usama.anjum@collabora.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220214184109.3739179-1-usama.anjum@collabora.com> References: <20220214184109.3739179-1-usama.anjum@collabora.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org CC can have multiple sub-strings like "ccache gcc". For check_cc.sh, CC needs to be treated like one argument. Put double quotes around it to make CC one string and hence one argument. Fixes: 2adcba79e69d ("selftests/x86: Add a selftest for SGX") Reported-by: "kernelci.org bot" Signed-off-by: Muhammad Usama Anjum --- tools/testing/selftests/sgx/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/sgx/Makefile b/tools/testing/selftests/sgx/Makefile index 2956584e1e37f..75af864e07b65 100644 --- a/tools/testing/selftests/sgx/Makefile +++ b/tools/testing/selftests/sgx/Makefile @@ -4,7 +4,7 @@ include ../lib.mk .PHONY: all clean -CAN_BUILD_X86_64 := $(shell ../x86/check_cc.sh $(CC) \ +CAN_BUILD_X86_64 := $(shell ../x86/check_cc.sh "$(CC)" \ ../x86/trivial_64bit_program.c) ifndef OBJCOPY