From patchwork Thu Mar 3 18:00:13 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 548011 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91F15C433EF for ; Thu, 3 Mar 2022 18:01:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235557AbiCCSBu (ORCPT ); Thu, 3 Mar 2022 13:01:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47070 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231147AbiCCSBu (ORCPT ); Thu, 3 Mar 2022 13:01:50 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D2510198D1D; Thu, 3 Mar 2022 10:01:04 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 34D636198A; Thu, 3 Mar 2022 18:01:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 88E04C004E1; Thu, 3 Mar 2022 18:01:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1646330463; bh=04i2eZv5qTAuP3AEyiHIUhvzqHVYSg3BWxLhzLKqjlw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fThq9067ilo5VqJdZcN905SWb/WIOXTBNq9YhSAdlOjllMfhmm47DQpdfYhlMfTNK oTxJY9wqpBlz050G/bqoK6B65W9typ9QGvks4S0KOQBsE2GTSySHuKYoHYoagF4elI Do/f/sxE9cOLrCitJHgrSoAa6xuI9gb3rLbd0iVo6cO1TFxvOkGI5Y6WE5uKwj3Bak PEvshiZYoVt3vpz8qejgQdLM1O/EmF3VuHRRNZWVqVNDsZwX0N6CmXpC924l5wsu/s pmIXzeXQRtiv6LRmznrVoCaVzzw+8yXzIoyKdUxEbicv+8AVMU034LghLjDXL3XW31 M6yy5Of9aeS8w== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1nPpl8-0000io-7K; Thu, 03 Mar 2022 19:01:02 +0100 From: Johan Hovold To: Tony Lindgren Cc: linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH 1/2] ARM: OMAP2+: drop omap_device_register() helper Date: Thu, 3 Mar 2022 19:00:13 +0100 Message-Id: <20220303180014.2639-2-johan@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220303180014.2639-1-johan@kernel.org> References: <20220303180014.2639-1-johan@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org The omap_device_register() helper is unused since commit 82f12e64a019 ("ARM: OMAP2+: Drop legacy init for sdma") and can be removed. Signed-off-by: Johan Hovold --- arch/arm/mach-omap2/omap_device.c | 17 ----------------- arch/arm/mach-omap2/omap_device.h | 1 - 2 files changed, 18 deletions(-) diff --git a/arch/arm/mach-omap2/omap_device.c b/arch/arm/mach-omap2/omap_device.c index 56d6814bec26..3cfa7b01a24b 100644 --- a/arch/arm/mach-omap2/omap_device.c +++ b/arch/arm/mach-omap2/omap_device.c @@ -473,23 +473,6 @@ struct dev_pm_domain omap_device_pm_domain = { } }; -/** - * omap_device_register - register an omap_device with one omap_hwmod - * @pdev: the platform device (omap_device) to register. - * - * Register the omap_device structure. This currently just calls - * platform_device_register() on the underlying platform_device. - * Returns the return value of platform_device_register(). - */ -int omap_device_register(struct platform_device *pdev) -{ - pr_debug("omap_device: %s: registering\n", pdev->name); - - dev_pm_domain_set(&pdev->dev, &omap_device_pm_domain); - return platform_device_add(pdev); -} - - /* Public functions for use by device drivers through struct platform_data */ /** diff --git a/arch/arm/mach-omap2/omap_device.h b/arch/arm/mach-omap2/omap_device.h index f77e76a7841a..d607532cf5e0 100644 --- a/arch/arm/mach-omap2/omap_device.h +++ b/arch/arm/mach-omap2/omap_device.h @@ -71,7 +71,6 @@ int omap_device_idle(struct platform_device *pdev); struct omap_device *omap_device_alloc(struct platform_device *pdev, struct omap_hwmod **ohs, int oh_cnt); void omap_device_delete(struct omap_device *od); -int omap_device_register(struct platform_device *pdev); struct device *omap_device_get_by_hwmod_name(const char *oh_name); From patchwork Thu Mar 3 18:00:14 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 548010 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F048C433FE for ; Thu, 3 Mar 2022 18:01:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235562AbiCCSB4 (ORCPT ); Thu, 3 Mar 2022 13:01:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47208 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235560AbiCCSBv (ORCPT ); Thu, 3 Mar 2022 13:01:51 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 330D81A1C56; Thu, 3 Mar 2022 10:01:06 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id E7FC9B82664; Thu, 3 Mar 2022 18:01:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A0E79C340EF; Thu, 3 Mar 2022 18:01:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1646330463; bh=xGgnnVHyGleDpVkH9gkP5NrpsGASPkv/CJewUK6NLDU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JcO8OXDEAyL+U547uBOC8tTHMHCd+zP060n+yMQOOYLKkDW7vhWTYCZcQMDwossNu BIpKFOOxv8JWtfM4jVphHMuIVEv87l5eIWRVGUwYXo3p2Xciha+Zg8o8RP/Ha0T/20 EAQuHUdE700SSmrxIf7ggqU8y/5ZRDHrigKXam8cZ59D0LucvX3lxxipeOdVeG2VPZ sjjuaxa4diGeHMhw9e8Qw1MD393dESCFq8yOGHrlc3IK/lq3wFz2/gG5blDgjx1o2i 7RMv/WEJiK0XqoMtkpMl72YSn7UKOkgMLaNUnl6vLNs4Fv2IOf0CEIQALhduHgqIGX gg9nqfq2z+wlA== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1nPpl8-0000iq-AF; Thu, 03 Mar 2022 19:01:02 +0100 From: Johan Hovold To: Tony Lindgren Cc: linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH 2/2] ARM: OMAP2+: drop hwmod-clock helper comment Date: Thu, 3 Mar 2022 19:00:14 +0100 Message-Id: <20220303180014.2639-3-johan@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220303180014.2639-1-johan@kernel.org> References: <20220303180014.2639-1-johan@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org Since commit a4f6cdb0672f ("ARM: OMAP: omap_device: Add omap_device_[alloc|delete] for DT integration"), _add_hwmod_clocks_clkdev() is called from omap_device_alloc(). Drop the outdated comment referring to how this function was used ten odd years ago. Signed-off-by: Johan Hovold --- arch/arm/mach-omap2/omap_device.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/arch/arm/mach-omap2/omap_device.c b/arch/arm/mach-omap2/omap_device.c index 3cfa7b01a24b..8b3701901991 100644 --- a/arch/arm/mach-omap2/omap_device.c +++ b/arch/arm/mach-omap2/omap_device.c @@ -96,9 +96,6 @@ static void _add_clkdev(struct omap_device *od, const char *clk_alias, * omap_device, this function adds an entry in the clkdev table of the * form if it does not exist already. * - * The function is called from inside omap_device_build_ss(), after - * omap_device_register. - * * This allows drivers to get a pointer to its optional clocks based on its role * by calling clk_get(, ). * In the case of the main clock, a "fck" alias is used.