From patchwork Wed Dec 5 19:50:37 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rob Herring X-Patchwork-Id: 152948 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp9695334ljp; Wed, 5 Dec 2018 11:51:20 -0800 (PST) X-Google-Smtp-Source: AFSGD/V5PundA7S+xThkTFgbYP3NWfajXPwPCoF1Exot1efQnx9BKodAZ/U5oH2fq3NIZIdl0LpZ X-Received: by 2002:a17:902:24a2:: with SMTP id w31mr25055642pla.216.1544039480430; Wed, 05 Dec 2018 11:51:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544039480; cv=none; d=google.com; s=arc-20160816; b=hesR/JcZYIzR8FktbnVkG3u1AUk9gGjm4IqKh2eix5qFg2dWBXMx93lQtZA8etPvR/ 51ZckUSouo0FWHqn1rKiPnPfFQAZddJykeOe8nXiWXBWy34pgXwTH/PLmLb5Qz6V3B0p a/Wr6OX0DCaj2kzSqoW+X5ApAUaB6SnpL54G2GiICU5gqKSxT4qOku3pY9Vudc79Ilsf iajLK3K6Jrd0INBR+LHFr+mdt1HmsUnTlssZ4pt+P47VpJlydUqcsr/WXzI4j4PrfD3n A78bkJspbMr1ofyp+4GED5vZ+pRzgAbrUzeUwljtxXBshCKJs3OQTC2GbOH41jbIWcYd vRUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=ZT2CIk3VKIW0+KTeOjaZQKGiIbm+8YjA18EhBPqm0fo=; b=S2hTjFHJSnR73BClhA+fpAs66O0CyMyTJOoIyD74rAkiqv0Pu1ysZdCr/cGXIoVBpU eiXgqkkIUN5hH8xF4KCHhQBT2BtioF/8fRVRNbH5IT5yOX/Tjr3MqK0JQ5LaXRGBpz6n 4GZ8rJWfSzsyTzsA5hgKpc8mb38BRdsidzf8Rkt04nVG4PlXthBkNjUxBJc35SdXR/st PrsdXy6U93gzvlDyGtqV+y3H18vFWtttnS8CymM94Aepo98LdFQfuYLet41CYQ3hZShQ 3xgLUaiA/y/DA60eS3ChidURCYHQi9LVnATKJtQl6Ru56fnSbaIYMJly9HPwht4cKSNf gXWQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w12si19875173pgl.122.2018.12.05.11.51.20; Wed, 05 Dec 2018 11:51:20 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728801AbeLETvT (ORCPT + 6 others); Wed, 5 Dec 2018 14:51:19 -0500 Received: from mail-ot1-f65.google.com ([209.85.210.65]:37611 "EHLO mail-ot1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728769AbeLETvQ (ORCPT ); Wed, 5 Dec 2018 14:51:16 -0500 Received: by mail-ot1-f65.google.com with SMTP id 40so19802365oth.4; Wed, 05 Dec 2018 11:51:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ZT2CIk3VKIW0+KTeOjaZQKGiIbm+8YjA18EhBPqm0fo=; b=p+cHTyO2SjkfWTiTuM1GMF+2pHscE3M+AqxT7CixphE35I/hQV7XrruG8PK83wGN80 RrDaMaZeZxKWZO+4eU1ZYJ1yvT/uRaElMd+Ps3mHY3xvEgE3p2nIWfZwacSqrfi9RvR5 oDsX0csdER2XQ0OjwAXYiEopsv+zjLgCpLfapViPFQv9EeG/eEg54AnuQAqGNyAs9XtI 1MfbuVsJ+z2e6myVnF3Oq7fjC0Dz0MeCiNuQAqf6Pn82IzpoaciRmRGA+8Rg5sk6CbB0 GgHwYMw/vU+lO/CRXIWnRx2Q2gqqFB+xIUrPvUMPvYWpcGmTME319vtx0CMAnXV5xKEi GiyQ== X-Gm-Message-State: AA+aEWYdC4KDhnwSdeXQMNpJ26fM7kxeRZcekdurrELEWYQN8r2aXWMJ pTfI/bhjVqz4DBBlZ5gBFLKJGEM= X-Received: by 2002:a9d:b8e:: with SMTP id 14mr15296146oth.279.1544039475230; Wed, 05 Dec 2018 11:51:15 -0800 (PST) Received: from xps15.herring.priv (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.googlemail.com with ESMTPSA id k13sm25759879otj.19.2018.12.05.11.51.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 05 Dec 2018 11:51:14 -0800 (PST) From: Rob Herring To: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Liam Girdwood , Mark Brown , Support Opensource , Sangbeom Kim , Krzysztof Kozlowski , Bartlomiej Zolnierkiewicz , linux-samsung-soc@vger.kernel.org Subject: [PATCH] regulator: Use of_node_name_eq for node name comparisons Date: Wed, 5 Dec 2018 13:50:37 -0600 Message-Id: <20181205195050.4759-21-robh@kernel.org> X-Mailer: git-send-email 2.19.1 MIME-Version: 1.0 Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Convert string compares of DT node names to use of_node_name_eq helper instead. This removes direct access to the node name pointer. For instances using of_node_cmp, this has the side effect of now using case sensitive comparisons. This should not matter for any FDT based system which all of these are. Cc: Liam Girdwood Cc: Mark Brown Cc: Support Opensource Cc: Sangbeom Kim Cc: Krzysztof Kozlowski Cc: Bartlomiej Zolnierkiewicz Cc: linux-samsung-soc@vger.kernel.org Signed-off-by: Rob Herring --- drivers/regulator/88pm8607.c | 2 +- drivers/regulator/da9052-regulator.c | 2 +- drivers/regulator/max8997-regulator.c | 2 +- drivers/regulator/mc13xxx-regulator-core.c | 2 +- drivers/regulator/qcom-rpmh-regulator.c | 2 +- drivers/regulator/s5m8767.c | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-) -- 2.19.1 diff --git a/drivers/regulator/88pm8607.c b/drivers/regulator/88pm8607.c index fd86446e499b..28f55248eb90 100644 --- a/drivers/regulator/88pm8607.c +++ b/drivers/regulator/88pm8607.c @@ -328,7 +328,7 @@ static int pm8607_regulator_dt_init(struct platform_device *pdev, return -ENODEV; } for_each_child_of_node(nproot, np) { - if (!of_node_cmp(np->name, info->desc.name)) { + if (of_node_name_eq(np, info->desc.name)) { config->init_data = of_get_regulator_init_data(&pdev->dev, np, &info->desc); diff --git a/drivers/regulator/da9052-regulator.c b/drivers/regulator/da9052-regulator.c index 37e4025203e3..207cb3859dcc 100644 --- a/drivers/regulator/da9052-regulator.c +++ b/drivers/regulator/da9052-regulator.c @@ -435,7 +435,7 @@ static int da9052_regulator_probe(struct platform_device *pdev) return -ENODEV; for_each_child_of_node(nproot, np) { - if (!of_node_cmp(np->name, + if (of_node_name_eq(np, regulator->info->reg_desc.name)) { config.init_data = of_get_regulator_init_data( &pdev->dev, np, diff --git a/drivers/regulator/max8997-regulator.c b/drivers/regulator/max8997-regulator.c index 3bf5ddfaaea8..4d2487279a0a 100644 --- a/drivers/regulator/max8997-regulator.c +++ b/drivers/regulator/max8997-regulator.c @@ -925,7 +925,7 @@ static int max8997_pmic_dt_parse_pdata(struct platform_device *pdev, pdata->regulators = rdata; for_each_child_of_node(regulators_np, reg_np) { for (i = 0; i < ARRAY_SIZE(regulators); i++) - if (!of_node_cmp(reg_np->name, regulators[i].name)) + if (of_node_name_eq(reg_np, regulators[i].name)) break; if (i == ARRAY_SIZE(regulators)) { diff --git a/drivers/regulator/mc13xxx-regulator-core.c b/drivers/regulator/mc13xxx-regulator-core.c index 65eb1e0350cf..2243138d8a58 100644 --- a/drivers/regulator/mc13xxx-regulator-core.c +++ b/drivers/regulator/mc13xxx-regulator-core.c @@ -186,7 +186,7 @@ struct mc13xxx_regulator_init_data *mc13xxx_parse_regulators_dt( for (i = 0; i < num_regulators; i++) { if (!regulators[i].desc.name) continue; - if (!of_node_cmp(child->name, + if (of_node_name_eq(child, regulators[i].desc.name)) { p->id = i; p->init_data = of_get_regulator_init_data( diff --git a/drivers/regulator/qcom-rpmh-regulator.c b/drivers/regulator/qcom-rpmh-regulator.c index 39ccf53fdeb3..b2c2d01d1637 100644 --- a/drivers/regulator/qcom-rpmh-regulator.c +++ b/drivers/regulator/qcom-rpmh-regulator.c @@ -410,7 +410,7 @@ static int rpmh_regulator_init_vreg(struct rpmh_vreg *vreg, struct device *dev, vreg->dev = dev; for (rpmh_data = pmic_rpmh_data; rpmh_data->name; rpmh_data++) - if (!strcmp(rpmh_data->name, node->name)) + if (of_node_name_eq(node, rpmh_data->name)) break; if (!rpmh_data->name) { diff --git a/drivers/regulator/s5m8767.c b/drivers/regulator/s5m8767.c index 219b9afda0cb..654f65abcb5a 100644 --- a/drivers/regulator/s5m8767.c +++ b/drivers/regulator/s5m8767.c @@ -561,7 +561,7 @@ static int s5m8767_pmic_dt_parse_pdata(struct platform_device *pdev, pdata->opmode = rmode; for_each_child_of_node(regulators_np, reg_np) { for (i = 0; i < ARRAY_SIZE(regulators); i++) - if (!of_node_cmp(reg_np->name, regulators[i].name)) + if (of_node_name_eq(reg_np, regulators[i].name)) break; if (i == ARRAY_SIZE(regulators)) {