From patchwork Thu Apr 7 11:51:24 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Markuss Broks X-Patchwork-Id: 559817 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19F5EC433FE for ; Thu, 7 Apr 2022 11:51:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245010AbiDGLxm (ORCPT ); Thu, 7 Apr 2022 07:53:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33650 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245008AbiDGLxl (ORCPT ); Thu, 7 Apr 2022 07:53:41 -0400 Received: from mail-lj1-x233.google.com (mail-lj1-x233.google.com [IPv6:2a00:1450:4864:20::233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E4FC519EC4D; Thu, 7 Apr 2022 04:51:41 -0700 (PDT) Received: by mail-lj1-x233.google.com with SMTP id s13so7116308ljd.5; Thu, 07 Apr 2022 04:51:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=iXxYhOZovoVWD00T32nm/pWCIlnIIec23xpqqBb7OP8=; b=bG2HiRVZ6ugkT9G97JKobzo+9dWTNwMMSe2ERsuhwJNbfmVXhfNz6yGQIqA7Qr+6G3 wtxOMTLAv0/0SDqeVIGcpQi06eh37yM23WSXB/vkgDSdilTPI0hGPBjSOCdppKNRjR/p ZUuuHRyRn1jB4yjypYmKe3Ig83MacP8/DRmgd4S+CjhRl+Qqa/JXTtd5cMA4ebZj6yN+ j3VzUJZlkI4bDGW8lLhyD3RGc9JYM4qbL3ccKHPEFfkwz2OZcIdDl9Sa3c+TIesUb+22 exhmiUAG+izHOT9CxHBAxIOl/lYoquHGcj4rLASN7SxYfhH9EMHx0Uq/n/+PMrvOZ7JQ /uRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=iXxYhOZovoVWD00T32nm/pWCIlnIIec23xpqqBb7OP8=; b=ah849aC4vK1nubdlHYuCsJkWIi2WNIRIkKkeMonYQv690kzstpedOl1W+j4RDSw2T7 5MNBvRnjSa6k8aDRbWq7UBjptgJ56EILAD/CjgHxXikTaVOgr3W8sJZXhdpqircxv3cW Kr/t2WYlWD7eK7WTF/vgtqQaXtnoqV7/7lfJkE+S3/CReEgpWs9FZi45KAjk1ELJUufR Ih6BZEsWPM9I+ER1Got7zWUUnJgshpIMvC0u+aKVWcv94kGjM2KjxiNIKjgRIcsBHS0n Qi2mFdQkDeFAf04ozSM9a4h6pHl83lM37cKaYsPjgX9g2cAHqAWpHHeun1RRz3MJ+vEa DvQQ== X-Gm-Message-State: AOAM532othtXHUmsLe6wjt0vyUux/wGeptTYpr4sSw5IgSIKCPpzr8Ci FmEhuJnwomgUJco6G1I17y8Z1WKr8z4= X-Google-Smtp-Source: ABdhPJxCKyS0qoxBqqvw0xi7MA3CIWjgtJ+YBiASZflnWHyLXbngv/djaDT6pjH7DZ5uEXvnwyHMWA== X-Received: by 2002:a2e:a374:0:b0:24b:4344:1440 with SMTP id i20-20020a2ea374000000b0024b43441440mr2042181ljn.380.1649332299951; Thu, 07 Apr 2022 04:51:39 -0700 (PDT) Received: from nergzd-desktop.localdomain ([194.39.226.133]) by smtp.gmail.com with ESMTPSA id i16-20020a198c50000000b0044a2580a2d3sm2143666lfj.156.2022.04.07.04.51.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Apr 2022 04:51:39 -0700 (PDT) From: Markuss Broks To: linux-kernel@vger.kernel.org Cc: phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, Markuss Broks , Pavel Machek , Rob Herring , Linus Walleij , Christophe JAILLET , linux-leds@vger.kernel.org, devicetree@vger.kernel.org Subject: [PATCH v3 1/2] dt-bindings: leds: convert ktd2692 bindings to yaml Date: Thu, 7 Apr 2022 14:51:24 +0300 Message-Id: <20220407115126.69293-2-markuss.broks@gmail.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220407115126.69293-1-markuss.broks@gmail.com> References: <20220407115126.69293-1-markuss.broks@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org This patch converts the leds-ktd2692.txt bindings to modern yaml style device-tree bindings. Signed-off-by: Markuss Broks --- .../bindings/leds/kinetic,ktd2692.yaml | 87 +++++++++++++++++++ .../devicetree/bindings/leds/leds-ktd2692.txt | 50 ----------- 2 files changed, 87 insertions(+), 50 deletions(-) create mode 100644 Documentation/devicetree/bindings/leds/kinetic,ktd2692.yaml delete mode 100644 Documentation/devicetree/bindings/leds/leds-ktd2692.txt diff --git a/Documentation/devicetree/bindings/leds/kinetic,ktd2692.yaml b/Documentation/devicetree/bindings/leds/kinetic,ktd2692.yaml new file mode 100644 index 000000000000..bac95a51afa1 --- /dev/null +++ b/Documentation/devicetree/bindings/leds/kinetic,ktd2692.yaml @@ -0,0 +1,87 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/leds/kinetic,ktd2692.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: KTD2692 Flash LED Driver from Kinetic Technologies + +maintainers: + - Markuss Broks + +description: | + KTD2692 is the ideal power solution for high-power flash LEDs. + It uses ExpressWire single-wire programming for maximum flexibility. + + The ExpressWire interface through CTRL pin can control LED on/off and + enable/disable the IC, Movie(max 1/3 of Flash current) / Flash mode current, + Flash timeout, LVP(low voltage protection). + + Also, When the AUX pin is pulled high while CTRL pin is high, + LED current will be ramped up to the flash-mode current level. + +properties: + compatible: + const: kinetic,ktd2692 + + ctrl-gpios: + maxItems: 1 + description: Specifier of the GPIO connected to CTRL pin. + + aux-gpios: + maxItems: 1 + description: Specifier of the GPIO connected to CTRL pin. + + vin-supply: + description: LED supply (2.7V to 5.5V). + + led: + type: object + $ref: common.yaml# + description: Properties for the LED. + properties: + function: true + color: true + flash-max-timeout-us: + description: Flash LED maximum timeout. + + led-max-microamp: + maximum: 300000 + description: Minimum Threshold for Timer protection + is defined internally (Maximum 300mA). + + flash-max-microamp: + maximum: 300000 + description: Flash LED maximum current + Formula - I(uA) = 15000000 / Rset. + + additionalProperties: false + +required: + - compatible + - ctrl-gpios + - led + +additionalProperties: false + +examples: + - | + #include + #include + + ktd2692 { + compatible = "kinetic,ktd2692"; + ctrl-gpios = <&gpc0 1 0>; + aux-gpios = <&gpc0 2 0>; + vin-supply = <&vbat>; + + led { + function = LED_FUNCTION_FLASH; + color = ; + flash-max-timeout-us = <250000>; + flash-max-microamp = <150000>; + led-max-microamp = <25000>; + }; + }; + +... diff --git a/Documentation/devicetree/bindings/leds/leds-ktd2692.txt b/Documentation/devicetree/bindings/leds/leds-ktd2692.txt deleted file mode 100644 index 853737452580..000000000000 --- a/Documentation/devicetree/bindings/leds/leds-ktd2692.txt +++ /dev/null @@ -1,50 +0,0 @@ -* Kinetic Technologies - KTD2692 Flash LED Driver - -KTD2692 is the ideal power solution for high-power flash LEDs. -It uses ExpressWire single-wire programming for maximum flexibility. - -The ExpressWire interface through CTRL pin can control LED on/off and -enable/disable the IC, Movie(max 1/3 of Flash current) / Flash mode current, -Flash timeout, LVP(low voltage protection). - -Also, When the AUX pin is pulled high while CTRL pin is high, -LED current will be ramped up to the flash-mode current level. - -Required properties: -- compatible : Should be "kinetic,ktd2692". -- ctrl-gpios : Specifier of the GPIO connected to CTRL pin. -- aux-gpios : Specifier of the GPIO connected to AUX pin. - -Optional properties: -- vin-supply : "vin" LED supply (2.7V to 5.5V). - See Documentation/devicetree/bindings/regulator/regulator.txt - -A discrete LED element connected to the device must be represented by a child -node - See Documentation/devicetree/bindings/leds/common.txt - -Required properties for flash LED child nodes: - See Documentation/devicetree/bindings/leds/common.txt -- led-max-microamp : Minimum Threshold for Timer protection - is defined internally (Maximum 300mA). -- flash-max-microamp : Flash LED maximum current - Formula : I(mA) = 15000 / Rset. -- flash-max-timeout-us : Flash LED maximum timeout. - -Optional properties for flash LED child nodes: -- label : See Documentation/devicetree/bindings/leds/common.txt - -Example: - -ktd2692 { - compatible = "kinetic,ktd2692"; - ctrl-gpios = <&gpc0 1 0>; - aux-gpios = <&gpc0 2 0>; - vin-supply = <&vbat>; - - flash-led { - label = "ktd2692-flash"; - led-max-microamp = <300000>; - flash-max-microamp = <1500000>; - flash-max-timeout-us = <1835000>; - }; -}; From patchwork Thu Apr 7 11:51:25 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Markuss Broks X-Patchwork-Id: 558639 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6723AC433EF for ; Thu, 7 Apr 2022 11:51:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245021AbiDGLxq (ORCPT ); Thu, 7 Apr 2022 07:53:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33994 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245008AbiDGLxp (ORCPT ); Thu, 7 Apr 2022 07:53:45 -0400 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [IPv6:2a00:1450:4864:20::135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 68ACA2364EB; Thu, 7 Apr 2022 04:51:45 -0700 (PDT) Received: by mail-lf1-x135.google.com with SMTP id x33so2725175lfu.1; Thu, 07 Apr 2022 04:51:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=kRv8uThwMjemCPH0U9dWg7Ga/t+oDd3aBEoB7wfTW1U=; b=e8tCwr77YvJqF7FoJIybsEy25RG/pfAVowZUzfc881Sk/yMJLDsR+7CzirdJFcwRtD Sp/Q3a30PzdphOy/3Ah+Re6Wzo+o13iItwUpjC+2prQW19JKNs9m+45co9ubbDqoZd++ uWHIS9VrmDEne4XlYygrdv6Cul23hGgFwTW/isFdj8gVOCkCPTSRKfWIwVlAnuXrMqrL 8DrnC8goGUqt8eUMoQNeBEc4ooGtg87e1rsWUATSkN0dWT/hv/mmIRT89sRWOV4r16VN ZD9sglGkr6VVHHZJc02RRuP6FSZBrE5nqmP7F2avG7LkCYhfIohMokF2Q5Uaqn7cR3pP u7XQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=kRv8uThwMjemCPH0U9dWg7Ga/t+oDd3aBEoB7wfTW1U=; b=mI0Bi85mXdu6bwXLGKU5lO8afNLVo5D4OE99r7JT72ZVHWpBPGiKg8OZIha5OGjMo9 moeu1K0iZ5nLXKjSREzCB4a5M/87juXVyG7CCLyjD+MxQNMtSgpo7Tjfq4KcrJW1BWz6 2levvr1e3KFqqb5iyuKo6gvfHGF2nz38fLLSsVtZWz6JMcGG0ZXk6WpXbFdPwV8NDKQn k61MKvGOGBAUIN+kwHjERDjGXPmdxYeGdFzNLvnT7FXnQQOOTxALS2CSrI7UMQFOL7fF yoKyEnqOg+Gc909CXI2KXilUzYfswKYAVtt1eAUfdrYcBcQd5FyebGM1wsX7T+ankBXI JKLQ== X-Gm-Message-State: AOAM533EWmVnNranfDrztelOpNSoTjr1Gd+ks79JvIhdT5o0LwvtOiCO jibnVsP5IHZ0CTJIxyikMr7bA2/tH1I= X-Google-Smtp-Source: ABdhPJwsnQgFOt+/HsuI52G0JTO0s6m2NWSDkgYAkdvr/Nj3kQNfmE8EVNYcGrUXfftrPoCABhVNZQ== X-Received: by 2002:a05:6512:e97:b0:464:f4dc:89f8 with SMTP id bi23-20020a0565120e9700b00464f4dc89f8mr1834802lfb.655.1649332303536; Thu, 07 Apr 2022 04:51:43 -0700 (PDT) Received: from nergzd-desktop.localdomain ([194.39.226.133]) by smtp.gmail.com with ESMTPSA id i16-20020a198c50000000b0044a2580a2d3sm2143666lfj.156.2022.04.07.04.51.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Apr 2022 04:51:43 -0700 (PDT) From: Markuss Broks To: linux-kernel@vger.kernel.org Cc: phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, Markuss Broks , Pavel Machek , Rob Herring , Linus Walleij , Christophe JAILLET , linux-leds@vger.kernel.org, devicetree@vger.kernel.org Subject: [PATCH v3 2/2] leds: ktd2692: Make aux-gpios optional Date: Thu, 7 Apr 2022 14:51:25 +0300 Message-Id: <20220407115126.69293-3-markuss.broks@gmail.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220407115126.69293-1-markuss.broks@gmail.com> References: <20220407115126.69293-1-markuss.broks@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org Make the AUX pin optional, since it isn't a core part of functionality, and the device is designed to be operational with only one CTRL pin. Also pick up maintainership for the LED driver and the yaml bindings. Signed-off-by: Markuss Broks --- MAINTAINERS | 6 ++++++ drivers/leds/flash/leds-ktd2692.c | 16 ++++++++++------ 2 files changed, 16 insertions(+), 6 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 2db49ea7ae55..8ef5667a1d98 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -10479,6 +10479,12 @@ S: Maintained F: Documentation/devicetree/bindings/leds/backlight/kinetic,ktd253.yaml F: drivers/video/backlight/ktd253-backlight.c +KTD2692 FLASH LED DRIVER +M: Markuss Broks +S: Maintained +F: Documentation/devicetree/bindings/leds/backlight/kinetic,ktd2692.yaml +F: drivers/leds/flash/leds-ktd2692.yaml + KTEST M: Steven Rostedt M: John Hawley diff --git a/drivers/leds/flash/leds-ktd2692.c b/drivers/leds/flash/leds-ktd2692.c index f341da1503a4..bfbe1d5f7b8e 100644 --- a/drivers/leds/flash/leds-ktd2692.c +++ b/drivers/leds/flash/leds-ktd2692.c @@ -163,7 +163,8 @@ static int ktd2692_led_brightness_set(struct led_classdev *led_cdev, if (brightness == LED_OFF) { led->mode = KTD2692_MODE_DISABLE; - gpiod_direction_output(led->aux_gpio, KTD2692_LOW); + if (led->aux_gpio) + gpiod_direction_output(led->aux_gpio, KTD2692_LOW); } else { ktd2692_expresswire_write(led, brightness | KTD2692_REG_MOVIE_CURRENT_BASE); @@ -191,10 +192,12 @@ static int ktd2692_led_flash_strobe_set(struct led_classdev_flash *fled_cdev, | KTD2692_REG_FLASH_TIMEOUT_BASE); led->mode = KTD2692_MODE_FLASH; - gpiod_direction_output(led->aux_gpio, KTD2692_HIGH); + if (led->aux_gpio) + gpiod_direction_output(led->aux_gpio, KTD2692_HIGH); } else { led->mode = KTD2692_MODE_DISABLE; - gpiod_direction_output(led->aux_gpio, KTD2692_LOW); + if (led->aux_gpio) + gpiod_direction_output(led->aux_gpio, KTD2692_LOW); } ktd2692_expresswire_write(led, led->mode | KTD2692_REG_MODE_BASE); @@ -248,7 +251,8 @@ static void ktd2692_setup(struct ktd2692_context *led) { led->mode = KTD2692_MODE_DISABLE; ktd2692_expresswire_reset(led); - gpiod_direction_output(led->aux_gpio, KTD2692_LOW); + if (led->aux_gpio) + gpiod_direction_output(led->aux_gpio, KTD2692_LOW); ktd2692_expresswire_write(led, (KTD2692_MM_MIN_CURR_THRESHOLD_SCALE - 1) | KTD2692_REG_MM_MIN_CURR_THRESHOLD_BASE); @@ -287,8 +291,8 @@ static int ktd2692_parse_dt(struct ktd2692_context *led, struct device *dev, led->aux_gpio = devm_gpiod_get(dev, "aux", GPIOD_ASIS); ret = PTR_ERR_OR_ZERO(led->aux_gpio); if (ret) { - dev_err(dev, "cannot get aux-gpios %d\n", ret); - return ret; + dev_info(dev, "aux-gpios not available, flash mode current might be reduced\n"); + led->aux_gpio = NULL; } led->regulator = devm_regulator_get(dev, "vin");