From patchwork Tue Apr 12 08:54:26 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 559981 Delivered-To: patch@linaro.org Received: by 2002:a05:7000:6886:0:0:0:0 with SMTP id m6csp3210745map; Tue, 12 Apr 2022 01:56:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxnp4k9WuhBEb2DS/i/C260v/K7XnDi3gfq/SY3C3TyHwTPqpVPPZie0gEK0o9jN1zEdfw2 X-Received: by 2002:a05:6214:e82:b0:441:3231:4bce with SMTP id hf2-20020a0562140e8200b0044132314bcemr2689696qvb.89.1649753816419; Tue, 12 Apr 2022 01:56:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649753816; cv=none; d=google.com; s=arc-20160816; b=zB5+kQW9jnsll+U72FKZxtEXiKXlrn+nefsygh8HTs5+btnVo4tFoSdf6DFdKuZRdj nIMpza7s+1YXDvrWNNygFFfOw2umT/PPsRN1QwUMY6LojCExcvCM5EnMAeEbQb0VkQGz hUV+3xrqMrWQVgwZqlczSSjOPN2wAyFBO9SocsFjVIGYA9xPvIws451QgOMAFXUeY6lA yydVE1o5cWwHnG/VDwQH4rAwBgXtjYba1LJOuIcCV3aOoO7ol7Of9UlqvaGY/6LQoCY5 SXmEaDFt6IvpgOK5XuLZ/yQ9Cjm8k9JfW8gK74COhQaS9a+AT/p6G3pOdChPDBNtGjBX SXgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:message-id:date:subject:to:from:dkim-signature; bh=7IxBAb0CB9yBD91NLQnjbzmPApzLPhxC8VwvuJrZz1I=; b=bZhEZB9wynQaYDIBw5xVxOyDa44rYdbGkjMA/rjDUpq2IlotKqxR4QF6RlMm2MAVsO FakbM6Jw/AHfQFp9Sk6KBec8T/0qcGV08VkBAu/QUaKY66McyIFFaMKFDHERsTtMBuyf YLRBPB7JgsEueW8oQOQNHGunTjIFdfp62HQ/+AJ1UDwkTkxTu5CbwzuPI3d/bqlIRq2i 3/CUwXNxC0470b50B0p4oCw7a+6QlperLXKAdJZ7YgLMeRklAQ5/Y74EgEFUZCSYTwl/ jg0s76ZZmOjwyQ6hf1F4lFnh7tIFYulCO5Toy211PvClD882X9Y6JP8MsjeHh995wnes xIrQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=RA2BioZS; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id hr10-20020a05621423ca00b00443f251fa56si5503067qvb.244.2022.04.12.01.56.56 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 12 Apr 2022 01:56:56 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=RA2BioZS; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:33012 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1neCKW-0005TR-1s for patch@linaro.org; Tue, 12 Apr 2022 04:56:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45602) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1neCIF-0005Sw-BH for qemu-devel@nongnu.org; Tue, 12 Apr 2022 04:54:36 -0400 Received: from mail-ed1-x52f.google.com ([2a00:1450:4864:20::52f]:36657) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1neCIC-00069q-Kl for qemu-devel@nongnu.org; Tue, 12 Apr 2022 04:54:34 -0400 Received: by mail-ed1-x52f.google.com with SMTP id u18so10828217eda.3 for ; Tue, 12 Apr 2022 01:54:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=7IxBAb0CB9yBD91NLQnjbzmPApzLPhxC8VwvuJrZz1I=; b=RA2BioZSgtHLWyGd7Qm71LkdAlOqa88svmERnl5qC2EVHTYNqRcnw9SWYKOsgluAvc VBcKKf/bB9xuASApHw0makAtDwfK0Ngc0YSZUmWRMQhhqVbLGv9O0Jjs0WIW84qDMVbH o0OfNSx+2RPFf1kbYgXedDzOoEUnvP5v9cAsNMd78JN2pSgkYVUKiaboIo+TjBjFfTET avLkVa+hdIEZaIGezD/F8s5xnAnvdu92N5k9/hLHwM13hwjlOavoigAsHBlBQ7+vJQlb uhoe4YfegSYqEZ4oO03GsLRQg8ujPyy/q36f0H+A6HIzUztHsbpgaCQ+C9NlfyYYyFhb dVhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=7IxBAb0CB9yBD91NLQnjbzmPApzLPhxC8VwvuJrZz1I=; b=icvtm8vZN2TZACuX/QMadNthbLQ1BAqqSZyaZ3GZpxY/JSR3pFWr5HaeSvsCX8sy8t KvV43+uA4j+n3HhfEX0C8x/fmLwKMw6n2yFLp56x4Roy7VVwqP4xG8x3gY2m7RfBOYBP 5UeidZC+PswPvc7PFtcqOpvnmlTZeepFmoyztXAjeMPYUtfZVSjAQUsP/xtkfMKNFkwT MZWTYUCZbt2x09G8S8540wfieYMv92YJxxZK4IC7FzWtswuG604RPHf/JFmaU3+ER1JY 1F8ljk90g1pRg575xapCJBohk13ilHEE3qf4IXgRAjNGcxUDhyjBPAduA5S4PkA9tyE6 p7yA== X-Gm-Message-State: AOAM530kPC+pTpdMjiRWul3ic6NtJkzSxTn8OvZGgt7NADAWAbfggbn1 wD3Ir1yUHTdoOsIJNV5MEbuNpw== X-Received: by 2002:a05:6402:42d4:b0:416:5cac:a9a0 with SMTP id i20-20020a05640242d400b004165caca9a0mr38439177edc.86.1649753671157; Tue, 12 Apr 2022 01:54:31 -0700 (PDT) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id a1-20020a1709063e8100b006ce06ed8aa7sm13024936ejj.142.2022.04.12.01.54.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Apr 2022 01:54:30 -0700 (PDT) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 74D561FFB7; Tue, 12 Apr 2022 09:54:29 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Subject: [RFC PATCH] target/i386: fix byte swap issue with XMM register access Date: Tue, 12 Apr 2022 09:54:26 +0100 Message-Id: <20220412085426.148191-1-alex.bennee@linaro.org> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::52f; envelope-from=alex.bennee@linaro.org; helo=mail-ed1-x52f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: pbonzini@redhat.com, =?utf-8?q?Alex_Benn=C3=A9e?= , qemu-stable@nongnu.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" During the conversion to the gdb_get_reg128 helpers the high and low parts of the XMM register where inadvertently swapped. This causes reads of the register to report the incorrect value to gdb. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/971 Fixes: b7b8756a9c (target/i386: use gdb_get_reg helpers) Signed-off-by: Alex Bennée Cc: qemu-stable@nongnu.org Reviewed-by: Richard Henderson --- target/i386/gdbstub.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/i386/gdbstub.c b/target/i386/gdbstub.c index 098a2ad15a..c3a2cf6f28 100644 --- a/target/i386/gdbstub.c +++ b/target/i386/gdbstub.c @@ -129,8 +129,8 @@ int x86_cpu_gdb_read_register(CPUState *cs, GByteArray *mem_buf, int n) n -= IDX_XMM_REGS; if (n < CPU_NB_REGS32 || TARGET_LONG_BITS == 64) { return gdb_get_reg128(mem_buf, - env->xmm_regs[n].ZMM_Q(0), - env->xmm_regs[n].ZMM_Q(1)); + env->xmm_regs[n].ZMM_Q(1), + env->xmm_regs[n].ZMM_Q(0)); } } else { switch (n) {