From patchwork Thu Apr 28 06:24:27 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Gortmaker X-Patchwork-Id: 567218 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1933DC433F5 for ; Thu, 28 Apr 2022 06:25:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243761AbiD1G23 (ORCPT ); Thu, 28 Apr 2022 02:28:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40906 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243751AbiD1G21 (ORCPT ); Thu, 28 Apr 2022 02:28:27 -0400 Received: from mx0a-0064b401.pphosted.com (mx0a-0064b401.pphosted.com [205.220.166.238]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 074067521A; Wed, 27 Apr 2022 23:25:10 -0700 (PDT) Received: from pps.filterd (m0250809.ppops.net [127.0.0.1]) by mx0a-0064b401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 23S6HAJf019758; Wed, 27 Apr 2022 23:24:59 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=windriver.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : content-type : mime-version; s=PPS06212021; bh=jcM04rkaaZDza5PLVUxfFVHLWveiakrCUOr8eW3fUmM=; b=ZkshTkgEqyIKI4vSitEbjXRf9fdBXrAJOxfyF1N5qJ1alUugMbXn0lLs0Pho1CofcgLt Z3tel5MBv4Ew3mulMJAN+GdatUjKbs0/LbP4L16DmyXSdgnlVqyRW+UlJOFP8qZ1Q2sa ordECR1jHzuSfFBps9N7RhJi0uN1LUQBdRFKrm8nSUICZprQ82ebnEtfVvLBQBjY0J2N hr6eUCh+hTmIDnUjgwgfw1H1l+KQLdA9IMA0Z6HgpcGC7Z9Tag/1cUcHhDcOmk8c9vjX Q2Sgdle4+wn+NyUHFotsmRBdxCBudWSLfkXdT3t1U4NUMMbbHqj4NqYTNul5w3mTC57l RA== Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2170.outbound.protection.outlook.com [104.47.55.170]) by mx0a-0064b401.pphosted.com (PPS) with ESMTPS id 3fps57s3ua-3 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 27 Apr 2022 23:24:58 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=R+3+nRlIudDdM3XAX2dnuZqvMGBpJ7JdHDz89w/fCx9I0hgR/45RcmO85Jrlfkr7edvRpaM2iW2LXF9dQMEtqDiRGeySkJn/4rj9d61Pb+G7QbXe0d3V8cCwZtmaa/N40n8DNUDL1cBmDFt54UEtDys040wxy7MI1I03OYWY8ipCs3dlPpMjcA2Bj0EZP+ltaCeZqFX7HHB91GI9NeWraKMnzVFtsC/TILu9LW8+ck938wWpARFWXrHAE23K1u0BT+Ub5LaxgHo9aC8Oaos6ibJPOG38A5Z5eXjq0pyHB9SPSJKog1mxrhsT26AfpLJXe+X6zQBwcGzrtPep4vMOLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jcM04rkaaZDza5PLVUxfFVHLWveiakrCUOr8eW3fUmM=; b=HTtphQVahofc5tijehlqp7MPsSrJ7tJUQJkMbEtnlLq0+gdqDJr4hlzujkdB09pxz3LoLW3euS6rAUM1uMTXgeL/cAGz/HpwitvuYfmGaFLYdKhecGjrhCSA5phBPceSmudSodOpf9bdPb2G4HVu6n2+NwIB7qhrhjXxk/f3arcujN+wha7MUwnMax1ceOZg90GNkmmbyxnAX1LEej2j0XdPx6Jf2BRNt7bPKcljmGE0A2YtXgbkiz+H5gdJSb1OKeY2a0iCQvO4KyXyrUj1hB3KFXW032gEDXrUR4KyizDrC47V/u55mhUNnRPRxv6xg7qmkXI0Jfma9Xgwux6fxw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=windriver.com; dmarc=pass action=none header.from=windriver.com; dkim=pass header.d=windriver.com; arc=none Received: from DM6PR11MB4545.namprd11.prod.outlook.com (2603:10b6:5:2ae::14) by SA2PR11MB4921.namprd11.prod.outlook.com (2603:10b6:806:115::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Thu, 28 Apr 2022 06:24:48 +0000 Received: from DM6PR11MB4545.namprd11.prod.outlook.com ([fe80::89e0:ae63:8b71:4a0f]) by DM6PR11MB4545.namprd11.prod.outlook.com ([fe80::89e0:ae63:8b71:4a0f%5]) with mapi id 15.20.5186.021; Thu, 28 Apr 2022 06:24:48 +0000 From: Paul Gortmaker To: linux-kernel@vger.kernel.org Cc: Andy Shevchenko , Aubrey Li , Hans de Goede , Len Brown , linux-acpi@vger.kernel.org, Mark Gross , platform-driver-x86@vger.kernel.org, "Rafael J. Wysocki" , Paul Gortmaker Subject: [PATCH 1/4] platform/x86: pmc_atom: remove unused pmc_atom_write() Date: Thu, 28 Apr 2022 02:24:27 -0400 Message-Id: <20220428062430.31010-2-paul.gortmaker@windriver.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220428062430.31010-1-paul.gortmaker@windriver.com> References: <20220428062430.31010-1-paul.gortmaker@windriver.com> X-ClientProxiedBy: YT3PR01CA0005.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:86::25) To DM6PR11MB4545.namprd11.prod.outlook.com (2603:10b6:5:2ae::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f8558d4c-68fa-4ed6-6f98-08da28dfcb7e X-MS-TrafficTypeDiagnostic: SA2PR11MB4921:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: e+ohchjzLxyQjVSZb+82Fj3JaByySPZ4sy9mec+SB4OaQHt3UQfgGpqv410k1OQs6M/yqo1xPbr3zu6XAZlC+ryAC46070Qu9P1S1zhmcK1psIsNqeaU1/u5etZxDDDXFa1hrJNc/oh5625FlQ5StO/7kQQeqPdw/wmSpDAaqwljO33xVOs+VqhIQgoj8YozpIyPw1zG44wgM4hp3OH8o+D5wIq+TdCJcXIopILR1MtwHkVIq8ZO/XcQ1lh7xyB9VNAUAd3KfDxvfFXFIkM37YL9qs5xUGLOTlwR6xnM0LbpaWCSEv2zF3ML8M0XmdygB4vFoSkxfFUAp1JxAiIwu6SdZjDCEio65f/FnrHd+3eCG6Yp49LhrpNAeWzjRyFNjZbCAv6KKUI2fYKyDLQkpKvLlxIbNOUdGMS9rEUVCu3Tu0cC7K9C857Y8TZYpVyXUaKA29VQDxuABnBO8WPl9JLONFpXJ8/uR1Ois07sCndihyLPsMqYp0SS+hsZg9n1Eb0bEALw12c0vWJ28oI/HPor2bHS08wEyDStdac6YcW1Tax1dqzxVJIXrIGK3fLJp6mjqlQV4Ua+2sLfV9BWhzUcluhmh+ayf1SqhnVj0VtWyco7KzaASxQhnJdpKiGEBTs49b0yB3oCbAtjxuMNx2WL8l+fY/nlxrDBSB9YZMIfP4N6xzFm/FKyORknHQoA X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB4545.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(66946007)(107886003)(2906002)(44832011)(508600001)(5660300002)(38350700002)(38100700002)(6486002)(8936002)(54906003)(6916009)(1076003)(66556008)(8676002)(4326008)(36756003)(316002)(2616005)(186003)(66476007)(52116002)(86362001)(6666004)(6506007)(26005)(83380400001)(6512007); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: H+M0NarkTARysmqLrEsEjCbJaXif7PssWkdfzlEM6GaBdqYuZCyLv/O3+wYKfWQ37BL6Q/rqPCGJ4OYNPmNjop5+glikd/inzEmc9ojFIgGGU9yzA0TH8LFrj7eGp3IT7DoziEnhj6ccqI7zb2fS6eIOMhloTuSJXk+5aT40t5p41MnHw8UGOL1VkPizYL7uBYyia6r4rlXe7sPxoFKdYwAaMimJj+bU12JRoAHkeFBxRTVusDPZYfGRPay7dFp7JOuYVz/dwsFl4huiKWGOF4PtU65TiD+4QwZJdgjr0uxQNqh3uEdVFB32p8RyuxIM87NlWPkKPyQJKqZn6/4vkcSk7OYuN9BPuVdSKG8jCGRp4F9AfWTBMXtl5vECTnXRcI4+CcAxDPxVlV24Pl8WJACbKbGnWWqdww+SJVmgmnpAOwXLFByJrnVCpD5hU8yBqCDHkeHZiq3O8GJndQ8DM5r8Lo7nxkJ4HX/EgiE521xfzQ+2+rfQGttKiNh0UZ8GOD0LnLxMOT/xHK7n/H16d5QBCZHGvz1PhsBaXoSpU41TY/d7BqP3KOlIHoEF2GfyCtfoCpsqdUpjeyMNQhgHioNMj1fNJxyC0bc4Z/YX19CGguYLk1b34TwEfTSHyOj98Qb/IjlP0iyx1a3e0gPm1lig3QmjnowP2WQmNWK2/qRPzBUH5IRJfTTxmWIqGv1uvxv2Gf/hF3BZXUyXp7QZOBJbxv7xEs4DJYqsNYz7LiTMl96uMvmhMAyAKQnfS7ZWHQ9JwRhkgaH74cjCIDMxVkTE6FeTeJEMvRyw+0uanSjtBkdTUqiV+vL7snkeA8nlZ9HP+RukY6F54Vj5DrOl14cyiBAGuPJYfRTdcWtKrpyIEbrSiThWhbRVLz+1FkIuHQasxRtofOmYRurTQBcXhT6fBAYBwd4BUwRmb+4aejAJV9Jer57qvDHGbelPHY06kye0TxwQ9pMeMGg29kL+KVesS5wE/bl4uI51kfVBTn4/q/3W8bepG+fU+mAwRRtbT9FpsNZwC0DDUwTHk7KgYk9r0x7AxIvX4eQYqtyF6isTjNQ7TrYSTMJTF76sf2lxuTiRpXDaoye4/7tLXRco+AT/yT8/gH/OUwNzol0K/TDgB4BYjpSfqkDQ9h0IZURhx8vT8Ypa8ZK+Kbi1FwCYej1Dfag/vqh37tMOfS2nKMQd0BzW5oEG8ctUQgkaDX1NuRd7udQ4ScMailmg11xDIBdV/baexOnfC7Jb+UGu0pwMdAVmnLMtE/Dq3lKO52IP8DNTUtUhz4p8Fp1qeXireEiAMnGgzGVCIFoZqAncLJdFyYNFrRDsR1iYpv3uR8GSMTUUnX5EECOrlbZsllvCKaw0v2ei1PrWKzmwMXvemrmLjr3tdqAGG7xh4++f3kScEqhxiAneb34sNcFAC2UWY+LgCgTReeI0AlDU7fc6wNZ5r0pKGx9SUZkkWfLl9qSnvDwDSvN3p4FrIfUrJeE/W1bjPTyRj4IMRxDO3KGR7Duv+hxpf5Gdhy0bhbpW0IdAB6TX7yf8OcLUwf5eAED771P+R3emb+TEa8GXwrTw4ZGLZpymqgBXYrT8uGeqp3fWwTPFSClId5JnH+5T+q5he/JJhQx5fq5QvEYng4SJIi55Rt+kO8bmsTHkMTqYmy/zRU1nva8tlw0HdvVkH0o/KsBwf00W1ebsMsgN9MXqSyJCBGMaauvkATTZCVImNF3AwzKwu+o+p8esVVfRmO0zDmDKpEXAORFacrn3qh0H8Gc= X-OriginatorOrg: windriver.com X-MS-Exchange-CrossTenant-Network-Message-Id: f8558d4c-68fa-4ed6-6f98-08da28dfcb7e X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4545.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Apr 2022 06:24:48.4475 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8ddb2873-a1ad-4a18-ae4e-4644631433be X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0dDa8S+9Z58AamKBbfzKE0mqzjyxE25AAGM4LkmFEGdXHNmgE8vR3qNmwIU6hsoPKhXXXedcDeTxPbZukSywNuHiqkwDu/NYOTELl6kpmeA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4921 X-Proofpoint-GUID: HI9GPboFp3qO_ZcRGMmbJEtDVdytcmF5 X-Proofpoint-ORIG-GUID: HI9GPboFp3qO_ZcRGMmbJEtDVdytcmF5 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.858,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-04-27_04,2022-04-27_01,2022-02-23_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 spamscore=0 priorityscore=1501 lowpriorityscore=0 impostorscore=0 phishscore=0 mlxlogscore=908 malwarescore=0 clxscore=1015 adultscore=0 bulkscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2204280037 Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org This function isn't used anywhere in the driver or anywhere in tree. So remove it. It can always be re-added if/when a use arises. Cc: Andy Shevchenko Cc: Aubrey Li Cc: Hans de Goede Cc: Mark Gross Cc: platform-driver-x86@vger.kernel.org Signed-off-by: Paul Gortmaker --- drivers/platform/x86/pmc_atom.c | 12 ------------ include/linux/platform_data/x86/pmc_atom.h | 1 - 2 files changed, 13 deletions(-) diff --git a/drivers/platform/x86/pmc_atom.c b/drivers/platform/x86/pmc_atom.c index a40fae6edc84..31cf25d25d66 100644 --- a/drivers/platform/x86/pmc_atom.c +++ b/drivers/platform/x86/pmc_atom.c @@ -223,18 +223,6 @@ int pmc_atom_read(int offset, u32 *value) } EXPORT_SYMBOL_GPL(pmc_atom_read); -int pmc_atom_write(int offset, u32 value) -{ - struct pmc_dev *pmc = &pmc_device; - - if (!pmc->init) - return -ENODEV; - - pmc_reg_write(pmc, offset, value); - return 0; -} -EXPORT_SYMBOL_GPL(pmc_atom_write); - static void pmc_power_off(void) { u16 pm1_cnt_port; diff --git a/include/linux/platform_data/x86/pmc_atom.h b/include/linux/platform_data/x86/pmc_atom.h index 022bcea9edec..6807839c718b 100644 --- a/include/linux/platform_data/x86/pmc_atom.h +++ b/include/linux/platform_data/x86/pmc_atom.h @@ -144,6 +144,5 @@ #define SLEEP_ENABLE 0x2000 extern int pmc_atom_read(int offset, u32 *value); -extern int pmc_atom_write(int offset, u32 value); #endif /* PMC_ATOM_H */ From patchwork Thu Apr 28 06:24:28 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Gortmaker X-Patchwork-Id: 567523 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DCC4C433F5 for ; Thu, 28 Apr 2022 06:26:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243818AbiD1G3e (ORCPT ); Thu, 28 Apr 2022 02:29:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43232 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244321AbiD1G3W (ORCPT ); Thu, 28 Apr 2022 02:29:22 -0400 Received: from mx0a-0064b401.pphosted.com (mx0a-0064b401.pphosted.com [205.220.166.238]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1A6BE38BF2; Wed, 27 Apr 2022 23:26:08 -0700 (PDT) Received: from pps.filterd (m0250809.ppops.net [127.0.0.1]) by mx0a-0064b401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 23S6HAJd019758; Wed, 27 Apr 2022 23:24:56 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=windriver.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : content-type : mime-version; s=PPS06212021; bh=0jQtq33KfQX1v/IaxLPVsRa4+qmo6hzUgfj9a6njTsw=; b=lcndo2FGg66q4dgWlKgy26CTGEBLPdL06myB4iI0OBhVuNR53uZbBtb29m+9kTt09MWw 3glueByJ5yJvccr+WgFTFYkabkv5fVAsEIrLZMisqPxVyfcabEgdhsDgnh9kiKiZ8h8D n9DpYPJ9xt7DM6FMFMnMPNagczuPSFjdYcTEPkxxmnmIlSqOFRcnj+GTal76xxdiva1S kMdBeZQ6TPhuaa0LyFfFBTATNh+xH8g/YnSVmWM7wM7mw+m+GtSR8nDBFNTCyZ85VXkq 7FriE7c+rmUoGO5koyrV3HblxgnxcCophFMRPF37sftJylHaKfEC8qKa2FCrZ3Shtx/3 Cw== Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2170.outbound.protection.outlook.com [104.47.55.170]) by mx0a-0064b401.pphosted.com (PPS) with ESMTPS id 3fps57s3ua-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 27 Apr 2022 23:24:51 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=i4HribPAVUkcxg7PA57rplFQ48iBMF83bos3LwwYahFCLokghIGDQ6ZSOtBU/dYme6/HILEUs96ChyecXivDWhWV5IJdxdNHAH1LRCKRDvsVBDyhkzIn8fb3mHdHT9lkfHv3vRbhVhPDEIyfdf6bqB5uuJP0DORW0gm8HnvISR3v8YuRJxjgtlY9LfRtvfdu+OjSBVaxO5hBodc0QJZD8VDtS/i7OqUWowA3A/FTu6UrKhNWORJJmAXT72tanVIEtZRPx8TA4+TppxFOaaT1FWeBmWxTBkeqec58sD4v9ln5bzB1UDXPN8H6AP07jwogS/QuhngGfE2Np1q3GkGoWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0jQtq33KfQX1v/IaxLPVsRa4+qmo6hzUgfj9a6njTsw=; b=kPQQbtycD83xpuF4wGAn7AwTZWE+FclC5/5T4D2SsopJAUZhVLK4RSVOYUXC3p1C4/7gZEq5p3DPtSW6rjdOwgfDvo5gywnbAcrN37oBuehal9IKwzjn7OIWIN8e/jXiE8Tr6EFpfq5+eMpi1kMem9JyIkl1nP6TwPRc/QlKIMq/B7M2NO2l495VjgCZbxUar201ubHJRvMoj/C7c3oTbwag1mVCnAWul7pYQugttmmNoeBBNAF6hgdFjjM1lDIM15dXotQF6mzQ9TPinhnUcuftZX/VK1kG1VG8h2HHunXAfHCJ+5O5wq35ED6FuScwfadKVdrVY+nRfm0E36WLBw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=windriver.com; dmarc=pass action=none header.from=windriver.com; dkim=pass header.d=windriver.com; arc=none Received: from DM6PR11MB4545.namprd11.prod.outlook.com (2603:10b6:5:2ae::14) by SA2PR11MB4921.namprd11.prod.outlook.com (2603:10b6:806:115::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Thu, 28 Apr 2022 06:24:49 +0000 Received: from DM6PR11MB4545.namprd11.prod.outlook.com ([fe80::89e0:ae63:8b71:4a0f]) by DM6PR11MB4545.namprd11.prod.outlook.com ([fe80::89e0:ae63:8b71:4a0f%5]) with mapi id 15.20.5186.021; Thu, 28 Apr 2022 06:24:49 +0000 From: Paul Gortmaker To: linux-kernel@vger.kernel.org Cc: Andy Shevchenko , Aubrey Li , Hans de Goede , Len Brown , linux-acpi@vger.kernel.org, Mark Gross , platform-driver-x86@vger.kernel.org, "Rafael J. Wysocki" , Paul Gortmaker Subject: [PATCH 2/4] ACPI: LPSS: make the Kconfig dependency on PMC_ATOM explicit Date: Thu, 28 Apr 2022 02:24:28 -0400 Message-Id: <20220428062430.31010-3-paul.gortmaker@windriver.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220428062430.31010-1-paul.gortmaker@windriver.com> References: <20220428062430.31010-1-paul.gortmaker@windriver.com> X-ClientProxiedBy: YT3PR01CA0005.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:86::25) To DM6PR11MB4545.namprd11.prod.outlook.com (2603:10b6:5:2ae::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 94edcd59-b85e-4e59-8dad-08da28dfcbe2 X-MS-TrafficTypeDiagnostic: SA2PR11MB4921:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mv8RWBwQScJO0IW5ZRpZFp6CXf/sXBaFcy3Sb7XZLUWWiWW0TXpR4tFvLKeG7WkBiRF8lHX/qavJuv4cA/I+YTqf1Y8eEA6QiBdNfMomaRkbZ8WusrO/t3VYXBhy5AQAN/EVdOEPCrfp6/vc0yuW9pR8XxPAvSQbN96yTMWiwFLmDloMR5TaPz7Ky6Bc+WHnV+jyfsGtremT6I2fRY5ETCwRpH9F7ba4qsHelaW5RrfmRsIaUE/HUnDfRumujltCgGwBr2fK3GUkh7Sc18XeSjz7/ylUGo2XD3dQ9E7AB6FT7b9Pz7FxUNbdqBLTttWyZ+lO9QxN92sGFjlthj9sWscswPgAM0LVZQojTp0g1JITnGzQW8OPQIfZGIGy2ZdGROmzUn6nyfbQZrxAGMplxLiTdsar1KdijAK7/Gt6YHkHCICPXJMIfsqPsizj8X2uMJwIMhLIhpybqa/o0r4J6TH4C9/RWHZ/yO03pHRqEWfEHoqP5/mYiu3l81YAHVQ0oGKQUdWyLuX6J6XZ/kEYIN9D4aK65qyiXkUtCOwanJu75HSOapAk+AEcwRiGO++0KeaazukqVvbN+/q8SBXXUiV+v5W7EMywFoD55HwiythHT84Sy9C/eQ+dIaepP2EKT+f/a/faER/t81f500NBm5LLtXiuJlzPcaZt7vhB/5c6TLMDO5SoMZtO/Ov7l8kISu2Ldx/oSBxhmsvfu9QvFw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB4545.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(66946007)(107886003)(2906002)(44832011)(508600001)(5660300002)(38350700002)(38100700002)(6486002)(8936002)(54906003)(6916009)(1076003)(66556008)(8676002)(4326008)(36756003)(316002)(2616005)(186003)(66476007)(52116002)(86362001)(6666004)(6506007)(26005)(6512007); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 4yc6wk7pUPvpUYbMSFQq6wZWCXHEA+2+O6RWMEXPc6eC1LP5jpy58S0+LbnalCu0ny3l4VF8kfO8fqA9TzQSgxMiWDHKKqQ2fpTo02R2Mu/8jFBgX60CeXBkwx7UMEHqeYxGUugpPqT8VnSdRkGVFCm0EvpLuFgNG+xBNqs9hTsVpeK5wEnSPxxSP5XVBRIkHgwa70szCbPY7U3VSnu2fyaCmhEkT9Xddl1YFZ2laH/cOawGbWVDt7PKqIRofIgQQnlS7fmoqinCyqKkYrk21engEjdSe+EOLkexkxqwS0PY3fq8mFl3cxyR49qe1B3DykvO96EII0ecbW+cVUZBfCEoPg4hYKP/t5ziQ3wjQCjNRGDpwzYGzCRl98BE1qXkSaPWZHFMZ7zviCGb0nxnYG0D+FuWP8VFOSaRgE7hfoiglSHX3+8tNrbnKLBrZ9mEmlSrE0/Myk5wxlwDeiknx3IhkEkUmlApIqhY1JWdPLhiVWVgcOlXbp3xZWuMBqp+1N2DmkPyurxc3KjnWKa3U6xSn7GJfLc2mh3QrHFGdMZ/DcLQtKP2k4yONaup0cKM55q/QHhyuGuLXWyIfY9rop+0HlYW3AZKZQrCLJ/Liasy4yUdRG8fpDwwkK+r9/s/rp61nXSNN90RM0GeggrPaIJp3Fbo4zKYZ91T29bAZd95+2zjSLJ7xFiy+URW8q9nbYld6XemPN8wXv4YgcXPWwnC7ysgl8nfStZRa0iLj15Y6ozQXgtUAtb00fWVN9e9p5p9Asm7mwSfZ8bjAvCnfpaBPDp1T4Oc5YDbBRDq95hG17W5+kTpx77YhTqTiwHkkGrKhmPJhdu5K1w5u7+6cfuMjhAu3aNOCzuna+FqEstos/J1AQDOZzujGjIho0K5lxOZQt7fTRgO9rmnP+sMhIBcRgD7QvCT+x6BKlk6O9qjng3kxAOW7s7+SqHlaB0kDlLt2hiBBJfRCgZC5dpDcEKY5/DOLEo5K1lOSKF6yISha6dg06JJW2RFETqr7QmArG1zI4KZodBS5NuP5GMHN1PParErlLK0CO3haveoXw6jrli6xDg5EU8eUXnFTNLeZolY+sYInwImCs04/0KikpV+8MYNbrfHB53BZhLOserzsqxDH5JxMGNd8Xzm6LZLxOuiuuQDq+tf+oR7gvzr6XDIJSj3E9Vgvfan6Tj6yptIt3jj1R1m1vsFWbZFNhMVRLPALIHLvnVFBVD1GKoKspSyaEje2nmilVGEcWgslWXSfsaX90I5UQCOnrFAY6zAgJ9zhIyfjqTJ0J+Q+My69p/S1o14j8bY7judshDe5RvZk5Dd01azm/e319myrJz+cuyScheCmv0RMREMtEHVpyY28W59NyWkt7zD8jf2AlEkX+/crfHMhEXvqAGEegbMTg6Cgk7LIr1+4oIczeVSGM/qKGOY7PZdnlb/VWDZgA+2uRSMBdqTOWeCEYIQYNXnG1FSTS7AIBv8z1xFvWnltD18sfW0W0jx2xKdly7lcJlMen2PjuknEGcMduw8ce/eeyiOekz+OHfS1vNV5c6PplmT7mI9E1kO+cd4bXMJJlhj9FYEop5JOx11anLylVXof0LV72wZ0OIjYVWCM7/UQ8g/CJAs9gfyM+mc2cvI0NbcTK7lofycoI5HNEplYWgqO6sj0FtnD1vgb/t/9WbxYZp6ZDJTk24RRKKTDMdpsk3EqptJ7Gj/bbxd8g23c4l8ablFMcDM+a22VGPnUL2B8i30kLAqcaejv0pu4QWRgnQ= X-OriginatorOrg: windriver.com X-MS-Exchange-CrossTenant-Network-Message-Id: 94edcd59-b85e-4e59-8dad-08da28dfcbe2 X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4545.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Apr 2022 06:24:49.1349 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8ddb2873-a1ad-4a18-ae4e-4644631433be X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: r5e+KxOA8lPRHG/o5WFItU0oVWSP/cAR2zs8oKbLxfmb4sKEyjVUHZBrunKKKZirqZmBs3MFpfwhKQR5rDAJJ9ecketPf0xFMI50xSqryhs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4921 X-Proofpoint-GUID: bXDakq_r0g8Z9eZLrfCxi6qAToJcqhbW X-Proofpoint-ORIG-GUID: bXDakq_r0g8Z9eZLrfCxi6qAToJcqhbW X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.858,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-04-27_04,2022-04-27_01,2022-02-23_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 spamscore=0 priorityscore=1501 lowpriorityscore=0 impostorscore=0 phishscore=0 mlxlogscore=607 malwarescore=0 clxscore=1011 adultscore=0 bulkscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2204280037 Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org The code in acpi_lpss.c has been unconditionally using pmc_atom_read() for about the past six years. This hasn't been a problem since you currently can't disable PMC_ATOM short of disabling PCI entirely. But it doesn't need to be that way, and so that we can change Kconfigs in a subsequent commit, we make sure LPSS selects PMC_ATOM in advance, so that existing .config files can live on with "make oldconfig". In theory, one could make LPSS build w/o PMC_ATOM, similar to what it did six years ago, but I doubt there is any demand for that now. Cc: Andy Shevchenko Cc: Aubrey Li Cc: "Rafael J. Wysocki" Cc: Len Brown Cc: linux-acpi@vger.kernel.org Signed-off-by: Paul Gortmaker Acked-by: Rafael J. Wysocki --- arch/x86/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig index 2ee26f10a814..163c198ec8ec 100644 --- a/arch/x86/Kconfig +++ b/arch/x86/Kconfig @@ -654,6 +654,7 @@ config X86_INTEL_LPSS select COMMON_CLK select PINCTRL select IOSF_MBI + select PMC_ATOM help Select to build support for Intel Low Power Subsystem such as found on Intel Lynxpoint PCH. Selecting this option enables From patchwork Thu Apr 28 06:24:29 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Gortmaker X-Patchwork-Id: 567525 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80A53C433EF for ; Thu, 28 Apr 2022 06:25:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243764AbiD1G22 (ORCPT ); Thu, 28 Apr 2022 02:28:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40028 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230482AbiD1G21 (ORCPT ); Thu, 28 Apr 2022 02:28:27 -0400 Received: from mx0a-0064b401.pphosted.com (mx0a-0064b401.pphosted.com [205.220.166.238]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E5CC35A5A9; Wed, 27 Apr 2022 23:25:10 -0700 (PDT) Received: from pps.filterd (m0250809.ppops.net [127.0.0.1]) by mx0a-0064b401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 23S6HAJg019758; Wed, 27 Apr 2022 23:24:59 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=windriver.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : content-type : mime-version; s=PPS06212021; bh=aItVUOEpLYfdRTYrg5TGczriMieIcIkd1VOooKonveQ=; b=FRtgA50NY+5CPyfpNu0itrLH11xWSHwIClOfWKvIIqsrT4E7hcKwELwtWM8VJOWTmn2o SaZqgHM3n0Lj03awgGJSzhQioFWWPCth0qNLkNzZZnp1uhcyNtTU4qDY8V85qlbvwGA4 AuzlO6K1Mh7KkIS6++ITfWaO0PUkEhV8ELECUIYhoG4stlKO5czGtyws2lZEgNgKnFWr Lk/mC+HMLflm+UHYHOve9CvOZa76n1sSDz4pOaNUf9apAEg0XztL4eWNDruZzetou3R2 t9MZTV5D3diwCBU7Y/YTJFcOitbFA1GDZ55JIiscmjAmq3aZn+nambKHViINtHtZW4ui 2Q== Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2170.outbound.protection.outlook.com [104.47.55.170]) by mx0a-0064b401.pphosted.com (PPS) with ESMTPS id 3fps57s3ua-4 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 27 Apr 2022 23:24:59 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ddzFnKq2DJMStjsx4Cj76bSpuaOVLbYNpyYe3pqm70eyNgUkAmxVhEGvlGXyDPlFyhPW1eFLIadHrORUnIyy0sprUUbDBqCl4q3NKNEjvuvyLCl8234nK5i/dkG5Niw9MNNJkFgY7ImRXYzjjW+RgFfe0RjfM3irQikupe3ifIBNIb9PAoKS3NM9zns7eHHnlmf7gvOKykWY+2atHRE+Mxer4UkCXZ4UovuUvViI3jNwYvY+35c7Mwwgr6qJ8X8ei1sbYTu3d+witLEFmUaZ8IYP9obKK7YSRY0lBiLZ8LthdWpALBnG0uvRgCtVgHH+yeQOQ6dg+uUgOhDqq2QvaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aItVUOEpLYfdRTYrg5TGczriMieIcIkd1VOooKonveQ=; b=NcOAF6SW9zvU1XhSkY9LXaLaoolWMdq2l2vXA2/UOJ+YkOZE9qPJpky4vVPXE/qDzyGt7iSUfiqTQ+ybMRdLTXoOntzJwsRzlADtqONpxlbgpjxShFKUgZRTtDiYBb4fmgxB9YrSKwYobw0tCByhK2BHkHM56nn3o5q+tBykZVuXoDcmC9Ncn2Nb4Ou8AeWTmB0fgPk+PKnPGkrAdlKOp0Zd0jebLpfV0mZd7Z65TNhKk6lDBhyLYkm74qby3+1QZNRYma9PWq764kdScUsaW9+fVkxizNvNOC+/JI4Vv6bRPbMvGDjygOSDjsb1Qvv+Q5OA+KmWJ+9aKPri/A2PPA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=windriver.com; dmarc=pass action=none header.from=windriver.com; dkim=pass header.d=windriver.com; arc=none Received: from DM6PR11MB4545.namprd11.prod.outlook.com (2603:10b6:5:2ae::14) by SA2PR11MB4921.namprd11.prod.outlook.com (2603:10b6:806:115::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Thu, 28 Apr 2022 06:24:49 +0000 Received: from DM6PR11MB4545.namprd11.prod.outlook.com ([fe80::89e0:ae63:8b71:4a0f]) by DM6PR11MB4545.namprd11.prod.outlook.com ([fe80::89e0:ae63:8b71:4a0f%5]) with mapi id 15.20.5186.021; Thu, 28 Apr 2022 06:24:49 +0000 From: Paul Gortmaker To: linux-kernel@vger.kernel.org Cc: Andy Shevchenko , Aubrey Li , Hans de Goede , Len Brown , linux-acpi@vger.kernel.org, Mark Gross , platform-driver-x86@vger.kernel.org, "Rafael J. Wysocki" , Paul Gortmaker Subject: [PATCH 3/4] platform/x86: pmc_atom: dont export pmc_atom_read - no modular users Date: Thu, 28 Apr 2022 02:24:29 -0400 Message-Id: <20220428062430.31010-4-paul.gortmaker@windriver.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220428062430.31010-1-paul.gortmaker@windriver.com> References: <20220428062430.31010-1-paul.gortmaker@windriver.com> X-ClientProxiedBy: YT3PR01CA0005.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:86::25) To DM6PR11MB4545.namprd11.prod.outlook.com (2603:10b6:5:2ae::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 75e55010-e3d0-45d5-d463-08da28dfcc4d X-MS-TrafficTypeDiagnostic: SA2PR11MB4921:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: eMKJ9yFA0X+dVxBQB7wF9JfuSHBTvwdAnBG40Z/5INMql3k+zpJOGpwatFG2VjX5QwK1m2umZKcPJsxfhpY6YFs5jQ+8f4BFdK51GtBFZWHzwYptma7RNjvJPIDY/EPD040XWrL6cRS+9/Ez9yQ/Z2/E6qoubzvDD+3PVa8CW9nH8mZfIRWso1S19KgUvSkwhj9WBloOyUpZ0RUezpd7Xe7KFdC/yMMY1znFQSRvBuEzMG63kj4YhEASia7Ed07WByqZDQn3Jf/++/Uyg1xPYfuuBk0bNVTSYt6JcJ15QKGEEWk7cdK9kQvgkR4/XboYnYwgjRX2+5BOnFM8lbARhlsYdb4+MFFfqauAEiFwGmWWTFfZttKZ8M+ZkRHUR7V3lMvQTzeiCfpLOpJWmspCxtDSIFr4kDeOSSADWaq3wBAcyWngAKfDQ99ZHx0vg8rdsk0z4XIhxS8U2YW4yvPCPPixIqzbOerF2DmoN1tqoSKWXreNieI5GhE0CeJUO116uzIjT2OveGAW6qa0Ql1AAn65fjpqbcP7Pr1qtrZOVAPhtfG+M3J7O6zN9b3Un0n8X35Oy85XpjGoBX4l80/IMClA4c6iRSP4HolVo/SxSu6e2dqSKnuNq1IYple8BK/d89tIsHhhqf0x6jjhlYIJksimIy290HUINVVn1iF3/szyxbG9cJp/XM+YHq3191zmpaxRYSz+E+Fb1UbIGuXLAgs+uIU5ZsVCWlyWXaFMm6cbRqJcyo8dj+5EgId/ln2qSRdMboWR5SkEc7gdca0Awnbv+Sk/f7i917aVeZxwZss= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB4545.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(66946007)(107886003)(2906002)(44832011)(508600001)(5660300002)(38350700002)(38100700002)(6486002)(8936002)(54906003)(6916009)(1076003)(66556008)(8676002)(4326008)(36756003)(316002)(2616005)(186003)(66476007)(52116002)(86362001)(6666004)(6506007)(26005)(83380400001)(6512007)(26730200005)(192303002)(19860200003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: QiG3JxDusXg4WiMLneKWb373/FpDxzHutcuhpvOPaRIB+TofqMweAkQ4t60t2pRM+3qlKeUhB8WCwWztdXKspwbM+JTAW3Zm+4s/51tMlxd7mYKJUyT9suBkZHq11J466QWPeGCq6AXS9kFebXFw77G8csegpGcHGbGKKpkduHkn8cWs5WV5wUyAudHGF1dCX+mWqIV/g9fifctHcaCX8s+hUMWTk24lb0JcGO2nBSCTIhaSip7WdlAmG0iA3p45EcPnycj4RSF8wpdX4K+VMqNIrAuDOWpX5alWJ7hqyy5lsy6NEOsjP6eTW6gsgMKkdYJUzHV2nf9ANJmjwNmNHyPL3wE+auG/CFhXNGDDIhsjP3jM5+ZpwCFNAmDJdDuIp/n6ySpSI+K5c1u81fisZj9gkmAsJPLOLJmLI4uikAq6WZWj8JYHRCyw2HL6QJFUg8DGOeb+v+47lUfdD1m2xjB4pyONQBwr+fotW5AetIa16K5b/jqJRnLkSLTXGL5AC+xykUHMTMcB+OdYf0Lg4QgCGbKPDnMCXzmey0OjfQDGAZCm2akwRpMHbD92VVFkZxTCEXMC9xbvNP1QuhMxfMg74xyT7qBOzSXlilih/BxrRNwnHSKpLIeuzd3dSUEDqdiGfO8h9JJD/L/jiQHjdr3zgAG7eljOwncboQYcKR+SI/OpjFRrZwJzi9U9i0S10HIm4twLfGbEj9lrBUgngcKc1UMJmlsSo3n59Wsm/zSyjuuT3ulbpXiE3s0w2WvlhNSF5HV29y6XSlA2II2Y2JSgsyO7R2G0TXcqeWtVHz02j7pLreb2YLsyoZfbsyJ/lDRQH02ZIDYb5gZG19wNcWvAlU6A6yHu6Zg6tRZx1wdo2nLuQFQWm86Bej1ENyYjejuWuvFph9/odyzTswle7YuhGZB7R13oFS744kCL6nhsWnzDwhjTWLrRPcJ0vczFFsHdpldactldqSKrZ1fis0MhJ7a75FLHda1s1EpxvURhUqvgDThozTc1JteU5xTyi9ytW8/CJr87ToBkGMs68I0TECStE+LRkoU2qR+ZYWCZdURCWVHC2zwU2z8RXnScdU4pGl2dYfZRPzovaxAikzf3GJNboy/5GVbayywwUHWEc3V9DxFkEOIOG9BP7AyKOfD9y90C6td8q1tCJytWY8251kxT99gYbSM4oWGFAx0Y9KGyLFwcGvBC/YnZorqZq2AaRNMFjVazQ731PaGhLJdKo6lonuBJx785N+3t3stzFWXWFiQ1AE8sRC444yzGA6vNISfkHlIL74k+jwBAd3ap5UHY9l74HuO+317Rlt5iID9M4QzlalL/+EiRxYgv/QCRNpBtJgmnPZNNxGuBWGgkmDDUlxtF4nOs8t8Kf2XXJw6aMon65HN4sVrCxgZciTd2SV0fmnEnauJM6qQCl1o+L6mmMOfpIlk8NJsIKBW5mjOVtfbE3GjcWKdHV8tGeMx+Qs7GEfRYv4TEG5nrbRw7ztf8eiR7CKkDZDFrNaceANq5NbYxO76xInZWaKJtrzfOo/L9kIGaji4CvGIDrY1E9wlIxxTJoVf6hwb9NqmJafsjRBppQl4xsCr9yxqOurEaHOcHO2r0bKWL9udye+AmE/fFSGIr0E1Xaua+nWcFdNT1MNTRvpR/k82pG792P6kWURancC/ozA4dfHvmpi1dvBu1MRulrBG6oa8N/F/4xtE54eYaD8MEsdQZ3O0oR1vhGIWOtNwieKo8PTD5sDGyG+C/UwIytfokCXNh4EY= X-OriginatorOrg: windriver.com X-MS-Exchange-CrossTenant-Network-Message-Id: 75e55010-e3d0-45d5-d463-08da28dfcc4d X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4545.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Apr 2022 06:24:49.8379 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8ddb2873-a1ad-4a18-ae4e-4644631433be X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LDcOVaLfdLMkb6YhKbHrT1a+kwUObx9ne5MNtOn9mxGeE7JffWGjl4rAvdS6pi7Lq49mZ8Ddciqu4qi2Z/MHysWwK1dMliJscF8GksLfF+E= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4921 X-Proofpoint-GUID: 0MOVjOVB6A44zMixY2dTCeuo-h0MGrNU X-Proofpoint-ORIG-GUID: 0MOVjOVB6A44zMixY2dTCeuo-h0MGrNU X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.858,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-04-27_04,2022-04-27_01,2022-02-23_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 spamscore=0 priorityscore=1501 lowpriorityscore=0 impostorscore=0 phishscore=0 mlxlogscore=703 malwarescore=0 clxscore=1015 adultscore=0 bulkscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2204280037 Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org There is only one user of pmc_atom_read in tree, and that is in drivers/acpi/acpi_lpss.c -- which can't be anything but built-in. As such there is no point in adding this function to the global symbol list exported to modules. Note that there is no include removal since the code was getting that header implicitly. Cc: Andy Shevchenko Cc: Aubrey Li Cc: Hans de Goede Cc: Mark Gross Cc: platform-driver-x86@vger.kernel.org Signed-off-by: Paul Gortmaker --- drivers/platform/x86/pmc_atom.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/platform/x86/pmc_atom.c b/drivers/platform/x86/pmc_atom.c index 31cf25d25d66..b8b1ed1406de 100644 --- a/drivers/platform/x86/pmc_atom.c +++ b/drivers/platform/x86/pmc_atom.c @@ -221,7 +221,6 @@ int pmc_atom_read(int offset, u32 *value) *value = pmc_reg_read(pmc, offset); return 0; } -EXPORT_SYMBOL_GPL(pmc_atom_read); static void pmc_power_off(void) { From patchwork Thu Apr 28 06:24:30 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Gortmaker X-Patchwork-Id: 567524 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8EE9C4332F for ; Thu, 28 Apr 2022 06:25:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243847AbiD1G2a (ORCPT ); Thu, 28 Apr 2022 02:28:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40910 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243805AbiD1G21 (ORCPT ); Thu, 28 Apr 2022 02:28:27 -0400 Received: from mx0a-0064b401.pphosted.com (mx0a-0064b401.pphosted.com [205.220.166.238]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 07C69972FC; Wed, 27 Apr 2022 23:25:12 -0700 (PDT) Received: from pps.filterd (m0250809.ppops.net [127.0.0.1]) by mx0a-0064b401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 23S6HAJh019758; Wed, 27 Apr 2022 23:25:00 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=windriver.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : content-type : mime-version; s=PPS06212021; bh=DapDWoSM5Bklo+s++Jx3eGyTV1DIWXW30/bxdef9jIU=; b=WEnX9YSggplBReYE9XEt9KOoa/qJ/NkxeYJKo2j1CPLWaSidYJ6lE1gJ4vtzBWUEmBR+ CGlIbGxC7t7JKBAU16usqk/cUT4fS1fh8voptMz2459HSt6vcl+afvuQMm+ni6l0CGZ2 PHTFdslB+0BVPeqJW9oVl6R1sfafljkVzxPGhzZOBbwydYEPLd0alR7txLobVq6TrcE/ HwxbPRpIIB5EgYrzGvofV2ZqhaBte28LPOYXFwkyOvN7sfd9P2gk2fNL8Ii+Aihtgk6V 7Qmiucnny4pP6EoLLUpxEvVEucpsybYp3QmwNz8/ILwyAIXZhlVTcBLHW0r1AN7JHd8l BQ== Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2170.outbound.protection.outlook.com [104.47.55.170]) by mx0a-0064b401.pphosted.com (PPS) with ESMTPS id 3fps57s3ua-5 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 27 Apr 2022 23:25:00 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hhuDGdrjnEyZ7XUkGSi0sAUE2RvKXqEaVDZORbuS4JaJwIZT+/A09CRkQo7BJFoB5fXGZ+24Z5x2aUcklc1SV4jF8MnGL94oLTLtCmnwqNyA9hsmnP+3xasOnqLHAOX4uRIX3k1dXFAIV3NDRSZvdVIiOm+qoPlwfkK6AxR+/qUzAKceyoP6daOFf4nokyVkNmP3AFoNnO3k9SqaoPt163JAiz4RBY7gme2K2Oke8l1I021ztQRIvZX9Mgzhhx4qalsg8k8uQQfq4EZ0gEHE+nGqyfwLvekzeApcXf/t7LX0sNcPjTA70zJeXWXoe5W+MLWxqUOSbq9A91NhGNQGTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DapDWoSM5Bklo+s++Jx3eGyTV1DIWXW30/bxdef9jIU=; b=AE4oX/S41XPhFpyOL/uLVWR35JZwfXf60rxQQLzGbaS6CMLF7Q4WJ6cmNu6/w0OFZz1qb8CpDZynQqqDfb23URh9SVOGlGim3wlrg3m+QijGsRhwDGgbhl2A+2FVO6kzP1uO1s2/ySNrxqxzzD+v6gHg+HtTKFcFnPOrAmvccfdkFMlTOqQ7veHAcT+8NPYJIREceVt4D2dP7hnLZ2hhOIZ/9owZHP+kL2fQ5rtmb/ZfNuzwJGg8d3nU/dStpeNKnwiE7wKBobQBOWgMJdvvYr6zi8riTjTo5gTJThFzPB/3ASa3BvFPqGHlvdmE14wQ6iiWInALvSQa5ztF5ar7MQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=windriver.com; dmarc=pass action=none header.from=windriver.com; dkim=pass header.d=windriver.com; arc=none Received: from DM6PR11MB4545.namprd11.prod.outlook.com (2603:10b6:5:2ae::14) by SA2PR11MB4921.namprd11.prod.outlook.com (2603:10b6:806:115::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Thu, 28 Apr 2022 06:24:50 +0000 Received: from DM6PR11MB4545.namprd11.prod.outlook.com ([fe80::89e0:ae63:8b71:4a0f]) by DM6PR11MB4545.namprd11.prod.outlook.com ([fe80::89e0:ae63:8b71:4a0f%5]) with mapi id 15.20.5186.021; Thu, 28 Apr 2022 06:24:50 +0000 From: Paul Gortmaker To: linux-kernel@vger.kernel.org Cc: Andy Shevchenko , Aubrey Li , Hans de Goede , Len Brown , linux-acpi@vger.kernel.org, Mark Gross , platform-driver-x86@vger.kernel.org, "Rafael J. Wysocki" , Paul Gortmaker Subject: [PATCH 4/4] platform/x86: pmc_atom: make the PMC driver actually unselectable Date: Thu, 28 Apr 2022 02:24:30 -0400 Message-Id: <20220428062430.31010-5-paul.gortmaker@windriver.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220428062430.31010-1-paul.gortmaker@windriver.com> References: <20220428062430.31010-1-paul.gortmaker@windriver.com> X-ClientProxiedBy: YT3PR01CA0005.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:86::25) To DM6PR11MB4545.namprd11.prod.outlook.com (2603:10b6:5:2ae::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2cfa4685-ca95-415d-243b-08da28dfccb2 X-MS-TrafficTypeDiagnostic: SA2PR11MB4921:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MFElWaAer6O1U58Uxa9gc5E6wOv2IbAP6tFnWJp56hPp0UbTpx7DgW4U1HlNNYH2YySMJOIHJzVuc8QBIjOTzyCfKPa46h5Y1H+FPgGrMjotBoz9Vvx3VuZ9ZGQhdSAzHek4DIsJV61LfgTdc8u0p2QxFwbME0fo3agUnPWDIPzxYdcr+8+IgLqL9VGTlBAH8Y9H2FCOQqv0CfFGzWmdGWrbtJVTGHmaGf6O+QzLF4hLLiL/kFpub6Usf4dbutqyK0LjYxevXOOcfjBl8ZOiEcsYRhSJ5ajgIr5tsgG668ZEKQlbDHitvpm1BNIsAhAHlPFuyuBz/eRK1gntpGWQqCXFBg4qoxxkjCbrvdEH37V2hReg+rvNzfP3+HJPscj/3z9IJzpWMwYUxbEB/PfbNiZRl8FL7x7q0R0LsFomHv6nXUiziotbvehDW4tW8KoyUBNd3yYtLyv8leyxnWuGavPw8pK5+FJvPw9mroP+Qm/fImo83UelhXe9RauW446TMYfu6Lxalgv3lZshuBxgTIt34Z/J3ft8by6gaJX3B5bE3JM/A6wkrZYrTGLlaG0ELujvvRd4GNyblvf6LHbg2Y8EECJwkvn1JPUvKQdaidqTiaE8PiCxgvsyoylCSpooS43st2Av8FoMY88QTWG630fVpZYqwzzOvV51Q/7wMrG0+zCzqrXayrxSAM/ppnQZ19wKrh+l7QbUZmRtfC83bw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB4545.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(66946007)(107886003)(2906002)(44832011)(508600001)(5660300002)(38350700002)(38100700002)(6486002)(8936002)(54906003)(6916009)(1076003)(66556008)(8676002)(4326008)(36756003)(316002)(2616005)(186003)(66476007)(52116002)(86362001)(6666004)(6506007)(26005)(83380400001)(6512007); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: lvUreOB5YZ8AC9MhMIG3o6S/XQJ/SslJr4zCkW6l+VXa362njxA1jxtfKBY9ce1ar/pnhlB8skIVlRXZ2VAre2+C40672q/UFgIWRIVYmJpuKvfFU/9uBdhrqTGaqpIyHwMhRDcQGqBaybtjGcha9MgQEGEAj1SC0XHPdYJva1G9VWoQt8XLZmglhhWwGkbimWmY+MdFEVPh1TtI6fiIPy6dkgK/IKGfqC28Q46snhLzQRnj3iYwmkVyL9brjI1Bpam8/0mnBQ++vcMbZ+BT8KpcWUFIevqAd/b6t6L1ah0JOjcUxVvb4520LDPxBFByKETd+qqzEVVCExC5ig4QHbho9IOuAIJrCoZuYiSWLPQH4zyjSvN0sbK48gHP2QBNB7hOfnBi+5rae7n1Fn4HboEsa+5S1hqnNbsXJewcDqDRtuJv2+ChTkL2FDI12O9Ls8/FeNs18BzT3/d2diQP0eC+/6xespE8DsGFDMYiMEQx56hWLTbxhOZxNpuFf5v2IMdkLDZBdgw1b1Qkt0m/GyNPO/TU5NSC6monpyA7FvV9NqX3b5HuW1k+LyigmaDH6bFieCtcbqi8PEJFd85MQBEd3zEgUn8eE0I60BVcbXfD7Wetxt9147fR8JTpJ0m4mJ3qAPTcfY5gXNvDrP96zT+H6JXUg4AvvTLfjArO3B2UkkikctDDzzsOU6GHylpZ8siOxrhpJt64wpbeyyRfIm7eY82os8/J2RIiI1wLaSxoiBIUimHbTCInRBAXquX7LXQ5LvFt5wLWYlTZjmdgyj+PjL6YFQ2hzkm1tAsTgZI8bOwC5smjE8fRpNZAjCQ/nE1+8dkSRlCdZFSbdd8vJxyb9osuPI6GSFmPaTA+XBqTiVdDASCD57B+2SULyToDWRAMEwoPvb5Kgnzf3Qen/rL9jRA0sVwtaYmplBZXdqAP+n8CyBLlKEhW1s0y27Z5qD5Srx2jZPSljjeGyDa8WVvzFCnsYDKXNCv69L3vrQ64CVBl55Gj2q63N9jfLcP+t9KfOWKe2YoR+zjn5BA/snEvf63V+75jbr+Koy42Y0NNIXyP71aJL0DsUXFWxBIPHD57AWudwcgRMHhFq4Voflp3vEXYg95h7d7AdicxzUpjS2+5eOdoEmv50OHXTj96x8B4JGukjNXceZCR6/ypby/9Qzi0Hedukywui5H2sB2yN7zHlZo+4gPnfHvwVsv6Dp40xMMjlL2Z7EkQYkZsSfqtbpQrCxterGDUeHy0FYL4MeSbkK/s6gEN5AZwVRWMCDpc+dk1triptECfRKd90ZT6IgjHQE7rgYxyvd+cBMXhAVAB2qw9DLyl0E9CU8fXnnGBlerHi/LUcPRtbT1KVV0AbFX8mRKcjS5vNUOr4ZQwhIECxuSkiXCRGA3YvTP/80/8qMUk/8/qW0Kmhph7CD1H47tGYBcYiHrYDaOf5jqhfQ3MPRvBAJaQkvOaN5x9uvzXFY8XRAT9oOyvLLwKZ5AHsAzyozmdFd7cdRzhRo2CGBPpahposXVqTxopn6uyKn3+e6/QnJir/0ykn3RcY21ce+HwKWfhY9bGW+89W00uVhPR+EFuVG1TklA2NUA6h/8ah+yZbtQWEx2Lys1+sD55n9NLoJU68dyeQIxw5RroOd55Eh8+5f/nqXRgfX8cN5ILcdoBcLInnzaVFqAdBQVaIRspzLRn3jhLOGX+qnS3h8wffGy77l4VxVBvsbfJTE2j9X/jWiO2If/H6ygZR1rtUA+NRoSe1QQap3tpBUU= X-OriginatorOrg: windriver.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2cfa4685-ca95-415d-243b-08da28dfccb2 X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4545.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Apr 2022 06:24:50.4328 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8ddb2873-a1ad-4a18-ae4e-4644631433be X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qbupXlzWtQVA9ufug5k/xiiQ7oocjySYJErQs05nxOTHbkdi39OE4z43qdba+YtYHv+jpBWzs/SpAPGkDF8JsM/PLd5Gqt3zUS+i1br4L/A= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4921 X-Proofpoint-GUID: Ht-H5As48OOpJMxmyqvRlmbO51TLGpmM X-Proofpoint-ORIG-GUID: Ht-H5As48OOpJMxmyqvRlmbO51TLGpmM X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.858,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-04-27_04,2022-04-27_01,2022-02-23_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 spamscore=0 priorityscore=1501 lowpriorityscore=0 impostorscore=0 phishscore=0 mlxlogscore=910 malwarescore=0 clxscore=1015 adultscore=0 bulkscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2204280037 Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org This caught my eye when I saw it was def_bool and hence largely pointless to have a Kconfig for it at all. Yet there is no reason why you shouldn't be able to opt out of Atom platform support if you only care about desktop and server class CPUs. It was introduced as def_bool, but there is no obvious reason as to why it was forcibly built-in for everyone, other than LPSS implicitly relying on it (which is now fixed). So here we fix up the Kconfig and open the door for people to opt out. Since putting "default y" on anything that isn't absolutely essential is generally frowned upon, I made the default be CONFIG_MATOM. People who use "make oldconfig" or similar won't notice any difference. The two "unchanged" lines for PCI and COMMON_CLK appear in the diff from fixing a whitespace issue that somehow managed to live on despite being moved between two different Kconfig files since its introduction. Cc: Aubrey Li Cc: Andy Shevchenko Cc: Hans de Goede Cc: Mark Gross Cc: platform-driver-x86@vger.kernel.org Signed-off-by: Paul Gortmaker --- drivers/platform/x86/Kconfig | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig index f08ad85683cb..86459e99d831 100644 --- a/drivers/platform/x86/Kconfig +++ b/drivers/platform/x86/Kconfig @@ -1163,6 +1163,11 @@ config WINMATE_FM07_KEYS endif # X86_PLATFORM_DEVICES config PMC_ATOM - def_bool y - depends on PCI - select COMMON_CLK + bool "Intel Atom SOC Power Management Controller driver" + default MATOM + depends on PCI + select COMMON_CLK + help + This enables support for the Atom SOC Power Management Controller + driver, and associated platform clocks. If you intend to boot this + kernel on platforms with an intel Atom CPU, say Y here.