From patchwork Wed May 4 19:34:35 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Markuss Broks X-Patchwork-Id: 570632 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57B58C433FE for ; Wed, 4 May 2022 19:35:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1377533AbiEDTjJ (ORCPT ); Wed, 4 May 2022 15:39:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39464 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1377564AbiEDTjD (ORCPT ); Wed, 4 May 2022 15:39:03 -0400 Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8A392E0FD; Wed, 4 May 2022 12:35:24 -0700 (PDT) Received: by mail-wm1-x329.google.com with SMTP id ay11-20020a05600c1e0b00b0038eb92fa965so3829373wmb.4; Wed, 04 May 2022 12:35:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ZT7VKniHc2GWnckoL6MlPZLbnEyYu3dBdYD4+s+IxsM=; b=Bp58nmH7PUo//wUZc2uhmQN2OX+RZ5aQLpK6AkiBmVXbEzAekaYLhmj3Yih1HanvNT k6YuK85Gjho+Yrn/QAKJG9v6W2N7DDfE+AIDYaBExDlbWgY9NwaUyGXdpyrMn0ojQoIx +VHexJKd2czGapDFNe/UVyD1MCNSM5F/IwjFvt4yKGfF/faiWMzpVglJZ58FkxIuLwFe aSwhc/Msl6oAoyefPqLYYJ7V3aQI/zettQWHEi3kSpafZCPvKHQUhSCYE2C0DOhSxxQT oKWfCsY8nodzf9jHC+1bFubtqxZCTUxBdCWDh6RYaV6sLYovNEOb0zf2itxfUEl34QG+ nt5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ZT7VKniHc2GWnckoL6MlPZLbnEyYu3dBdYD4+s+IxsM=; b=Vo0gHYHBspGSAebnM9AdXZntqSDZELLPyS9jqp64s9D0/4/W4/Y99CDod9d/h0LYhh Zm8mrUzT3vBvSN9EnnJX1hXucNHxhh1nto8JzDC8esb0bh9qf6b4c7fqw5Eo7aHhBuaF pwVZk36ImfKsoOZs+uP1l3eR01wSIiZ2/E9Qrjb9jhPBefTAeuPWk7WI00xJhmPJQy/K qJvwYediztxaSZCEWbxyq9aah3CYIdSsR80y+hzfxKnh+BQUBsmGnI/RbhwuEEgV4Tbf OG8wWl4RYHsDgKwFYeW0RFHXBatkdzEbHKWturcFkWYhdrjIewZfzUwxLLaaEM4z3FZM wQAg== X-Gm-Message-State: AOAM530+SSpitU90lOYoS05FDCmY+Hwr+8RebVqSWRzpzAaiSJtFddX0 0tC3JbodrhRugX9FPva5R+M= X-Google-Smtp-Source: ABdhPJw+Kv9dqOx2Wgp0gAQYZHdG6ke4h+kiL7EqNHqEJBn8Z7t0RoZXM5k2Pha5doozf7pbKxfxEg== X-Received: by 2002:a05:600c:1ca6:b0:393:eb0e:afd9 with SMTP id k38-20020a05600c1ca600b00393eb0eafd9mr843858wms.87.1651692922999; Wed, 04 May 2022 12:35:22 -0700 (PDT) Received: from nergzd-desktop.localdomain ([194.39.226.133]) by smtp.gmail.com with ESMTPSA id 67-20020a1c1946000000b003942a244f2csm5519358wmz.5.2022.05.04.12.35.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 May 2022 12:35:22 -0700 (PDT) From: Markuss Broks To: pavel@ucw.cz Cc: Markuss Broks , Rob Herring , Rob Herring , Krzysztof Kozlowski , Lad Prabhakar , Linus Walleij , Christophe JAILLET , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v7 1/2] dt-bindings: leds: convert ktd2692 bindings to yaml Date: Wed, 4 May 2022 22:34:35 +0300 Message-Id: <20220504193439.15938-2-markuss.broks@gmail.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220504193439.15938-1-markuss.broks@gmail.com> References: <20220504193439.15938-1-markuss.broks@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org This patch converts the leds-ktd2692.txt bindings to modern yaml style device-tree bindings. Reviewed-by: Rob Herring Signed-off-by: Markuss Broks --- .../bindings/leds/kinetic,ktd2692.yaml | 87 +++++++++++++++++++ .../devicetree/bindings/leds/leds-ktd2692.txt | 50 ----------- 2 files changed, 87 insertions(+), 50 deletions(-) create mode 100644 Documentation/devicetree/bindings/leds/kinetic,ktd2692.yaml delete mode 100644 Documentation/devicetree/bindings/leds/leds-ktd2692.txt diff --git a/Documentation/devicetree/bindings/leds/kinetic,ktd2692.yaml b/Documentation/devicetree/bindings/leds/kinetic,ktd2692.yaml new file mode 100644 index 000000000000..bac95a51afa1 --- /dev/null +++ b/Documentation/devicetree/bindings/leds/kinetic,ktd2692.yaml @@ -0,0 +1,87 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/leds/kinetic,ktd2692.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: KTD2692 Flash LED Driver from Kinetic Technologies + +maintainers: + - Markuss Broks + +description: | + KTD2692 is the ideal power solution for high-power flash LEDs. + It uses ExpressWire single-wire programming for maximum flexibility. + + The ExpressWire interface through CTRL pin can control LED on/off and + enable/disable the IC, Movie(max 1/3 of Flash current) / Flash mode current, + Flash timeout, LVP(low voltage protection). + + Also, When the AUX pin is pulled high while CTRL pin is high, + LED current will be ramped up to the flash-mode current level. + +properties: + compatible: + const: kinetic,ktd2692 + + ctrl-gpios: + maxItems: 1 + description: Specifier of the GPIO connected to CTRL pin. + + aux-gpios: + maxItems: 1 + description: Specifier of the GPIO connected to CTRL pin. + + vin-supply: + description: LED supply (2.7V to 5.5V). + + led: + type: object + $ref: common.yaml# + description: Properties for the LED. + properties: + function: true + color: true + flash-max-timeout-us: + description: Flash LED maximum timeout. + + led-max-microamp: + maximum: 300000 + description: Minimum Threshold for Timer protection + is defined internally (Maximum 300mA). + + flash-max-microamp: + maximum: 300000 + description: Flash LED maximum current + Formula - I(uA) = 15000000 / Rset. + + additionalProperties: false + +required: + - compatible + - ctrl-gpios + - led + +additionalProperties: false + +examples: + - | + #include + #include + + ktd2692 { + compatible = "kinetic,ktd2692"; + ctrl-gpios = <&gpc0 1 0>; + aux-gpios = <&gpc0 2 0>; + vin-supply = <&vbat>; + + led { + function = LED_FUNCTION_FLASH; + color = ; + flash-max-timeout-us = <250000>; + flash-max-microamp = <150000>; + led-max-microamp = <25000>; + }; + }; + +... diff --git a/Documentation/devicetree/bindings/leds/leds-ktd2692.txt b/Documentation/devicetree/bindings/leds/leds-ktd2692.txt deleted file mode 100644 index 853737452580..000000000000 --- a/Documentation/devicetree/bindings/leds/leds-ktd2692.txt +++ /dev/null @@ -1,50 +0,0 @@ -* Kinetic Technologies - KTD2692 Flash LED Driver - -KTD2692 is the ideal power solution for high-power flash LEDs. -It uses ExpressWire single-wire programming for maximum flexibility. - -The ExpressWire interface through CTRL pin can control LED on/off and -enable/disable the IC, Movie(max 1/3 of Flash current) / Flash mode current, -Flash timeout, LVP(low voltage protection). - -Also, When the AUX pin is pulled high while CTRL pin is high, -LED current will be ramped up to the flash-mode current level. - -Required properties: -- compatible : Should be "kinetic,ktd2692". -- ctrl-gpios : Specifier of the GPIO connected to CTRL pin. -- aux-gpios : Specifier of the GPIO connected to AUX pin. - -Optional properties: -- vin-supply : "vin" LED supply (2.7V to 5.5V). - See Documentation/devicetree/bindings/regulator/regulator.txt - -A discrete LED element connected to the device must be represented by a child -node - See Documentation/devicetree/bindings/leds/common.txt - -Required properties for flash LED child nodes: - See Documentation/devicetree/bindings/leds/common.txt -- led-max-microamp : Minimum Threshold for Timer protection - is defined internally (Maximum 300mA). -- flash-max-microamp : Flash LED maximum current - Formula : I(mA) = 15000 / Rset. -- flash-max-timeout-us : Flash LED maximum timeout. - -Optional properties for flash LED child nodes: -- label : See Documentation/devicetree/bindings/leds/common.txt - -Example: - -ktd2692 { - compatible = "kinetic,ktd2692"; - ctrl-gpios = <&gpc0 1 0>; - aux-gpios = <&gpc0 2 0>; - vin-supply = <&vbat>; - - flash-led { - label = "ktd2692-flash"; - led-max-microamp = <300000>; - flash-max-microamp = <1500000>; - flash-max-timeout-us = <1835000>; - }; -}; From patchwork Wed May 4 19:34:36 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Markuss Broks X-Patchwork-Id: 570633 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2462AC433EF for ; Wed, 4 May 2022 19:35:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1377544AbiEDTjJ (ORCPT ); Wed, 4 May 2022 15:39:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39624 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1377571AbiEDTjF (ORCPT ); Wed, 4 May 2022 15:39:05 -0400 Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3C4371C13D; Wed, 4 May 2022 12:35:28 -0700 (PDT) Received: by mail-wr1-x42f.google.com with SMTP id e2so3343833wrh.7; Wed, 04 May 2022 12:35:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Pd70Q4kWObWSujRxWPRUBFu3tMsCwi7TVBTLrG5xt18=; b=RIyrV26bXmtm94kY9IFJlcdISavl7bv95wd4i912RKfrRErbLp4Ff0AaWe8rY8wSCp uKP1STMiIGzG1rYqqwErdqQkCDSdqqxJt1l7yXKh1KuiDOYC5n/lBg3Xek1N6Z7S3XYB i278bW1tZEkjSBXac8pvFHS7LIik7Eyy3LkcvJP5c3ECS4GYVBoXGV4uEVyBlulOJRsq cD9DMa4A/e2Vci97K69aQm45aRrZ/oqTmxqi5lfc2AXQBwlyHBbYx+YlJ4WN/5IANGq6 t09WZSXjfqS5qaiq96mahg91N47iHT7r7Aaa1zOXcZLDX1sbFjm5+nbKNPQHaPnpoIFr puyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Pd70Q4kWObWSujRxWPRUBFu3tMsCwi7TVBTLrG5xt18=; b=fQ4ZxicaBjHb1SOX4k9iwuSb+5OxxauDVb9bFPnTviqnGG743rTiZNYwiFutN59wkN 4v6WRMyYn7u/TXVti0cMNzWxbr/D3WPcMYaJe7B11I/+NELD+TzbeqpUpczoB/2oIoNi lr3TFy1xyB3tM/grZE64hBRp25Sd0WKGqyUNeopJ/Vdl729vyykcr3QdOig7nX9hoMOB 60S8fNDmhxDFHQz+6hYjRvrYVqILxZV/oP8z4vrZrEm90Imt4zZShKqvLBP0psQ8V37N ugmrfyzaXX1yFmUiaJGsS8dJW1W5y4UrPfUNaRgB9QzH++rO5w5U6G78EXPAS+rFIFXX P8/w== X-Gm-Message-State: AOAM533ZxkZvbX6xcyHv2LK5OjMy+gT4zjPJqcvjLTN6hmWhq9TspTAR elsGwfzPZ9Y9uMbw3TGxG67EYHWDQis= X-Google-Smtp-Source: ABdhPJxsC8Z1xAfENXiVAtjB8zOJtFn885Jmd3oBmZJtFMghavGiy424SmkYi9GZjac2kWwzolMUMQ== X-Received: by 2002:a5d:64a6:0:b0:20c:64ef:c9cc with SMTP id m6-20020a5d64a6000000b0020c64efc9ccmr12003206wrp.190.1651692926854; Wed, 04 May 2022 12:35:26 -0700 (PDT) Received: from nergzd-desktop.localdomain ([194.39.226.133]) by smtp.gmail.com with ESMTPSA id 67-20020a1c1946000000b003942a244f2csm5519358wmz.5.2022.05.04.12.35.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 May 2022 12:35:26 -0700 (PDT) From: Markuss Broks To: pavel@ucw.cz Cc: Markuss Broks , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Christophe JAILLET , Linus Walleij , Lad Prabhakar , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v7 2/2] leds: ktd2692: Make aux-gpios optional Date: Wed, 4 May 2022 22:34:36 +0300 Message-Id: <20220504193439.15938-3-markuss.broks@gmail.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220504193439.15938-1-markuss.broks@gmail.com> References: <20220504193439.15938-1-markuss.broks@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org Make the AUX pin optional, since it isn't a core part of functionality, and the device is designed to be operational with only one CTRL pin. Reviewed-by: Andy Shevchenko Signed-off-by: Markuss Broks --- drivers/leds/flash/leds-ktd2692.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/leds/flash/leds-ktd2692.c b/drivers/leds/flash/leds-ktd2692.c index ed1f20a58bf6..1736b3f6b899 100644 --- a/drivers/leds/flash/leds-ktd2692.c +++ b/drivers/leds/flash/leds-ktd2692.c @@ -284,9 +284,9 @@ static int ktd2692_parse_dt(struct ktd2692_context *led, struct device *dev, return ret; } - led->aux_gpio = devm_gpiod_get(dev, "aux", GPIOD_ASIS); - ret = PTR_ERR_OR_ZERO(led->aux_gpio); - if (ret) { + led->aux_gpio = devm_gpiod_get_optional(dev, "aux", GPIOD_ASIS); + if (IS_ERR(led->aux_gpio)) { + ret = PTR_ERR(led->aux_gpio); dev_err(dev, "cannot get aux-gpios %d\n", ret); return ret; }