From patchwork Thu May 5 07:07:27 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 570629 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7FC1C433F5 for ; Thu, 5 May 2022 07:07:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245593AbiEEHLZ (ORCPT ); Thu, 5 May 2022 03:11:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49414 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245583AbiEEHLR (ORCPT ); Thu, 5 May 2022 03:11:17 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CD4914754D for ; Thu, 5 May 2022 00:07:37 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nmVaK-0008HO-7y; Thu, 05 May 2022 09:07:36 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1nmVaK-000SVm-Oi; Thu, 05 May 2022 09:07:35 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1nmVaI-007guP-CZ; Thu, 05 May 2022 09:07:34 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Pavel Machek Cc: linux-leds@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH] leds: lp50xx: Remove duplicated error reporting in .remove() Date: Thu, 5 May 2022 09:07:27 +0200 Message-Id: <20220505070727.68768-1-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1250; h=from:subject; bh=AUB8yiy3bQr4BKx5sFehIFcd5mZcdR9Tb2trohsD0ME=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBic3epio51oct0QsrNvZMsfKaphzK2w0gQgHfdLzHB GiSw/aWJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCYnN3qQAKCRDB/BR4rcrsCeHACA CgExR63xPxIsAbHZf27QHWTSjClGMQOT1ycqfOCcGTeKf4JhFHPNW4z/yJfCjEjMbkQLeMqov30x/A E1u7JM6JNbCZCyDoKrAEFhqnrnbp6O+Z4KynXu1b2GGBfJHJSm9vAd/ZGouKbz6ZUuEd41ZE6yMVI8 9iBoYxaUVvzv8x015mztZmVZr4oZ898KkhDZbJM8gNl+ZgkKEM8yDEX3JWtHIrEqLxP+c88D35pMxG sPyHM4RfngQFxpio7UQNAHs8kfeMgAKfsyQY1CSASmA9vJynGBdFx6aEzqgibx+32GHIfWhyJ5SZV5 E3/8i5tGWdGrTlSK8qDHkqp3c2U+u8 X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-leds@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org Returning an error value from an i2c remove callback results in an error message being emitted by the i2c core, but otherwise it doesn't make a difference. The device goes away anyhow and the devm cleanups are called. As stk3310_set_state() already emits an error message on failure and the additional error message by the i2c core doesn't add any useful information, don't pass the error value up the stack. Instead continue to clean up and return 0. This patch is a preparation for making i2c remove callbacks return void. Signed-off-by: Uwe Kleine-König --- drivers/leds/leds-lp50xx.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) base-commit: 3123109284176b1532874591f7c81f3837bbdc17 diff --git a/drivers/leds/leds-lp50xx.c b/drivers/leds/leds-lp50xx.c index 50b195ff96ca..e129dcc656b8 100644 --- a/drivers/leds/leds-lp50xx.c +++ b/drivers/leds/leds-lp50xx.c @@ -569,10 +569,8 @@ static int lp50xx_remove(struct i2c_client *client) int ret; ret = lp50xx_enable_disable(led, 0); - if (ret) { + if (ret) dev_err(led->dev, "Failed to disable chip\n"); - return ret; - } if (led->regulator) { ret = regulator_disable(led->regulator);