From patchwork Fri Dec 16 09:19:57 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 101406 Delivered-To: patch@linaro.org Received: by 10.182.112.6 with SMTP id im6csp147779obb; Fri, 16 Dec 2016 01:20:50 -0800 (PST) X-Received: by 10.99.37.2 with SMTP id l2mr3885893pgl.160.1481880050842; Fri, 16 Dec 2016 01:20:50 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q127si6879800pfb.189.2016.12.16.01.20.50; Fri, 16 Dec 2016 01:20:50 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of netdev-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of netdev-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759982AbcLPJUs (ORCPT + 5 others); Fri, 16 Dec 2016 04:20:48 -0500 Received: from mout.kundenserver.de ([217.72.192.73]:63334 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754763AbcLPJUn (ORCPT ); Fri, 16 Dec 2016 04:20:43 -0500 Received: from wuerfel.lan ([78.43.21.235]) by mrelayeu.kundenserver.de (mreue101 [212.227.15.145]) with ESMTPA (Nemesis) id 0MCqdn-1cPl383n1v-009gKP; Fri, 16 Dec 2016 10:20:22 +0100 From: Arnd Bergmann To: "David S. Miller" Cc: Arnd Bergmann , Grygorii Strashko , Thomas Gleixner , John Stultz , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , WingMan Kwok , Nicolas Pitre , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net 1/3] cpsw/netcp: cpts depends on posix_timers Date: Fri, 16 Dec 2016 10:19:57 +0100 Message-Id: <20161216092017.2560717-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:Z7qY+YSNRGxsTQuQC2HuA5w4/7JGlFM1hEWNJRZOwFMg+Y4grCS HlSwDjiMeihDRH5bptztMZIrVjqU6R5elvFqdc+hMO7V8UAu6uyyzn4Z8McIyNbDX6Yr7Dw C4zKPubYKFd3SeVUaiEgD2DIXQW9HXESdF5XPwqWDOr0sCYjU8Mx3IMKKxsD2KsbRm9HQv5 xYLV+RRCqGE7yozwCIU9w== X-UI-Out-Filterresults: notjunk:1; V01:K0:Df0F94Y76AE=:zNr8HyeogFnk+3KZTesze6 G3qVqMgJhYJv3bu01RfLXs9buEMMyaIRfPGxTsUgUTuC9WVzf9F4fwH4Ea0WBKGGZLb7ddNne YBrRKC7xcEFtWt6dp4IUh3+J142IpAV0iN3+miCD7rCArU9enwhCFWqyMFuPan5OZ7x5XUOWS Hx6aLocRtjz2A8L9R/iiiqESY2YlCfrEFK9H8TKJqAFG8DvcUewxDvu7yHWFljq7f+A/Mp4w4 BGoKkSQyO9xCKjuDkQ0NWk/dYtUvs8Lk+7SjFKpEg6AZaH2pwU0y1l0U6+kvBizrSTzBxXorW SogKiwqGS5rqx0WM2dh78veIxc58me2GTN0eRqwSUpOE/A9gEIRt5/RkQ5BCp3InltFD+aWHd zahYGErL4HvGpxyU27rQRw71zRxB3g2vMYUuourIIP+xBB7drrQ07rtObQsBiNlfaSFtno5hI lVlHwlYVvd/azCcXHOUBsvwl+jTHSJVTbJ4q4qpdxVZ+dTVs+3qIrxJy6jWC+j3pMh/VBQ4wc 3p+xVC8qJWFoD/ytvMFJcsqJtno3V3OYj9xHmdgQcPk75xe06zmVesShbia41etIsp8jOHzJl I8u9Hd0+odqvNLqjsGT2R471H62n80kXyYTXpyH77vxBv1woD6dqH0NSomhfWgAeCAHZuAEYG zfH6uXn5/gwbyLogleroyNaIDELLSvz5zx97VSPjgzu9FoNo/uzfrb4GIn7hFYLqnoU0= Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org With posix timers having become optional, we get a build error with the cpts time sync option of the CPSW driver: drivers/net/ethernet/ti/cpts.c: In function 'cpts_find_ts': drivers/net/ethernet/ti/cpts.c:291:23: error: implicit declaration of function 'ptp_classify_raw';did you mean 'ptp_classifier_init'? [-Werror=implicit-function-declaration] It really makes no sense to build this driver if we can't use PTP, so it's better to go back to 'select PTP_1588_CLOCK' but instead add a dependency on POSIX_TIMERS. Fixes: baa73d9e478f ("posix-timers: Make them configurable") Signed-off-by: Arnd Bergmann --- drivers/net/ethernet/ti/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 2.9.0 diff --git a/drivers/net/ethernet/ti/Kconfig b/drivers/net/ethernet/ti/Kconfig index 296c8efd0038..366e29ff8605 100644 --- a/drivers/net/ethernet/ti/Kconfig +++ b/drivers/net/ethernet/ti/Kconfig @@ -76,7 +76,8 @@ config TI_CPSW config TI_CPTS tristate "TI Common Platform Time Sync (CPTS) Support" depends on TI_CPSW || TI_KEYSTONE_NETCP - imply PTP_1588_CLOCK + depends on POSIX_TIMERS + select PTP_1588_CLOCK ---help--- This driver supports the Common Platform Time Sync unit of the CPSW Ethernet Switch and Keystone 2 1g/10g Switch Subsystem. From patchwork Fri Dec 16 09:19:59 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 101404 Delivered-To: patch@linaro.org Received: by 10.182.112.6 with SMTP id im6csp148086obb; Fri, 16 Dec 2016 01:21:45 -0800 (PST) X-Received: by 10.99.245.21 with SMTP id w21mr3905535pgh.5.1481880105050; Fri, 16 Dec 2016 01:21:45 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k21si6913647pgg.84.2016.12.16.01.21.44; Fri, 16 Dec 2016 01:21:45 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of netdev-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of netdev-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760204AbcLPJVi (ORCPT + 5 others); Fri, 16 Dec 2016 04:21:38 -0500 Received: from mout.kundenserver.de ([212.227.17.10]:51446 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760190AbcLPJVc (ORCPT ); Fri, 16 Dec 2016 04:21:32 -0500 Received: from wuerfel.lan ([78.43.21.235]) by mrelayeu.kundenserver.de (mreue101 [212.227.15.145]) with ESMTPA (Nemesis) id 0MYekE-1c45DR1jaE-00VSQy; Fri, 16 Dec 2016 10:21:11 +0100 From: Arnd Bergmann To: "David S. Miller" Cc: Arnd Bergmann , Grygorii Strashko , Thomas Gleixner , Nicolas Pitre , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , WingMan Kwok , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net 3/3] cpsw/netcp: work around reverse cpts dependency Date: Fri, 16 Dec 2016 10:19:59 +0100 Message-Id: <20161216092017.2560717-3-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 In-Reply-To: <20161216092017.2560717-1-arnd@arndb.de> References: <20161216092017.2560717-1-arnd@arndb.de> X-Provags-ID: V03:K0:T+XphN2sMgYktxaCQFrW4MwWN3v9OHS4IOcoZyzufRfvjT5UeBy naMvMuJ0/ZQohrRFkLF4lFfukR0GokUs8vutfbf5VKlwmDP+1iWLHggP7Axy06rs8ANnUDR IiTD80noj4sncyi+KIpxey19K/1bA5ynTT4Ib3X8WqEnv8h01LgamZYSUfr/TKTQoNny3ye tiaA15vHtprjGNcRZQoCA== X-UI-Out-Filterresults: notjunk:1; V01:K0:S9L8IvZM4qU=:8b7u5p8CmOCxAp4ZC0bcF+ hjPpSL/3KoZJQQEFrnCiFgtAMzCoCdPhyhz5dTSJTLd6dwKwe13IzUsnkc2YbLnO6Q3mqBupK bZ+H0h7as+ilaxC2TR8dpfFz+r3qRWZkx+GP5/CEemcJQO62nT15EzxcT1E6KTxdPRbV9B6KJ z7HQv33vgQN3gppXWq5EErNasUVm/IJmC8cKknRinv4aht++vn2C6KlXsWxyqbTSYeA9MJcOi bXNbHMM5FWY/yUrCRZ2Eby6hTDe1AmHeEFn8DBuleREzAdWFl7ya/Nlh2Vy1QwAqkbmG+mbkF mMcpz+V+rIVKz23rbJpkDAWVzny0USMZz3Av3BQmiWzXTJ/qw/toYOF4ETwBUu7tHNgbh2mjQ RD2y+Wq4/F/sMHZEi7k5dGBBSj4S+8FeeNo7ChY1BxwMnasZAkN5KjBKd+hnZ1Y5HQWogtFOh uUkNI1NKTf10SEOay8uCE32PgutnCfGLUL6dmPt2ihFfn3MNiUiX6exVR2dM9ty5XmBqCmSTk PPOPDuF8GUqMn6TkGA9k/igVBDcnvuYz19P0yViuidf0HBLn3s4p+H5WRTyH9V/LX0DDz8/pl aetCFr2RJIYsP8nmrNf22oABSxqvaO+cNqYr8a2WGsKhxBRTV+eBfPVxnokIIPwn5oc+lqxuP Ajaz/1MlCz7/aAaI0GYmKjhBQ9MeNXKe1G57AWs/7WMnCTrPFeOwWp91H0h4O0vsCJhw= Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The dependency is reversed: cpsw and netcp call into cpts, but cpts depends on the other two in Kconfig. This can lead to cpts being a loadable module and its callers built-in: drivers/net/ethernet/ti/cpsw.o: In function `cpsw_remove': cpsw.c:(.text.cpsw_remove+0xd0): undefined reference to `cpts_release' drivers/net/ethernet/ti/cpsw.o: In function `cpsw_rx_handler': cpsw.c:(.text.cpsw_rx_handler+0x2dc): undefined reference to `cpts_rx_timestamp' drivers/net/ethernet/ti/cpsw.o: In function `cpsw_tx_handler': cpsw.c:(.text.cpsw_tx_handler+0x7c): undefined reference to `cpts_tx_timestamp' drivers/net/ethernet/ti/cpsw.o: In function `cpsw_ndo_stop': As a workaround, I'm introducing another Kconfig symbol to control the compilation of cpts, while making the actual module controlled by a silent symbol that is =y when necessary. Fixes: 6246168b4a38 ("net: ethernet: ti: netcp: add support of cpts") Signed-off-by: Arnd Bergmann --- drivers/net/ethernet/ti/Kconfig | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) -- 2.9.0 diff --git a/drivers/net/ethernet/ti/Kconfig b/drivers/net/ethernet/ti/Kconfig index 366e29ff8605..c114efcd1575 100644 --- a/drivers/net/ethernet/ti/Kconfig +++ b/drivers/net/ethernet/ti/Kconfig @@ -73,8 +73,8 @@ config TI_CPSW To compile this driver as a module, choose M here: the module will be called cpsw. -config TI_CPTS - tristate "TI Common Platform Time Sync (CPTS) Support" +config TI_CPTS_ENABLE + bool "TI Common Platform Time Sync (CPTS) Support" depends on TI_CPSW || TI_KEYSTONE_NETCP depends on POSIX_TIMERS select PTP_1588_CLOCK @@ -84,6 +84,12 @@ config TI_CPTS The unit can time stamp PTP UDP/IPv4 and Layer 2 packets, and the driver offers a PTP Hardware Clock. +config TI_CPTS + tristate + depends on TI_CPTS_ENABLE + default y if TI_CPSW=y || TI_KEYSTONE_NETCP=y + default m + config TI_KEYSTONE_NETCP tristate "TI Keystone NETCP Core Support" select TI_CPSW_ALE