From patchwork Sun Jan 6 22:50:33 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 154846 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp2899795ljp; Sun, 6 Jan 2019 14:53:15 -0800 (PST) X-Google-Smtp-Source: ALg8bN4H+d1HEGFsQmWcUJ0KDDNZeynfeJQp6iL1nPXtOifZE8jQZoVY4C1LvzpTjcpgEKGw5g3q X-Received: by 2002:a1c:7eca:: with SMTP id z193mr7578523wmc.140.1546815195478; Sun, 06 Jan 2019 14:53:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1546815195; cv=none; d=google.com; s=arc-20160816; b=I+fV2/qgstQSA587RDnVBZuVxFApW3mcJvCKZsgX0ju42YGfVGJH5+2ZDRQU1sjth0 Hf1bmWb78QYzodMyhx5tp2nZr9+R9Gi2MaeikoGPt/Ddig0/fumV+wMaKLuSBChyjJCX J6idUOvvSnVsNj6/j14mdjibI2WlddF33BTpUDADuIbAzHGy+yLa31xal+Kyu4VnNIab 0mCyfk5+Ia7NkONmcJ8ZWwHZ7ef6pT91YrBPxmbGhE8ADWpJgcpsGWPYpJ9oN/nlCns4 hrdDlyHHWkdgxjfDgy9YmTzQi5bt2xYEg+/N/OkZpLstGltF4gEpJOfedkHH++ixM2z4 0d0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=kn8TChn9a+pm0RN7mZwckgPE1JRDgQHcCQVRvVrkJ7Y=; b=iluwhtHBCxmUUddF8UMTL1ExVgCDJHguwohBdIjFNEpeUn2Q/oYCsDbVAQQCMif6g7 XLwfcQKnmDphs/d6pyiLClIGt9jKVE6hsaUmjEdkPe6fzyFIELDsd6vZbpUtzaoYFb5F 3e3e2h4K35X4D/jlMRLqAEXAVjxVMfl/9vq5XT9k8JWslI/ojMxHgG1n4uPLaJOtxDhj OpkWYsx00mrYdfmbxAFF6CGn/VD3C/Z6As6+EZavWTOuKTuoMxI1F60pDvsJ8YeNFA32 BGzDfVQPlicSqwazaymWG33tnIhXhGHUQkluXvbpzgly1+fHXCdBrBMQbKB4jB8XVpFs KJhQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=bHLGqdcH; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from listsout.gnu.org (listsout.gnu.org. [208.118.235.17]) by mx.google.com with ESMTPS id w203si4298009wma.43.2019.01.06.14.53.15 for (version=TLS1 cipher=AES128-SHA bits=128/128); Sun, 06 Jan 2019 14:53:15 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=bHLGqdcH; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([127.0.0.1]:50568 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ggHI9-00054W-0v for patch@linaro.org; Sun, 06 Jan 2019 17:53:13 -0500 Received: from eggs.gnu.org ([209.51.188.92]:53551) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ggHFo-0003mR-MP for qemu-devel@nongnu.org; Sun, 06 Jan 2019 17:50:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ggHFn-0004gQ-Pg for qemu-devel@nongnu.org; Sun, 06 Jan 2019 17:50:48 -0500 Received: from mail-pl1-x644.google.com ([2607:f8b0:4864:20::644]:40558) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ggHFn-0004g4-KR for qemu-devel@nongnu.org; Sun, 06 Jan 2019 17:50:47 -0500 Received: by mail-pl1-x644.google.com with SMTP id u18so19931181plq.7 for ; Sun, 06 Jan 2019 14:50:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=kn8TChn9a+pm0RN7mZwckgPE1JRDgQHcCQVRvVrkJ7Y=; b=bHLGqdcHZdEZOXs6S+jX0XGhwgSMIKO1PeZi6eVSo+9f3gVrKfuz3O3gPa6rooL9x1 xhMJDocZEpeKSf6f5ozxI2getqhOqxfC9nTd+Ucv18RfePA/cx9QHudDK96GYLnV8NkL x2mi3MhIhrgbgb7mF3kcx542fpjbO5y8WBUl0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=kn8TChn9a+pm0RN7mZwckgPE1JRDgQHcCQVRvVrkJ7Y=; b=nefR5CTJWroWq3fMsiagP5z7QJG2+UhR5Il3Mu3STHfZ/1xZSBKl4qripuNGauV9Lo eZukO5IZboNtRu0gXx002Oo/WCft/iuPfoQcmAv5Qga0vOew2oo+tTcUxs/rpaRIJpTV YJKxVSGlFrNDmUJhBYZPJbsO/0SpnuJ8HGhhxo6HpWtzEiRTMLtGS8VMyg/UoO4T/Qbz CfxgeW73l/1O6HqEMawN3EPPcDP50kGzAs4kz3F2ZqUZbKSCBKBMTQwx1+CAEYUaNxjR iqRy0WktL3qOiEVtcjf0R1zbcv5MgOOfliBmHRHd/9plL7KHS04FxVrBWrbQ+POoGpOs qAxQ== X-Gm-Message-State: AJcUukdBgYYl1nQRkFnBKmE5bQatljaRgatKM/7Pz6hNEX9BOTlC8TKS v2AVYQj5sPo+7xQSjuhMtV98eARO6UmJFw== X-Received: by 2002:a17:902:b090:: with SMTP id p16mr59152015plr.190.1546815046394; Sun, 06 Jan 2019 14:50:46 -0800 (PST) Received: from cloudburst.lan (2001-44b8-2176-c800-8cc6-2630-7d99-5ef1.static.ipv6.internode.on.net. [2001:44b8:2176:c800:8cc6:2630:7d99:5ef1]) by smtp.gmail.com with ESMTPSA id n78sm45905768pfk.19.2019.01.06.14.50.43 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 06 Jan 2019 14:50:45 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Date: Mon, 7 Jan 2019 08:50:33 +1000 Message-Id: <20190106225035.5671-2-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20190106225035.5671-1-richard.henderson@linaro.org> References: <20190106225035.5671-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::644 Subject: [Qemu-devel] [PATCH 1/3] target/arm: Rely on optimization within tcg_gen_gvec_or X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, qemu-arm@nongnu.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Since we're now handling a == b generically, we no longer need to do it by hand within target/arm/. Reviewed-by: David Gibson Signed-off-by: Richard Henderson --- target/arm/translate-a64.c | 6 +----- target/arm/translate-sve.c | 6 +----- target/arm/translate.c | 12 +++--------- 3 files changed, 5 insertions(+), 19 deletions(-) -- 2.17.2 diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index e1da1e4d6f..2d6f8c1b4f 100644 --- a/target/arm/translate-a64.c +++ b/target/arm/translate-a64.c @@ -10152,11 +10152,7 @@ static void disas_simd_3same_logic(DisasContext *s, uint32_t insn) gen_gvec_fn3(s, is_q, rd, rn, rm, tcg_gen_gvec_andc, 0); return; case 2: /* ORR */ - if (rn == rm) { /* MOV */ - gen_gvec_fn2(s, is_q, rd, rn, tcg_gen_gvec_mov, 0); - } else { - gen_gvec_fn3(s, is_q, rd, rn, rm, tcg_gen_gvec_or, 0); - } + gen_gvec_fn3(s, is_q, rd, rn, rm, tcg_gen_gvec_or, 0); return; case 3: /* ORN */ gen_gvec_fn3(s, is_q, rd, rn, rm, tcg_gen_gvec_orc, 0); diff --git a/target/arm/translate-sve.c b/target/arm/translate-sve.c index b15b615ceb..3a2eb51566 100644 --- a/target/arm/translate-sve.c +++ b/target/arm/translate-sve.c @@ -280,11 +280,7 @@ static bool trans_AND_zzz(DisasContext *s, arg_rrr_esz *a) static bool trans_ORR_zzz(DisasContext *s, arg_rrr_esz *a) { - if (a->rn == a->rm) { /* MOV */ - return do_mov_z(s, a->rd, a->rn); - } else { - return do_vector3_z(s, tcg_gen_gvec_or, 0, a->rd, a->rn, a->rm); - } + return do_vector3_z(s, tcg_gen_gvec_or, 0, a->rd, a->rn, a->rm); } static bool trans_EOR_zzz(DisasContext *s, arg_rrr_esz *a) diff --git a/target/arm/translate.c b/target/arm/translate.c index 7c4675ffd8..33b1860148 100644 --- a/target/arm/translate.c +++ b/target/arm/translate.c @@ -6294,15 +6294,9 @@ static int disas_neon_data_insn(DisasContext *s, uint32_t insn) tcg_gen_gvec_andc(0, rd_ofs, rn_ofs, rm_ofs, vec_size, vec_size); break; - case 2: - if (rn == rm) { - /* VMOV */ - tcg_gen_gvec_mov(0, rd_ofs, rn_ofs, vec_size, vec_size); - } else { - /* VORR */ - tcg_gen_gvec_or(0, rd_ofs, rn_ofs, rm_ofs, - vec_size, vec_size); - } + case 2: /* VORR */ + tcg_gen_gvec_or(0, rd_ofs, rn_ofs, rm_ofs, + vec_size, vec_size); break; case 3: /* VORN */ tcg_gen_gvec_orc(0, rd_ofs, rn_ofs, rm_ofs, From patchwork Sun Jan 6 22:50:34 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 154848 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp2900829ljp; Sun, 6 Jan 2019 14:55:29 -0800 (PST) X-Google-Smtp-Source: ALg8bN6Nhcr+ehsvNQUxL8nX1UyUquQV/g1bHSm5mJ1awcPUpPGb5YQzUszxQ1MhFrtbNDpqaIxZ X-Received: by 2002:adf:fdc2:: with SMTP id i2mr52310484wrs.117.1546815329184; Sun, 06 Jan 2019 14:55:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1546815329; cv=none; d=google.com; s=arc-20160816; b=xV5FZNr7SfwNZo/AiVpwOqeyMWnc0fp+J3tyKGviHRqziHrUXriZn88jl5VP9JCAGw O6qxut5QQV97osH2aX5lfSBKbydYSEtl+c37X61tyqGF4O/SoKSbuANULYe3I9PRrglE oxOR6P1tw0oNoWjnbV9UUXZjXALgxdtbKnxb0qBBSKEBt3mSvENP9vJ9DG9lsUInlDof rDo/9bP5QevaPemvnDb7fxH+xbkPYv6bE8jrnqSvT9RdiMkQN/uwzxzIfAcv+K4aypwR mkcN9gavMeXYbp/miT7y/0z9xXiWA5wSkbwJyCMGJiqHrbcv7artw77iZENwmLlUUyVO p8BA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=FerA1jdUPmyzDQdllgAlLCmDGQMUpOXaXKd/jiLP8aM=; b=qDq9oUt4K3bisqj1UB67Kx13gWfKRv1HlhY9ZiU4CoNJW85yzFceINmQADy20Pr7cu UrM5znxJEkPsBBMGYsCLJgV1zZ6AhO1GLxF2uY4FWtYrVrKkhQxWi5eYiijb5BRs55g1 oWrPosP92e+WcifEmBGf1yTDMv62mUZ8P85BaBWyQweDov+VK17XfP8lXPNGN4RjOu7C AQErAZ6Q2eRrZ0kOOtbh7IxmYExkWr5q1QDSYOTqnTmOZpUmq/Ww8v+l84u6kLNOuFq2 hmWR5uEYa4bGdO7hIx8OueaVrSVGAArpoRkmlwiVTAOhGJXIhFXmP7gCDUDOoTLXLMLk w80Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=CgDnNjU3; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id k132si4191916wmd.106.2019.01.06.14.55.29 for (version=TLS1 cipher=AES128-SHA bits=128/128); Sun, 06 Jan 2019 14:55:29 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=CgDnNjU3; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([127.0.0.1]:51201 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ggHKK-0007es-9O for patch@linaro.org; Sun, 06 Jan 2019 17:55:28 -0500 Received: from eggs.gnu.org ([209.51.188.92]:53574) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ggHFr-0003pr-9S for qemu-devel@nongnu.org; Sun, 06 Jan 2019 17:50:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ggHFq-0004h8-Fk for qemu-devel@nongnu.org; Sun, 06 Jan 2019 17:50:51 -0500 Received: from mail-pl1-x643.google.com ([2607:f8b0:4864:20::643]:43783) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ggHFq-0004gs-Ag for qemu-devel@nongnu.org; Sun, 06 Jan 2019 17:50:50 -0500 Received: by mail-pl1-x643.google.com with SMTP id gn14so19945372plb.10 for ; Sun, 06 Jan 2019 14:50:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=FerA1jdUPmyzDQdllgAlLCmDGQMUpOXaXKd/jiLP8aM=; b=CgDnNjU3z/4026ZoL+JSXZx91soiI0VkY8LF2EkblXEjDAPh2sWt9qNB82bIsuQK6M uThgi2KY3zWP9+1hU1NkEH+FtoZUWG/lKAkhAQXVHpitAKuqvTsj4JJO14uTrjTnpWOU RnSQRf+uEdEAd58JH8exzmAUtAaYjvOFk02Zo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=FerA1jdUPmyzDQdllgAlLCmDGQMUpOXaXKd/jiLP8aM=; b=tYa414SqG+ZKsD9C/sLmQlOHIv0Bl9OLfTCjAV2RK2ddW57K30oCQvD3lkE8CyxIEV kQg/L3OMXivIUPmhgLUl7SdbgMIp5/7WdVa+e3XW4o2Z7nYrYdxZEX1ae2dNMGpsQwRB IyS6chXPwmGDevjhGaAjZwA6siINudWDkLMqyA7SNapKM0xLBuYkbp/N0dxZh4NDsrT1 yaGmTuEIjWXktgdxlSU1wVFmxjjzdPJYo6pSmDNCzWHxJaYp58x/B/S1HiHhBr0XcWve utlSFx8GNSADgnzMasfWqpJ5++JAjzgK+zMC2yhIdPrmR1iITXNN6gamoZ2Yb5BlmKd9 jB0w== X-Gm-Message-State: AJcUukdBPb+QDxXqqSCX3I68Y0xyjgdR2zodS9Oy9t4TzZqLObJBStCN TiiQJqAw2p4Fb0etLncth0/gCwzvtvH/aQ== X-Received: by 2002:a17:902:5a4d:: with SMTP id f13mr60842695plm.49.1546815049177; Sun, 06 Jan 2019 14:50:49 -0800 (PST) Received: from cloudburst.lan (2001-44b8-2176-c800-8cc6-2630-7d99-5ef1.static.ipv6.internode.on.net. [2001:44b8:2176:c800:8cc6:2630:7d99:5ef1]) by smtp.gmail.com with ESMTPSA id n78sm45905768pfk.19.2019.01.06.14.50.46 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 06 Jan 2019 14:50:48 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Date: Mon, 7 Jan 2019 08:50:34 +1000 Message-Id: <20190106225035.5671-3-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20190106225035.5671-1-richard.henderson@linaro.org> References: <20190106225035.5671-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::643 Subject: [Qemu-devel] [PATCH 2/3] target/arm: Use vector minmax expanders for aarch64 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, qemu-arm@nongnu.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Signed-off-by: Richard Henderson --- target/arm/translate-a64.c | 35 ++++++++++++++--------------------- 1 file changed, 14 insertions(+), 21 deletions(-) -- 2.17.2 Reviewed-by: Peter Maydell diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index 2d6f8c1b4f..bef21ada71 100644 --- a/target/arm/translate-a64.c +++ b/target/arm/translate-a64.c @@ -10452,6 +10452,20 @@ static void disas_simd_3same_int(DisasContext *s, uint32_t insn) } switch (opcode) { + case 0x0c: /* SMAX, UMAX */ + if (u) { + gen_gvec_fn3(s, is_q, rd, rn, rm, tcg_gen_gvec_umax, size); + } else { + gen_gvec_fn3(s, is_q, rd, rn, rm, tcg_gen_gvec_smax, size); + } + return; + case 0x0d: /* SMIN, UMIN */ + if (u) { + gen_gvec_fn3(s, is_q, rd, rn, rm, tcg_gen_gvec_umin, size); + } else { + gen_gvec_fn3(s, is_q, rd, rn, rm, tcg_gen_gvec_smin, size); + } + return; case 0x10: /* ADD, SUB */ if (u) { gen_gvec_fn3(s, is_q, rd, rn, rm, tcg_gen_gvec_sub, size); @@ -10613,27 +10627,6 @@ static void disas_simd_3same_int(DisasContext *s, uint32_t insn) genenvfn = fns[size][u]; break; } - case 0xc: /* SMAX, UMAX */ - { - static NeonGenTwoOpFn * const fns[3][2] = { - { gen_helper_neon_max_s8, gen_helper_neon_max_u8 }, - { gen_helper_neon_max_s16, gen_helper_neon_max_u16 }, - { tcg_gen_smax_i32, tcg_gen_umax_i32 }, - }; - genfn = fns[size][u]; - break; - } - - case 0xd: /* SMIN, UMIN */ - { - static NeonGenTwoOpFn * const fns[3][2] = { - { gen_helper_neon_min_s8, gen_helper_neon_min_u8 }, - { gen_helper_neon_min_s16, gen_helper_neon_min_u16 }, - { tcg_gen_smin_i32, tcg_gen_umin_i32 }, - }; - genfn = fns[size][u]; - break; - } case 0xe: /* SABD, UABD */ case 0xf: /* SABA, UABA */ { From patchwork Sun Jan 6 22:50:35 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 154847 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp2900826ljp; Sun, 6 Jan 2019 14:55:29 -0800 (PST) X-Google-Smtp-Source: ALg8bN6sWnosVRJZ3vD2ZRqzqaXVxC71DYgSuKlEg0FwuBfCfP9kINLF9P2oFtTAfW5lvn9X0Qy9 X-Received: by 2002:adf:f504:: with SMTP id q4mr52229918wro.321.1546815329022; Sun, 06 Jan 2019 14:55:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1546815329; cv=none; d=google.com; s=arc-20160816; b=Ki2ACal2AKp1DxehbpsoLtug4/pC+f4qAqdaZLVII8HOdKndN3QNW//p/32M5CYj3V j0RAcSkDb5VNS2jaJSeB2itSarTEZcBk/E+p9lgYXv3FTPUNGYBTDsRwB2vp+sEss3hL GC5apU/QiydyxDTAlciznm6K6z3SCa/aUQDnxkDOSElOtR8rM/E8YR8vzz9/EDIJDHYU Gg7TnaermbIgD2alWGz0JLRrY1ZzF6nJJJiUj3TXgHIer8z2E4EH2ZPFF2HeBuJv5CVE gO2zTe65GfIjwzyzrFHEWVgWDsklQKAr9Ix4dIgHv8TMRTq1dGCRdLufAS4c5VJQyieu le6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=kSo0oKSo1CsoY2QHLe3rTxnPQOT4r7h09gkl4JXYPGw=; b=zeX2njZzfJiuYPK/KW9TxWTfQCvfPm4ZUDAFaRUb7gqqBtg+jeS/YalxUJrdZY/CJH 2IA8Cgjoc8J8FaDpiZcYJHA+CUbNZvQR3ruxF2P2crdbeozOMhOBtoHVmctBvGUYQ8Gc 5AYeoyRrXNMPmyJL5lUducbM92Kg+ZzYdqzSgKNmA3uv+oATqPJa9CLFiPXjlL3Te9mv XIUvk62K+PqS33Gze17pUtQ5a2bnf6HrTUJxyuf7ns4DWMoDVojx1dM+KYUetynpquD+ KXg6eRU2qYGuzuL4nUT9nDQJZ6UhYybNScUkT9elhzjaEpTaUUhQHSZbMKIQXEfDyDeR b/1g== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b="Lfh/sl+/"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id a10si36943055wrh.180.2019.01.06.14.55.28 for (version=TLS1 cipher=AES128-SHA bits=128/128); Sun, 06 Jan 2019 14:55:29 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b="Lfh/sl+/"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([127.0.0.1]:51199 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ggHKK-0007eo-4t for patch@linaro.org; Sun, 06 Jan 2019 17:55:28 -0500 Received: from eggs.gnu.org ([209.51.188.92]:53612) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ggHFv-0003v0-2y for qemu-devel@nongnu.org; Sun, 06 Jan 2019 17:50:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ggHFt-0004lY-MB for qemu-devel@nongnu.org; Sun, 06 Jan 2019 17:50:54 -0500 Received: from mail-pl1-x641.google.com ([2607:f8b0:4864:20::641]:41691) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ggHFt-0004ja-EK for qemu-devel@nongnu.org; Sun, 06 Jan 2019 17:50:53 -0500 Received: by mail-pl1-x641.google.com with SMTP id u6so19934294plm.8 for ; Sun, 06 Jan 2019 14:50:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=kSo0oKSo1CsoY2QHLe3rTxnPQOT4r7h09gkl4JXYPGw=; b=Lfh/sl+/68m//Y2YF1vDNRLPg+ceFxNSlF9404jjh0mTezBeeNR7Sh5ONIHrVeXYqf Ft0yNymMn585Df6cedqBrQaBaJphw70wDDP7BtHk0/IIXHIGcw5v9uvUuXtbnqxffOig RlGZgQIyW09eIT5mhQP3eRiC0TjMf+u3g/RrY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=kSo0oKSo1CsoY2QHLe3rTxnPQOT4r7h09gkl4JXYPGw=; b=Cn8e7QxBmTHUO26arXGeNzv8npgLYAWWFZrwLSofiCkmVZV9DKu/fN7hh8QXuYFvGK ndy+I/RN+eqMh2hzbNbOib/LCGRbRJHJuTxv8Fa89LDd9WbzujG0EgmQWcWsppRXLtum l3pYDqe6n38tWi9DKqSiQIxb0574e0lS1kzXSw5ttpChznedhQuPcLhVBivjkJB+7InR e9aRajzbFEdXfX17dxAVhXDJx8AWBcK9Jpk2QgmZ4IM7wHSK5FKtIvk9CHMat1AKp0Y5 uzWUWsKXqv3H2oj4wmm+AGV9aruj/LablAR7Fo/Z1V2rkkkvDAbtCMK1MPb1FjceDuE+ p2ZQ== X-Gm-Message-State: AJcUukeHo3JjvaR4ZX7wpTcAzvaAbzfn4E4q2Uvz28oYKGchLp+KCpkT W/SJRYTLIkkkmRiqFoHZjzO5udxCPIy6xA== X-Received: by 2002:a17:902:1008:: with SMTP id b8mr57215902pla.252.1546815052118; Sun, 06 Jan 2019 14:50:52 -0800 (PST) Received: from cloudburst.lan (2001-44b8-2176-c800-8cc6-2630-7d99-5ef1.static.ipv6.internode.on.net. [2001:44b8:2176:c800:8cc6:2630:7d99:5ef1]) by smtp.gmail.com with ESMTPSA id n78sm45905768pfk.19.2019.01.06.14.50.49 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 06 Jan 2019 14:50:51 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Date: Mon, 7 Jan 2019 08:50:35 +1000 Message-Id: <20190106225035.5671-4-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20190106225035.5671-1-richard.henderson@linaro.org> References: <20190106225035.5671-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::641 Subject: [Qemu-devel] [PATCH 3/3] target/arm: Use vector minmax expanders for aarch32 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, qemu-arm@nongnu.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Signed-off-by: Richard Henderson --- target/arm/translate.c | 25 +++++++++++++++++++------ 1 file changed, 19 insertions(+), 6 deletions(-) -- 2.17.2 Reviewed-by: Peter Maydell diff --git a/target/arm/translate.c b/target/arm/translate.c index 33b1860148..f3f172f384 100644 --- a/target/arm/translate.c +++ b/target/arm/translate.c @@ -6368,6 +6368,25 @@ static int disas_neon_data_insn(DisasContext *s, uint32_t insn) tcg_gen_gvec_cmp(u ? TCG_COND_GEU : TCG_COND_GE, size, rd_ofs, rn_ofs, rm_ofs, vec_size, vec_size); return 0; + + case NEON_3R_VMAX: + if (u) { + tcg_gen_gvec_umax(size, rd_ofs, rn_ofs, rm_ofs, + vec_size, vec_size); + } else { + tcg_gen_gvec_smax(size, rd_ofs, rn_ofs, rm_ofs, + vec_size, vec_size); + } + return 0; + case NEON_3R_VMIN: + if (u) { + tcg_gen_gvec_umin(size, rd_ofs, rn_ofs, rm_ofs, + vec_size, vec_size); + } else { + tcg_gen_gvec_smin(size, rd_ofs, rn_ofs, rm_ofs, + vec_size, vec_size); + } + return 0; } if (size == 3) { @@ -6533,12 +6552,6 @@ static int disas_neon_data_insn(DisasContext *s, uint32_t insn) case NEON_3R_VQRSHL: GEN_NEON_INTEGER_OP_ENV(qrshl); break; - case NEON_3R_VMAX: - GEN_NEON_INTEGER_OP(max); - break; - case NEON_3R_VMIN: - GEN_NEON_INTEGER_OP(min); - break; case NEON_3R_VABD: GEN_NEON_INTEGER_OP(abd); break;