From patchwork Wed Jan 9 18:01:32 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vincent Guittot X-Patchwork-Id: 155090 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp987716jaa; Wed, 9 Jan 2019 10:01:40 -0800 (PST) X-Google-Smtp-Source: ALg8bN5e+10xlCtjlKvWZLcCsIpLk8KzNqL/VtL76KiDqgDR60OhwXP40yNp96vKkOnMNxiGYK/K X-Received: by 2002:a17:902:112c:: with SMTP id d41mr6786120pla.144.1547056900446; Wed, 09 Jan 2019 10:01:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547056900; cv=none; d=google.com; s=arc-20160816; b=1Ab2nJgxJ7VXDe63OjObUsRo2Y9oahNRJXCle6oHzGXQ65VRei3vFuqs5jm96Rjy75 4gTwTCI5Tzg8nGa7dY4g+MiRKfXScvWpAQwxvnkO+1RxVCh4H78z2lyr9uxhNy/jr6Yi XLm5lnBw8qngro2OG26CaB3cc81sMvDYOev5fOaMeJemMhEVCXtQhtGiilEfwS1MQnRR 5rE0o4oIbNRcRSwqKX8oTXGeC/hao3xpn234bOB0e9S+6Q0yGxKlnlIhVXScfMy3SQz9 DmOvScJgIk1i5bhj8FCJ6ZjIW/NVNDjmgrpZvLnlJat1MJ/zIAtIpCjrwsjcbvW7SE+b 0hQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature; bh=aa7DBW2jefMqiPG5SEMBLPrEapaMRoLwEi0UQnoTFU8=; b=VxTh4uLq22GTB/JfA4MD1GyHAoLRnMJmQ0rD5LHeenE9fRJVQrsv9j8H4tdyiNhPrA 5yWJdHbiHR8QOm7F6aKofwCL3mXuxH3pLhSafwdRy7ex78TxFYJ5zi/lm/+PtTKs2ZfU v+ShyZDqQ69VPmtmDq7KgYAAS92cAmbh50WwaTcRMJZN7p3GepK+8VRlZivUk0Xib2Pv 58WLMEFSIhXJsWT52/t85jOKOfg5k5bMnQNOgmQoWOAMfbUai8J/tC8vIGjFn8zkIEPD YWhf+tBI6v0toStFw8kJeCnJN6xIDAgGargIzSV2UdcJssh33WqneSJxvZzUdRcc25Kg Enyw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=kHrRpM+t; spf=pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u10si2948699plz.119.2019.01.09.10.01.38; Wed, 09 Jan 2019 10:01:40 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=kHrRpM+t; spf=pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727286AbfAISBi (ORCPT + 7 others); Wed, 9 Jan 2019 13:01:38 -0500 Received: from mail-wr1-f65.google.com ([209.85.221.65]:37821 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727284AbfAISBi (ORCPT ); Wed, 9 Jan 2019 13:01:38 -0500 Received: by mail-wr1-f65.google.com with SMTP id s12so8636790wrt.4 for ; Wed, 09 Jan 2019 10:01:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=aa7DBW2jefMqiPG5SEMBLPrEapaMRoLwEi0UQnoTFU8=; b=kHrRpM+tjApF6eo1Zoxeiztl2FiwR3WBHD4oQFYwP0nnI8i7B0paOQaj4rtScDvFqy skEhNcLQEuVf86pFN4mklZeUyvysvXZzxr+h69qncZgJeLNS/e+e9QiVJ/QVK+9dxj8o VdlLATOi4nSqcan2ERN7GSK0BlnsPJgu6fWkw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=aa7DBW2jefMqiPG5SEMBLPrEapaMRoLwEi0UQnoTFU8=; b=VguB05U5+M5kJ5hs85Gz/EO4stKGMjxyK7dcrqBOMYQhImRqnjGHI94+bW4SA+h7V9 gufMQKzKh+qdGdvb9afcsVeIqWSw++MRpIC8cxmCL6MmqmKGAfL5cSXqn6V/o/1mmbJ+ Hl3a2axwM2+DIRt0NVkRxhF/y3n2lp46jdBYKUPsFbdoLffWBgFTAcHhWjBpr8QUo6EF XcteVpT8vLxlWDSX0EeFWPSsaKwC+5goJ0l+gjtgEykbqe/iHrCBZLQlZUCx+/QeXxVJ 6ki+vOqbZUbolKGCN3BYdaJUEmN5U8TxVrGTDzx3N7WpirGiIMjbH5C0zW93ARtacN5a GBgQ== X-Gm-Message-State: AJcUukcQqu0EXcOCxWGxX+IUCkgiWyQm9VNgDQz7maR6tR46BEVBgd8J S0u/yS1YENEgr8YC6vjuWDXiCzSanR22aA== X-Received: by 2002:a5d:5208:: with SMTP id j8mr6265762wrv.188.1547056896228; Wed, 09 Jan 2019 10:01:36 -0800 (PST) Received: from localhost.localdomain ([2a01:e0a:f:6020:1811:b2bc:9000:4c9]) by smtp.gmail.com with ESMTPSA id m193sm14880509wmb.26.2019.01.09.10.01.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 09 Jan 2019 10:01:35 -0800 (PST) From: Vincent Guittot To: xuwei5@hisilicon.com, robh+dt@kernel.org, mark.rutland@arm.com, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linus.walleij@linaro.org Cc: Vincent Guittot Subject: [PATCH] arm64/hisilicon: fix SDcard detection Date: Wed, 9 Jan 2019 19:01:32 +0100 Message-Id: <1547056892-16527-1-git-send-email-vincent.guittot@linaro.org> X-Mailer: git-send-email 2.7.4 Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org commit 89a5e15bcba8 ("gpio/mmc/of: Respect polarity in the device tree") has changed how cd_gpios phandle and cd-inverted are used to set gpio's flags. Since this change, hikey960 SDcard is not detected anymore because flags are not set correctly. Updating cd-gpios to set GPIO_ACTIVE_LOW instead of high, fixes the problem. Signed-off-by: Vincent Guittot --- arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.7.4 diff --git a/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts b/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts index 4643546..4ef1642 100644 --- a/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts +++ b/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts @@ -582,7 +582,7 @@ sd-uhs-sdr104; disable-wp; cd-inverted; - cd-gpios = <&gpio25 3 0>; + cd-gpios = <&gpio25 3 GPIO_ACTIVE_LOW>; pinctrl-names = "default"; pinctrl-0 = <&sd_pmx_func &sd_clk_cfg_func