From patchwork Mon Jan 14 11:13:27 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anders Roxell X-Patchwork-Id: 155434 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp3533891jaa; Mon, 14 Jan 2019 03:13:39 -0800 (PST) X-Google-Smtp-Source: ALg8bN4aMkAtbR3uJQ6d+tauv6HFwnElgR9Nmi174Qm/jbIwq2yokIcMAmkxbkYtY8+AGwcWcKcT X-Received: by 2002:a17:902:4503:: with SMTP id m3mr25263980pld.23.1547464419684; Mon, 14 Jan 2019 03:13:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547464419; cv=none; d=google.com; s=arc-20160816; b=zrgtg/vn05ewNsM+9HSgFDqHeQSO7O3GpHJrBc+GdFmneXCFjO9k0f1wvkie3bF8Xw GuF8dpENmDGkzLiEW6uNylk4tLPUSU/ja74XycsYDgA5NN5Ohmj/wKBp2xXvLCKaRcxg 4kHk7DV6sl6tAAIkSqA6PQhtb5H7qRHGKFLeS8rELqx11AlNoKhVyu/YShlUz8rr9/Oa b5v8BlBGUPBCubzAUc4NPjytCFO45V0NfYW5s+SFo5XHGI8aqT9TO5NLFRAZdtfqIVxb PRGz214kQasXGaYbdmn5t6kQhZTUchaKeve5BONDo8I/N+K90udfBdTnwHu1BzUZkbMR LkdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature; bh=rYIMl9/h9EZOQmMPk92EhDxxI1xRjILmyoLT4QeKm3M=; b=pAckeQMGj6lAF8l3jVyg8o9F+cmVc9bpdhIzNF4RAv+SCT6IR9BqN9jB98bXm0f4r/ QX21SV0uJDkX9OXNB1/v18Q+Nw/EfXjZ46RABxKyT+K+eGlCfxHqoNBrvnqt/SIEuQcr MVd1AtFAZNdwIMbzVu/pSGNYGE1TCpybCRSqEcvyjo5lK867tmNhYJACU/QRf34iIoJB 9gFXiH9YZliKv1cU+GSgzOQBT18upKH87muxiEXWbLCF0lzKgiCdRj9hJMOjE0FjLKYB K/ggB6lfEuQYenlC2Wg8Ek5YnVuVqXfQfkQy4VgNafT2bsHSBeGalN6vVRRidig0hAY2 Y4UQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=XMPW9bh3; spf=pass (google.com: best guess record for domain of linux-gpio-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-gpio-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v185si131508pfb.65.2019.01.14.03.13.39; Mon, 14 Jan 2019 03:13:39 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-gpio-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=XMPW9bh3; spf=pass (google.com: best guess record for domain of linux-gpio-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-gpio-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726666AbfANLNj (ORCPT + 5 others); Mon, 14 Jan 2019 06:13:39 -0500 Received: from mail-lf1-f67.google.com ([209.85.167.67]:41456 "EHLO mail-lf1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726526AbfANLNi (ORCPT ); Mon, 14 Jan 2019 06:13:38 -0500 Received: by mail-lf1-f67.google.com with SMTP id c16so15266882lfj.8 for ; Mon, 14 Jan 2019 03:13:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=rYIMl9/h9EZOQmMPk92EhDxxI1xRjILmyoLT4QeKm3M=; b=XMPW9bh3DkgBuWhCBgRf9IkQTrK+wVhTFd+AFtB3ndn8y/TiHX2q8CYSqQ1hXgMX/b +klvYxQDL3TPW5r0Zf4tvyznotCCQSDseZqthkQOy1pOnXBJi79E/j12mkybq5uSsLIc LlfKi+9E3sRbqy5q10nbTOdtGF5/ZlXaHlCBA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=rYIMl9/h9EZOQmMPk92EhDxxI1xRjILmyoLT4QeKm3M=; b=Gw+guDnxk6GNqIWp6pdZ3O8ieSldrs+Pi9YdA3q13k8L4Rk/qtFdeV6PiVL798NzIp Y/uwzVXyobt2B2j5f+7BWZQEFw9VVrXpFUCfRchP2fXYGfwMbAy8MyivBbmie9yuixJD R6bUFzKN/mWLsC250PypfhqzezhWkrBngC3TtvzS0oQSpmbSlci6rUXTe6z0szx8JYmn l7nmd47n1cGYUly2Ld/8OHIjE1fqmBjlQCnZO5f/UuRqnOOVOernXT8AnTa3Ecbc1A5F Rj5s56n8h7U7m3BP+5HZgJtaen/JuhgM5MW2w8GR4KEIAxDFRqXNPo5FCgPKMkEHsvha cqMg== X-Gm-Message-State: AJcUukeIMi58RLFkouVokuPOqCOrzVA5/Xc3u8rMNF4ZsLZdruGU7Ufx K6iCb1wDS1l7+C9VIky9+Fps8SzXGaSJQQ== X-Received: by 2002:a19:7006:: with SMTP id h6mr13729987lfc.147.1547464416777; Mon, 14 Jan 2019 03:13:36 -0800 (PST) Received: from localhost (c-573670d5.07-21-73746f28.bbcust.telenor.se. [213.112.54.87]) by smtp.gmail.com with ESMTPSA id h3sm28169lfj.25.2019.01.14.03.13.35 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 14 Jan 2019 03:13:36 -0800 (PST) From: Anders Roxell To: aisheng.dong@nxp.com, festevam@gmail.com, shawnguo@kernel.org, stefan@agner.ch, linus.walleij@linaro.org Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Anders Roxell Subject: [PATCH v2] pinctrl: freescale: fix link errors Date: Mon, 14 Jan 2019 12:13:27 +0100 Message-Id: <20190114111327.27272-1-anders.roxell@linaro.org> X-Mailer: git-send-email 2.11.0 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Fix link errors when PINCTRL_IMX_SCU, PINCTRL_IMX8QM or PINCTRL_IMXBQXP is enabled as a module and the dependent module is built-in. ld: drivers/pinctrl/freescale/pinctrl-scu.o: in function `imx_pinctrl_sc_ipc_init': pinctrl-scu.c:(.text+0x10): undefined reference to `imx_scu_get_handle' ld: pinctrl-scu.c:(.text+0x10): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `imx_scu_get_handle' ld: drivers/pinctrl/freescale/pinctrl-scu.o: in function `imx_pinconf_get_scu': pinctrl-scu.c:(.text+0xa0): undefined reference to `imx_scu_call_rpc' ld: pinctrl-scu.c:(.text+0xa0): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `imx_scu_call_rpc' ld: drivers/pinctrl/freescale/pinctrl-scu.o: in function `imx_pinconf_set_scu': pinctrl-scu.c:(.text+0x1b4): undefined reference to `imx_scu_call_rpc' ld: pinctrl-scu.c:(.text+0x1b4): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `imx_scu_call_rpc' ld: drivers/pinctrl/freescale/pinctrl-imx8qxp.o: in function `imx8qxp_pinctrl_probe': pinctrl-imx8qxp.c:(.text+0x28): undefined reference to `imx_pinctrl_probe' ld: pinctrl-imx8qxp.c:(.text+0x28): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `imx_pinctrl_probe' Rework so that PINCTRL_IMX_SCU and the config's that 'select PINCTRL_IMX_SCU' depends on IMX_SCU=y. Suggested-by: Arnd Bergmann Signed-off-by: Anders Roxell --- drivers/pinctrl/freescale/Kconfig | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- 2.19.2 diff --git a/drivers/pinctrl/freescale/Kconfig b/drivers/pinctrl/freescale/Kconfig index b318c24b61be..a599b72b350a 100644 --- a/drivers/pinctrl/freescale/Kconfig +++ b/drivers/pinctrl/freescale/Kconfig @@ -7,7 +7,7 @@ config PINCTRL_IMX config PINCTRL_IMX_SCU bool - depends on IMX_SCU + depends on IMX_SCU=y select PINCTRL_IMX config PINCTRL_IMX1_CORE @@ -131,14 +131,14 @@ config PINCTRL_IMX8MQ config PINCTRL_IMX8QM bool "IMX8QM pinctrl driver" - depends on ARCH_MXC && ARM64 + depends on IMX_SCU=y && ARCH_MXC && ARM64 select PINCTRL_IMX_SCU help Say Y here to enable the imx8qm pinctrl driver config PINCTRL_IMX8QXP bool "IMX8QXP pinctrl driver" - depends on ARCH_MXC && ARM64 + depends on IMX_SCU=y && ARCH_MXC && ARM64 select PINCTRL_IMX_SCU help Say Y here to enable the imx8qxp pinctrl driver