From patchwork Tue Jan 15 08:11:34 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 155635 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp4602310jaa; Tue, 15 Jan 2019 00:12:20 -0800 (PST) X-Google-Smtp-Source: ALg8bN6CXXB32MprJCUIRdxURppd9AxYaMei3Qhd1pRqjY0qxO5M18YQj49LDo4Vr5yfbRwFw6HQ X-Received: by 2002:a17:902:7481:: with SMTP id h1mr2805251pll.341.1547539940597; Tue, 15 Jan 2019 00:12:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547539940; cv=none; d=google.com; s=arc-20160816; b=yaH1gLU8pe9CA0MZTrHDzIoYRuFvobTrPvphpzFSBvDa4/nQepN0JkTyve2ogFbsyZ 5FsHG2R691xV5Fjvg1qhsvi4Yocjgn+dWfw9ecIxqz+5U0mqud5W+aWSNwZcDoaBTR7r uOwgPwJTWQT/5VU2Lr1kn4Wc3j8PF41kXElpuvf+IcY+sjMqwu7BREVSjcg6Wi6cUCit Ep/yU2Jg+nmZnw2LxMndYwO9AtJs9rQnXY2gNJX4rZzUUPxDW8c75S4Mu1e04Slfu4Cs Ma1rk+W+ehrA2cY9zZVH7JYHibF3VhSHn1MOV7GHOvTj5Dvp65G6xJ07ZWOrJtoCDWRg F5Wg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:sender:content-transfer-encoding:mime-version:cc :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:message-id:date:subject:to:from:dkim-signature :dkim-filter:dkim-signature; bh=DDwTRBxrkZIyGXFo2upU5sg5YyTIlJZmXO1TALc0TdA=; b=mQkOjzoXrRzaGscSKT1wW02uuu/fxkysx+o2BvQzI/dXkzSatTIXvPajhvIrnYnpBH aoz1zgl2lkGlzfODNeZhOQCPHmx58b8ulwp/or2zUKhhmrlVgBGpQdecH3GL3uoFKLIR ElenoIzTPK2ONIxUnP7II+ZtZHlxJr21YFoOabhHfjSrDoYkWHhC89Dzy2MaHyZL0hwp MDrLN1weZsp9nFux/5vUCLjOLiipeH6wiAE+Beia6uCf37w59HxJi58JPAABjGpKdPU7 8wVg5KQ3BmkQOPlBBAunnWNkgOxz+S2Q8uN49xZt24VOC7/us7Xkyu132KGn52fV6gkI dUYQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.infradead.org header.s=bombadil.20170209 header.b="H/Sb7Mar"; dkim=neutral (body hash did not verify) header.i=@nifty.com header.s=dec2015msa header.b=yKNEibH8; spf=pass (google.com: best guess record for domain of linux-mtd-bounces+patch=linaro.org@lists.infradead.org designates 2607:7c80:54:e::133 as permitted sender) smtp.mailfrom="linux-mtd-bounces+patch=linaro.org@lists.infradead.org" Return-Path: Received: from bombadil.infradead.org (bombadil.infradead.org. [2607:7c80:54:e::133]) by mx.google.com with ESMTPS id p1si2650271pld.353.2019.01.15.00.12.20 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 15 Jan 2019 00:12:20 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-mtd-bounces+patch=linaro.org@lists.infradead.org designates 2607:7c80:54:e::133 as permitted sender) client-ip=2607:7c80:54:e::133; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.infradead.org header.s=bombadil.20170209 header.b="H/Sb7Mar"; dkim=neutral (body hash did not verify) header.i=@nifty.com header.s=dec2015msa header.b=yKNEibH8; spf=pass (google.com: best guess record for domain of linux-mtd-bounces+patch=linaro.org@lists.infradead.org designates 2607:7c80:54:e::133 as permitted sender) smtp.mailfrom="linux-mtd-bounces+patch=linaro.org@lists.infradead.org" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=DDwTRBxrkZIyGXFo2upU5sg5YyTIlJZmXO1TALc0TdA=; b=H/S b7MariCeQ2lb4Bv9dJYOQ6PrxexOHh9v166UhXZBMzHka5+p6pLAa89jbBCZBZmkPiEqmf4+Jpg5z SPIiVTzhXlu0kIBg9hyQD7hW45dQlLbOl+hnSI+opxzaA9/7N2jo6qC8X7bnJo5TXVl/IG27UNw0u lQX2QIBF1x3suynq0o1+4LCixjfYAdGoUD+LvTS9GN334EeoFER/7BPDqMCNQb9oxH3f5WO9BlY9e xFe7kBX6Bwe7z/3r20ZKeGaZljJXGM2FhKIdjCVfaZoxS9bXwx5gia03lZNNPyASMk8MPEaoA4EBE YmvJEFa+gFgiwpIhtFQbzBFe6q3RzBA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gjJpW-0002HU-LF; Tue, 15 Jan 2019 08:12:14 +0000 Received: from conuserg-07.nifty.com ([210.131.2.74]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gjJpT-0002H3-Eu for linux-mtd@lists.infradead.org; Tue, 15 Jan 2019 08:12:13 +0000 Received: from pug.e01.socionext.com (p14092-ipngnfx01kyoto.kyoto.ocn.ne.jp [153.142.97.92]) (authenticated) by conuserg-07.nifty.com with ESMTP id x0F8BngX023329; Tue, 15 Jan 2019 17:11:50 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-07.nifty.com x0F8BngX023329 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1547539910; bh=OUfJ3OLYNT1gN1lsc/KpmyBq7v1Da05HpG6V735Lw48=; h=From:To:Cc:Subject:Date:From; b=yKNEibH8fL7l/0/Aa4bU17wH3pgw9gXrLlp732DFHbz+Y6MdellPcLb7uwFSWo5/Y XySbgwg9U9ywsgXCA6KXkqasl1mYVfTGt82AjibLGym3jn8/uS8h0JdrM+iNkyqCyx YozNywHjxz+cdurKqtHISblzhgoprj4Lcf6Ph608mPMwaSdKOty4oLYKW5z43KU3vA uEdjjCTDezM40AgnBWdOQz7+BEXcrte74tqneUiLl8jc01Mig/JEbarupYhvKhzZG6 bsqgGiv+Kw0A1mxrnlUy7CkvEjZEGWh3VjtT8LhxFfP/+kfhCVxshA5gkxrQ4Mg55Z CAFsMv3YGw4JA== X-Nifty-SrcIP: [153.142.97.92] From: Masahiro Yamada To: linux-mtd@lists.infradead.org, Boris Brezillon , Miquel Raynal Subject: [PATCH] mtd: rawnand: denali_dt: remove single anonymous clock support Date: Tue, 15 Jan 2019 17:11:34 +0900 Message-Id: <1547539894-12898-1-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.7.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190115_001211_742032_1994A1DB X-CRM114-Status: GOOD ( 11.33 ) X-Spam-Score: 1.0 (+) X-Spam-Report: SpamAssassin version 3.4.2 on bombadil.infradead.org summary: Content analysis details: (1.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [210.131.2.74 listed in list.dnswl.org] 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marek Vasut , Richard Weinberger , Boris Brezillon , linux-kernel@vger.kernel.org, Masahiro Yamada , Brian Norris , David Woodhouse MIME-Version: 1.0 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+patch=linaro.org@lists.infradead.org Commit 6f1fe97bec34 ("mtd: rawnand: denali_dt: add more clocks based on IP datasheet") introduced a more correct binding that requires three named clocks. Now that all upstream DT files migrated over to it, remove the single anonymous clock support. Signed-off-by: Masahiro Yamada --- drivers/mtd/nand/raw/denali_dt.c | 27 ++++----------------------- 1 file changed, 4 insertions(+), 23 deletions(-) -- 2.7.4 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ diff --git a/drivers/mtd/nand/raw/denali_dt.c b/drivers/mtd/nand/raw/denali_dt.c index 7c6a8a4..0b5ae24 100644 --- a/drivers/mtd/nand/raw/denali_dt.c +++ b/drivers/mtd/nand/raw/denali_dt.c @@ -109,25 +109,17 @@ static int denali_dt_probe(struct platform_device *pdev) if (IS_ERR(denali->host)) return PTR_ERR(denali->host); - /* - * A single anonymous clock is supported for the backward compatibility. - * New platforms should support all the named clocks. - */ dt->clk = devm_clk_get(dev, "nand"); if (IS_ERR(dt->clk)) - dt->clk = devm_clk_get(dev, NULL); - if (IS_ERR(dt->clk)) { - dev_err(dev, "no clk available\n"); return PTR_ERR(dt->clk); - } dt->clk_x = devm_clk_get(dev, "nand_x"); if (IS_ERR(dt->clk_x)) - dt->clk_x = NULL; + return PTR_ERR(dt->clk_x); dt->clk_ecc = devm_clk_get(dev, "ecc"); if (IS_ERR(dt->clk_ecc)) - dt->clk_ecc = NULL; + return PTR_ERR(dt->clk_ecc); ret = clk_prepare_enable(dt->clk); if (ret) @@ -141,19 +133,8 @@ static int denali_dt_probe(struct platform_device *pdev) if (ret) goto out_disable_clk_x; - if (dt->clk_x) { - denali->clk_rate = clk_get_rate(dt->clk); - denali->clk_x_rate = clk_get_rate(dt->clk_x); - } else { - /* - * Hardcode the clock rates for the backward compatibility. - * This works for both SOCFPGA and UniPhier. - */ - dev_notice(dev, - "necessary clock is missing. default clock rates are used.\n"); - denali->clk_rate = 50000000; - denali->clk_x_rate = 200000000; - } + denali->clk_rate = clk_get_rate(dt->clk); + denali->clk_x_rate = clk_get_rate(dt->clk_x); ret = denali_init(denali); if (ret)