From patchwork Tue Jul 5 08:36:23 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 587437 Delivered-To: patch@linaro.org Received: by 2002:a05:7000:1ec:0:0:0:0 with SMTP id 12csp1540599map; Tue, 5 Jul 2022 01:37:29 -0700 (PDT) X-Google-Smtp-Source: AGRyM1txBo3LFF84VBrcNGUc+Z7VoNAkg3hRBHkbuwuQje5AeASmSFtMQbR1lfm7R03NofSpC2l2 X-Received: by 2002:a05:620a:675:b0:6b4:85f3:f868 with SMTP id a21-20020a05620a067500b006b485f3f868mr908638qkh.324.1657010249618; Tue, 05 Jul 2022 01:37:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657010249; cv=none; d=google.com; s=arc-20160816; b=pcTIK1yC9TXvfSyRlkZ2322v0ls4MqziSt9opNtB/7mZVXKxBn/IHNqgvJ3OGmc+2U eGtR/Y76IbNS7+GSvBCa0Pj/IHTrrWMbBGhTmeKpAZD0ft5+27jS3lrDjMe5Zqdc9cCl LHRiuTx9k5JrH8dFlbnrTIchCDEk5QXC1J7gzULtVnDd7LdxiXmumPB1rmbsjKidsHV9 DfO7WUnCbXK74ooHxjQjO+4ZCQLTj5mITuSR1t4oEmAuhOq+uD4ju6DkQzbaUgwjzE2T SJBcTJuP500e3+SPF9DQbpyPEj1Txfxe6ZhpppUjG4KTwf7QN37y/q+gH0jvxheAfsp1 nh+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:message-id:date:subject:cc:to:from:dkim-signature; bh=cb/72d2FcQmj3zj3zP3mY08HLs4aMXys8/KVOUFQofg=; b=dMDUr6fw0EkHX/hEN92w2MDvF741YZZkdU72TlrVmWzhfZWieF1C/9UXaXJf+Nb7ad nQWJOwCtnlrzd1yTHq752FtwGF4tYsoaNeSL+/j1J2TjwV29K2skE1Y5DDNBWk12cwB7 R8eE4s3rkseTxZuWTJ4vIS0xzH8aii+nTYUxxz3+8TJL46oWe49M1Hie3EzYVzu9VMkX 8FMTU+39mu46KCO7Mr679bB6epX7paMsnV6CRwlfioP0yQvAo3WSZijcqDk/Bpl5u41n +7Yn8dpVzN88zkZWo4J4nCyccfu19sKZq7Ne4H+0aMyLeU8yYa1KMp0SgDiTeZFj71vS 4Idw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=FEePoiCL; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id g4-20020ac842c4000000b00304bf77a97dsi18562334qtm.350.2022.07.05.01.37.29 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 05 Jul 2022 01:37:29 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=FEePoiCL; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:51088 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o8e3l-0004kJ-5k for patch@linaro.org; Tue, 05 Jul 2022 04:37:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39622) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o8e2q-0004hj-Rh for qemu-devel@nongnu.org; Tue, 05 Jul 2022 04:36:32 -0400 Received: from mail-pj1-x102e.google.com ([2607:f8b0:4864:20::102e]:34512) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o8e2o-0004eT-CH for qemu-devel@nongnu.org; Tue, 05 Jul 2022 04:36:31 -0400 Received: by mail-pj1-x102e.google.com with SMTP id cp18-20020a17090afb9200b001ef79e8484aso4243339pjb.1 for ; Tue, 05 Jul 2022 01:36:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=cb/72d2FcQmj3zj3zP3mY08HLs4aMXys8/KVOUFQofg=; b=FEePoiCLfCyTIstv1Kchcpc/5ASJs2OWZYxbkn/ea2en6SvLp5w0gk9lbQlnRsxIaD Pjan+qASKdjw+ki94wRoNERlQxR4fFPB8w5grjrOV/kYp/5Ixz2nqnNp+9pzkeiU2RXH lnjUbw5sgsc2s1u2KCO4ZCJQgQPmoDl/LlozE6lf+NdccCZtdf5YHAsMXDavKTSKCwyB fAZn4rzC/0j3HaALzc5NbICwUKr16MEVxMAfYnRdxTGdCzAXrVSr0zIEoQxC7eAO7/Ab a9P1FBqrtOlgr6ZZiBRgxvEp2Vhv5sOXxMrai4Hv0+wx0t/MGRRivoDzCB9vsXTmo+B1 hjiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=cb/72d2FcQmj3zj3zP3mY08HLs4aMXys8/KVOUFQofg=; b=DaBpBSxIGSmewCzlJ+FZ4F2ijMyKGPUPUFFbCxkF+aHZfNsoxc+his1YasMmD3h0T5 WIjwtDe849JIEOFHQyOFrubjjRR1WTjRx9BLUmWEZ/HF4CoRv34kdmxc9iklBNsvXC9j YfcVBR34ykI+HZpgT8FglTftoN4bLsC/gsGZopCU+AyZIqhi+En5RW1GG+HnxA3d0C6e IrJ7Q5E52mREJ44wVrdWQKRRkCgHt0ncrsnWGbrsR0yAxot4St5DYTtxdg+kzxu5bPFx zIYO8/R4ZCqM4GUon402Z0AtQojsSjqPN0wSbglZ9h7RObxJO9TzR3MpT5qN8hdJJDxq iEzQ== X-Gm-Message-State: AJIora91/12THGxeVAXaRkBCevQflWrNgUbPRJisXwiCtqFMgurRPBt7 Ku67nCXrLeE7vx0B1xH8/GRFnkAELk8mUvpl X-Received: by 2002:a17:902:9041:b0:16a:aef:7b84 with SMTP id w1-20020a170902904100b0016a0aef7b84mr41191109plz.124.1657010188899; Tue, 05 Jul 2022 01:36:28 -0700 (PDT) Received: from stoup.. ([122.255.60.245]) by smtp.gmail.com with ESMTPSA id 196-20020a6303cd000000b004127ad2407fsm589050pgd.51.2022.07.05.01.36.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Jul 2022 01:36:28 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: Song Gao Subject: [PATCH] tcg/tci: Remove CONFIG_DEBUG_TCG_INTERPRETER Date: Tue, 5 Jul 2022 14:06:23 +0530 Message-Id: <20220705083623.1142250-1-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::102e; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x102e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" There is nothing in this environment variable that cannot be done better with -d flags. There is nothing special about TCI that warrants this hack. Moreover, it does not compile -- remove it. Reported-by: Song Gao Signed-off-by: Richard Henderson Reviewed-by: Song Gao Reviewed-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé --- tcg/tci/tcg-target.h | 5 ----- tcg/tci/tcg-target.c.inc | 7 ------- 2 files changed, 12 deletions(-) diff --git a/tcg/tci/tcg-target.h b/tcg/tci/tcg-target.h index 033e613f24..ceb36c4f7a 100644 --- a/tcg/tci/tcg-target.h +++ b/tcg/tci/tcg-target.h @@ -53,11 +53,6 @@ # error Unknown pointer size for tci target #endif -#ifdef CONFIG_DEBUG_TCG -/* Enable debug output. */ -#define CONFIG_DEBUG_TCG_INTERPRETER -#endif - /* Optional instructions. */ #define TCG_TARGET_HAS_bswap16_i32 1 diff --git a/tcg/tci/tcg-target.c.inc b/tcg/tci/tcg-target.c.inc index 98337c567a..f3d7441e06 100644 --- a/tcg/tci/tcg-target.c.inc +++ b/tcg/tci/tcg-target.c.inc @@ -823,13 +823,6 @@ static void tcg_out_nop_fill(tcg_insn_unit *p, int count) static void tcg_target_init(TCGContext *s) { -#if defined(CONFIG_DEBUG_TCG_INTERPRETER) - const char *envval = getenv("DEBUG_TCG"); - if (envval) { - qemu_set_log(strtol(envval, NULL, 0)); - } -#endif - /* The current code uses uint8_t for tcg operations. */ tcg_debug_assert(tcg_op_defs_max <= UINT8_MAX);