From patchwork Tue Jan 22 21:50:06 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 156323 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp39372jaa; Tue, 22 Jan 2019 13:50:48 -0800 (PST) X-Google-Smtp-Source: ALg8bN5fI+N6zqW/vySeTAiMqL9SyOLa64VnjQmlb1TjAesg0Ou877OvUrCSQ9Lua8/tR9PnvNwb X-Received: by 2002:a1c:a6c2:: with SMTP id p185mr149514wme.133.1548193848196; Tue, 22 Jan 2019 13:50:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548193848; cv=none; d=google.com; s=arc-20160816; b=lkuFdsrLR5Hb0DDyutNJ7PIdwGSYEj14EZwJy6MpptFEdrTkcVbaDlUMcbMhLpgaNp SoZskQ4VBQIOTOfHdRmxm4Gd4No7+YC7qFrLUvco3W1nLR+0OrjRbO/jYDedPgE7dRvE fxuaHL2aJgF3svxedhDgIcVLX9gqU/Pcb9ukl16qp9lfPFjDtzos90m6kl4XJoCnynMN SyiGuAEDvZw3RcewvDnvJp89si5DyHyvu5EMpxMoPM2VLs/DfVeTgjp9F5E62ghsiwZv 0WbPFtSyP4n6PP5LCWhsmvSeohWpNQqR8NtHUu/S/qGzM+UWM7OpDEh4qurpQAqECr1G EBMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=1nYURC9J3WUUZatMQMjMushGVVnRe2BtZ2VT+vU0n5Y=; b=YdnYwa9iCxckiSqp+8xBjrkBBoE0PWSEySn2R/wsMuVvFi52aXzK/qQYgRn/1rJC0J RoDA536Ik5qM2SDp06hhEx/2sCkmkATtJt2MqWUmr7WgRv7ecYf1CIhViegQ4OBqpnVk JZ/pUBaWHQRPlpth8LReHCfHUe+7d3dUoLCVRp0ZwCh6uub4GxTvnwkJqxJcLR/6ue29 WVZvytIu+h31QOmyd7HAzv6T8sjiQVIku3OfiUPBEwkDL3EcmNGvd5yPqIBwEPj8COm7 J55iDo3SglyhqwxrEnaC/bTa5WycRH+OYobCTCsqQr98dkHZGxkZoxeteNA0Nw/2C/15 5BmA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=KvLilcT7; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id w72si35781026wme.155.2019.01.22.13.50.47 for (version=TLS1 cipher=AES128-SHA bits=128/128); Tue, 22 Jan 2019 13:50:48 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=KvLilcT7; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([127.0.0.1]:50769 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gm3wV-0007KM-4l for patch@linaro.org; Tue, 22 Jan 2019 16:50:47 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60832) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gm3wA-0007Js-0r for qemu-devel@nongnu.org; Tue, 22 Jan 2019 16:50:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gm3w4-0007nr-Sb for qemu-devel@nongnu.org; Tue, 22 Jan 2019 16:50:21 -0500 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]:38146) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gm3w2-0007jE-RR for qemu-devel@nongnu.org; Tue, 22 Jan 2019 16:50:19 -0500 Received: by mail-wr1-x441.google.com with SMTP id v13so83358wrw.5 for ; Tue, 22 Jan 2019 13:50:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=1nYURC9J3WUUZatMQMjMushGVVnRe2BtZ2VT+vU0n5Y=; b=KvLilcT7T/5EypOW6sb2RhODzswUWt58bUcNYBmvVMxpZPVd/DLHLvbOBgYWoWYQds q0g7HC/Cl3RT6kHtz10sP1PjnSRjDprYMTgcnLeLEbhFy6DTDVfeP5baFMxxRZ+g4laj nzR6Yg07qThPXuomsa6zn68zBr0aD+UVeFgIA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1nYURC9J3WUUZatMQMjMushGVVnRe2BtZ2VT+vU0n5Y=; b=lE7ksnZbAL53h7JpMFmTzSnFv5xWZHPVpL4mY3SL2i38xyTahny9PGuKxEHdly3xTO atCrWZpJljlWnBQHoTF8E66c4J0IGjTKPlPyFhEkV/z897O0UGuGUpe3OBNGdS37DCxW h9zbk1TfT6YXlAzrpDCZ+V67GJmPQEnFv9BHImUtNjq+vs9DM7OXX0+tLHrqzkOQeUgH I5FMgx7dF4r1q7IKejqGor25jAsfikgwKfFZo8CA0KufYrN3CdygapH8nGUaT0tzCNON he18nmqYMkgk6x6Ew5LsGNFOKGKWE4fRTIyXt2zcsnzNHcxj92in8YXt1ZIBtSBYBOzy OyWA== X-Gm-Message-State: AJcUukevAWB5KwTCgPFej8pkwCZ0DxhLkP1LHBUXFHcQDiCKOrc6guW6 mWBh96RygyWRMwvZW4pHQj3vZQ== X-Received: by 2002:a5d:4a0c:: with SMTP id m12mr34170832wrq.38.1548193817615; Tue, 22 Jan 2019 13:50:17 -0800 (PST) Received: from zen.linaro.local ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id p4sm81010790wrs.74.2019.01.22.13.50.16 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 22 Jan 2019 13:50:17 -0800 (PST) Received: from zen.linaroharston (localhost [127.0.0.1]) by zen.linaro.local (Postfix) with ESMTP id 3B6243E0807; Tue, 22 Jan 2019 21:50:16 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Date: Tue, 22 Jan 2019 21:50:06 +0000 Message-Id: <20190122215016.18697-2-alex.bennee@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190122215016.18697-1-alex.bennee@linaro.org> References: <20190122215016.18697-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::441 Subject: [Qemu-devel] [PATCH v3 01/11] fp-bench: fix update_random_ops X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , "Emilio G. Cota" , =?utf-8?q?Alex_Benn=C3=A9e?= , Aurelien Jarno Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: "Emilio G. Cota" The second test in the branches is wrong; fix while converting to a switch statement, which is easier to get right. Signed-off-by: Emilio G. Cota Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée --- tests/fp/fp-bench.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) -- 2.17.1 diff --git a/tests/fp/fp-bench.c b/tests/fp/fp-bench.c index f5bc5edebf..546bac9c9c 100644 --- a/tests/fp/fp-bench.c +++ b/tests/fp/fp-bench.c @@ -143,15 +143,20 @@ static void update_random_ops(int n_ops, enum precision prec) for (i = 0; i < n_ops; i++) { uint64_t r = random_ops[i]; - if (prec == PREC_SINGLE || PREC_FLOAT32) { + switch (prec) { + case PREC_SINGLE: + case PREC_FLOAT32: do { r = xorshift64star(r); } while (!float32_is_normal(r)); - } else if (prec == PREC_DOUBLE || PREC_FLOAT64) { + break; + case PREC_DOUBLE: + case PREC_FLOAT64: do { r = xorshift64star(r); } while (!float64_is_normal(r)); - } else { + break; + default: g_assert_not_reached(); } random_ops[i] = r; From patchwork Tue Jan 22 21:50:07 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 156329 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp44125jaa; Tue, 22 Jan 2019 13:57:49 -0800 (PST) X-Google-Smtp-Source: ALg8bN7/EedirW+X/OTR4K+ZoZJ1pfR360YMBCcP1ITvqgeq0Od5Fbv7aaL+AVysGrthMUu6P3zo X-Received: by 2002:adf:c042:: with SMTP id c2mr35824136wrf.158.1548194269596; Tue, 22 Jan 2019 13:57:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548194269; cv=none; d=google.com; s=arc-20160816; b=H8hGqB3UATdZVUcy19lcchcVafDUXLYz31aGrDIoIVJqj6logMyQsuMiuFaqhzXd9c 91j7H4mYM2WdlWPkjPGqi1GDRpFDvAL/tz/xt70thLss3BhGF9zqpZNdXS4+x1Yphb01 wSGK5FQ8L7t8XdJM5R91YBBx1EckHcEhyKNmz9cI8hCZeM0kFpOUq5Ad1EQLD7sQkKXq VsOwZBfLMQwILG40tXz5zlk6JkHAUbolIhvkFySeC+pRT6VOxN/HACd/QPgY9oGqqIUn baHkqqZzd7oZX65xci2GOhwpyu0Qb2Wlkh9qXYw3XTqRicwlKOfw7L2KHKRJD2VxeQgz k8bQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=BKiceF0eCEcLLYJ2HmNMq8GOYGcVmd+bgBmQXvFufFI=; b=YTYzjNXldW/dvDdAWz6HRZDT3eW8X8il1ceLGq71GBNuGgPSXuTp/ljfc2ho1+/XBb 5Y76eJV1r8uIPCDKqY/NbWlldrqpf/Gw/vK0fDno/G38BLYjwCL+VBRaVF1ExEztaGvQ +3ZdQkLwfFGbfQxEficnXExv/EFP2of0sy2TP35k8cn4DbCiFpEYq8POZqGv32M9p9wr 15HuArxjz0hJzC9P8zNDdYAKnwsQYH4DVmUUZJD1c5CCyMEMCKq5Ylrc7S1xv3lOYHP7 S4NTUUM+XvzZkjbhyo+m05vFXGpVq6sswseqbwDuAs35fhwe/asBQIdEaqISWamnQu8+ nlzw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=eaNrnb9l; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 21si27625887wmw.118.2019.01.22.13.57.49 for (version=TLS1 cipher=AES128-SHA bits=128/128); Tue, 22 Jan 2019 13:57:49 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=eaNrnb9l; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([127.0.0.1]:50873 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gm43I-0005oZ-GU for patch@linaro.org; Tue, 22 Jan 2019 16:57:48 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60887) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gm3wP-0007RT-3E for qemu-devel@nongnu.org; Tue, 22 Jan 2019 16:50:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gm3wM-0008CJ-Iv for qemu-devel@nongnu.org; Tue, 22 Jan 2019 16:50:40 -0500 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]:44930) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gm3wK-0007l2-JJ for qemu-devel@nongnu.org; Tue, 22 Jan 2019 16:50:37 -0500 Received: by mail-wr1-x444.google.com with SMTP id z5so50588wrt.11 for ; Tue, 22 Jan 2019 13:50:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=BKiceF0eCEcLLYJ2HmNMq8GOYGcVmd+bgBmQXvFufFI=; b=eaNrnb9lJUzjFslVmypTpso1EiPUsPfYAhRJ04YXOhFS4b9k7aIFIxy9jpTkRjvlZj S9myyW4AG7mRTbeRsA8peKMhcyJQXVzTQbVyNu+gUMAhO0DGhPh08F6Ql+dsbipD7JpA 3ONq5X/qe0EgErmda5B1XR6/HxfsWdbayJ+7Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=BKiceF0eCEcLLYJ2HmNMq8GOYGcVmd+bgBmQXvFufFI=; b=Vj4/TCfoOIPOz7rmbWxaLvisqsoJ16jfszOp0JsSuPMcM1cNbNumbqyPF621KECeq2 fmzZYsDuAszy6SCP8QjN94z1f1lDkdcIIHD+n7RKXe/N2SBolbfffrV9oAm4YwwEFV97 cfBLE65N9vA86s0R29Q6JZ8Uqns50Y8OaevLWAuRZQg23R0Gag7QTHpMjGrKasdffPay maauAUbQmu1fscXbsgzZUNZFLLaVq1SfSM5lGR0MI2IimBsAu/7+Le+dw53OFxMSC5NN m61RTkYWWPOqC2QIlU/HjsNYDTE1Pj/dNqQt0g7uC+WS7Pb6KgWd8BN/iOMRSsb5EePi AJ0g== X-Gm-Message-State: AJcUukfEG9OSbsR8rs602pjHzr02xKf5aIbrJwo5ivrJ5ly4yvBD1eqa 7rmZTgbhgQpCzqSRASzf9ZKKjiST2Qo= X-Received: by 2002:adf:fc09:: with SMTP id i9mr32149284wrr.299.1548193818596; Tue, 22 Jan 2019 13:50:18 -0800 (PST) Received: from zen.linaro.local ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id c13sm108608405wrb.38.2019.01.22.13.50.16 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 22 Jan 2019 13:50:17 -0800 (PST) Received: from zen.linaroharston (localhost [127.0.0.1]) by zen.linaro.local (Postfix) with ESMTP id 4DC923E08E3; Tue, 22 Jan 2019 21:50:16 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Date: Tue, 22 Jan 2019 21:50:07 +0000 Message-Id: <20190122215016.18697-3-alex.bennee@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190122215016.18697-1-alex.bennee@linaro.org> References: <20190122215016.18697-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::444 Subject: [Qemu-devel] [PATCH v3 02/11] fp-bench: remove wrong exponent raise in fill_random X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , "Emilio G. Cota" , =?utf-8?q?Alex_Benn=C3=A9e?= , Aurelien Jarno Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: "Emilio G. Cota" At this point random_ops[] only contains normals, so there's no need to do anything to them. In fact, raising the exponent here can make the output !normal, which is precisely what the comment says we want to avoid. Signed-off-by: Emilio G. Cota Reviewed-by: Richard Henderson Signed-off-by: Alex Bennée --- tests/fp/fp-bench.c | 4 ---- 1 file changed, 4 deletions(-) -- 2.17.1 diff --git a/tests/fp/fp-bench.c b/tests/fp/fp-bench.c index 546bac9c9c..4ba5e1d2d4 100644 --- a/tests/fp/fp-bench.c +++ b/tests/fp/fp-bench.c @@ -176,8 +176,6 @@ static void fill_random(union fp *ops, int n_ops, enum precision prec, if (no_neg && float32_is_neg(ops[i].f32)) { ops[i].f32 = float32_chs(ops[i].f32); } - /* raise the exponent to limit the frequency of denormal results */ - ops[i].f32 |= 0x40000000; break; case PREC_DOUBLE: case PREC_FLOAT64: @@ -185,8 +183,6 @@ static void fill_random(union fp *ops, int n_ops, enum precision prec, if (no_neg && float64_is_neg(ops[i].f64)) { ops[i].f64 = float64_chs(ops[i].f64); } - /* raise the exponent to limit the frequency of denormal results */ - ops[i].f64 |= LIT64(0x4000000000000000); break; default: g_assert_not_reached(); From patchwork Tue Jan 22 21:50:08 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 156327 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp41915jaa; Tue, 22 Jan 2019 13:54:40 -0800 (PST) X-Google-Smtp-Source: ALg8bN57jeNWhCrg14KVqFpzzdCDLuM0k+EEU8+hRoWBqzFFRcNYdb9lCqBmxEhe5WbFh/stb0vG X-Received: by 2002:adf:f550:: with SMTP id j16mr34220378wrp.258.1548194080703; Tue, 22 Jan 2019 13:54:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548194080; cv=none; d=google.com; s=arc-20160816; b=BoYJww21dP+ElhdHtoGkAMqMCxXf+wvPvGr4n1HQAyUsTGhwkUCGTCn6UJ0eQKelBS RhbLP6vFGp+WzRQO6wNYfqiIgfbO4gFMF1x1gJjSL51znr2MIboDICvrNO+EPLtYNHxN iTrkdZoF1aIPsa2oCC+9/ewjFrGnwLhuMwk31dAPWmUtYJDVkUG6LOb5bdCdJ9FMSLej A6coK0WrItLC8Cq1nQLjJtFIXn6XY0VcLGJhRw3zq2TwEt3VHXcPjQbmNhQv3SwxA8jk Y0PRGzaGdaY8jwQ/SKhKSw19eUKYUJF0JXTaYJWj0eg5DSSXF68YMypwwWX70JeSkPQz nlFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=gZImyNtt7AiS5wLW217m9CulCQW4HP3CZXV2WKdWr+k=; b=ueL34DuEP/xsfOrGPSuss3YVcTjp9ZnBR1Q9yTpFwiTfMB7rzC0MVAQDEmoRhgLG6b QWdtzH/oRoaqI63m0L31PCqUhSVdbObUnnRyZcSIagajaSJaj7aQbJNYeLb4z75oa107 5QzlTAC8xKkBlz6WDJCg6WClkRwIT0vUWbqY6LeoeUYN9KJJ2qNp9najI3W8G0b5jhba ++58oNM1ZoTPjY7Wff9uzwYN10QF4mzaTh8rnuPTpmYEj/XP5lMUyS2VcrpK1Apkmfjd 5A9KltxTpywNXTn2/W29vxby+Md1N3BdSVJ3m9S/tLxI3x/Qz44XJcj1Pbp5yJguvfNh fTjQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=ZHempPUz; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id u18si68726749wrd.292.2019.01.22.13.54.40 for (version=TLS1 cipher=AES128-SHA bits=128/128); Tue, 22 Jan 2019 13:54:40 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=ZHempPUz; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([127.0.0.1]:50809 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gm40F-0002Lm-IQ for patch@linaro.org; Tue, 22 Jan 2019 16:54:39 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60854) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gm3wD-0007LO-85 for qemu-devel@nongnu.org; Tue, 22 Jan 2019 16:50:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gm3wA-0007wA-Lz for qemu-devel@nongnu.org; Tue, 22 Jan 2019 16:50:29 -0500 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]:39083) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gm3w6-0007mP-9w for qemu-devel@nongnu.org; Tue, 22 Jan 2019 16:50:25 -0500 Received: by mail-wr1-x443.google.com with SMTP id t27so77683wra.6 for ; Tue, 22 Jan 2019 13:50:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gZImyNtt7AiS5wLW217m9CulCQW4HP3CZXV2WKdWr+k=; b=ZHempPUzgdYfOG+cL99bYuwX8nJx8SPLtXl3y99YKeYzRMEUEnmkgVvuo8cqMB3P50 ARp2lzHw+Ghl6o4yFQF8NsSkC04R8yYu5bH3snscOcB7YTGF8PY1e8BZZGHn1NamJ/iz 3UlTXESU3+6d8kRFdQo+SXh/otCCGrqSWRO7Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gZImyNtt7AiS5wLW217m9CulCQW4HP3CZXV2WKdWr+k=; b=PeAQSo/Gp4VASPYfkesh91EBQkrXxEdsOL0HMEqYTeeC/tlMK+MUY3W9yCSUOpmI0U 0LFYgsgC/1v8h/G5clbri+p69KV6EmysUjC3zXcPrBgFZKVbRjKY6YSPBeCleX7HqLgC h71bO0LEiVY7YgX6jBdzz0RdUaV11f86dkjZE2Xc/n77Mmf+/xm4hqL5gQ8k1DknlYav xaNk6VRnSUa/wh4YBaSmWsyu/3rNR9MJuBExwzEuxLiToFfbRbQ4uvd0L4BvN1ZAAaC1 kTpdzX7PrtEk+SVJpeWG/fvJGEOHtKP/5emu1S1kL6D4uPTjyulVnz5Z+D9vb4UlaZYJ iZWQ== X-Gm-Message-State: AJcUukeDvqN/o5HhnufGVMh3Jas2Bfp8UhKGrQ/N/r9JyDkl9GzWrvbV l8wAd1oK6I7mJxTuXCgt+6np1fR5zF8= X-Received: by 2002:adf:fa05:: with SMTP id m5mr33815400wrr.155.1548193819114; Tue, 22 Jan 2019 13:50:19 -0800 (PST) Received: from zen.linaro.local ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id q9sm75353684wrv.26.2019.01.22.13.50.16 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 22 Jan 2019 13:50:17 -0800 (PST) Received: from zen.linaroharston (localhost [127.0.0.1]) by zen.linaro.local (Postfix) with ESMTP id 631A03E0971; Tue, 22 Jan 2019 21:50:16 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Date: Tue, 22 Jan 2019 21:50:08 +0000 Message-Id: <20190122215016.18697-4-alex.bennee@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190122215016.18697-1-alex.bennee@linaro.org> References: <20190122215016.18697-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::443 Subject: [Qemu-devel] [PATCH v3 03/11] berkeley-testfloat-3: pull changes X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , "Emilio G. Cota" , =?utf-8?q?Alex_Benn=C3=A9e?= , Aurelien Jarno Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: "Emilio G. Cota" - fail: constify fail_programName Signed-off-by: Emilio G. Cota Signed-off-by: Alex Bennée --- tests/fp/berkeley-testfloat-3 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.17.1 diff --git a/tests/fp/berkeley-testfloat-3 b/tests/fp/berkeley-testfloat-3 index ca9fa2ba05..5a59dcec19 160000 --- a/tests/fp/berkeley-testfloat-3 +++ b/tests/fp/berkeley-testfloat-3 @@ -1 +1 @@ -Subproject commit ca9fa2ba05625ba929958f163b01747e07dd39cc +Subproject commit 5a59dcec19327396a011a17fd924aed4fec416b3 From patchwork Tue Jan 22 21:50:09 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 156324 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp39495jaa; Tue, 22 Jan 2019 13:51:00 -0800 (PST) X-Google-Smtp-Source: ALg8bN4jRW16vZBUlUR7Yl2MYVkam6G4Il2EZmAERb58lVH2nb0yQSM//FJzSi/VG+Oj6ODn1g4t X-Received: by 2002:a1c:2902:: with SMTP id p2mr179958wmp.19.1548193860574; Tue, 22 Jan 2019 13:51:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548193860; cv=none; d=google.com; s=arc-20160816; b=OhxHOJOPybdBXJIGCRJkNjKmExnSF566MtU9wWHhsBo7N+BNbzIbyhlU8qPqWTcGf/ TQpGw+byPUPLoUN2tnIPF2pqVJHKwMisbSSzxn78rsuNKpg5hDcMRNhQ96StO0TNltiT jbFISwiOhzzBsh/Ds8AlgVzsWn+wQC6j3YJr08eFp2tYH00xNNSrrUKgFqBiAiyel7lZ EL9Ysuk2hkn93IUpmHgs0Z9+tWVSwmsHQHRvxJEx151nvrFOy0sOXpttjZ2dGX3f6qXl JQUtfBLn/9Ad4V/GcrhxHC+shvniqAdehWgndnmEvlPv4CtV5CEDKcmCVUEN/pQOAd4p N32g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=OWcHEp1BPzETLyMerlsa5+Hn4wdXJpxzWX+97qsuLY4=; b=t16tjnr5a2qw2twvas7k6VojGE7tuqJBr+tXburyyy2R3UdIW9/usFNOEqC5iFTfEo qSCgqDq0NggIQ6Rc9SUNRh+VaVyDvMhY7CfoASvJ9q6q9S9n3Pdvjnd+SYrvOKw5XFOG 2ehbQddTqGeWq6IBppsStle77w+yfaNyCQO0qDm2Zjtca75KfXmEVGR0gtwYuAClE9wA wk8WhtWQseRnc5Ar5NGv0jbVzqO6PGVD+XCYyFsN0FREVGFhWRZ3z7vzjX4n8UTFzoaZ LH+270CKrQl++ZT834XYSVsfEQwybu2E+8QsacL34KslUPZmXVxFx29Zm7a/UjsO0Oj/ CRVg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=B+xMoClL; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id g2si34639654wmh.52.2019.01.22.13.51.00 for (version=TLS1 cipher=AES128-SHA bits=128/128); Tue, 22 Jan 2019 13:51:00 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=B+xMoClL; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([127.0.0.1]:50771 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gm3wh-0007QK-Eg for patch@linaro.org; Tue, 22 Jan 2019 16:50:59 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60870) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gm3wL-0007OS-7n for qemu-devel@nongnu.org; Tue, 22 Jan 2019 16:50:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gm3wI-00084T-2o for qemu-devel@nongnu.org; Tue, 22 Jan 2019 16:50:35 -0500 Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]:43979) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gm3wH-0007n0-52 for qemu-devel@nongnu.org; Tue, 22 Jan 2019 16:50:33 -0500 Received: by mail-wr1-x42f.google.com with SMTP id r10so56540wrs.10 for ; Tue, 22 Jan 2019 13:50:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=OWcHEp1BPzETLyMerlsa5+Hn4wdXJpxzWX+97qsuLY4=; b=B+xMoClLjdMAkkugg673u5UMI2e1mXXzdV7aE0vbroVereThxwkscULkJTUvGCgwpK NiBONi4eSLWSNDjAyGlPwQNSZQ0P0gmXftSYuuevR6Q6tSnGtnIbbP3vfxIPuiY7XwOy gnDMmF2Sr8E0NuWCLX3A/LNWyPRqYs4ToRcBo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=OWcHEp1BPzETLyMerlsa5+Hn4wdXJpxzWX+97qsuLY4=; b=J8JxagrGrUEAitNy4mQy6SO06tatbIGxyGWWfXO1qw7Xt2YaV9GnYg+aeDbNDbP+GI Ntivn5DBDjvn6gOU8e7bGrV1OJ71gZIUwZxB/Uf3mseZckeFsZkZAv5XupZLUncmoDle BPlApYleHtDzwoWW0nMeYxm5UX3qkdtUtgfbNr93IhTDRtcIWpB8LZpVC6EI7Yty1Sro YrtsoVcDKY9InLMcmTnMyACadnsTnv2yWLjBnyJO+YJI9FWDFLwTWK/d0ckasIwSMt1Z emIw+CFu+k3VeKBfqOBl23EEh0YEkNBh2/sqmAPmCn6FKb0rWaUCZwiWVyQTJ2/wxtfj rfYw== X-Gm-Message-State: AJcUukepF9eihSYZG6hkHxkA4b6VIZzCMSL0gFBWP5f+QGv/MOWdhmGK TmDNORPvkwgp2vBpIs9sWOvT9A== X-Received: by 2002:a5d:4acb:: with SMTP id y11mr5384373wrs.281.1548193819758; Tue, 22 Jan 2019 13:50:19 -0800 (PST) Received: from zen.linaro.local ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id e17sm154618562wri.36.2019.01.22.13.50.16 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 22 Jan 2019 13:50:17 -0800 (PST) Received: from zen.linaroharston (localhost [127.0.0.1]) by zen.linaro.local (Postfix) with ESMTP id 75CE53E09BE; Tue, 22 Jan 2019 21:50:16 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Date: Tue, 22 Jan 2019 21:50:09 +0000 Message-Id: <20190122215016.18697-5-alex.bennee@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190122215016.18697-1-alex.bennee@linaro.org> References: <20190122215016.18697-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::42f Subject: [Qemu-devel] [PATCH v3 04/11] tests/fp/Makefile: do not use gcc-only -W flags X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , "Emilio G. Cota" , =?utf-8?q?Alex_Benn=C3=A9e?= , Aurelien Jarno Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: "Emilio G. Cota" The build now completes in both gcc and clang. Signed-off-by: Emilio G. Cota Signed-off-by: Alex Bennée --- tests/fp/Makefile | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) -- 2.17.1 diff --git a/tests/fp/Makefile b/tests/fp/Makefile index 5019dcdca0..5a35e7c210 100644 --- a/tests/fp/Makefile +++ b/tests/fp/Makefile @@ -65,8 +65,7 @@ QEMU_CFLAGS += $(TF_OPTS) TF_CFLAGS := TF_CFLAGS += -Wno-strict-prototypes TF_CFLAGS += -Wno-unknown-pragmas -TF_CFLAGS += -Wno-discarded-qualifiers -TF_CFLAGS += -Wno-maybe-uninitialized +TF_CFLAGS += -Wno-uninitialized TF_CFLAGS += -Wno-missing-prototypes TF_CFLAGS += -Wno-return-type TF_CFLAGS += -Wno-unused-function From patchwork Tue Jan 22 21:50:10 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 156333 Delivered-To: patch@linaro.org Received: by 2002:a02:b531:0:0:0:0:0 with SMTP id l46csp37297jaj; Tue, 22 Jan 2019 14:03:33 -0800 (PST) X-Google-Smtp-Source: ALg8bN4OZawKeUCrBwBrOpCQIYTiwvWu6876qWl2KuLcwj3PDj2ooAE4EsKoK8RlgruhvFUqLLJ/ X-Received: by 2002:a1c:a4c4:: with SMTP id n187mr212464wme.15.1548194613586; Tue, 22 Jan 2019 14:03:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548194613; cv=none; d=google.com; s=arc-20160816; b=ACkMFOS0SL/OJ+18c368uxRXuM08PCESiaujZ1KmLN8wxGDu+J23sdr+5Pn4OpbEWL 1C2L36sWO18HTHchBREfFABPy5uqRd2iuVcVmA5slwOq3TsZxuGCH8oweemLNL0xmHZI 23AhI/HvjHQj+YIts3YZN5U1fmQ5d6q4qxVYWHXtMb+1QRc7FXuk9LEWIe/E6xJ/4Vx6 QHTUd8AuTOWtAMQSXN6hoGb6bxClyEadHEWoBVXGVA6qRZ8OFYYR34E+bUm0mljyjK/w qoE4apvsalq91cXH95aiQbhi7emYo3bbEgmDYbyS8DJlZxm9ds2hOFCWCxo2r+YWPkzN PzrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=kDdMLOeQCo1DbHRKXtgMY221tGVIm99Vb8Z6bllUC2U=; b=Z4FTrcOTCUOgkzuWsfpp7obVrfU2XzhpN6jhnRTPdTWyVO+g9qz6lSW3FBhRxaodBQ o84s4ygEYyX7cIojesGt0pakCHGY5VwYQuAo8t7a/duKQZdA96T5JTShbLHswFOFjimh fNzN6Gpg0ZyumImdir9tKKUW14Mkc9mAOIQpu6DNpKuIRvdBLJH+KT6j5xTnzWiL+jPC q/dIhVixvavXB6hrRlCFXBH03Yp5lrLRjOLH6KVVlYMVoox8ySl2UHf6ugR1GV0EvX9v DRjUjxkvAqVyF9Q0j+gvomb4x8IEFI+3OC82d2PngPAqlqGQIsn42LuJEc2BRwUZMqeT TLTQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=R3uT0wqe; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id s8si41063851wra.403.2019.01.22.14.03.33 for (version=TLS1 cipher=AES128-SHA bits=128/128); Tue, 22 Jan 2019 14:03:33 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=R3uT0wqe; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([127.0.0.1]:50988 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gm48q-0001Wv-I5 for patch@linaro.org; Tue, 22 Jan 2019 17:03:32 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60971) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gm3wR-0007TM-2g for qemu-devel@nongnu.org; Tue, 22 Jan 2019 16:50:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gm3wP-0008GK-Sh for qemu-devel@nongnu.org; Tue, 22 Jan 2019 16:50:42 -0500 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]:39877) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gm3wP-0007p5-I0 for qemu-devel@nongnu.org; Tue, 22 Jan 2019 16:50:41 -0500 Received: by mail-wm1-x341.google.com with SMTP id y8so75583wmi.4 for ; Tue, 22 Jan 2019 13:50:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=kDdMLOeQCo1DbHRKXtgMY221tGVIm99Vb8Z6bllUC2U=; b=R3uT0wqe2+7SmjtPweR215y4cIf7K9cgAtELwn2SzP1VKT3pwlLwTCRtHY9a8sn8gv SBOXA35Y56znxwSLlaVnBKznsavaA8yLzhnCaYBLo1bIz/ojX3kKNKXgXRioPWSLcdwW 5arVwzd2UkiAFOX1klD1BKVfgX57N0aeBxJTg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=kDdMLOeQCo1DbHRKXtgMY221tGVIm99Vb8Z6bllUC2U=; b=BUPX1fnXHyVAEDWjmyqvbj9XFW3ev+Q4x7pAg1J856xCL23f4ltbE81Ul52/tlWbnM O0Y1HhC9l9KwHmTfmTC7nJDXDm7tgLBzyzzcCv/Q39+ZiklnMNykjoVsVRRz+ojxnKBD C6m1mwGphxydjMR9Manj5Sg6xxVLr5iVslBUeDXzysqzncYJQu3mLS4nn8JZ8Br18qPH Vc/LJ4QoRY0ge3pflL/sJ+kfrZAbYVbPqfv527xyM89e9urjljQFLetZJDYs2K6JoYTw Hxq1l2J2P1UwuWYweJbjKvvhD6WdI0UdNCiuiI7cmH4Krrjc9/PXTXm2XQ6I7uiAAxzK NkHw== X-Gm-Message-State: AJcUuke4BPCZ9m0vXjPpHPA+uBvxcERDFsPGYK34QTs0rQ+XlMXguKwY roWiwvWcf7xe5DyNSKg57QZX3Q== X-Received: by 2002:a1c:7eca:: with SMTP id z193mr175136wmc.5.1548193821782; Tue, 22 Jan 2019 13:50:21 -0800 (PST) Received: from zen.linaro.local ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id t70sm84764921wmd.36.2019.01.22.13.50.17 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 22 Jan 2019 13:50:19 -0800 (PST) Received: from zen.linaroharston (localhost [127.0.0.1]) by zen.linaro.local (Postfix) with ESMTP id 887713E0AA5; Tue, 22 Jan 2019 21:50:16 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Date: Tue, 22 Jan 2019 21:50:10 +0000 Message-Id: <20190122215016.18697-6-alex.bennee@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190122215016.18697-1-alex.bennee@linaro.org> References: <20190122215016.18697-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::341 Subject: [Qemu-devel] [PATCH v3 05/11] fp-test: fix signature of slow_clear_flags and qemu_clear_flags X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , "Emilio G. Cota" , =?utf-8?q?Alex_Benn=C3=A9e?= , Aurelien Jarno Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: "Emilio G. Cota" To match the type in testfloat. Signed-off-by: Emilio G. Cota Signed-off-by: Alex Bennée --- tests/fp/fp-test.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.17.1 diff --git a/tests/fp/fp-test.c b/tests/fp/fp-test.c index fca576309c..2a35ef601d 100644 --- a/tests/fp/fp-test.c +++ b/tests/fp/fp-test.c @@ -789,7 +789,7 @@ static int set_init_flags(const char *flags) return 0; } -static uint8_t slow_clear_flags(void) +static uint_fast8_t slow_clear_flags(void) { uint8_t prev = slowfloat_exceptionFlags; @@ -797,7 +797,7 @@ static uint8_t slow_clear_flags(void) return prev; } -static uint8_t qemu_clear_flags(void) +static uint_fast8_t qemu_clear_flags(void) { uint8_t prev = qemu_flags_to_sf(qsf.float_exception_flags); From patchwork Tue Jan 22 21:50:11 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 156330 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp44788jaa; Tue, 22 Jan 2019 13:58:51 -0800 (PST) X-Google-Smtp-Source: ALg8bN4Sb9DbYLWOXIcnlcwiDCFtNM0OGnxfEDWBRx/r1/yXYwmcYvQ3RJw8R0J+9Xtao0vRdCMR X-Received: by 2002:a1c:d00d:: with SMTP id h13mr192816wmg.13.1548194331233; Tue, 22 Jan 2019 13:58:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548194331; cv=none; d=google.com; s=arc-20160816; b=BX6XmNVPzYBuNhe1UQnLdUOZ9U7zwOxbiabvPwBkJZzYeLgF3LIg7EUe92xMnk7J87 DduKK+CsbvM2iVgmJn7qR2UYyVCF4oFQoXnwHcung8imUOs+VfXGPAR1/7kZL34lXG+L TASsCHfygBdPUSLAfmfXKEPH5Wvjb4kjEdvx0MrrATvUGoQ5W3v3V4vkajwMCD6euxyw SFBn78VKBmaAramlVrfQxRh8k1EixiGvyPams6dTHC5RKZDLNqW1jeeR3PqW31Wl+YCU hgOqQgMrIhPjIQUcU6NG2HyaFSlgMbMm8sjkH37Hn//6ExJMCiZ0ibnHImNyGVzcXoow y9Qw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=vz8eNc4Bi34/phbpQzL2afwL7DpHo9/quR04/vTR/5U=; b=X+NQKqSbp7CZoeLTQ8cpFtT1zMNhhrnrTP8WD83o+L+xPSBuY3eieR7+YIqoVksm93 wqNyXb4i09798g5FVB0sE8J/Aspi7q9WBq7OWSVBkt8NunQ10A5QqHjE7toUYoooAFwa HZPTDFtCWbjthFc3i0VgWaloe+lxz3/lRQBrLsl5DL6glcuAFD0pDEr6gLvU/WauLbXg 7rHhpBlxK4KYtHAZG8f49eAjlBX5I+26n2CyZjVyVsZYsQfkekiyQpUo6qJrgVH/TgWi EwYbF1LrESWv/NAOKPP7+sFijXzcaNAGoGalsLHaHVrzrAuuT3Eah5oJlrK0oSSzJJH+ Ot9Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=B1iNqrHf; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id j204si34581375wma.169.2019.01.22.13.58.51 for (version=TLS1 cipher=AES128-SHA bits=128/128); Tue, 22 Jan 2019 13:58:51 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=B1iNqrHf; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([127.0.0.1]:50875 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gm44I-0005sd-7z for patch@linaro.org; Tue, 22 Jan 2019 16:58:50 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60951) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gm3wQ-0007Sr-LS for qemu-devel@nongnu.org; Tue, 22 Jan 2019 16:50:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gm3wP-0008Fo-KK for qemu-devel@nongnu.org; Tue, 22 Jan 2019 16:50:42 -0500 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]:38101) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gm3wP-0007s8-Bk for qemu-devel@nongnu.org; Tue, 22 Jan 2019 16:50:41 -0500 Received: by mail-wm1-x343.google.com with SMTP id m22so81307wml.3 for ; Tue, 22 Jan 2019 13:50:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=vz8eNc4Bi34/phbpQzL2afwL7DpHo9/quR04/vTR/5U=; b=B1iNqrHfkicFlYMPxQtuRM+aLHlqLqH562v5bud2JGg0Rd78JG60Xy+d/JhSbQs56q jOWJ0ksxzfyw1B0/WyyxyGJTT53h0VyrKs5wOEkx+Hto1G5LPyCBg/LJGP/nJwib2pDw J/WzQ7UFFFA1465sSQ5scsiJooa6GhuKTcn4k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=vz8eNc4Bi34/phbpQzL2afwL7DpHo9/quR04/vTR/5U=; b=gQ9ASw2AFuvaTTlZwrtVhjxRAQaEckXNn+TXXBeO03pk+O9Mo0DatOvXCrqODaNafk HxZHldAEL3nXjTAOPckcYjqYTXv//33hoJ1W8FynOa1eBKHtqR4QospQaHP4fjzTDc2J o2W8M0/b4pT6LBuO5bEwx+SVOieAwO9QVLpr803S7LBET9skH5gtccufxUlvN7ikCr+F +FowXwbcKNV4crXUCSPiKoVGaStBYWsTfztbf7UjnvBdIoTX1/4Ay98WDCc8lfZFqxVk sfSwq2HqT+Q3KzIqTgjkTJhJC3T5fr9egi0B+9wTabOH9NYgWVfY/y6QQF/XtADKJGIC 2Z+g== X-Gm-Message-State: AJcUukckrczH8h4XctfXlVg0lvm78hRkR/QddHU5zRYqworFU2Dr4eby lcZan/+dxQN/xAlLfUI4dIbGRQ== X-Received: by 2002:a1c:e046:: with SMTP id x67mr183532wmg.122.1548193823634; Tue, 22 Jan 2019 13:50:23 -0800 (PST) Received: from zen.linaro.local ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id b129sm45369446wmd.24.2019.01.22.13.50.17 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 22 Jan 2019 13:50:19 -0800 (PST) Received: from zen.linaroharston (localhost [127.0.0.1]) by zen.linaro.local (Postfix) with ESMTP id 9AA983E0B11; Tue, 22 Jan 2019 21:50:16 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Date: Tue, 22 Jan 2019 21:50:11 +0000 Message-Id: <20190122215016.18697-7-alex.bennee@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190122215016.18697-1-alex.bennee@linaro.org> References: <20190122215016.18697-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::343 Subject: [Qemu-devel] [PATCH v3 06/11] tests/fp/platform.h: include config-host.h X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , "Emilio G. Cota" , =?utf-8?q?Alex_Benn=C3=A9e?= , Aurelien Jarno Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: "Emilio G. Cota" We get HOST_WORDS_BIGENDIAN from config-host.h, but the include is missing. Fix it. This fixes `make check-softfloat' on big endian hosts. Reported-by: Peter Maydell Signed-off-by: Emilio G. Cota Signed-off-by: Alex Bennée --- tests/fp/platform.h | 1 + 1 file changed, 1 insertion(+) -- 2.17.1 diff --git a/tests/fp/platform.h b/tests/fp/platform.h index f8c423dde3..c20ba70baa 100644 --- a/tests/fp/platform.h +++ b/tests/fp/platform.h @@ -29,6 +29,7 @@ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */ +#include "config-host.h" #ifndef HOST_WORDS_BIGENDIAN #define LITTLEENDIAN 1 From patchwork Tue Jan 22 21:50:12 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 156328 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp43904jaa; Tue, 22 Jan 2019 13:57:31 -0800 (PST) X-Google-Smtp-Source: ALg8bN6RO42UzPE/oMB7Q7LMDkDYMRVjLzwLU7UxXPe+uVjV3QO5w523w8yWW+RPxrHH0/oUW17r X-Received: by 2002:adf:fd87:: with SMTP id d7mr33456272wrr.74.1548194251268; Tue, 22 Jan 2019 13:57:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548194251; cv=none; d=google.com; s=arc-20160816; b=jl/AjQ0JhczEGbnEAIFfiMm95GHrNczKLoFYKBb2exTlVHPPF7MN0Qr6NT7eWZAYwn 7DGk6h6lY7B3QDM9M60Iu1OQ9/D0MwUU0tKDLBdqJLs7nhm3btCZTUuP24pm/mp+Zlaw T3YtJ7N+uTItBsxzztrpyj+g33gT7IXMs/uOnY2lZ9WUPQkH/mPl3ReBIdOM5PRkIOLF eANcq5CBNcsilx0kNEZTJUWsvN5kY9si3dGjP/pHbOWnGYrp+0U5Pgq7aNnSA1GRHWtd 6xGQbNwA9GB0/fLQM44jTvC+MjsvOtvchwiDhHX/guhtzhF2lHSsgkNtWujuOOlg0JNj BxYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=faBd61OejxUkxq2rvQ3pDsb42Y/YIlwTE9s8AKa1cmg=; b=K8WXC8935Rvi4pVl/MFprnBYz7KEQYE7aV/nCq4DR3PpSOi0pw31suMG7dLB5dH5bq CdOW2vzB1Qp5xsBG9MgdhRpuPJQdlhI3nRa74N/b5dDyLF5IYK0tje6WO9BNzBG8r88W Ata0gYDJOkaofr2d9N7+Ehvmu5WMilCoF/MMfkoJtFyhQVv6qevaz3Jzz7fxmINxIZ5B XZI0NgBqQm4oPItVdO7sougU+EGg5s6tri1WWJDEhn9ButQnH2FVcjl2JW0C8571NK2k GZFAUHr1VBG7Rl6mOKvClFy6TiPPmgBpwykC6qxzOF8++1qMGk0MPt2FSJZ8lAw5dJeY 1+ww== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=KeP0kqWa; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id r2si80385489wrc.441.2019.01.22.13.57.30 for (version=TLS1 cipher=AES128-SHA bits=128/128); Tue, 22 Jan 2019 13:57:31 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=KeP0kqWa; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([127.0.0.1]:50867 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gm430-00049D-5O for patch@linaro.org; Tue, 22 Jan 2019 16:57:30 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60932) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gm3wQ-0007SZ-Bh for qemu-devel@nongnu.org; Tue, 22 Jan 2019 16:50:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gm3wP-0008Eu-25 for qemu-devel@nongnu.org; Tue, 22 Jan 2019 16:50:42 -0500 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]:53089) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gm3wL-0007ph-70 for qemu-devel@nongnu.org; Tue, 22 Jan 2019 16:50:37 -0500 Received: by mail-wm1-x341.google.com with SMTP id m1so81910wml.2 for ; Tue, 22 Jan 2019 13:50:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=faBd61OejxUkxq2rvQ3pDsb42Y/YIlwTE9s8AKa1cmg=; b=KeP0kqWau5nI7FaqnskD8K9BYGaUs789d8O9AfKetFJ/Y1t/oWMlUn3MgA26p7Sg4n acl1XhdHokeENrbBPX3G7UqIvpB6iIeVZJHqhV/kPg1q6sU6ZtIEczVgg6UPgjQfqyNW 0zDK5tbBhq+OgNjlIKZexY8edRBF2YIjSMD6I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=faBd61OejxUkxq2rvQ3pDsb42Y/YIlwTE9s8AKa1cmg=; b=E4gTOxL0JH+K9CpANJye0kH7W21OceD6rF1KIYI672D5Wtxr/AobSnPTR28WFMRdhT puOrDoRMzWsOYPYn2aCUOhTrIiSXInYXuDV5QGbX1kB1XBPjFtJP8KkDG65GK8lZiSjy l+EzZFvWo0fe1fMm8Oaht73Qqzc6rlZxloPzyHeaEPPue94CYD9+fK5+NNlvxEceAj10 zJRYi9CSCaJP7TM6TaAC0wsy1npp82oys7wYHu3iYFJdhrW+OmVy3cWSEBMrnFBz9tC5 +DsUTBNjiBIwUkDZVaSslF4Lw+qQqV2dtpY+2Kr370LEuBj/VdVQSF0P3Xva00rXlVWq qlpA== X-Gm-Message-State: AJcUukfCe7LzD+I9mZE8Q58LEJirT3ZHOJZYUpv3ZCU00bT+m4HOLAbX 6WYq7cI30M1F5i4VdJyGaF6lQ47qDJY= X-Received: by 2002:a1c:4855:: with SMTP id v82mr179502wma.15.1548193822289; Tue, 22 Jan 2019 13:50:22 -0800 (PST) Received: from zen.linaro.local ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id f187sm39611990wma.4.2019.01.22.13.50.17 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 22 Jan 2019 13:50:19 -0800 (PST) Received: from zen.linaroharston (localhost [127.0.0.1]) by zen.linaro.local (Postfix) with ESMTP id AD8E33E0B76; Tue, 22 Jan 2019 21:50:16 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Date: Tue, 22 Jan 2019 21:50:12 +0000 Message-Id: <20190122215016.18697-8-alex.bennee@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190122215016.18697-1-alex.bennee@linaro.org> References: <20190122215016.18697-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::341 Subject: [Qemu-devel] [PATCH v3 07/11] softfloat: enforce softfloat if the host's FMA is broken X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , "Emilio G. Cota" , =?utf-8?q?Alex_Benn=C3=A9e?= , Aurelien Jarno Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: "Emilio G. Cota" The added branch to the FMA ops is marked as unlikely and therefore its impact on performance (measured with fp-bench) is within noise range when measured on an Intel(R) Xeon(R) Gold 6142 CPU @ 2.60GHz. Reported-by: Laurent Desnogues Signed-off-by: Emilio G. Cota Reviewed-by: Richard Henderson Signed-off-by: Alex Bennée --- fpu/softfloat.c | 33 +++++++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+) -- 2.17.1 diff --git a/fpu/softfloat.c b/fpu/softfloat.c index 59eac97d10..9132d7a0b0 100644 --- a/fpu/softfloat.c +++ b/fpu/softfloat.c @@ -1542,6 +1542,8 @@ soft_f64_muladd(float64 a, float64 b, float64 c, int flags, return float64_round_pack_canonical(pr, status); } +static bool force_soft_fma; + float32 QEMU_FLATTEN float32_muladd(float32 xa, float32 xb, float32 xc, int flags, float_status *s) { @@ -1562,6 +1564,11 @@ float32_muladd(float32 xa, float32 xb, float32 xc, int flags, float_status *s) if (unlikely(!f32_is_zon3(ua, ub, uc))) { goto soft; } + + if (unlikely(force_soft_fma)) { + goto soft; + } + /* * When (a || b) == 0, there's no need to check for under/over flow, * since we know the addend is (normal || 0) and the product is 0. @@ -1623,6 +1630,11 @@ float64_muladd(float64 xa, float64 xb, float64 xc, int flags, float_status *s) if (unlikely(!f64_is_zon3(ua, ub, uc))) { goto soft; } + + if (unlikely(force_soft_fma)) { + goto soft; + } + /* * When (a || b) == 0, there's no need to check for under/over flow, * since we know the addend is (normal || 0) and the product is 0. @@ -7974,3 +7986,24 @@ float128 float128_scalbn(float128 a, int n, float_status *status) , status); } + +static void __attribute__((constructor)) softfloat_init(void) +{ + union_float64 ua, ub, uc, ur; + + if (QEMU_NO_HARDFLOAT) { + return; + } + /* + * Test that the host's FMA is not obviously broken. For example, + * glibc < 2.23 can perform an incorrect FMA on certain hosts; see + * https://sourceware.org/bugzilla/show_bug.cgi?id=13304 + */ + ua.s = 0x0020000000000001ULL; + ub.s = 0x3ca0000000000000ULL; + uc.s = 0x0020000000000000ULL; + ur.h = fma(ua.h, ub.h, uc.h); + if (ur.s != 0x0020000000000001ULL) { + force_soft_fma = true; + } +} From patchwork Tue Jan 22 21:50:13 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 156332 Delivered-To: patch@linaro.org Received: by 2002:a02:b531:0:0:0:0:0 with SMTP id l46csp34216jaj; Tue, 22 Jan 2019 14:00:26 -0800 (PST) X-Google-Smtp-Source: ALg8bN7NSSQGjpcNIcs84PveeFQgYGVo6BRAIDrA59+ITA9D41xYD1GOLgJLCsdF46SVmrLC8mvM X-Received: by 2002:adf:a743:: with SMTP id e3mr33450674wrd.56.1548194426259; Tue, 22 Jan 2019 14:00:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548194426; cv=none; d=google.com; s=arc-20160816; b=KECXqs50dJglEwFVFhqi34cdDoVxVLlYVYYD/iJbU6DEMkP5SfXnxUbn4y2W9PWrqn AexPTsjYXIK76Egsax56wMX2rSLbyBxh3NKLZgyG6euCtjqXv+tuXBEMiqAoGNaY6dNa 4X5TcuR3T64sR7w55jISl36KwG7riQYWcLOWHYsBrXj6VMl0YCxlZC4Ae+jtOr+nfBIm GWXiJc1nRuyoOHqu8Ynqs2zT7WmBrFkTGEjyt5feuMKkPWvJnnmCqJUO5z8MLWgdUKWr UXLobSJn7hfZTSsclYO/aVOMjMaIXQs5bRmOQYHZj1Tb2cvRc3Y+42Cz34crlFnSIL9N TiOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=EAPNIESGsiwOeWgYA3ZDDIcXw7LSNCiic8+xiezNhwM=; b=QfQfKE9buRkqM6umxr2jvAE8KnEDsrRwxIvl8R4Ko+qpKMF6qIYufBIvXpjjZqY4Qb J33qs4aAzM7GU0rUHLckZksf5skov+FtsBzGflPXF5+nopTzR7RDrVFcee3xHPutSoJy FMK3a9Zxba5ViO99wQ5Z3doDbzwR59wSj6Dl/Rksko2+CTO1W5mK8zNLo8MB0wW2HFDl wuiVVXkx83++NgS7jUmAQl7sDS9W6YMSqtQyoXCT9+4fK63BMa6KnqQpTN83fD/T8l8k a4sEkTEJPXGJuKRxJo6+HY/ayXZFg7EsjL5t57JiAwnMh5vrlMTQSn3Ks2kH6J2lEIpM HCuw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=P5S48D6l; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id k81si35389556wmf.8.2019.01.22.14.00.25 for (version=TLS1 cipher=AES128-SHA bits=128/128); Tue, 22 Jan 2019 14:00:26 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=P5S48D6l; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([127.0.0.1]:50919 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gm45p-0007uV-1a for patch@linaro.org; Tue, 22 Jan 2019 17:00:25 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60925) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gm3wQ-0007SU-99 for qemu-devel@nongnu.org; Tue, 22 Jan 2019 16:50:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gm3wP-0008FN-AO for qemu-devel@nongnu.org; Tue, 22 Jan 2019 16:50:42 -0500 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]:45683) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gm3wP-0007qg-3e for qemu-devel@nongnu.org; Tue, 22 Jan 2019 16:50:41 -0500 Received: by mail-wr1-x441.google.com with SMTP id t6so46281wrr.12 for ; Tue, 22 Jan 2019 13:50:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=EAPNIESGsiwOeWgYA3ZDDIcXw7LSNCiic8+xiezNhwM=; b=P5S48D6lZDPHsZ0AYxDOU4oL63tRzp+9ifQhhFjoxgPxV2rL1gIuU4ZqEMKuOWwIFh gdJ3h5UxE5/edrHo6hropJxQpQZkGZRwYAOCqJEWLNXWntVSTie4f2rLqULQyiTrBckl G/ePlfhPc28IyBErMkBMDzDc/MyAgyvx6XEVQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=EAPNIESGsiwOeWgYA3ZDDIcXw7LSNCiic8+xiezNhwM=; b=LEffwSmD7fZ0rnX2O5eEOswOM67MHrv1OG4wyD68Z7DDFdg9HyDwuzEnBOwLhEP1dF SRPWSrgGvaBn95Z/3PLfq5Idx8bxrJXsDwZHJ2f5+jBfHPXPw5brggGKUk2MtsBPUYmb nViChNDt38quRvlZB6It4XqnYC3xqB5TK/ApLYAbRqjZGaHTvKXN229LfYcCoz7dxk8H 7ICdgjhverGL5bA+r3GAvzfUXFB0SP8XkOaWxATDmWrmPTTOvbeLYNtV/HJTonvevq2o iPjm19pbm8kYTaHdNOZzxC9ohLA1kzxSJv1ex02cyr5Y9j04ie937UJqUAL14bxMTn8h DujQ== X-Gm-Message-State: AJcUukd6OVw2Ze2DZdA1QsfvS/c4EydQ6/rGVoJ+sRFAmMnOCWbsHVTc Ax3RULxJH+lG5QALfCjtfn6enA== X-Received: by 2002:adf:ff09:: with SMTP id k9mr33231940wrr.97.1548193822915; Tue, 22 Jan 2019 13:50:22 -0800 (PST) Received: from zen.linaro.local ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id y138sm64153926wmc.16.2019.01.22.13.50.17 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 22 Jan 2019 13:50:19 -0800 (PST) Received: from zen.linaroharston (localhost [127.0.0.1]) by zen.linaro.local (Postfix) with ESMTP id C00D13E0CD5; Tue, 22 Jan 2019 21:50:16 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Date: Tue, 22 Jan 2019 21:50:13 +0000 Message-Id: <20190122215016.18697-9-alex.bennee@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190122215016.18697-1-alex.bennee@linaro.org> References: <20190122215016.18697-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::441 Subject: [Qemu-devel] [PATCH v3 08/11] include/fpu/softfloat: Fix compilation with Clang on s390x X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Thomas Huth , =?utf-8?q?Alex_Benn=C3=A9e?= , Aurelien Jarno Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Thomas Huth Clang v7.0.1 does not like the __int128 variable type for inline assembly on s390x: In file included from fpu/softfloat.c:97: include/fpu/softfloat-macros.h:647:9: error: inline asm error: This value type register class is not natively supported! asm("dlgr %0, %1" : "+r"(n) : "r"(d)); ^ Disable this code part there now when compiling with Clang, so that the generic code gets used instead. Signed-off-by: Thomas Huth Reviewed-by: Richard Henderson Acked-by: Cornelia Huck Signed-off-by: Alex Bennée --- include/fpu/softfloat-macros.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.17.1 diff --git a/include/fpu/softfloat-macros.h b/include/fpu/softfloat-macros.h index b1d772e6d4..bd5b6418e3 100644 --- a/include/fpu/softfloat-macros.h +++ b/include/fpu/softfloat-macros.h @@ -641,7 +641,7 @@ static inline uint64_t udiv_qrnnd(uint64_t *r, uint64_t n1, uint64_t q; asm("divq %4" : "=a"(q), "=d"(*r) : "0"(n0), "1"(n1), "rm"(d)); return q; -#elif defined(__s390x__) +#elif defined(__s390x__) && !defined(__clang__) /* Need to use a TImode type to get an even register pair for DLGR. */ unsigned __int128 n = (unsigned __int128)n1 << 64 | n0; asm("dlgr %0, %1" : "+r"(n) : "r"(d)); From patchwork Tue Jan 22 21:50:14 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 156331 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp45071jaa; Tue, 22 Jan 2019 13:59:18 -0800 (PST) X-Google-Smtp-Source: ALg8bN7F0SBxKk4mhtfsQtpYE7AioTNZZxZvi/kyOhUX/w+U65RRe0NEG9hMOOTG0y7nTBSOrAy7 X-Received: by 2002:adf:fe43:: with SMTP id m3mr33532377wrs.290.1548194358796; Tue, 22 Jan 2019 13:59:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548194358; cv=none; d=google.com; s=arc-20160816; b=jlpQCnUhsi+WdXW32RMHuSw7nbN1eBQi3xfiWWLa2o4jOW4IbWxQl5BBRx2piT9+3Y iHtTyEK8bfVsklfZq+BU4kxWBmUvLfapAq3T0w6yEEbZ0OGMAmwdxbk56O/qLYm74VCN M8fN8zZBbKQQJ5dzaGNyJwWze3YUNQ4jFJUG3dHioyeuVar//m3oaSBwRAtOSzCorg+A hmpsJgzN6J+KMdPfOlqwL+a8O5KpjAwWS8vz8qJeh1F9vZVicrTO+OgF66rUlrtnkRHH ShJDUoy4B4fsi2bvFjDGJItUgHH57pWDL3dkZ1aOu3In7KU54h7Rkg2E3zOhNxl8TMjd e0xw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=vNUVzXJMeciF3yCxVe8r8HtMv+v24ndvlEQDb539ja8=; b=ssiDjNC+j7Tgb+bX91tFdv7XSylh777mEIas9FPciewKoZLp0Mc5Mq6vEzSIos7Xiz dL7vBK6m6JwVRqv1tiMXvFKXh8NM5OKU0L+kmiXwW+x4WIA8g4QHGFA9RiyWYkyVkJ+c KLL1ujYLcQu4dGnUau/f2tsWTXUcsUsw9H7N2ahcpL5o4bk43ixxMA3sJxSgTuWj7iyE xMvs1sNv8U6g5GsLoqH8f3pEhg+as06yPfTsh68A2OnLp62APD1ztwooSWTVjDKj+Lz1 ABRzJyCkTpfX58znEkbg2KkUQLIRg4hc2xFzFY1wm8zS14wHkHjiEl8JkqGBbYb2cMGo cd1A== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=hkGkPTyM; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id i89si71491103wri.305.2019.01.22.13.59.14 for (version=TLS1 cipher=AES128-SHA bits=128/128); Tue, 22 Jan 2019 13:59:18 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=hkGkPTyM; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([127.0.0.1]:50911 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gm44g-000727-7A for patch@linaro.org; Tue, 22 Jan 2019 16:59:14 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60972) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gm3wR-0007TN-2s for qemu-devel@nongnu.org; Tue, 22 Jan 2019 16:50:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gm3wP-0008Fi-Ij for qemu-devel@nongnu.org; Tue, 22 Jan 2019 16:50:42 -0500 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]:34734) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gm3wP-0007uB-9s for qemu-devel@nongnu.org; Tue, 22 Jan 2019 16:50:41 -0500 Received: by mail-wm1-x341.google.com with SMTP id y185so9540697wmd.1 for ; Tue, 22 Jan 2019 13:50:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=vNUVzXJMeciF3yCxVe8r8HtMv+v24ndvlEQDb539ja8=; b=hkGkPTyMs3RHAunAfxnBdNpIoMnn1uNsLcEULTrjtaww0vHAm3F6v82bZPcEAK9ZcV CG1U20cTTF49UQvIb0EK3As+i9vrcpftDVZOTG6hQKyYkHGY1HLQLrrCymkJAGKM0FK5 2mJjVGPwfm0VpEUBcgtAVV/hXtPlrhhfBH/Vo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=vNUVzXJMeciF3yCxVe8r8HtMv+v24ndvlEQDb539ja8=; b=F79P2M11tko+9MT/TnU2qffFKx37+E7PXYogAcQ9Rzp1MsrfwedrTkxKnapXZrldhH yZCwfl0vkjwZFvcBi3l6qRrmrFKQ5Ic9f3J8S71J1ZV+6sP6UIyw+lP54Xsw7LAzdoTJ urqmBK5lNH0PbUcA3URNnVxcgKi+VpbwEDcL5Mx3orhU6y/JO6FEZ4a62MkMZ1QJXLUY vUwieqWoNOrvwt6VifyByVlCnA8n241g5TCgZJZSmyKr4nnjHLXe4tVJaoP+b3yKyER+ 8pdj6C9Ca1+QrCYf0E4fKOPN5effPU4nDZ8eBVF52Dnqi38wCFqf/xSpz6C3gIbgXzZq GKug== X-Gm-Message-State: AJcUukcxPiQinMOHGEBtXwKm7urwTteILZRdQu+WWL2teEe2O4iUZLzy hzHTE6SYMdrjuUoSvRAz6SDUIY9EaF4= X-Received: by 2002:a1c:f71a:: with SMTP id v26mr152368wmh.131.1548193824398; Tue, 22 Jan 2019 13:50:24 -0800 (PST) Received: from zen.linaro.local ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id t66sm18073834wme.15.2019.01.22.13.50.18 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 22 Jan 2019 13:50:20 -0800 (PST) Received: from zen.linaroharston (localhost [127.0.0.1]) by zen.linaro.local (Postfix) with ESMTP id D24103E0D0E; Tue, 22 Jan 2019 21:50:16 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Date: Tue, 22 Jan 2019 21:50:14 +0000 Message-Id: <20190122215016.18697-10-alex.bennee@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190122215016.18697-1-alex.bennee@linaro.org> References: <20190122215016.18697-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::341 Subject: [Qemu-devel] [PATCH v3 09/11] tests/Makefile: add floating point tests X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Alex_Benn=C3=A9e?= Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Wire up test/fp-test into the main testing Makefile. Currently we skip some of the extF80 and f128 related tests. Once we re-factor and fix these tests the plumbing should get simpler. Signed-off-by: Alex Bennée --- v3 - tweak test function - always call fp-test build --- tests/Makefile.include | 120 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 120 insertions(+) -- 2.17.1 diff --git a/tests/Makefile.include b/tests/Makefile.include index 4eea38ae99..f123616bc7 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include @@ -880,6 +880,126 @@ check-report-unit.tap: $(check-unit-y) check-report.tap: $(patsubst %,check-report-qtest-%.tap, $(QTEST_TARGETS)) check-report-unit.tap $(call quiet-command,./scripts/tap-merge.py $^ > $@,"GEN","$@") +# FPU Emulation tests (aka softfloat) +# +# As we still have some places that need fixing the rules are a little +# more complex than they need to be and have to override some of the +# generic Makefile expansions. Once we are cleanly passing all +# the tests we can simplify the make syntax. + +FP_TEST_BIN=$(BUILD_DIR)/tests/fp/fp-test + +# the build dir is created by configure +.PHONY: $(FP_TEST_BIN) +$(FP_TEST_BIN): $(BUILD_DIR)/tests/fp fpu/softfloat.c + $(call quiet-command, \ + cd $(BUILD_DIR)/tests/fp && make, \ + "BUILD", $<) + +# The full test suite can take a bit of time, default to a quick run +ifeq ($(SPEED), quick) +FP_TL=-l 1 +else +FP_TL=-l 2 -r all +endif + +# $1 = tests, $2 = description +test-softfloat = $(call quiet-command, \ + cd $(BUILD_DIR)/tests/fp && \ + ./fp-test -s $(FP_TL) $1 > $2.out 2>&1 || \ + (cat $2.out && exit 1;), \ + "FLOAT TEST", $2) + +# Conversion Routines: +# FIXME: i32_to_extF80 (broken), i64_to_extF80 (broken) +# ui32_to_f128 (not implemented), f128_to_ui32 (not implemented) +# extF80_roundToInt (broken) +# +check-softfloat-conv: $(FP_TEST_BIN) + $(call test-softfloat, \ + i32_to_f16 i64_to_f16 \ + i32_to_f32 i64_to_f32 \ + i32_to_f64 i64_to_f64 \ + i32_to_f128 i64_to_f128, int-to-float) + $(call test-softfloat, \ + ui32_to_f16 ui64_to_f16 \ + ui32_to_f32 ui64_to_f32 \ + ui32_to_f64 ui64_to_f64 \ + ui64_to_f128, uint-to-float) + $(call test-softfloat, \ + f16_to_i32 f16_to_i32_r_minMag \ + f32_to_i32 f32_to_i32_r_minMag \ + f64_to_i32 f64_to_i32_r_minMag \ + extF80_to_i32 extF80_to_i32_r_minMag \ + f128_to_i32 f128_to_i32_r_minMag \ + f16_to_i64 f16_to_i64_r_minMag \ + f32_to_i64 f32_to_i64_r_minMag \ + f64_to_i64 f64_to_i64_r_minMag \ + extF80_to_i64 extF80_to_i64_r_minMag \ + f128_to_i64 f128_to_i64_r_minMag, \ + float-to-int) + $(call test-softfloat, \ + f16_to_ui32 f16_to_ui32_r_minMag \ + f32_to_ui32 f32_to_ui32_r_minMag \ + f64_to_ui32 f64_to_ui32_r_minMag \ + f16_to_ui64 f16_to_ui64_r_minMag \ + f32_to_ui64 f32_to_ui64_r_minMag \ + f64_to_ui64 f64_to_ui64_r_minMag, \ + float-to-uint) + $(call test-softfloat, \ + f16_roundToInt f32_roundToInt \ + f64_roundToInt f128_roundToInt, \ + round-to-integer) + +# Generic rule for all float operations +# +# Some patterns are overidden due to broken or missing tests. +# Hopefully these can be removed over time. + +check-softfloat-%: $(FP_TEST_BIN) + $(call test-softfloat, f16_$* f32_$* f64_$* extF80_$* f128_$*, $*) + +# Float Compare routines +SF_COMPARE_OPS=eq eq_signaling le le_quiet lt_quiet +SF_COMPARE_RULES=$(patsubst %,check-softfloat-%, $(SF_COMPARE_OPS)) + +# FIXME: extF80_le_quiet (broken) +check-softfloat-le_quiet: $(FP_TEST_BIN) + $(call test-softfloat, \ + f16_le_quiet f32_le_quiet f64_le_quiet \ + f128_le_quiet, \ + le_quiet) + +# FIXME: extF80_lt_quiet (broken) +check-softfloat-lt_quiet: $(FP_TEST_BIN) + $(call test-softfloat, \ + f16_lt_quiet f32_lt_quiet f64_lt_quiet \ + f128_lt_quiet, \ + lt_quiet) + +.PHONY: check-softfloat-compare +check-softfloat-compare: $(SF_COMPARE_RULES) + +# Math Operations + +# FIXME: extF80_mulAdd (missing) +check-softfloat-mulAdd: $(FP_TEST_BIN) + $(call test-softfloat, \ + f16_mulAdd f32_mulAdd f64_mulAdd f128_mulAdd, \ + mulAdd) + +# FIXME: extF80_rem (broken) +check-softfloat-rem: $(FP_TEST_BIN) + $(call test-softfloat, \ + f16_rem f32_rem f64_rem f128_rem, \ + rem) + +SF_MATH_OPS=add sub mul mulAdd div rem sqrt +SF_MATH_RULES=$(patsubst %,check-softfloat-%, $(SF_MATH_OPS)) + +.PHONY: check-softfloat-ops +check-softfloat-ops: $(SF_MATH_RULES) + # Per guest TCG tests LINUX_USER_TARGETS=$(filter %-linux-user,$(TARGET_DIRS)) From patchwork Tue Jan 22 21:50:15 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 156326 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp41394jaa; Tue, 22 Jan 2019 13:53:50 -0800 (PST) X-Google-Smtp-Source: ALg8bN4Ks3Xly/vQymbSnBtEKwwMU5JAF+ojT/+3DxrIgqcDyQo/X7DXoEYWydSKAsFuMSgU1Ymk X-Received: by 2002:a5d:6244:: with SMTP id m4mr33865832wrv.314.1548194029961; Tue, 22 Jan 2019 13:53:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548194029; cv=none; d=google.com; s=arc-20160816; b=dIismhS1Wh5VNywn5335Z4iJrHGzBuOyMHBAE8VtwT9LdpGDUNOow5IyLvlArvB5I8 pmm7itHiamV+kG/gI7sRyNOZ/UGFg/3lRZT75EWp1N2aQfSDFWV5OMlUxyLpvw7XBRWc 7iMhNE+1KxqqlOsuQZ6HMBn3jMlNfzP3ard09jveZrEHv/qDKvhL+NBAioX4FNNXTRZO kNeaqjgWdnpB/V7VhFlUCZGtAWVu+q63sVMaYsvaz6Y8w3oFSJbAsMrnDJHHhHDdmsqh r9MygJm85f0q4h7Y8afgKn1YvPW/f+HOMbZTY3a7hGjChZyB6rEtadwn32K/JWPoNSjT mXZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=HjyDClYTa4RavIRqdKjd3FAFDFKhqzTfdleMBuojdXM=; b=Yx93ydSYvy+4vaFLtsd2jS4s9ijR8dTkCX/QcUWVqd53lEX4eghfjgqsCKG8yM0rnr VM8qgsqBZR5sOtUQUyK5GB+1TzxF2zV0UgyyiFAUiL/fk/h5MW1TK4g9kBu1wrjZNof0 skz2k6uPJCGx0rT1Fayo7+X0bWZJrthTPGHaTkQEyhaqwlTlUNEr7kzUfrCmRxIvtjBY 6MTmUQz8nxA5PLEluE1aTtZw+4WTpzHC1uPmtniLYvZuxc3XjC4uRb8wWF77Fxq1gIK+ y7IAdzMu4OWyQqbPLHETbIfc82tCAXcBOHORNPKkk4VHxtcMIFT+ENWOvKJoJT6xfTeo w5WQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=XCLNqwUd; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id r68si36452137wme.104.2019.01.22.13.53.49 for (version=TLS1 cipher=AES128-SHA bits=128/128); Tue, 22 Jan 2019 13:53:49 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=XCLNqwUd; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([127.0.0.1]:50781 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gm3zQ-0000QL-TE for patch@linaro.org; Tue, 22 Jan 2019 16:53:48 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60965) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gm3wQ-0007TC-Ty for qemu-devel@nongnu.org; Tue, 22 Jan 2019 16:50:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gm3wP-0008GJ-SP for qemu-devel@nongnu.org; Tue, 22 Jan 2019 16:50:42 -0500 Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]:52536) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gm3wP-0007vu-J9 for qemu-devel@nongnu.org; Tue, 22 Jan 2019 16:50:41 -0500 Received: by mail-wm1-x333.google.com with SMTP id m1so82040wml.2 for ; Tue, 22 Jan 2019 13:50:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=HjyDClYTa4RavIRqdKjd3FAFDFKhqzTfdleMBuojdXM=; b=XCLNqwUdqnz5SIuu0zCkuBinV77EtEfmkPjtO/cBY5xQacMZkOJTmAPnF/HFUjYwoA wcGXm3/pLUIWPYbviF1M2ZLpueMu+JTtPUouddQljT0wZ6nqBvZq5/oK2/W/BEPFwTMo 9QcE/pPOpUZdlmQt2AcW6PVfTonz7Fqf56xmA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=HjyDClYTa4RavIRqdKjd3FAFDFKhqzTfdleMBuojdXM=; b=IIOR/nf2z7GvaLHq6IJMhmAaC84AkJYnqw4W1ANe9C6d3n/zGXfAlTT0Bx0SEfdHoN ciO2zPgZ2Bw7vTYfJVhKp2K0EJqangVlx2epr8PZUpXbhL2s9WTMe8ypw1k1eb3tv4eX SS6MLo2Rguy2L3k1sHNHb4QrVeKEMNukNNTvPDi6ntfTAcF3RJkoiHAS3WK3NMRcfzKJ AuyzQR1ktUMMgbWUNbzKcMfGup9WlQXzZ1Goj9RNF0ZjaBQk/2oX3PnlCSxkugUfHAq4 Vq3c49butr3WkOAH+VQrvmDpYNEV+rFG6VT1nmlLVc24LCzVid6xzIN+DbKkIv4hlFBc ovyQ== X-Gm-Message-State: AJcUukdJ4uMFHZc06ZE+uUByXlCmI/qK0H7D9GHurXx+M1wC+Z/hiCg8 kMk9JucYhFmRAvmkAX91pNHYgw== X-Received: by 2002:a7b:c2a9:: with SMTP id c9mr212197wmk.44.1548193825850; Tue, 22 Jan 2019 13:50:25 -0800 (PST) Received: from zen.linaro.local ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id f191sm10843767wmg.12.2019.01.22.13.50.18 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 22 Jan 2019 13:50:20 -0800 (PST) Received: from zen.linaroharston (localhost [127.0.0.1]) by zen.linaro.local (Postfix) with ESMTP id E466F3E0D4B; Tue, 22 Jan 2019 21:50:16 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Date: Tue, 22 Jan 2019 21:50:15 +0000 Message-Id: <20190122215016.18697-11-alex.bennee@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190122215016.18697-1-alex.bennee@linaro.org> References: <20190122215016.18697-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::333 Subject: [Qemu-devel] [PATCH v3 10/11] scripts/archive-source: include softfloat tests X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Alex_Benn=C3=A9e?= Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" We need these if we want to run unit/softfloat tests in our docker containers. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- scripts/archive-source.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.17.1 diff --git a/scripts/archive-source.sh b/scripts/archive-source.sh index 62bd22578b..6eed2a29bd 100755 --- a/scripts/archive-source.sh +++ b/scripts/archive-source.sh @@ -26,7 +26,7 @@ vroot_dir="${tar_file}.vroot" # independent of what the developer currently has initialized # in their checkout, because the build environment is completely # different to the host OS. -submodules="dtc ui/keycodemapdb" +submodules="dtc ui/keycodemapdb tests/fp/berkeley-softfloat-3 tests/fp/berkeley-testfloat-3" trap "status=$?; rm -rf \"$list_file\" \"$vroot_dir\"; exit \$status" 0 1 2 3 15 From patchwork Tue Jan 22 21:50:16 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 156334 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp3676jaa; Tue, 22 Jan 2019 14:08:41 -0800 (PST) X-Google-Smtp-Source: ALg8bN6V3Z+RHWnshIBrk7dUVaDpkicIaBJG3m3VDHiiClFr5XQAzOE7CRXTeGmDos4gtQ/gEDai X-Received: by 2002:a1c:5fd7:: with SMTP id t206mr212851wmb.145.1548194921685; Tue, 22 Jan 2019 14:08:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548194921; cv=none; d=google.com; s=arc-20160816; b=x9S9bCGba96jGiyQyRikEkTJ05ddodoSM06BOewY2Ig506hE2zcaog9eHqrGq7ae+f mMsRSy0mR7ZNhe5Gzq021nQkfJx+gyMLbyZF49Y8UEl0gFZuvULgZ4AOdSKjnfyvJkMs f8ASbll/NO5VbXmGit65q+5IBIqkvFWMr3s0fAMeMxQfwuackzeTHa/iwAdLPqKaqSNn bGPDLRGtR9QsJnFWRXZonTQJDu7/Sn+36erIMn7n1auBbCgigSGm55srjpw236kADHsO E1HiTz8NnU7n1W6hewmY7PUVX2JARcBsbzc0hN+NYH0tCysbNRAMqHmpy1OfbXQY9tRy vtdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=yttWb6PrQgq8ISO/77UEb790jQuJJJcQac8NOTluiGI=; b=kAV0wLzFSzKOB3ZeBVgkcRCiiy2zkZI9fmLgOryXEhJn3p9ln/7uNbQseYbMaDL1HM IGiPe+fkMOako+anDourePxj9EO8nwbUzm0zZRNWWlvJuaJlwkKHbhWjp/7t/fMWkHHZ sZ8t/qAFCEdcUa6sjMjqqwH0CHGIQ9JGQBQIZTOXdxofnG7/20WYp7Kev12LXRQi3ClR ZCfVqcEvSe1AULrcS12DQ5XF9KTN55g7/SqkfuD5sTA4ZZVaOZFRoXyLv3UKyzqfzc2k KZnXXoc4wk3I/f1bEiDWgiXy2D4fbp373w8Hx0YTYzNq6k0RGgLuo2vCxQMdmGiPRzCl 2U0g== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=XWN4xjzR; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id a3si34911092wmf.189.2019.01.22.14.08.41 for (version=TLS1 cipher=AES128-SHA bits=128/128); Tue, 22 Jan 2019 14:08:41 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=XWN4xjzR; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([127.0.0.1]:51096 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gm4Do-0004PC-LB for patch@linaro.org; Tue, 22 Jan 2019 17:08:40 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60991) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gm3wS-0007V1-MR for qemu-devel@nongnu.org; Tue, 22 Jan 2019 16:50:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gm3wP-0008Gb-Tg for qemu-devel@nongnu.org; Tue, 22 Jan 2019 16:50:43 -0500 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]:34735) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gm3wP-0007uk-Kv for qemu-devel@nongnu.org; Tue, 22 Jan 2019 16:50:41 -0500 Received: by mail-wm1-x342.google.com with SMTP id y185so9540708wmd.1 for ; Tue, 22 Jan 2019 13:50:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=yttWb6PrQgq8ISO/77UEb790jQuJJJcQac8NOTluiGI=; b=XWN4xjzReym44TgmGejty7JvcaGYLiaOCnu/rwV3fMotUUAPatf0wXxMwn6UYyDxMz i/4S+kyOb/NRKfpoFlPf2qt8K7CDmQph4/H3zxMh7xgkRvP7XijNfmlTHqKOEwyGyWjG NfRGkyv8x3xi6cLQ0d/r6BcGk2nlF6zmTYEGU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=yttWb6PrQgq8ISO/77UEb790jQuJJJcQac8NOTluiGI=; b=n6z0wCXTgEi106xEjYwJuOZivLWCxqOKOIYl4QPsVcRCaFoXzepzcJvV0fll7d0QMP SeNZKZ91yurw9la95D+ZIuyuG9ewWag0OXuGnzYgqKAXzTbm6a9317Ps+flulU4O9Cmg EjEVR+ugkl9B/vHrfLUmnso+WLz0VOnpDrGOHvd4e4skt/Ul2DsRN3/JCJFkAxxQa1B9 26+j72MkxaKeu3mf61uDwgriKgi807/ozSbylBTTkWv7ZQNj+IDhgYuMVLzxP8fspBrq MJCRhrvYqV+RpIhgtiL6BmTuBnR0j26ZNWFn3MISvUjD+O1o/hmb1CPFwo/JgXBRje3b ywzg== X-Gm-Message-State: AJcUukc2AQaTEnzWEpPbBcLYHTldqwry4sa/VrqHQIosDsgkwpSwsNik ebi9rMdfJprZco7of4x9u+HtUWKVqq8= X-Received: by 2002:a1c:b14:: with SMTP id 20mr175133wml.103.1548193825022; Tue, 22 Jan 2019 13:50:25 -0800 (PST) Received: from zen.linaro.local ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id k128sm72720551wmd.37.2019.01.22.13.50.19 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 22 Jan 2019 13:50:20 -0800 (PST) Received: from zen.linaroharston (localhost [127.0.0.1]) by zen.linaro.local (Postfix) with ESMTP id 020313E0DCD; Tue, 22 Jan 2019 21:50:17 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Date: Tue, 22 Jan 2019 21:50:16 +0000 Message-Id: <20190122215016.18697-12-alex.bennee@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190122215016.18697-1-alex.bennee@linaro.org> References: <20190122215016.18697-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::342 Subject: [Qemu-devel] [PATCH v3 11/11] tests/Makfile: add check-softfloat rule X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Alex_Benn=C3=A9e?= Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" This adds a rule to run all of our softfloat tests. It is included as a pre-requisite to check-tcg and check-unit as well. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- tests/Makefile.include | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) -- 2.17.1 Reviewed-by: Emilio G. Cota diff --git a/tests/Makefile.include b/tests/Makefile.include index f123616bc7..acf166e0e2 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include @@ -12,6 +12,7 @@ check-help: @echo " $(MAKE) check-qapi-schema Run QAPI schema tests" @echo " $(MAKE) check-block Run block tests" @echo " $(MAKE) check-tcg Run TCG tests" + @echo " $(MAKE) check-softfloat Run FPU emulation tests" @echo " $(MAKE) check-acceptance Run all acceptance (functional) tests" @echo @echo " $(MAKE) check-report.html Generates an HTML test report" @@ -1000,6 +1001,18 @@ SF_MATH_RULES=$(patsubst %,check-softfloat-%, $(SF_MATH_OPS)) .PHONY: check-softfloat-ops check-softfloat-ops: $(SF_MATH_RULES) +# Finally a generic rule to test all of softfoat. If TCG isnt't +# enabled we define a null operation which skips the tests. + +.PHONY: check-softfloat +ifeq ($(CONFIG_TCG),y) +check-softfloat: check-softfloat-conv check-softfloat-compare check-softfloat-ops +else +check-softfloat: + $(call quiet-command, /bin/true, "FLOAT TEST", \ + "SKIPPED for non-TCG builds") +endif + # Per guest TCG tests LINUX_USER_TARGETS=$(filter %-linux-user,$(TARGET_DIRS)) @@ -1032,7 +1045,7 @@ clean-tcg-tests-%: build-tcg: $(BUILD_TCG_TARGET_RULES) .PHONY: check-tcg -check-tcg: $(RUN_TCG_TARGET_RULES) +check-tcg: check-softfloat $(RUN_TCG_TARGET_RULES) .PHONY: clean-tcg clean-tcg: $(CLEAN_TCG_TARGET_RULES) @@ -1113,7 +1126,7 @@ check-acceptance: check-venv $(TESTS_RESULTS_DIR) check-qapi-schema: $(patsubst %,check-%, $(check-qapi-schema-y)) check-tests/qapi-schema/doc-good.texi check-qtest: $(patsubst %,check-qtest-%, $(QTEST_TARGETS)) check-block: $(patsubst %,check-%, $(check-block-y)) -check: check-qapi-schema check-unit check-qtest check-decodetree +check: check-qapi-schema check-unit check-softfloat check-qtest check-decodetree check-clean: rm -rf $(check-unit-y) tests/*.o $(QEMU_IOTESTS_HELPERS-y) rm -rf $(sort $(foreach target,$(SYSEMU_TARGET_LIST), $(check-qtest-$(target)-y)) $(check-qtest-generic-y))