From patchwork Mon Jul 11 04:28:37 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yassine Oudjana X-Patchwork-Id: 590708 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB966C43334 for ; Mon, 11 Jul 2022 04:30:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229687AbiGKEaC (ORCPT ); Mon, 11 Jul 2022 00:30:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35104 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229688AbiGKEaA (ORCPT ); Mon, 11 Jul 2022 00:30:00 -0400 Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9BA7A18E3A; Sun, 10 Jul 2022 21:29:58 -0700 (PDT) Received: by mail-ej1-x62f.google.com with SMTP id dn9so6805312ejc.7; Sun, 10 Jul 2022 21:29:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Yv9OpwL9wanJopC4m2vgg7+GMxN3Dmx4qKHjP8pLI8w=; b=GSc+/hthmv5AO96QcPzeJ5L0HfFuhhef8GwitjmYLtqK+6gUdyDwMUSLNvI8WQ3wE/ uk4FUWIbbdPvX9mHKYNCJ3qDr7GFLm9SA122abF9DY1VuOO6S+PYY4fyAlROCM1qJ9PD ghAkG3Ds1donGmWhE0KwrJpNo4XoJlV0hs7UEB3Zaorwxd40IqULWIpmiB/3yiejsXUF 575A8s/+z45xloSQbZVd0Tg5Pi/FghOrMtBM6yQH5aM8d0KCgshH1NsscCD/itN/M2fq hFXMnkUr93DPl0VANY5aPINw5Z61DwCtCum/hnOXj3UDqeZylhxTR36xzpY7izj1HksX RxVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Yv9OpwL9wanJopC4m2vgg7+GMxN3Dmx4qKHjP8pLI8w=; b=BdGiyIoqBTFTNhCquFpohVwFNHKHFaKAOAL2qBp1lyU0uecolbuxfIZxuhcpsnZPmI nK5YOWharpdgzDIOKl0EjmoBDRO+zYBT2Ln4UnH1e2pDGcYZ1AORZL4CCvU5IBl/uQmr RdgPJ7LOEtQKitYwaPN344e0ouhZEMeFQ7Pfz3/wsql8FFmCsiPGMZ9SoN5/Z2KEAyaL 2VSeJsjhS1LFTOty9z+aCq43qC7mUjZNIix3auWgUFu3vl82zFtkA/m7YRnlYvKcOEcC 3GJJ/abTckTQ9bWfSSWlShAppA4zygQ5xqLwdzcjNMyfhO2L/1EVnyuY+i2Xu9Ryzcag /VCg== X-Gm-Message-State: AJIora/EO6J5ZBfJ0pGJspUDkO32JXRnTK3T2tdGe9QXGVnU94iTSNyP nlYt6e8bEdBj1kmO1PitowU= X-Google-Smtp-Source: AGRyM1uD5satbuuh1hHHCA8GEKVcLteXvA4sAWvyM3FwCJY4LWBcHQfj9LuFHg84KkrCfUwIaQ/aqw== X-Received: by 2002:a17:907:2cf0:b0:72a:aec1:2bcb with SMTP id hz16-20020a1709072cf000b0072aaec12bcbmr16089440ejc.565.1657513797092; Sun, 10 Jul 2022 21:29:57 -0700 (PDT) Received: from localhost.localdomain (89-39-107-113.hosted-by-worldstream.net. [89.39.107.113]) by smtp.gmail.com with ESMTPSA id j17-20020a17090623f100b00726298147b1sm2203100ejg.161.2022.07.10.21.29.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 10 Jul 2022 21:29:56 -0700 (PDT) From: Yassine Oudjana X-Google-Original-From: Yassine Oudjana To: Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Tianshu Qiu , Bingbu Cao Cc: Yassine Oudjana , Yassine Oudjana , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/3] media: dt-bindings: ak7375: Convert to DT schema Date: Mon, 11 Jul 2022 08:28:37 +0400 Message-Id: <20220711042838.213351-2-y.oudjana@protonmail.com> X-Mailer: git-send-email 2.37.0 In-Reply-To: <20220711042838.213351-1-y.oudjana@protonmail.com> References: <20220711042838.213351-1-y.oudjana@protonmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org From: Yassine Oudjana Convert DT bindings document for AKM AK7375 VCM to DT schema format and add an example. Signed-off-by: Yassine Oudjana --- .../devicetree/bindings/media/i2c/ak7375.txt | 8 ---- .../devicetree/bindings/media/i2c/ak7375.yaml | 41 +++++++++++++++++++ MAINTAINERS | 2 +- 3 files changed, 42 insertions(+), 9 deletions(-) delete mode 100644 Documentation/devicetree/bindings/media/i2c/ak7375.txt create mode 100644 Documentation/devicetree/bindings/media/i2c/ak7375.yaml diff --git a/Documentation/devicetree/bindings/media/i2c/ak7375.txt b/Documentation/devicetree/bindings/media/i2c/ak7375.txt deleted file mode 100644 index aa3e24b41241..000000000000 --- a/Documentation/devicetree/bindings/media/i2c/ak7375.txt +++ /dev/null @@ -1,8 +0,0 @@ -Asahi Kasei Microdevices AK7375 voice coil lens driver - -AK7375 is a camera voice coil lens. - -Mandatory properties: - -- compatible: "asahi-kasei,ak7375" -- reg: I2C slave address diff --git a/Documentation/devicetree/bindings/media/i2c/ak7375.yaml b/Documentation/devicetree/bindings/media/i2c/ak7375.yaml new file mode 100644 index 000000000000..4fc216846ae7 --- /dev/null +++ b/Documentation/devicetree/bindings/media/i2c/ak7375.yaml @@ -0,0 +1,41 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/media/i2c/ak7375.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Asahi Kasei Microdevices AK7375 voice coil lens actuator + +maintainers: + - Tianshu Qiu + +description: + AK7375 is a voice coil motor (VCM) camera lens actuator that + is controlled over I2C. + +properties: + compatible: + const: asahi-kasei,ak7375 + + reg: + maxItems: 1 + +required: + - compatible + - reg + +additionalProperties: false + +examples: + - | + i2c { + #address-cells = <1>; + #size-cells = <0>; + + ak7375: camera-lens@c { + compatible = "asahi-kasei,ak7375"; + reg = <0x0c>; + }; + }; + +... diff --git a/MAINTAINERS b/MAINTAINERS index a97fef8c131d..19faf9ce8258 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3063,7 +3063,7 @@ M: Tianshu Qiu L: linux-media@vger.kernel.org S: Maintained T: git git://linuxtv.org/media_tree.git -F: Documentation/devicetree/bindings/media/i2c/ak7375.txt +F: Documentation/devicetree/bindings/media/i2c/ak7375.yaml F: drivers/media/i2c/ak7375.c ASAHI KASEI AK8974 DRIVER From patchwork Mon Jul 11 04:28:38 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yassine Oudjana X-Patchwork-Id: 589644 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11F70CCA481 for ; Mon, 11 Jul 2022 04:30:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229698AbiGKEaF (ORCPT ); Mon, 11 Jul 2022 00:30:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35176 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229688AbiGKEaE (ORCPT ); Mon, 11 Jul 2022 00:30:04 -0400 Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0A20418E3A; Sun, 10 Jul 2022 21:30:03 -0700 (PDT) Received: by mail-ej1-x629.google.com with SMTP id a9so6815246ejf.6; Sun, 10 Jul 2022 21:30:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=fi53u4QJgosCISnTmcyYiG9I9s/LhFX3/A6st//BwUM=; b=Hd55IR61uvW2yTondhIt00vpk9E5U8B+C/utJoAupC7aIVwBiC7pAfSfxjlP69HlVf I1BJfhC5TyMSkhHlKm843yxrBVePP/9I/yoM4WQbkxAAtduvvOBUZWbYxezVbdhBN/A5 yA4Za8Uid9NBZXuudDSvgmQgTvV0G1f0/ralZYpK3kOXdsyCnzhh+h2PSAPXj0px2b4h raz1bIHbnL89lX/3jpX96yf5esgDt+ohllt3rgvqItOpWZXOdPKnhr1GyVDCEXIXh36P Sus3XA2j1PIH/POGVvqtc6WTkynYteu1zzcA9HdtMftFgOC9MAphnEWyKN+k/ZbFAqbH bhkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=fi53u4QJgosCISnTmcyYiG9I9s/LhFX3/A6st//BwUM=; b=lzTMnzvnD234ZSdverwU4ltgdiqDyqkWniTF1oZBqgD5bMHLsc7CfFVcKJ8NIYKscT YwLCr+QgbL+JExLIFpumuA2mzzw8uSv55qEvSJoNUOTvJKUGtD8rRc/6a/UrqZfjbfWJ K02lofA2uUU4s4bTeRcFVCVKhSeKMJ6ON2lAzdq0Q640fK2hQmz9UIGcctkNlG6NIsRG O/BH50k0/SQLBZL2j0Q14fqk6eSjg/4hOu9H6dePYfho7TKfFrSw5SL19C6q4K6MrWIZ RufyOKT92ZFf70BX+I4VgSpHpLaOyYRpJGFcemspNN4z30xElipSw0x3tMo+7iyKJiC7 U8zA== X-Gm-Message-State: AJIora/R0kq6bYmSwaUNf1tONomxuxxsxVb8sD4XUzTwNnNJQ43zRIQh vXY9lAJ1AIXV5Bm43oVI2Uk= X-Google-Smtp-Source: AGRyM1u5ok/VBonTP+OnfW26t7V5NT0deUGsauIvg2tLk5Lm3cqcvEcU3/9UoIiQdJ31AK80gQo3Bg== X-Received: by 2002:a17:907:75c6:b0:72b:496c:77c7 with SMTP id jl6-20020a17090775c600b0072b496c77c7mr6465141ejc.47.1657513801672; Sun, 10 Jul 2022 21:30:01 -0700 (PDT) Received: from localhost.localdomain (89-39-107-113.hosted-by-worldstream.net. [89.39.107.113]) by smtp.gmail.com with ESMTPSA id j17-20020a17090623f100b00726298147b1sm2203100ejg.161.2022.07.10.21.29.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 10 Jul 2022 21:30:01 -0700 (PDT) From: Yassine Oudjana X-Google-Original-From: Yassine Oudjana To: Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Tianshu Qiu , Bingbu Cao Cc: Yassine Oudjana , Yassine Oudjana , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/3] media: dt-bindings: ak7375: Add supplies Date: Mon, 11 Jul 2022 08:28:38 +0400 Message-Id: <20220711042838.213351-3-y.oudjana@protonmail.com> X-Mailer: git-send-email 2.37.0 In-Reply-To: <20220711042838.213351-1-y.oudjana@protonmail.com> References: <20220711042838.213351-1-y.oudjana@protonmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org From: Yassine Oudjana Add supply properties to describe regulators needed to power the AK7375 VCM. Signed-off-by: Yassine Oudjana --- .../devicetree/bindings/media/i2c/ak7375.yaml | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/Documentation/devicetree/bindings/media/i2c/ak7375.yaml b/Documentation/devicetree/bindings/media/i2c/ak7375.yaml index 4fc216846ae7..baa91de55927 100644 --- a/Documentation/devicetree/bindings/media/i2c/ak7375.yaml +++ b/Documentation/devicetree/bindings/media/i2c/ak7375.yaml @@ -20,9 +20,17 @@ properties: reg: maxItems: 1 + vdd-supply: + description: VDD supply + + vio-supply: + description: I/O pull-up supply + required: - compatible - reg + - vdd-supply + - vio-supply additionalProperties: false @@ -35,6 +43,9 @@ examples: ak7375: camera-lens@c { compatible = "asahi-kasei,ak7375"; reg = <0x0c>; + + vdd-supply = <&vreg_l23a_2p8>; + vio-supply = <&vreg_lvs1a_1p8>; }; }; From patchwork Mon Jul 11 04:28:39 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yassine Oudjana X-Patchwork-Id: 590707 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B996ECCA47B for ; Mon, 11 Jul 2022 04:30:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229722AbiGKEaQ (ORCPT ); Mon, 11 Jul 2022 00:30:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35316 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229708AbiGKEaO (ORCPT ); Mon, 11 Jul 2022 00:30:14 -0400 Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [IPv6:2a00:1450:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7D6311901C; Sun, 10 Jul 2022 21:30:07 -0700 (PDT) Received: by mail-ej1-x635.google.com with SMTP id h23so6780463ejj.12; Sun, 10 Jul 2022 21:30:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=oYyjBapI7Ol5ghwqsEsi6GKvHQk9dNKwshNrm1MBekA=; b=RIJjqGzCfNlhD/70v6LwMYa0s/R2xFo5RVDVOx6F1CGLarPal0lwxbPMR9I7PJl6xz 5TB2wRFgDihYRAH+UAnw3r1i3D3NPgwxRHjA82+3oUGxJSeuO4A+MOl+WY3fWjQNrec0 wbh8OQsHX3+i9bhcnZmV6aHyjRr2AK7METCWENv71z4a/7VknZibizx3H/VpyacyFNfY n5N+VUc/5EirLbiA1Vux++K6ZIdcPhE8myBvnj4BhZPp7c7ubAiErPASUnzKx734rjrO IfLpgPXgh32FjWnZ1ZXhhvt9jyxhKU/4NPoc4sJZc+atCbuDKxc2jee7sgo8t4mOosPJ FBVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=oYyjBapI7Ol5ghwqsEsi6GKvHQk9dNKwshNrm1MBekA=; b=ptKVPN7VynepkZUTZNWwcejnGyu5sLe51uGAi/sz7Dfps4zDrt0HyWKa2xAYn7ZLuj Lfwkw8sbMnZPbZAjvr0HGzTLbdJznX4uFAl4Lh/NVznZ5Di02TbTBOWKu+F0KENAzEUo A4yjDMWRFokFUZDfxHQj7/ptFLlLZ3U1qIRK9v89nUEiBd6SgZh08hN0muCMlx1DZySq 9wf/WQDT8RtpsaZSlFqHUUjaFnT50KXIceTkZhHp5+lcuYK+zwq+PmKLi03FAzHDVFgu 0KH58Ruw/GPGmeh2q860LpR9f+bcUyvey+RuWFof7X79rinFyr/E3nZYL5Um8ZQsrG6f JhGg== X-Gm-Message-State: AJIora+VTuivWDZig/8grZrsQJCdMQzrX945NMksV45S0OuPy3SGPQa4 gB5XxxWO9tUir0KBD8VHPA8= X-Google-Smtp-Source: AGRyM1tBsjHVOKf2envHi/oecZSomJvRCwVJM9BRJfdwLv3Yi8sUtsE3UkUVCACw5K7DDFClUw/q4Q== X-Received: by 2002:a17:907:16a2:b0:726:abbc:69bf with SMTP id hc34-20020a17090716a200b00726abbc69bfmr16517666ejc.363.1657513805976; Sun, 10 Jul 2022 21:30:05 -0700 (PDT) Received: from localhost.localdomain (89-39-107-113.hosted-by-worldstream.net. [89.39.107.113]) by smtp.gmail.com with ESMTPSA id j17-20020a17090623f100b00726298147b1sm2203100ejg.161.2022.07.10.21.30.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 10 Jul 2022 21:30:05 -0700 (PDT) From: Yassine Oudjana X-Google-Original-From: Yassine Oudjana To: Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Tianshu Qiu , Bingbu Cao Cc: Yassine Oudjana , Yassine Oudjana , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/3] media: i2c: ak7375: Add regulator management Date: Mon, 11 Jul 2022 08:28:39 +0400 Message-Id: <20220711042838.213351-4-y.oudjana@protonmail.com> X-Mailer: git-send-email 2.37.0 In-Reply-To: <20220711042838.213351-1-y.oudjana@protonmail.com> References: <20220711042838.213351-1-y.oudjana@protonmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org From: Yassine Oudjana Make the driver get needed regulators on probe and enable/disable them on runtime PM callbacks. Signed-off-by: Yassine Oudjana --- drivers/media/i2c/ak7375.c | 39 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 39 insertions(+) diff --git a/drivers/media/i2c/ak7375.c b/drivers/media/i2c/ak7375.c index 40b1a4aa846c..59d5cb00e3ba 100644 --- a/drivers/media/i2c/ak7375.c +++ b/drivers/media/i2c/ak7375.c @@ -6,6 +6,7 @@ #include #include #include +#include #include #include @@ -23,17 +24,32 @@ */ #define AK7375_CTRL_STEPS 64 #define AK7375_CTRL_DELAY_US 1000 +/* + * The vcm takes around 3 ms to power on and start taking + * I2C messages. This value was found experimentally due to + * lack of documentation. 2 ms is added as a safety margin. + */ +#define AK7375_POWER_DELAY_US 5000 #define AK7375_REG_POSITION 0x0 #define AK7375_REG_CONT 0x2 #define AK7375_MODE_ACTIVE 0x0 #define AK7375_MODE_STANDBY 0x40 +static const char * const ak7375_supply_names[] = { + "vdd", + "vio", +}; + +#define AK7375_NUM_SUPPLIES ARRAY_SIZE(ak7375_supply_names) + /* ak7375 device structure */ struct ak7375_device { struct v4l2_ctrl_handler ctrls_vcm; struct v4l2_subdev sd; struct v4l2_ctrl *focus; + struct regulator_bulk_data supplies[AK7375_NUM_SUPPLIES]; + /* active or standby mode */ bool active; }; @@ -132,6 +148,7 @@ static int ak7375_init_controls(struct ak7375_device *dev_vcm) static int ak7375_probe(struct i2c_client *client) { struct ak7375_device *ak7375_dev; + int i; int ret; ak7375_dev = devm_kzalloc(&client->dev, sizeof(*ak7375_dev), @@ -139,6 +156,17 @@ static int ak7375_probe(struct i2c_client *client) if (!ak7375_dev) return -ENOMEM; + for (i = 0; i < AK7375_NUM_SUPPLIES; i++) + ak7375_dev->supplies[i].supply = ak7375_supply_names[i]; + + ret = devm_regulator_bulk_get(&client->dev, AK7375_NUM_SUPPLIES, + ak7375_dev->supplies); + if (ret) { + dev_err(&client->dev, "Failed to get regulators: %pe", + ERR_PTR(ret)); + return ret; + } + v4l2_i2c_subdev_init(&ak7375_dev->sd, client, &ak7375_ops); ak7375_dev->sd.flags |= V4L2_SUBDEV_FL_HAS_DEVNODE; ak7375_dev->sd.internal_ops = &ak7375_int_ops; @@ -210,6 +238,10 @@ static int __maybe_unused ak7375_vcm_suspend(struct device *dev) if (ret) dev_err(dev, "%s I2C failure: %d\n", __func__, ret); + ret = regulator_bulk_disable(AK7375_NUM_SUPPLIES, ak7375_dev->supplies); + if (ret) + return ret; + ak7375_dev->active = false; return 0; @@ -230,6 +262,13 @@ static int __maybe_unused ak7375_vcm_resume(struct device *dev) if (ak7375_dev->active) return 0; + ret = regulator_bulk_enable(AK7375_NUM_SUPPLIES, ak7375_dev->supplies); + if (ret) + return ret; + + /* Wait for vcm to become ready */ + usleep_range(AK7375_POWER_DELAY_US, AK7375_POWER_DELAY_US + 10); + ret = ak7375_i2c_write(ak7375_dev, AK7375_REG_CONT, AK7375_MODE_ACTIVE, 1); if (ret) {