From patchwork Fri Feb 8 22:35:43 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Mathieu Poirier X-Patchwork-Id: 157890 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp19311jaa; Fri, 8 Feb 2019 14:35:48 -0800 (PST) X-Google-Smtp-Source: AHgI3IarVnxut4BU+Vewjfa4veMoU8M2UWUzpdfRwxS3y8tU5FzzXHiXxC0Fg0jCxpyMwH89sNen X-Received: by 2002:a62:a9b:: with SMTP id 27mr6883977pfk.223.1549665348553; Fri, 08 Feb 2019 14:35:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549665348; cv=none; d=google.com; s=arc-20160816; b=m62/3Eqeyqk/Wq9hDWFEX2J6qDfqUIODaOd1HpQOur4rq5BMYni6geyTBcrMQZgSbo syDKXMiFCi+GwTQf8AyIgjn6yQTdRQRcGlb7Lg1Dp0SpCFOnctNgQsLO2Xxte0EBk7pg HBeco1a5L5ZGJ9e9jyopok3S9JXiTtK6/+JESHv6OaE75HLtuA9AIwfrKfIS5BWcicG9 +EYfHLhTPpLnVxY9NdNK3XolUQnBr0wI1ln4IPCsxP3nCHqXxnpMFAiVx6jve91MngGc xZjjt49TFgaviJwac4voO+PJBesPWJqQoZlN2CfbLQP0lMYNALn2T4ljhz6mEV4d+Zey PT8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=i6GftFjwiUCvtcxvEAR034ySjK3PZ5xc2bnvkHKBDpk=; b=cQIIxDBI1fIgBi03cluttjAmDYG9WJyjNd7pcWRaU5LemHm4B/5DYyYtFh68brM5er w7sJzkte2dRyQ4ywjtegGd9YpzmSddhU0K1LXRde4WFOxBmDy9cOdtIJgLuLc7aacZtw 9N3pn2mFpT0iyFZ9xy1S6pHGk0ZfPa46AFNHqcSEBZRgW2+6xcks3MPqpZS87p/5BI6v 8ETqbpZWA9Jcld3E8gRf1IUN3qYSoMKGJRQMjQOWnGjY2sftWCnnPAbxiBCah2nCICeh 3TXUzpa6f2B+0yfMz5P4bZn90OjrwpRsdbHow/BZjGo241fBZcmZzGlTvh0x2Ji8UZsw s/UA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=bun0wgKe; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x23si3494157pln.100.2019.02.08.14.35.47; Fri, 08 Feb 2019 14:35:48 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=bun0wgKe; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727191AbfBHWfq (ORCPT + 31 others); Fri, 8 Feb 2019 17:35:46 -0500 Received: from mail-pl1-f193.google.com ([209.85.214.193]:45277 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726985AbfBHWfq (ORCPT ); Fri, 8 Feb 2019 17:35:46 -0500 Received: by mail-pl1-f193.google.com with SMTP id a14so2335103plm.12 for ; Fri, 08 Feb 2019 14:35:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=i6GftFjwiUCvtcxvEAR034ySjK3PZ5xc2bnvkHKBDpk=; b=bun0wgKexaPR9h1OnV4KNy3aKndX2kD6XNTFbuR6SjmfPYmiiApvRoy+EDadujf8lr L6DiA66LmluEXijU+iVgYFs9wY+QXXCf81bQHP4QfS00zuGXMK2AsEKfclZoAWEp1jpO CVMMYWzNdbm+jPau6bNJ0StEAHUAKJ1B/FrDj/YovDMrGLhqW5250mMpiRSzKEvOWRCR BYl/fT7VKrpROvNNb7xSRMTNljt2JIv0jL0jYXgp6g3psaivxqLrTv26pUpuyqCOMoMW tdGzEva6qK6vbQVPGeafzaWet2C85C/8cZX22Xasad3TIgHCdQso7fuwSsiJ6oapASho +FKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=i6GftFjwiUCvtcxvEAR034ySjK3PZ5xc2bnvkHKBDpk=; b=V6/dMh49IFSksUbU+4iohpfWAVyCVFLmamXZmUqnEomMC6MfHhYjgUHXXxLJufNCaT E12hAmgDn6+W9vI2TU7s3FNfs9g6rxtMRIC+lQqC1fAhHNtUZkpnUd9vzelOmdOcL1Jj eD8+FVCfPMQnUiHJKcE3M3N5u4naVYqxEmWgjyQowhzhVOyutAMaRhGsNgN72lPMRuwI 36llv0RssWpWV/1URHnOmpZf3wPulXXUxPEld/re64jMTsM27YDqAaYzAaC46HcGrdpj Q3jfiUZhQpvro1OCiM0J3t6IvPi1W5fU5lbzMdb8Ohd3CJeX+OHrM46vMMJOhhfCZ+XK HNrg== X-Gm-Message-State: AHQUAuYMM+IJW4twpAQhZHiFrNnTTET02eJQ59YbuEWW3GH5jgks1Edy CsbyUs5FyEc20/vDwIxQM9cb5A== X-Received: by 2002:a17:902:1008:: with SMTP id b8mr24548278pla.252.1549665345364; Fri, 08 Feb 2019 14:35:45 -0800 (PST) Received: from xps15.cg.shawcable.net (S0106002369de4dac.cg.shawcable.net. [68.147.8.254]) by smtp.gmail.com with ESMTPSA id h8sm3610634pgv.27.2019.02.08.14.35.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 08 Feb 2019 14:35:44 -0800 (PST) From: Mathieu Poirier To: acme@kernel.org Cc: suzuki.poulose@arm.com, peterz@infradead.org, mingo@redhat.com, jolsa@redhat.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] perf tools: Add proper header file for symbols Date: Fri, 8 Feb 2019 15:35:43 -0700 Message-Id: <20190208223543.31836-1-mathieu.poirier@linaro.org> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org After 'commit e22c1c751140 ("perf thread: Don't include symbol.h, symbol_conf.h is enough")' Compilation of the perf tools is broken when using the functionality provided by the openCSD library: [...] ... timerfd: [ on ] ... sched_getcpu: [ on ] ... sdt: [ OFF ] ... setns: [ on ] ... libopencsd: [ on ] [...] CC util/arm-spe.o CC util/arm-spe-pkt-decoder.o CC util/s390-cpumsf.o CC util/cs-etm.o CC util/parse-branch-options.o util/cs-etm.c: In function ‘cs_etm__mem_access’: util/cs-etm.c:297:24: error: storage size of ‘al’ isn’t known struct addr_location al; And rightly so since file cs-etm.c doesn't include symbol.h, something that is rectified in this patch. Signed-off-by: Mathieu Poirier --- tools/perf/util/cs-etm.c | 1 + 1 file changed, 1 insertion(+) -- 2.17.1 diff --git a/tools/perf/util/cs-etm.c b/tools/perf/util/cs-etm.c index 8b3f882d6e2f..0b11d653cfbe 100644 --- a/tools/perf/util/cs-etm.c +++ b/tools/perf/util/cs-etm.c @@ -25,6 +25,7 @@ #include "machine.h" #include "map.h" #include "perf.h" +#include "symbol.h" #include "thread.h" #include "thread_map.h" #include "thread-stack.h"