From patchwork Tue Sep 6 12:47:43 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "B. Niedermayr" X-Patchwork-Id: 604126 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D959C6FA83 for ; Tue, 6 Sep 2022 12:48:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240076AbiIFMsG (ORCPT ); Tue, 6 Sep 2022 08:48:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34962 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240089AbiIFMsF (ORCPT ); Tue, 6 Sep 2022 08:48:05 -0400 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2048.outbound.protection.outlook.com [40.107.22.48]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E379257568; Tue, 6 Sep 2022 05:48:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WJqvUtdXcmcQQhHKB8oTLT7RzQ5N4SgTcQp/+QczTQtTzdh6296EKY4+vta1VUrkFlewZfDNgWwVV7xSzX7p78DpVlOVktxdHn7OjWvYcrPTSIb+vb5Yic83cJpsSt1ZquNJF0k0Wj/FtKJosvF7RcVj6V1ws5aI8OBxpKwZ1DyVIx9MOdmSDcs+XcqS90fnsxQJA/MDck6oXdE217usSOAPmyo9V6bBqvSdQSaJpg66npda/ZkAYaxogxxxZ1hW6W+S8YfkdQ6fahszJR2QSpQrCCC1Qea/8G3oJJSlrMCkxJWyqATMyq6D5q11xVugQACy6MWDNBm+E5X2Ul/Hhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DjlwsobtRk47B7QvgYdE49/bly2RFxQWNgiRflamabk=; b=Ezx9InJ9U0kxu2y/9L3Z5m3FtlrLEw1sec6spt/Al2LBe80cDa8aLZMCuJ/0wWizNkajOQpomXB4WLhJr7iNwcU40gIvTRNL1PDdOrbNwQKjGJvz8hOMlckAf+rUN8gHf3oyQ7Rz/PnEDLMll/1NnvXQ15L+nYKB0oqnMXm/wCmXyO/mxKkVfs6Dqu6AG87MiLnBG8/YYCs6msdsLq+KwGEOp1HUFYu7SBfY8CoDm5i7nKpls3OS0TzjWqZpaKJEXAba578z5RfR4qlmYMvgT6v2YLv3O5R2fQUl4U9VOeDb1tXOTo/YYDYmzzvr5fS11Vp2t+V5mYMQrKkDB0r2rg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 194.138.21.75) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=siemens.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=siemens.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DjlwsobtRk47B7QvgYdE49/bly2RFxQWNgiRflamabk=; b=ELrF0NvIwoJS07H63U5a1vRWdS9MwC8LLclgBO5uLR/tAUOZu2cDlCkNCkSijarmEBFZ23dx3/0QobUySgXqTVhJsAh5uNX9XTOEsh857zqJrex/PK8GLCKzjQzZDKxP9/O8hTX4W7utPPiKjWl14m7s9zNMhtmH+S3Tt7OotEn59IJLOvboc0DPSOSZnysx0Ep4tD9XCchlcrtsK0NZw7zLSWWqHBxd9+mxYErHIWcD/Fawvj7OQlynTN0LPnuqGsUTAdKnR/mXb4p9ZEpviCx2bnvaHHvoseoJxwBAFPv3HnXgMbZPyfcF7NOyIQbE8WjvOF5UeWWFRSKSAh6JPg== Received: from OS6P279CA0120.NORP279.PROD.OUTLOOK.COM (2603:10a6:e10:3c::19) by VE1PR10MB3887.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:800:161::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.11; Tue, 6 Sep 2022 12:48:01 +0000 Received: from HE1EUR01FT037.eop-EUR01.prod.protection.outlook.com (2603:10a6:e10:3c:cafe::72) by OS6P279CA0120.outlook.office365.com (2603:10a6:e10:3c::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.11 via Frontend Transport; Tue, 6 Sep 2022 12:47:58 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 194.138.21.75) smtp.mailfrom=siemens.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=siemens.com; Received-SPF: Pass (protection.outlook.com: domain of siemens.com designates 194.138.21.75 as permitted sender) receiver=protection.outlook.com; client-ip=194.138.21.75; helo=hybrid.siemens.com; pr=C Received: from hybrid.siemens.com (194.138.21.75) by HE1EUR01FT037.mail.protection.outlook.com (10.152.1.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Tue, 6 Sep 2022 12:47:57 +0000 Received: from DEMCHDC8A0A.ad011.siemens.net (139.25.226.106) by DEMCHDC8VRA.ad011.siemens.net (194.138.21.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.12; Tue, 6 Sep 2022 14:47:57 +0200 Received: from bennie-lenovo.fritz.box (139.23.126.196) by DEMCHDC8A0A.ad011.siemens.net (139.25.226.106) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.12; Tue, 6 Sep 2022 14:47:56 +0200 From: "B. Niedermayr" To: , CC: , , , Subject: [PATCH v3 1/3] memory: omap-gpmc: allow shared wait pins Date: Tue, 6 Sep 2022 14:47:43 +0200 Message-ID: <20220906124747.1767318-2-benedikt.niedermayr@siemens.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220906124747.1767318-1-benedikt.niedermayr@siemens.com> References: <20220906124747.1767318-1-benedikt.niedermayr@siemens.com> MIME-Version: 1.0 X-Originating-IP: [139.23.126.196] X-ClientProxiedBy: DEMCHDC89XA.ad011.siemens.net (139.25.226.103) To DEMCHDC8A0A.ad011.siemens.net (139.25.226.106) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e806a05b-949c-4f45-abdb-08da90060677 X-MS-TrafficTypeDiagnostic: VE1PR10MB3887:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: OVt2ILiyMiZYzJxUdWfKWTCE2MI9DdA8UC+YvMFX0SeV5aunsBiPZn2izS5Ube1MHa/gVKBqx2s+f64quFXI0nS0coUTS/XxdKkNioaMdBF4DNCG1dQmY0wJK8N1l0DaG/Nr68qG/ZjZziQVFpM2D+54fbPWXQBJuwIhhK/+Z5+Ik4l3FuDL52DZ23bOzw3+I1LaihuJ7Irl6LHBIc6fDpdGaRV6KPWVKj/TD3VkVYweCq8R7nuIFN4xBclXoK/QdokHgFQZI0SwyGnZbQ77e6LONQPn/VJitKKIn0BaBsl6tdTxjnI1Z/O4KA80lAHYn5+GGAka/AGedaq3weX/j/us9HCi/mJLT6asLbe6/NhlLZon5Pp3taSzFMochGsLHxD1/WMR6L/8Xz/gY7HeJW+YkSynv5Bhh/gSj2P1daEIaBYHYQFqgw/9XuDM7o2/qlS+yrIB2Y2t8W+DTDpXvvdftYSzBNa0l+U1OK5ZwzehV49QG8b2DdUbzY1LRGmLNwCz7IoDo92riV1dC7azZxEsPvCYTiY89iRFgjMECIyYhHG+ZT1USc0diOq3OdC+YuCb0ycePKqiwV7QIL5s8r9qugSSupTuGed45ArCaP51kHeCLrjIsKtCWgZqq+FbB0nFI4shUVrBsf1ltvDvafrq5y+Jdg7+xOvfHP2uxYX/fXyvO89oQ5MtRfvGTkOtxZH3X+VSqICM/sdfulYtLYExTh95VQLdarXm12pttZ9aUHYv/87dTQ0tbuUA2ExHvnj/bf1/DejZHRHcmDKGLhxOsNBKADinVInTHVtq27yT3fC7UtjozWQ24iA0SWZV X-Forefront-Antispam-Report: CIP:194.138.21.75; CTRY:DE; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:hybrid.siemens.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230016)(4636009)(39860400002)(136003)(396003)(346002)(376002)(40470700004)(46966006)(36840700001)(40480700001)(26005)(86362001)(82310400005)(41300700001)(478600001)(82960400001)(6666004)(356005)(2616005)(40460700003)(81166007)(83380400001)(82740400003)(336012)(47076005)(186003)(956004)(16526019)(36860700001)(2906002)(316002)(110136005)(4326008)(8676002)(70206006)(70586007)(54906003)(36756003)(1076003)(5660300002)(8936002)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2022 12:47:57.7962 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e806a05b-949c-4f45-abdb-08da90060677 X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=38ae3bcd-9579-4fd4-adda-b42e1495d55a; Ip=[194.138.21.75]; Helo=[hybrid.siemens.com] X-MS-Exchange-CrossTenant-AuthSource: HE1EUR01FT037.eop-EUR01.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR10MB3887 Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org From: Benedikt Niedermayr Newer kernels refuse to probe when using the same wait pin for different chipselect regions. But this may be a usecase when connecting for example FPGA or ASIC modules to the gpmc, which only got one wait pin installed. Signed-off-by: Benedikt Niedermayr --- drivers/memory/omap-gpmc.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/memory/omap-gpmc.c b/drivers/memory/omap-gpmc.c index d9bf1c2ac319..e3674a15b934 100644 --- a/drivers/memory/omap-gpmc.c +++ b/drivers/memory/omap-gpmc.c @@ -2221,9 +2221,13 @@ static int gpmc_probe_generic_child(struct platform_device *pdev, GPIO_ACTIVE_HIGH, GPIOD_IN); if (IS_ERR(waitpin_desc)) { - dev_err(&pdev->dev, "invalid wait-pin: %d\n", wait_pin); ret = PTR_ERR(waitpin_desc); - goto err; + if (ret == -EBUSY) { + dev_info(&pdev->dev, "shared wait-pin: %d\n", wait_pin); + } else { + dev_err(&pdev->dev, "invalid wait-pin: %d\n", wait_pin); + goto err; + } } } From patchwork Tue Sep 6 12:47:44 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "B. Niedermayr" X-Patchwork-Id: 604127 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC96DECAAD5 for ; Tue, 6 Sep 2022 12:48:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240071AbiIFMsD (ORCPT ); Tue, 6 Sep 2022 08:48:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34944 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240069AbiIFMsC (ORCPT ); Tue, 6 Sep 2022 08:48:02 -0400 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2074.outbound.protection.outlook.com [40.107.22.74]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 69F9357250; Tue, 6 Sep 2022 05:48:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aG/mUTcEbMSECEFpF29NTHS7S2gg7dyDHxyaOAhR+u/y+CPcYwzrtHSZXzOKwQilVeDlIEp2Gj4QmpkcWh0pe8LYtNPJnfzDV4ed1dENavzTSP5ACAPIDnCwd2PkDruzDjVeaETCatonive1YWohbW0MGetTTlOGEbN9QsFI1T7w61cnhcamzMdbxmCbqQy9He3dLISwQF0JNCuD61jS93ZSl93lSc091sYuHw83R6tDGgTe/toqHIWib1aj0eDGueajoiuZaOWkUKPYAuGRgcYY4U9rxMr2R6bGuIhiUGMT/Rd7el9vJI14pf8eEbtLopc8cSF0dcVwjZkA/q0qhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=h7DoNJSB9r96Z1JilOK6nRjnPrk8RCLdULZ/0nq+lO0=; b=Q7KOrbINP4fdiJ7Jgsj2T/mA5shjzctyOK7kG2ODgshF6f5ddL3mswnukYSAYpz+U6qXZz0u6kV1suYoZyQKEr8SZShag1DyEgh4enTYwjjF3QfpMC4vVhiOXosjlwZjxJBi45NPrMXWH1oIDo6lqWosK/J9NcxuGXj82xuGUAvtxhWcISymlIcrDuzo/VIxTJlw5z2hWibADaa7AwbAa99Iqu0ONWfa1dWJUNyAPHXWWWGYLU2DZ8sO6X5uJ1ChFtS3ZHeq4v2ROY/0LlLwyZLF6kWzQwj2mcue6Br7xOs1wOFSIim2guooDC0s4GCEc3TfQxmuPpzA6SiTRcM2VQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 194.138.21.74) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=siemens.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=siemens.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=h7DoNJSB9r96Z1JilOK6nRjnPrk8RCLdULZ/0nq+lO0=; b=QJTkXhMpHrrgfI3VXhfqUeT0A9lUZegGjSZbKjNu/eG4DVBUXjVfHH4H8s04cahBXo0wsOyBE1pfPwe8KtTwFhro4KsWBE25D7Ynnz3uKJtN1CmzK8LhrGv4N5WbTIa1bXq8ukskwYp4cL5VioVvCX0S22Vx+9oPdGUFH6haz1zHDyQwE01L0ZFJmFvf+c08WiT7b/XoOK/V7fUQEvFfb5AXwTnGRu9guZD8hg+zW+NbQItvMhvJ0hEXI145muteJJcIpwOpKcPUZtsceAuyF7sRFzPLWZsyZlKVMS3sJMoOLMc8QEm7m2fwkk5derDQ8VQ9Bfn9TG8yP/QRQgpxuQ== Received: from FR0P281CA0081.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::7) by AS8PR10MB6248.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:561::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.18; Tue, 6 Sep 2022 12:47:58 +0000 Received: from VE1EUR01FT099.eop-EUR01.prod.protection.outlook.com (2603:10a6:d10:1e:cafe::fa) by FR0P281CA0081.outlook.office365.com (2603:10a6:d10:1e::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.12 via Frontend Transport; Tue, 6 Sep 2022 12:47:58 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 194.138.21.74) smtp.mailfrom=siemens.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=siemens.com; Received-SPF: Pass (protection.outlook.com: domain of siemens.com designates 194.138.21.74 as permitted sender) receiver=protection.outlook.com; client-ip=194.138.21.74; helo=hybrid.siemens.com; pr=C Received: from hybrid.siemens.com (194.138.21.74) by VE1EUR01FT099.mail.protection.outlook.com (10.152.3.11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Tue, 6 Sep 2022 12:47:57 +0000 Received: from DEMCHDC8A0A.ad011.siemens.net (139.25.226.106) by DEMCHDC8VQA.ad011.siemens.net (194.138.21.74) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.12; Tue, 6 Sep 2022 14:47:57 +0200 Received: from bennie-lenovo.fritz.box (139.23.126.196) by DEMCHDC8A0A.ad011.siemens.net (139.25.226.106) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.12; Tue, 6 Sep 2022 14:47:57 +0200 From: "B. Niedermayr" To: , CC: , , , Subject: [PATCH v3 2/3] memory: omap-gpmc: add support for wait pin polarity Date: Tue, 6 Sep 2022 14:47:44 +0200 Message-ID: <20220906124747.1767318-3-benedikt.niedermayr@siemens.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220906124747.1767318-1-benedikt.niedermayr@siemens.com> References: <20220906124747.1767318-1-benedikt.niedermayr@siemens.com> MIME-Version: 1.0 X-Originating-IP: [139.23.126.196] X-ClientProxiedBy: DEMCHDC89XA.ad011.siemens.net (139.25.226.103) To DEMCHDC8A0A.ad011.siemens.net (139.25.226.106) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7a8b7393-c3d6-471c-3646-08da90060661 X-MS-TrafficTypeDiagnostic: AS8PR10MB6248:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3q0jYayDT9zvrh4gupkM7ssMIjGIbQRbcvi4DmW0vHMl1dnOooxr/PBn6w7eWBaFb77SxYIv3Ae4yHuDWmdyRZqsNsbOqEVfRxyHhh/4b7vSdXOa3YYGkb+6diup6ny/CdNEsMF+KcWdyfN2vF8/PELj2xa6nbI1N9eu28/Yd4nCb/na1G0/c3kq7fj156/j4KTqluStr1OdlNHtxPOX8mRT6YDCHBBTM1ohTIXvsfcoVW201+WZazk/h1o7G6lNfWm+LFyp+X//yF/X6393wPFe9jt9xzum/erZeai5K/LtjgqTXdhs6kNsfEnfj5bz2a7gUc0T5/sl8Os51hY8x9NjPzk2WZfLXgGtuQU5k81RePk47Kbu4xlmZGpQpsvSw+/ogft2MNxDZ9yfusW5VmZ+O2ryW6gXwDKTwfJpfGGU+WtFZiKmGW58qYNha7Hp6KXCIR/6pOfc5o5nneDZTHRbkAvXgt4RrAg/fuVnFZh6GLBPLI7Oilw+XuYfUmeK6dBeA5LmMjawHvEyKfJuIogKomNhBzWNAcgthsFLyAMlZA7Xjeu5pDmzJIcM2TW765tdXlHE33tKaZxrG2encQR3yaIW/3lHifZChMUjhQpsoGimBWo9c7GgOkzdgtQB0bZaBD3fkVnG3PXFqCx1aPMwoFO7LzAZ9luz8gPI94e5oYAvqT7t/bS3tlfVwx52vMpNK35XXucsbILGgB4lYgCApljmT5N8RS4co2zROaSsUbLuKl8A36dg5JCsP00cnLCBviaI0gVyZP2mIjpzWw== X-Forefront-Antispam-Report: CIP:194.138.21.74; CTRY:DE; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:hybrid.siemens.com; PTR:hybrid.siemens.com; CAT:NONE; SFS:(13230016)(4636009)(346002)(376002)(396003)(136003)(39860400002)(40470700004)(36840700001)(46966006)(7636003)(36860700001)(8676002)(356005)(7596003)(4326008)(82960400001)(70206006)(70586007)(82740400003)(2616005)(1076003)(186003)(47076005)(41300700001)(16526019)(336012)(956004)(40460700003)(110136005)(6666004)(54906003)(316002)(26005)(8936002)(86362001)(478600001)(5660300002)(2906002)(40480700001)(82310400005)(36756003); DIR:OUT; SFP:1101; X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2022 12:47:57.7050 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7a8b7393-c3d6-471c-3646-08da90060661 X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=38ae3bcd-9579-4fd4-adda-b42e1495d55a; Ip=[194.138.21.74]; Helo=[hybrid.siemens.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR01FT099.eop-EUR01.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR10MB6248 Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org From: Benedikt Niedermayr The waitpin polarity can be configured via the WAITPINPOLARITY bits in the GPMC_CONFIG register. This is currently not supported by the driver. This patch adds support for setting the required register bits with the "gpmc,wait-pin-active-low" device tree property. Signed-off-by: Benedikt Niedermayr --- drivers/memory/omap-gpmc.c | 15 +++++++++++++++ include/linux/platform_data/gpmc-omap.h | 1 + 2 files changed, 16 insertions(+) diff --git a/drivers/memory/omap-gpmc.c b/drivers/memory/omap-gpmc.c index e3674a15b934..609df21e0ce6 100644 --- a/drivers/memory/omap-gpmc.c +++ b/drivers/memory/omap-gpmc.c @@ -132,6 +132,7 @@ #define GPMC_CONFIG_DEV_SIZE 0x00000002 #define GPMC_CONFIG_DEV_TYPE 0x00000003 +#define GPMC_CONFIG_WAITPINPOLARITY(pin) (BIT(pin) << 8) #define GPMC_CONFIG1_WRAPBURST_SUPP (1 << 31) #define GPMC_CONFIG1_READMULTIPLE_SUPP (1 << 30) #define GPMC_CONFIG1_READTYPE_ASYNC (0 << 29) @@ -1881,6 +1882,18 @@ int gpmc_cs_program_settings(int cs, struct gpmc_settings *p) gpmc_cs_write_reg(cs, GPMC_CS_CONFIG1, config1); + if (p->wait_on_read || p->wait_on_write) { + config1 = gpmc_read_reg(GPMC_CONFIG); + + if (p->wait_pin_active_low) + config1 &= ~GPMC_CONFIG_WAITPINPOLARITY(p->wait_pin); + else + config1 |= GPMC_CONFIG_WAITPINPOLARITY(p->wait_pin); + + gpmc_write_reg(GPMC_CONFIG, config1); + } + + return 0; } @@ -1985,6 +1998,8 @@ void gpmc_read_settings_dt(struct device_node *np, struct gpmc_settings *p) "gpmc,wait-on-read"); p->wait_on_write = of_property_read_bool(np, "gpmc,wait-on-write"); + p->wait_pin_active_low = of_property_read_bool(np, + "gpmc,wait-pin-active-low"); if (!p->wait_on_read && !p->wait_on_write) pr_debug("%s: rd/wr wait monitoring not enabled!\n", __func__); diff --git a/include/linux/platform_data/gpmc-omap.h b/include/linux/platform_data/gpmc-omap.h index c9cc4e32435d..7c9675165e8a 100644 --- a/include/linux/platform_data/gpmc-omap.h +++ b/include/linux/platform_data/gpmc-omap.h @@ -149,6 +149,7 @@ struct gpmc_settings { u32 device_width; /* device bus width (8 or 16 bit) */ u32 mux_add_data; /* multiplex address & data */ u32 wait_pin; /* wait-pin to be used */ + bool wait_pin_active_low; /* wait-pin polarity */ }; /* Data for each chip select */ From patchwork Tue Sep 6 12:47:45 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "B. Niedermayr" X-Patchwork-Id: 604125 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D131C6FA86 for ; Tue, 6 Sep 2022 12:48:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240069AbiIFMsJ (ORCPT ); Tue, 6 Sep 2022 08:48:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35078 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240089AbiIFMsI (ORCPT ); Tue, 6 Sep 2022 08:48:08 -0400 Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20061.outbound.protection.outlook.com [40.107.2.61]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3114B580B1; Tue, 6 Sep 2022 05:48:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IkdfeW/wsVLNfEDfwoUEt8yXHuuBspSYcWGqZv6OMBgGbMhQGRaTLRC0dptt60qOvhbpM8x1A3c5EDR/9Cz6EB0QvJz8rGpTXvEyQzvR+V2dVyDqzTFII1ky0GpFr4z/bOEXL1YkaO2FWIXWYSm/0lVN+TKc8ZMDWbRLlRBAJm7T+2HT0jjbDtbmhh4uwOB9o/ebviUrQF7OUUixyImnJXDDJNSWKH1pI3Ul6kdyejF4ZKvRqf9JNKaxslP+IlbmqACqBMpOkj/f/ZNSod5qfB/GCtLl3j3nSTh5U/vsndnQPA6ha4SDNG6jNidH7Zhx7iI2Leb+VWfew1qXU0PcaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FYJ+DnDcwvzKIB5SPuCxcJxEu1REjYn3keTA74iTLyE=; b=PMWaJ9VfhZBqZiet1+cbmoyD7EkOPe1yXJ+SiKgRlmdzfkCCw1KicZvTFJavnT3p2Sbxm9bQq3GVPNFt3dkLqcBp0C5a++33cU3NXX6YHiI4JwqhPPbPLQfuAprhvHNUnRdxn4vgdqwdwuwOcJbajCY+TNxN2xienDpKrsJ6LZoOtQMS4kuS6shRMPwsW9Mi17zhMSIjZYm+P1haiJMice5n63HfoUqZZU+eSWlBC/JFmAxA2ZjsHHd8MSqmhS5RwCrpcKmsPXg5Z8GjaXXvaya2xiDB+6s1WOyKLMLEV0yaM3eqATiOWDWodzEOa4OZJ3BkpLhQdiC+OEPT1ubgyQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 194.138.21.76) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=siemens.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=siemens.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FYJ+DnDcwvzKIB5SPuCxcJxEu1REjYn3keTA74iTLyE=; b=jFROnylkMYEcNB6X3Ulpm33Ri0YKGecVs0X+g31xx4fJ8OWoFewcWCghyGyohn2oj90hffddGQTg5PHu2bGVlLi4qMAfhyJBe8XUzNUzAjjVB0csLnBe2BP+Y1FOGUThHsiWBfpsUVaABGvZzjTbPx4Yez5kn/kil39Af7xmpUH3An/YKGpz+gXITaW9huGbPqWYip64pMqSNJJnJqXk6NvyARfDqDVtJL1z0uezktSmwx1j5VctrHceFKOFmWVcDsWIGMyfc+82UU5RNuacEEqeEnKxG0T7AUswhRDJaGl7kL8v2eXJD3j1H64jEhzXGWAeLsWd/PHJ4R6F8j33mg== Received: from OS6P279CA0151.NORP279.PROD.OUTLOOK.COM (2603:10a6:e10:39::8) by AM7PR10MB3591.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:13e::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.11; Tue, 6 Sep 2022 12:48:03 +0000 Received: from HE1EUR01FT093.eop-EUR01.prod.protection.outlook.com (2603:10a6:e10:39:cafe::5) by OS6P279CA0151.outlook.office365.com (2603:10a6:e10:39::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.11 via Frontend Transport; Tue, 6 Sep 2022 12:48:03 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 194.138.21.76) smtp.mailfrom=siemens.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=siemens.com; Received-SPF: Pass (protection.outlook.com: domain of siemens.com designates 194.138.21.76 as permitted sender) receiver=protection.outlook.com; client-ip=194.138.21.76; helo=hybrid.siemens.com; pr=C Received: from hybrid.siemens.com (194.138.21.76) by HE1EUR01FT093.mail.protection.outlook.com (10.152.0.243) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Tue, 6 Sep 2022 12:48:03 +0000 Received: from DEMCHDC8A0A.ad011.siemens.net (139.25.226.106) by DEMCHDC8VSA.ad011.siemens.net (194.138.21.76) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.12; Tue, 6 Sep 2022 14:48:02 +0200 Received: from bennie-lenovo.fritz.box (139.23.126.196) by DEMCHDC8A0A.ad011.siemens.net (139.25.226.106) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.12; Tue, 6 Sep 2022 14:48:02 +0200 From: "B. Niedermayr" To: , CC: , , , Subject: [PATCH 3/3] dt-bindings: memory-controllers: gpmc-child: Add binding for wait-pin-polarity Date: Tue, 6 Sep 2022 14:47:45 +0200 Message-ID: <20220906124747.1767318-4-benedikt.niedermayr@siemens.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220906124747.1767318-1-benedikt.niedermayr@siemens.com> References: <20220906124747.1767318-1-benedikt.niedermayr@siemens.com> MIME-Version: 1.0 X-Originating-IP: [139.23.126.196] X-ClientProxiedBy: DEMCHDC89XA.ad011.siemens.net (139.25.226.103) To DEMCHDC8A0A.ad011.siemens.net (139.25.226.106) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: dd29b7e8-4943-412f-9fd0-08da900609d6 X-MS-TrafficTypeDiagnostic: AM7PR10MB3591:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yx6EfpNlAWUpphTpAyBzeQe64cZmKCt69so8ABtR5I8ZY6Oe2t3yxhjY25vShPGYTHUSnvHBNu0cWuR3+Ya/9vz912fuLcH9IyVodoWUI/t9iRbVH7uQS3KgqCVmVN1EdUhckv3dtng9gnsJ6igY+sd2lOM0SGcGYwifECeCAdIvblX1iTBnTyq0yYfJxamIpjHLy7ZzqwvqszBWqn4D9cxxZvI5Lq5fcPqsSBd6v21n+5g5NMT23pVBUZoSHVLk6VJHU18lOIxvvE6PhaPmv6QNRULCfWY7GcVrHXA6TjxHEWKcv9fOLOyms7SHdmbXZArxUQXMjMhoK+wyY+RXHuE9OvjPFb2XEa/lGsJd9KoreLu2xjb6pdZU/22UnYqZtXMgxWF6kxnSQo0Ak7WFtRs0kZGD/clCIuUpFGt3qDfflwCjc3XzXh2culKEKznfUhxJq/JLWUTYf4sxc31qF4AYt46LYjKoRI0UJ1rYml/weak2s7TpBMwCk45xaGZ1E+ofmBF4H7se/Zg/JxPEPNYFD+7Dc2QNRnQgKIZV44kmfClD5lhq1NzjnI+Ma9pNHGwLEJ/H6DKP9pTKnLJc82rCRp8sIxFExGCXfc4yi3FzW7b8XMCPjO7b8fd8sPrZZeO47i7teE2+xO0/C5DVOcisymiYg7zANa263HiTR3ApJvb2pylfjQON2G95iFAr8BfK2N3/t5s6Z6CUA38pHo+boHoiJ+/daH9OG50J4MxOYeLvXR6eVWS2A01+heSB9wzWDrcF4P74rWZQ5GSRIHpvLa+1WS9dTuirXnijusaINxs0sBrxf024OXSjELds X-Forefront-Antispam-Report: CIP:194.138.21.76; CTRY:DE; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:hybrid.siemens.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230016)(4636009)(39860400002)(396003)(136003)(346002)(376002)(46966006)(36840700001)(40470700004)(36860700001)(54906003)(316002)(5660300002)(36756003)(70206006)(70586007)(8936002)(2906002)(8676002)(4326008)(47076005)(478600001)(82310400005)(40480700001)(6666004)(41300700001)(26005)(2616005)(336012)(186003)(1076003)(16526019)(81166007)(86362001)(956004)(356005)(82740400003)(40460700003)(110136005)(82960400001)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2022 12:48:03.4673 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: dd29b7e8-4943-412f-9fd0-08da900609d6 X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=38ae3bcd-9579-4fd4-adda-b42e1495d55a; Ip=[194.138.21.76]; Helo=[hybrid.siemens.com] X-MS-Exchange-CrossTenant-AuthSource: HE1EUR01FT093.eop-EUR01.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR10MB3591 Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org From: Benedikt Niedermayr Add a new dt-binding for the wait-pin-polarity property Signed-off-by: Benedikt Niedermayr --- .../bindings/memory-controllers/ti,gpmc-child.yaml | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/Documentation/devicetree/bindings/memory-controllers/ti,gpmc-child.yaml b/Documentation/devicetree/bindings/memory-controllers/ti,gpmc-child.yaml index 6e3995bb1630..7c721206f10b 100644 --- a/Documentation/devicetree/bindings/memory-controllers/ti,gpmc-child.yaml +++ b/Documentation/devicetree/bindings/memory-controllers/ti,gpmc-child.yaml @@ -230,6 +230,13 @@ properties: Wait-pin used by client. Must be less than "gpmc,num-waitpins". $ref: /schemas/types.yaml#/definitions/uint32 + gpmc,wait-pin-polarity: + description: | + Wait-pin polarity used by the clien. It relates to the pin defined + with "gpmc,wait-pin". + $ref: /schemas/types.yaml#/definitions/uint32 + default: 0 + gpmc,wait-on-read: description: Enables wait monitoring on reads. type: boolean