From patchwork Wed Aug 10 21:54:09 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 101959 Delivered-To: patch@linaro.org Received: by 10.140.29.52 with SMTP id a49csp609548qga; Wed, 10 Aug 2016 14:56:36 -0700 (PDT) X-Received: by 10.66.161.195 with SMTP id xu3mr11033673pab.68.1470866196133; Wed, 10 Aug 2016 14:56:36 -0700 (PDT) Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id xl3si50399525pab.117.2016.08.10.14.56.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 10 Aug 2016 14:56:36 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 548FE6E889; Wed, 10 Aug 2016 21:56:35 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.126.135]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6D9096E889 for ; Wed, 10 Aug 2016 21:56:33 +0000 (UTC) Received: from wuerfel.lan. ([78.42.132.4]) by mrelayeu.kundenserver.de (mreue005) with ESMTPA (Nemesis) id 0M36tX-1bGDFw3mbf-00stZe; Wed, 10 Aug 2016 23:56:24 +0200 From: Arnd Bergmann To: David Airlie Subject: [PATCH 3/9] drm/mediatek: add COMMON_CLK dependency Date: Wed, 10 Aug 2016 23:54:09 +0200 Message-Id: <20160810215424.1926658-4-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 In-Reply-To: <20160810215424.1926658-1-arnd@arndb.de> References: <20160810215424.1926658-1-arnd@arndb.de> X-Provags-ID: V03:K0:CQEVIpbZ4Rxj/MRAYZUmf1QWNiiP9KIhKIxnAgwJxugXbJEI8dj D7hJkHrQlglrExyaQyQu323EGpDI+Bx8J3Od28iOmREwDvZr3w+cmFoZw+4IaGrfmdJeQVB m8sU6B4DYz/zTke0iYk5P5boVeuBGt2Zk7hJrBr38W+eqXRNuK5IW6WXQc42ZyDcGp8Esy3 4NPQXBvhIRYbfH3H0gcJQ== X-UI-Out-Filterresults: notjunk:1; V01:K0:xnLJZLZaoq4=:+XMkP96Yc6CDvGr/CxCaqI HghQp6vadSqeC50FIzWW98WQ90dk3AKTzUxoUuCGk3B6ypBpqsFe01SlRypUhdG2mqs1BTUVH KsVgkkGhkboMZDcOJ/jSoRCoXgf6CHYmV+mc6eddTZN1YUtL0/mSnJpvDdAKVpLjY8D3YIMzx gvh2O8MPoWCLgSK3mrBRW64EvJ/9QDYcNBkOtdajRt5H5VFeaYoiwumRi7ShM+h49jdYmQ2Iz 0t+dvAAlC0qa4/qjPAb44SHKoYsMKDAV4d1QyjygLxveGnv73yNKxFbdMzPGdBVmO8/Bv29Ln iae9UgNK2oFDrcc7RMUbTOeCkW8OxQPwH211E+3CxVT6l4/qUgkiLmd4m1dtttz5OZxzG7L8E wWwwlBfPxNq+m10OUMa+HfslhTNViT4LvMOk0pvFJF76uVQnBuCOXxGeYYH+2xT7j1CaxUvHT x21U2nvdId8YgPjh7aU0BUXOkpnZEImbB5TNzvcODAsqSz4aoHbqxpKgpuTHs2rLDEIl81+wx r09MJ3iHQ8sqkVSYLRTQtoObpc7C7QF9Ioga95QI9vOvfqEG1Zz78zAN/ffalwfGtGsbrJB8f REHPy9F3/iH6B4RiAmJRcPTnPTPcgtIQ4NUCX9XuR3hgj+DXp19jZpDL4eEYnpbMLuY8HJ+x2 8ahVEsjNjIq1csN5nGzCdauUUoXgMwTFXqvMgmOdVNddLZuXgxV6Vqa8c3d3ZR1/jbyA= Cc: Arnd Bergmann , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On kernel builds without COMMON_CLK, the newly added mediatek drm driver fails to build: drivers/gpu/drm/mediatek/mtk_mipi_tx.c:130:16: error: field 'pll_hw' has incomplete type struct clk_hw pll_hw; ^~~~~~ In file included from ../include/linux/clk.h:16:0, from ../drivers/gpu/drm/mediatek/mtk_mipi_tx.c:14: drivers/gpu/drm/mediatek/mtk_mipi_tx.c: In function 'mtk_mipi_tx_from_clk_hw': include/linux/kernel.h:831:48: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types] const typeof( ((type *)0)->member ) *__mptr = (ptr); \ ^ /drivers/gpu/drm/mediatek/mtk_mipi_tx.c:136:9: note: in expansion of macro 'container_of' return container_of(hw, struct mtk_mipi_tx, pll_hw); ^~~~~~~~~~~~ drivers/gpu/drm/mediatek/mtk_mipi_tx.c: At top level: drivers/gpu/drm/mediatek/mtk_mipi_tx.c:302:21: error: variable 'mtk_mipi_tx_pll_ops' has initializer but incomplete type static const struct clk_ops mtk_mipi_tx_pll_ops = { This adds the required Kconfig dependency. Signed-off-by: Arnd Bergmann Acked-by: Philipp Zabel Link: https://patchwork.kernel.org/patch/9069061/ --- I originally sent this on May 11 2016 after the driver was added with this bug, but my fix never made it in. --- drivers/gpu/drm/mediatek/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/mediatek/Kconfig b/drivers/gpu/drm/mediatek/Kconfig index 23ac8041c562..5c2163737691 100644 --- a/drivers/gpu/drm/mediatek/Kconfig +++ b/drivers/gpu/drm/mediatek/Kconfig @@ -2,6 +2,7 @@ config DRM_MEDIATEK tristate "DRM Support for Mediatek SoCs" depends on DRM depends on ARCH_MEDIATEK || (ARM && COMPILE_TEST) + depends on COMMON_CLK select DRM_GEM_CMA_HELPER select DRM_KMS_HELPER select DRM_MIPI_DSI From patchwork Wed Aug 10 21:54:10 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 101958 Delivered-To: patch@linaro.org Received: by 10.140.29.52 with SMTP id a49csp609670qga; Wed, 10 Aug 2016 14:57:00 -0700 (PDT) X-Received: by 10.98.9.194 with SMTP id 63mr11054154pfj.56.1470866220320; Wed, 10 Aug 2016 14:57:00 -0700 (PDT) Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id pg14si50397399pab.47.2016.08.10.14.56.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 10 Aug 2016 14:57:00 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E4A6B6E88B; Wed, 10 Aug 2016 21:56:57 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.126.135]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7C8C46E88B for ; Wed, 10 Aug 2016 21:56:55 +0000 (UTC) Received: from wuerfel.lan. ([78.42.132.4]) by mrelayeu.kundenserver.de (mreue005) with ESMTPA (Nemesis) id 0MLT3m-1bX3G90mLi-000exX; Wed, 10 Aug 2016 23:56:47 +0200 From: Arnd Bergmann To: David Airlie Subject: [PATCH 4/9] drm/mediatek: add CONFIG_OF dependency Date: Wed, 10 Aug 2016 23:54:10 +0200 Message-Id: <20160810215424.1926658-5-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 In-Reply-To: <20160810215424.1926658-1-arnd@arndb.de> References: <20160810215424.1926658-1-arnd@arndb.de> X-Provags-ID: V03:K0:gSzM6o94HvTmSBzbq5jUOhLIkv4lJJnCJIyzoar9e5zaT01xTTV OUIqc1i26QCwpVPTbUlmHIRqschyHfxUwYm+y4vuKtBG1Jm7/23ke8a9mqXcqItvwCX7kNr IcG90ZmD7hbC7V5QN6h9F4+iuLTYGlNJVRR6Sm+SqWRexrMydiv2+yDQ7N5RDXwW1uLKW+s YB/c9x8x0QnQVz8aAdkoA== X-UI-Out-Filterresults: notjunk:1; V01:K0:/5MbaBeKlLM=:9Z2RAQwyazhxIN60KVaurH iNwkfWwATy9ljMNEKYbcNHg13/W5oB7jE/Hq5505gJ3y0cOGyMOS6cCaz8NMRPFE2M3Qd/++1 uWlO2AlbOnZC35HM3zRE96qdlDuMzoCpiZWVW6kITFE2vF7mxH62YExWc7AaSAhhuPa+HINdp JAsgI/Nc7CnN/w9FZdRJfu0rOR24bU+SSIqI3v163rLR3EFF+JQQcaLOGh3maebtwkhBhz+BC z9nNyhMsg7XOXvJRNNf2Ne8+h7D+b+fww/Ealduh+6PBbcS3HuVX084ETPQ+7dfQtUKDiBl8X u1G0PSf2rEvXKRCy6a6dRtzuzOyFu04sI/x7YAh13l7m8+NoN8YYNDRbKS5NUAqKV5SOIdw7p 3lyk760pEyAhFSALSWwGH8jQdAElFck3H5wZGgPutUz5GayU+dB2g45VQe+Ei8so8/tr8vQ4M wEZSJkPC/wxHK8q17+dcYN4p3dxoWYoBZtLr2jX2dEm7LdPTE8QkwydBpPQkpDrX1Nqwyc31Y l90yncHp3TWuN2TUc4uFtWMfdSbXHAL/Pe44zcNBSj7pHZdbXGXJKxFEOtf4Ra9ICpt5GI12A GrxbaEI4A4N7WbI0Yg98QHsg+iRd5v+yLe72crtv9TLLHnhyWKbvUIuogD0Qaf8xQ+hUtjQHq SoZehmTL+mK2I10KW8GUo9ErKMm6xq/X8cZuMfAsRrCPC+G15gRYJSZ9bWD9QvQboy2E= Cc: Arnd Bergmann , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The mediatek DRM driver can be configured for compile testing with CONFIG_OF disabled, but then fails to link: drivers/gpu/built-in.o: In function `mtk_drm_bind': analogix_dp_reg.c:(.text+0x52888): undefined reference to `of_find_device_by_node' analogix_dp_reg.c:(.text+0x52930): undefined reference to `of_find_device_by_node' This adds an explicit Kconfig dependency. Signed-off-by: Arnd Bergmann Link: https://patchwork.kernel.org/patch/9120871/ --- I originally sent this on May 18 when the driver was newly added, but my fix never made it. --- drivers/gpu/drm/mediatek/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/mediatek/Kconfig b/drivers/gpu/drm/mediatek/Kconfig index 5c2163737691..96ebf8bb6024 100644 --- a/drivers/gpu/drm/mediatek/Kconfig +++ b/drivers/gpu/drm/mediatek/Kconfig @@ -3,6 +3,7 @@ config DRM_MEDIATEK depends on DRM depends on ARCH_MEDIATEK || (ARM && COMPILE_TEST) depends on COMMON_CLK + depends on OF select DRM_GEM_CMA_HELPER select DRM_KMS_HELPER select DRM_MIPI_DSI From patchwork Wed Aug 10 21:54:11 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 101957 Delivered-To: patch@linaro.org Received: by 10.140.29.52 with SMTP id a49csp609802qga; Wed, 10 Aug 2016 14:57:27 -0700 (PDT) X-Received: by 10.66.157.40 with SMTP id wj8mr10839044pab.53.1470866247649; Wed, 10 Aug 2016 14:57:27 -0700 (PDT) Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id iv7si50460949pac.17.2016.08.10.14.57.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 10 Aug 2016 14:57:27 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 99DED6E88D; Wed, 10 Aug 2016 21:57:26 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.126.130]) by gabe.freedesktop.org (Postfix) with ESMTPS id D0EE46E88D for ; Wed, 10 Aug 2016 21:57:24 +0000 (UTC) Received: from wuerfel.lan. ([78.42.132.4]) by mrelayeu.kundenserver.de (mreue005) with ESMTPA (Nemesis) id 0MYrDT-1bk1hX0tZT-00Ve7W; Wed, 10 Aug 2016 23:57:16 +0200 From: Arnd Bergmann To: David Airlie Subject: [PATCH 5/9] drm/mediatek: add ARM_SMCCC dependency Date: Wed, 10 Aug 2016 23:54:11 +0200 Message-Id: <20160810215424.1926658-6-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 In-Reply-To: <20160810215424.1926658-1-arnd@arndb.de> References: <20160810215424.1926658-1-arnd@arndb.de> X-Provags-ID: V03:K0:SJxuRWRprBdISdUU3yqY3swUrrBPl8fegksHHv1NhylsJLQlC2H FxWyiIV86FCWWIIYwCuIuksWK1VahEcQWTBbySzfWH2hzxtVEFilhrdir9KeP7FsQFmofbv SAKBFFqP5rVHyZpel2QGvM/VxLZsRNDkqvnTPwcGAi+YuHg0tO+O600tXDIbCfmAxixBNxC bKHMbw96kR37oT6DgOISg== X-UI-Out-Filterresults: notjunk:1; V01:K0:hc88IJpJ6RM=:m9M/cHJd+DRninIYbM1ftp Llwyd047LqCpqeZyzVqtQn9zSg3DGMYArulMk4NKJ/yBIv7oLRWEcP/20MrRvFc787thWqGvv iiIobbDoPM5mDV3To+C+XMj7WXh2SfJAkV16SjpJetl0Kl843wpLASale8cRLfWEZMyZTE3fp c8FzgV8xYpqvnOXO3H+bLULIz/Qg1O1AFoQr9EKE6Thg2o5fADkEUAL0p+MRPG3M+aU1EYJl7 nn+S9pGS/74cZIFEdPCro+FtdljKOeaTnAMFRz8iWQ8wxRBicOd6PmBhuYLE0NmLI/dMqnZqu LzcznrAiHF1CFVDsnDWnYRolC1Y9Hg0MRqvUp3DH5vScbgqE8YuB6kXY9V8DmH6AvjD/Tk8HF lBgKkwXuwbl4TQJVKkJRNw0dg2ObhWKtEzxTaeB5NJva86hMovApdb8sGi8bJRB/XNas1/hNt CvOquQo1pf7nuuJgWDJcfvzFYzBYVRG/67j0wQTVDOpApWsPD0mqlOgyl0XqjBMUvHDl3LLmd mbE98UYsfrObwrSH8OGu3GI8vD7vJNDx/lBq4+alAdrLl8STuipNFG1OcYwc76QA18bqGZFfC JfrXy4fGTDSsJSp5VzAu9XsIavRiMehzm3lRZm3nxlZhJprfc0fHnanCqouDH/PfgMkzIi8QZ xRggY2tXstxkn3WsU0JZNll8P5OsuuUOlrmda4VMQLb8Y6sSTmemPK22d6qA/6qCNNiY= Cc: Arnd Bergmann , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" ARM SMCCC is only set for ARMv7 and ARMv8 CPUs, but we currently allow the driver to be build for older architecture levels as well, which results in a link failure: drivers/gpu/built-in.o: In function `mtk_hdmi_hw_make_reg_writable': :(.text+0x1e737c): undefined reference to `arm_smccc_smc' This adds a Kconfig dependency. The patch applies on my two previous fixes that are not yet applied, so please apply all three to get randconfig builds to work correctly. Signed-off-by: Arnd Bergmann Fixes: 8f83f26891e1 ("drm/mediatek: Add HDMI support") Reviewed-by: Matthias Brugger --- Sent first on June 27 when it first broke in linux-next. Two other dependencies were already missing, so I'm sending all three patches again now. --- drivers/gpu/drm/mediatek/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/mediatek/Kconfig b/drivers/gpu/drm/mediatek/Kconfig index 96ebf8bb6024..294de4549922 100644 --- a/drivers/gpu/drm/mediatek/Kconfig +++ b/drivers/gpu/drm/mediatek/Kconfig @@ -3,6 +3,7 @@ config DRM_MEDIATEK depends on DRM depends on ARCH_MEDIATEK || (ARM && COMPILE_TEST) depends on COMMON_CLK + depends on HAVE_ARM_SMCCC depends on OF select DRM_GEM_CMA_HELPER select DRM_KMS_HELPER