From patchwork Mon Mar 4 20:30:50 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 159610 Delivered-To: patch@linaro.org Received: by 2002:a02:5cc1:0:0:0:0:0 with SMTP id w62csp4182521jad; Mon, 4 Mar 2019 12:31:46 -0800 (PST) X-Google-Smtp-Source: AHgI3IbG/CB7hQKzLZ52m6eKRFq+vKaor0hCavpSqjHB24UlfMpxin+3GOjfeHm44J4m1rxNmyve X-Received: by 2002:aa7:854d:: with SMTP id y13mr21621551pfn.175.1551731506708; Mon, 04 Mar 2019 12:31:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551731506; cv=none; d=google.com; s=arc-20160816; b=P4Hn9TbexuyimyRwbWahts9EP9S6aXCiZr0AVZMqr3sCfr8GzJkF1KAAXTxCohmbuN a/OxF3rJfG9P7BJXGYQP4gkr38v6vDcHocnU+3MTF8cVBjwPDYjCNMoiqYfJOdPPCjDd JPUAZtnd8klcsGq5MZjWmwbdX3uxnqpDa0Xq7BHjKNsmfJMq6GEo6sGUbhFguGnDHJoU KOKPPKOnaQQthFMCtbxtgVPLlh1riV06e//n+uRci7Mfj/SkvKzcVkjAZKD6VjFz5cbg rBrrfb5z6qTVNxWircQTw8jfZg5azXeFN0X/tVTgNTlCKqfMT0NX8Z0PjZi3jYRprvt5 pDbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=3c5xU+b+7HutRwxna0zlwDL4cZs/QDshxA1Ean0n9GE=; b=YJ3BhxaoyGXzJ1v8R2agUpm/XAxFBjMPTKya19e5YPFUEOn1NuOnEYksSq0CMrkoUP uy7viZGw6IXoDP0JzYIssVqLb0KLaD3+PJGYy/n/okdmf6hFR3VZtypuyyxgp5314tsu EtmgqT7hk565TfhxjfS8eW6Oub9/ge0aEivLD6443qXWSkwYteQ0jLDMtzOXG9S/qACZ K7xzhh54OgVPcMJJuuA6/c9pmZUS2mI9EeMQQIOgUfWQDReN13bokoiAHVNghKBeBIjF jwzQFtrmLjAlz0XUNGZ0q4rFqv7qw0jfuRLXsfmXBAo5iBByyWKMBV0/2QLp1g49HN7A Mv0Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g186si6092157pfc.58.2019.03.04.12.31.46; Mon, 04 Mar 2019 12:31:46 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726737AbfCDUbo (ORCPT + 31 others); Mon, 4 Mar 2019 15:31:44 -0500 Received: from mout.kundenserver.de ([212.227.126.187]:57981 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726095AbfCDUbk (ORCPT ); Mon, 4 Mar 2019 15:31:40 -0500 Received: from wuerfel.lan ([109.192.41.194]) by mrelayeu.kundenserver.de (mreue011 [212.227.15.129]) with ESMTPA (Nemesis) id 1MqbI0-1hMorl3vvM-00mXxV; Mon, 04 Mar 2019 21:31:26 +0100 From: Arnd Bergmann To: Peter Ujfalusi , Mark Brown Cc: Arnd Bergmann , Liam Girdwood , Tony Lindgren , Jarkko Nikula , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/3] ASoC: ti: fix davinci_mcasp_probe dependencies Date: Mon, 4 Mar 2019 21:30:50 +0100 Message-Id: <20190304203114.1894822-1-arnd@arndb.de> X-Mailer: git-send-email 2.20.0 MIME-Version: 1.0 X-Provags-ID: V03:K1:4WHISUG8ocxAAwYPAmZ+zHkTsPViuEM8zA/h9WNrN67zQWO6mKi vczHmqhoMu7KVOHcdco2Hn20CHdsa1p/M4jTbVKGVZYPB3KgFP3VsElBpuO5ecQqIuLaZDu LgbopVZ7+rnSpXbF5nF7bJnKXHOW67J6HjNUy+0Vvj3lkEToYjCkE2vCbnWTy26uesIrsiu Wm3EMudsRZLHhRZLSbs1Q== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1; V03:K0:Q5iJxDzL/lY=:/nX2YjWdXcK6H3+UfEaatQ AW0M1Sl3iqJMSuByNIInJH+fhCmfQzNWc2FyiyWaNSUMsD/qja7h526MKV1G0spYGa9JChtDQ 2WoLZtGNem2SuVQn0bVd+jLNP0tnGhI3k5wyGxo3Zf9Oit9sIXhKRrsF3yzo9p+pujooHGtUA Q5eYocmgBB1dKjXQlJ+xsjlPPgTxyU2CruxSpEC2D945WMAzMtfd7Tedsu4asFqHhC+n+sNoI 4zR2MPovedGZg5fyhkFQm9aAY5BcTn6Ytt0pm0WKMpfPTGpRRp6rofRzhVexjz+ugRlggbSLc xw4VsXuhBKf/zv221wpqqdm2mLJfpB3U+g52/gWyK8D6K3Xd6ZrxRx0R7Afbl9L0mVNzv3o9L VKDdARcBse2ax9SsmyFSPzTNgKIpiHdqgVeTBW0zBEcUkj0A9civCvmzcUswAlsBWKRJuAtMN VtNHceQU3SKIUfZkPbTKyNcWSKgclOPjxU/E1dfc3PVeaOgHL9wTV9Av1VsXlSutIIqYKdXut pbHbisVjVjQXj4NUPRLIoX21ye6IjeK3aE+B/uJ2fNlTTKjpECrS8NYubgwpjhcUoKz/iVYrJ Oq2oJ7Ibnm2g27PzdZzF8CZqH3P69YeNm6W5wNUJNIyPyyzu20WGMUbNxuZI1Ui5/DbGcX9WE jLflRoM5WVflBvwHRl8Dg24YpCUeSUK56KQycu4gIZWmbQid/0WPQXe2YvnwKVVn3rHhh7YWR cvq6tBKRGIpbqBLIC9jtIsjrgftkDg5ZG2CGAg== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The SND_SOC_DAVINCI_MCASP driver can use either edma or sdma as a back-end, and it takes the presence of the respective dma engine drivers in the configuration as an indication to which ones should be built. However, this is flawed in multiple ways: - With CONFIG_TI_EDMA=m and CONFIG_SND_SOC_DAVINCI_MCASP=y, is enabled as =m, and we get a link error: sound/soc/ti/davinci-mcasp.o: In function `davinci_mcasp_probe': davinci-mcasp.c:(.text+0x930): undefined reference to `edma_pcm_platform_register' - When CONFIG_SND_SOC_DAVINCI_MCASP=m has already been selected by another driver, the same link error appears even if CONFIG_TI_EDMA is disabled There are possibly other issues here, but it seems that the only reasonable solution is to always build both SND_SOC_TI_EDMA_PCM and SND_SOC_TI_SDMA_PCM as a dependency here. Both are fairly small and do not have any other compile-time dependencies, so the cost is very small, and makes the configuration stage much more consistent. Fixes: f2055e145f29 ("ASoC: ti: Merge davinci and omap directories") Signed-off-by: Arnd Bergmann --- sound/soc/ti/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.20.0 Acked-by: Peter Ujfalusi diff --git a/sound/soc/ti/Kconfig b/sound/soc/ti/Kconfig index 4bf3c15d4e51..ee7c202c69b7 100644 --- a/sound/soc/ti/Kconfig +++ b/sound/soc/ti/Kconfig @@ -21,8 +21,8 @@ config SND_SOC_DAVINCI_ASP config SND_SOC_DAVINCI_MCASP tristate "Multichannel Audio Serial Port (McASP) support" - select SND_SOC_TI_EDMA_PCM if TI_EDMA - select SND_SOC_TI_SDMA_PCM if DMA_OMAP + select SND_SOC_TI_EDMA_PCM + select SND_SOC_TI_SDMA_PCM help Say Y or M here if you want to have support for McASP IP found in various Texas Instruments SoCs like: From patchwork Mon Mar 4 20:23:57 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 159602 Delivered-To: patch@linaro.org Received: by 2002:a02:5cc1:0:0:0:0:0 with SMTP id w62csp4176609jad; Mon, 4 Mar 2019 12:24:35 -0800 (PST) X-Google-Smtp-Source: AHgI3IYIsrPYStQHpntyTNH2T7fOzX5TuXBKmfxpaXElQQ3Nj4SUnAE9YnPcwPYh3WxfgimJd9sR X-Received: by 2002:a62:fb10:: with SMTP id x16mr21794797pfm.5.1551731075414; Mon, 04 Mar 2019 12:24:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551731075; cv=none; d=google.com; s=arc-20160816; b=zlzgRwOSRZ2wrB3VAoS6y3zlySqie4jaxFQe4/u1HXdeAJrcaFIFKxoM/PGouNyW5a cO7elazBUFnsoNBc0fRnFUdX1kPCeiZlU0vxfvioFMX7ztC0yScnSSqv8rHC0wpDq9L0 IwzDLJv+fVIhkjLPlpVpw7AhmRnu4UXr1jVI0GAiYR610W25gQVeOxSCvlaUvlD9iT6r +eFztwh26D4+KNBj9XHzyJAmHyxJp/ICwjSGn0VJf1vvvvhiuGiiX1D8v2n8MPNTeL2p f0EoEFCyjQX0cYwu4uhgM3VFvMTJayMnsPqjWtgUWnqfKMEdxYa+LKEzthTQVpiFkS+m kqsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=iQXb9m8YCFNohJSQ3lYyTMvtREnotdHdK1h2E1VTjIU=; b=xhRfkcn6K5M3dsldOEwav/FisvWQtag19c6N43evxet6YhLszUctIQPZOxUn8n6wuR 5lwwRp4FcKMUIQw4qJNaugqFmvzQjqRKZeCAy3R0REM7HDVtS0kLOsYHWxhB19WcP7B+ SH58UjDhbS2oAv2XqvdU4jFHm7fdkt3L12KllAFbjIrTQ9ayiSBRg8/q8/0m0TiNyn1B Z3LeMP7IMclvMNJf57Ilmw3s+GycqDmII7ZmGXoWrs5NUMmrEQLFDdl7Y7sudislhIAE H+fydpF2dNWp0bq60ejVVsIxLSQFvFesGhbj+Tshj17rqxLWAbJRVTlvBEDR2fDCz3CG 8/kg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v63si5947050pgb.248.2019.03.04.12.24.35; Mon, 04 Mar 2019 12:24:35 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726094AbfCDUYd (ORCPT + 31 others); Mon, 4 Mar 2019 15:24:33 -0500 Received: from mout.kundenserver.de ([212.227.17.13]:34529 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726095AbfCDUYd (ORCPT ); Mon, 4 Mar 2019 15:24:33 -0500 Received: from wuerfel.lan ([109.192.41.194]) by mrelayeu.kundenserver.de (mreue107 [212.227.15.145]) with ESMTPA (Nemesis) id 1MHFwM-1gnkyI0qI4-00DIlm; Mon, 04 Mar 2019 21:24:26 +0100 From: Arnd Bergmann To: Kishon Vijay Abraham I , Roger Quadros , Sekhar Nori , "David S. Miller" , Jason Gunthorpe , Arnd Bergmann , Grygorii Strashko Cc: linux-kernel@vger.kernel.org Subject: [PATCH 2/3] phy: ti: usb2: fix OMAP_CONTROL_PHY dependency Date: Mon, 4 Mar 2019 21:23:57 +0100 Message-Id: <20190304202406.1716350-2-arnd@arndb.de> X-Mailer: git-send-email 2.20.0 In-Reply-To: <20190304202406.1716350-1-arnd@arndb.de> References: <20190304202406.1716350-1-arnd@arndb.de> MIME-Version: 1.0 X-Provags-ID: V03:K1:JQmSenYXKz0L0BH+G3P7TY1KisuMQn0QAx1QkrKe2qDgQGQMrTQ ESSgdIMGeWW9yzezgH/Qx9E0QJBCyIppPHjLqXU1kAQEDVDDq1X7+3SklTrCn5133oVA7kd HPcAvx7ub5KYYTcZYkPmJ383/IC69nkGTQKXLgdi+yHmtCqwufG5D8KJGMCk1TfYQEmvMc6 gS3hOTsbvjl1+PNeJQdYw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1; V03:K0:FRjI4uFPDe4=:N9u4e4zQicx39gEeMMAziA XkdZIZ4KZEfeYXi1KcNK4e/QFcFkGfsAf8D1TP2Gjk1f9YLult+/0ryKjoj0cwblahtP6ojXT o9K9YCxnNxp9E9/UAqEbFYeA08YKaqgBoU8wvyxyWkLWK3F55D0/YQa66hcLNkxqGb3GjpJ6Y Q96QRd45lQsjjpFush718wbCv8a4KVwX0AhN2HN7n4cNvDKDfOTbTbIAaB/l1JO74ydoc6fdg qh81ggJokvmxqFCJlUjylWfRu+8YiPYKqFS0JyEm1rr6csb/qiaxnz5iqB9ZDaZL683vcmMAc vmHLrXA0WQg29l9Pr8Hu+96eQwINKgrd9qLHRRrUZVL6ukzIqz8wJ/PwZJFs/reA/BDGdPZ5z /bGcELv8VdeqHabZu/uQw7k7X5BzkyQBOm/JK8WHiuRis82ORsYu0ue+7r3/PALHU1mABSeOH lNlAFsn5KJ2ayNGZd7hvwRE1QVwiUta41exSOvpu2mZ//PsyrI99mp11Fr0OdaieFF0UeMvSk Ce5UzGz12pD+/siGaZTaS7b5UyU6NRmzcDYYvKZhIIshVu+qrpXUv+y6sUFiCBdYC2uM4Y8YL CfbMpiOQHfP9fJ0HsjGo8QhC6xkC1FVsDWDlsbjUsm5r7AqdM/vLrEngD712RQ6hjTCo1yJE/ 6JOpPIvINapgVpnd6LR0gROo5pIHQllOCzqdYrAOb0UUOFyYVZLFury55P1jOvxK+JstBia4E Cg4P8gaOjH8yEDl2CJ+kZfgPEnT6NPvBEygAuA== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org With randconfig build testing on arm64, we can run into a configuration that has CONFIG_OMAP_CONTROL_PHY=m and CONFIG_OMAP_USB2=y, which in turn causes a link failure: drivers/phy/ti/phy-omap-usb2.o: In function `omap_usb_phy_power': phy-omap-usb2.c:(.text+0x17c): undefined reference to `omap_control_phy_power' I could not come up with a good way to correctly describe the relation of the two symbols, but if we just select CONFIG_OMAP_CONTROL_PHY during compile testing, we can no longer run into the broken configuration. Fixes: 6777cee3a872 ("phy: ti: usb2: Add support for AM654 USB2 PHY") Signed-off-by: Arnd Bergmann --- drivers/phy/ti/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.20.0 diff --git a/drivers/phy/ti/Kconfig b/drivers/phy/ti/Kconfig index 103efc456a12..022ac16f626c 100644 --- a/drivers/phy/ti/Kconfig +++ b/drivers/phy/ti/Kconfig @@ -37,7 +37,7 @@ config OMAP_USB2 depends on USB_SUPPORT select GENERIC_PHY select USB_PHY - select OMAP_CONTROL_PHY if ARCH_OMAP2PLUS + select OMAP_CONTROL_PHY if ARCH_OMAP2PLUS || COMPILE_TEST help Enable this to support the transceiver that is part of SOC. This driver takes care of all the PHY functionality apart from comparator. From patchwork Mon Mar 4 20:23:58 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 159603 Delivered-To: patch@linaro.org Received: by 2002:a02:5cc1:0:0:0:0:0 with SMTP id w62csp4176739jad; Mon, 4 Mar 2019 12:24:44 -0800 (PST) X-Google-Smtp-Source: APXvYqzP1irrDgjrUtKuAhfKAMgTvG9JWD6zWg240Z72PGZXi6IrZ+bgmkg9y4KLK6owrtwrhgxq X-Received: by 2002:aa7:930b:: with SMTP id 11mr13428799pfj.49.1551731084790; Mon, 04 Mar 2019 12:24:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551731084; cv=none; d=google.com; s=arc-20160816; b=fd/8fFiYI38iau2WmnPX3A+VIo6q9xSGi0kHIMQdKhHrIUS5RII1qvTgKmLkFlJKcr 8BwRYmBBF8UqhOql8FopBmfwDJQOpLFQcdDOi+C7TmtceWR3UREzMwlHJMIecMT0MHgR OkMMcM9bIAkEJShHrPLaY4fjtUQMQUtAh5TGikKtaryyzcHBHQz/4b272d/D4/wqf0ud Dn8C7ZKoAuS4A37KTpo4keY97QMZ3nVx8QGAqNty89rr08ov4o2tJjGF5irb0g3ePrTx IhXhGHq6BAykKLxbGbF2lOjF5OuIIY9TyeJNE2wVdP4yjl2BGOmdZxpoWYHbCMFKVuQm 02ig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=3Ilx5YtPV8jHO/SEZOhtxX8gaySEXh9tkHEgSNK48AY=; b=jsXq+0p31fWFGH9Gnp73omOFAw0fSwQk5YErBhDKRzlhyhneM8tdYZsZ3CMBDz4Spu bZhXleibxoCGLqYi+Oe1UuKrPaVxHbnyA0Iv9dIV2Ie0MPMKxnoJlZ0cSuuYIyLcjTDt wK0B2NW2db4CpufTWYe6QnknlSI9/jMSTi7gKZPGD4Dp4GvRc4Zi53QPuQp8ZPl6PcHS OiEEN5bpsNLQkugNRgpjEZnYOo20WEUDpKEnLKkqFmqEnsf3qERZXHdQ9FxZZRIb/CR9 eJLB4slJSBdvbI+a9VkehWrtgd1lup4WPLBBtciRlJvuT7OVqIf5iPOmIz5264d8molM iMTw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id cv2si6814837plb.192.2019.03.04.12.24.44; Mon, 04 Mar 2019 12:24:44 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726630AbfCDUYn (ORCPT + 31 others); Mon, 4 Mar 2019 15:24:43 -0500 Received: from mout.kundenserver.de ([212.227.17.24]:43425 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726095AbfCDUYm (ORCPT ); Mon, 4 Mar 2019 15:24:42 -0500 Received: from wuerfel.lan ([109.192.41.194]) by mrelayeu.kundenserver.de (mreue107 [212.227.15.145]) with ESMTPA (Nemesis) id 1Mgw7n-1hS0A20zVd-00hOO7; Mon, 04 Mar 2019 21:24:35 +0100 From: Arnd Bergmann To: Kishon Vijay Abraham I , Tony Lindgren , Rob Herring , Arnd Bergmann Cc: linux-kernel@vger.kernel.org Subject: [PATCH 3/3] phy: mapphone-mdm6600: add gpiolib dependency Date: Mon, 4 Mar 2019 21:23:58 +0100 Message-Id: <20190304202406.1716350-3-arnd@arndb.de> X-Mailer: git-send-email 2.20.0 In-Reply-To: <20190304202406.1716350-1-arnd@arndb.de> References: <20190304202406.1716350-1-arnd@arndb.de> MIME-Version: 1.0 X-Provags-ID: V03:K1:dSwZJHcC1C9MpQ1yOPIGgBeO4Z6CAh/IO3/w2kOYJZGxsrQKV67 6Y9krjnXvOMr/0HEWg+0upmkgonXmbakzHRlP0vGGbPKoM0tuAcYlsYbnrbJC3LnDD98Wfw zHCv2GXmucNFhu91BPZrK28QaeSUyxw6JZBiRkQiJNiyqu86G2IBgRuTucX6dPOGVEqlAxn GSshz6dW5X54fHSQryy0w== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1; V03:K0:GlHpxjsHNeY=:f3W5jd0yaxbKyUmLvaf/HW s2TDzhrLSp9uL7paKbb7TA5Nqz/zVsQfBBkP6l4Ya5AfFdExBe0sIgLK/QrGXZaeQj+b7fOWp pTJocnjto6qAmAhQqJtcUGLDjyjnPDL5NtAPK3nEnFMiu/H12n1SFNgZbD5LlSHsmJJ9hjOI4 H5mgyVXMG/JxHXGqNtG62Ddv3gNP7UfhyFHKdpcXlBanMK8D/5XmeyPhGzPcexULFqqfYCAec umRuoslU/pYjc3uEUKcbEqYkfOSfCvfccz8c/Ru5yLlz3CO2uf5RkWX4e95GsGw5ezO7hIYBC GNKriWxDzCppIbL3HqmHYagn3MdGbIaNRLxIm8z/ElO6mEQg6XyjFNon8K9v22r/3esDvjczM 3xESmedw7KQ6BSon/Tk7WnlpOwAGRjvZbFkD4s6To0g9cbYBiywVlXOEkVRBmZT+tm+H/IUBm 2iaMnr8B5fegexlwPg9ySkcTUAt7VjUX8RC7Si7gP2VKDdXyt7bUKS6qHHzDA4qz/WrJOelvS qiEazxkRrzPzUL9jOzPtu//5w2cypVQFwI9m7fxTogVycfuDDdFzCld5FXnZ+r64caKWMfW7H a2oqWcG6QnDnc/LmeSAiUlaKhy1Zo37hsuptKUIAkSdy7ALZV4blIg+hFfK3FwxXHvavU8Ozr LNKhl9Lhmm3kKyc3EikMHrQnBKqSc/gF7iBxCYJ0pwSMECAyUDaY+h0p+YMJ6Tf2z9s8dP9kJ dFr+j/TE1j74y1rDRrjX+bMZEHsfPbQpVYJY0A== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org gcc points out that when CONFIG_GPIOLIB is disabled, gpiod_get_array_value_cansleep() returns 0 but fails to set its output: drivers/phy/motorola/phy-mapphone-mdm6600.c: In function 'phy_mdm6600_status': drivers/phy/motorola/phy-mapphone-mdm6600.c:220:24: error: 'values[0]' is used uninitialized in this function [-Werror=uninitialized] This could be fixed more generally in gpiolib by returning a failure code, but for this specific case, the easier workaround is to add a gpiolib dependency. Fixes: 5d1ebbda0318 ("phy: mapphone-mdm6600: Add USB PHY driver for MDM6600 on Droid 4") Signed-off-by: Arnd Bergmann --- drivers/phy/motorola/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.20.0 Acked-by: Tony Lindgren diff --git a/drivers/phy/motorola/Kconfig b/drivers/phy/motorola/Kconfig index 82651524ffb9..718f8729701d 100644 --- a/drivers/phy/motorola/Kconfig +++ b/drivers/phy/motorola/Kconfig @@ -13,7 +13,7 @@ config PHY_CPCAP_USB config PHY_MAPPHONE_MDM6600 tristate "Motorola Mapphone MDM6600 modem USB PHY driver" - depends on OF && USB_SUPPORT + depends on OF && USB_SUPPORT && GPIOLIB select GENERIC_PHY help Enable this for MDM6600 USB modem to work on Motorola phones