From patchwork Tue Nov 1 05:28:41 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ricardo Ribalda X-Patchwork-Id: 620759 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94095FA373D for ; Tue, 1 Nov 2022 05:28:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229835AbiKAF26 (ORCPT ); Tue, 1 Nov 2022 01:28:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49744 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229766AbiKAF25 (ORCPT ); Tue, 1 Nov 2022 01:28:57 -0400 Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [IPv6:2a00:1450:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3BDA425C3 for ; Mon, 31 Oct 2022 22:28:56 -0700 (PDT) Received: by mail-ed1-x531.google.com with SMTP id i21so20334903edj.10 for ; Mon, 31 Oct 2022 22:28:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=B4nRfPUFH4kRVISRtuRHDVjH66/Est6HwL+PfPdOnJw=; b=gHsVqSSXbjlfgoXdIUngrHxYLJiDMWrgDU8eRfrsl9olc2PPXsQSKZxrUid+Jg0yse JyPJxnCf+r3nh7bt9neMyolBdj71sMEJ8wCKt5svEZ+1JCUCSYXRq/fWpBZ0OdPOlxD7 POAslB5zxfsreOUhymZtQHX7IhhorIA1nAeKw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=B4nRfPUFH4kRVISRtuRHDVjH66/Est6HwL+PfPdOnJw=; b=yfRc1jTK17YxVhu0bdBtF8Hnch3Jd1/r2p8zaRLcXAf2tZY0Pa/1YwZRec4NOtxf20 XDc/fpiC4VuxqV3VziztUrDc7EoqM+VRl7AYT8DORkWjnwNZZrZCZXDfz5ExsmrsS09L 8NxJ5I6uiWNLd1W1oMv44e0qgDCyL/opOHtrxkJ4f2Yc1TpWYmf1YOSvqsJnaJHCfOaq e8+ZZpd6sXFGFPgAyOtDzQhc9om+213/n7H1QwnHtAukArt73VLFX1luXwYIhFfms6j9 d2DBVt6bZvvVPKbW2ZfpGzWhOAFG3Tj6GE/P1f9t/J1l/bDXdF0MYtfuYg5aBpdNFWlY XdKw== X-Gm-Message-State: ACrzQf1LKJbuZWflv6L2FY8Oj0l7WnaE+bIF2LlUyLkFQ7d9eD+k1JQS h1y7/tjt6ipuC/tPsvG988fqAw== X-Google-Smtp-Source: AMsMyM6PYFG0XOM1w5cDima8wlXSsT9qCj5+c6xJQsms50vzslJLn24hxhNEfiecg4AYNGljc0pWhQ== X-Received: by 2002:a50:ec0a:0:b0:461:c0ca:a0bc with SMTP id g10-20020a50ec0a000000b00461c0caa0bcmr17301489edr.306.1667280534869; Mon, 31 Oct 2022 22:28:54 -0700 (PDT) Received: from alco.roam.corp.google.com (80.71.134.83.ipv4.parknet.dk. [80.71.134.83]) by smtp.gmail.com with ESMTPSA id qo14-20020a170907874e00b0078d3f96d293sm3797074ejc.30.2022.10.31.22.28.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Oct 2022 22:28:54 -0700 (PDT) From: Ricardo Ribalda Date: Tue, 01 Nov 2022 06:28:41 +0100 Subject: [PATCH v1 1/1] media: uvcvideo: Limit power line control for Acer EasyCamera MIME-Version: 1.0 Message-Id: <20221101-easycam-v1-1-71d6409963da@chromium.org> References: <20221101-easycam-v1-0-71d6409963da@chromium.org> In-Reply-To: <20221101-easycam-v1-0-71d6409963da@chromium.org> To: Mauro Carvalho Chehab , Laurent Pinchart Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Ricardo Ribalda X-Mailer: b4 0.11.0-dev-d93f8 X-Developer-Signature: v=1; a=openpgp-sha256; l=1613; i=ribalda@chromium.org; h=from:subject:message-id; bh=IWHoN9NcN24qlf5Cq+y5YFKN7LwR/YB5HAIbEBiKT4E=; b=owEBbQKS/ZANAwAKAdE30T7POsSIAcsmYgBjYK6UwGhjegFV+GvO9lFpwxBZQH3gR3z6dq2J+6M8 c6PFtoeJAjMEAAEKAB0WIQREDzjr+/4oCDLSsx7RN9E+zzrEiAUCY2CulAAKCRDRN9E+zzrEiKA9D/ 9rMhOTvKgnupcqeU24qBBLnI3lRXrp4RMDJPLcWdb4MHNHbo8a5ukBkw6PYR9Ef0h4sGcLDF2e2Bg5 iZ8VIxjK/zZxWChS5TYya33kSDW/MjCjslQnaiAu4118f0kzt55V4fThyMuvTuBRYSWRWEClCzvBdq 9ajNGIjaMo8M6r0oI1S1cmNXNqB8h8oKBkWMEVY+Pz8ek8AhrQURzHROqHWPQz0NmzKWIES06jmioo m/kUQSjZgZkt+k8cIbTQD/L9abxGNzbRHRF7opZYUu5bTuHGx9OYY8Bfqu4m8QFe7s1akli/E1qxXm US8JHHM3sFg82+Gk7HCnUlr1Pg90Gq9Gs7yM/0pkQX6vbpsjgFdURzN87YdLYM+S+AkmfulySFJUTm pthn2O+gxkTOQ8U5I938uhwBrcLTVyutYza5tLYqMZDiqN5xuFh+Z5TCZ498jgLC1Hg1nclJt8ogf5 KxIxKZhGmvMMeSiSnSrBCddm2g1/jtTXhMmLiAmYolw3zeIAvJ/sN8MOwLjnJVSIjP6Q3QZXIYj5CE zjFL3p0lFcfHfrLiX6S0ATvkQEB6+ntkeISO2GL1uHumbmvoZh2JkafXdRzArTRCIg6uCkDaRHE/mT HW+tssGHeIwEmPsT0Bo874k7AEKi/iwQXLfqMnw04dLyieI4KjLyrSMWIRQA== X-Developer-Key: i=ribalda@chromium.org; a=openpgp; fpr=9EC3BB66E2FC129A6F90B39556A0D81F9F782DA9 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org The device does not implement the power line control correctly. Add a corresponding control mapping override. Bus 003 Device 002: ID 5986:1180 Acer, Inc EasyCamera Device Descriptor: bLength 18 bDescriptorType 1 bcdUSB 2.00 bDeviceClass 239 Miscellaneous Device bDeviceSubClass 2 bDeviceProtocol 1 Interface Association bMaxPacketSize0 64 idVendor 0x5986 Acer, Inc idProduct 0x1180 bcdDevice 56.04 iManufacturer 3 Bison iProduct 1 EasyCamera iSerial 2 bNumConfigurations 1 Signed-off-by: Ricardo Ribalda Reviewed-by: Sergey Senozhatsky diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c index 215fb483efb0..cca3012c8912 100644 --- a/drivers/media/usb/uvc/uvc_driver.c +++ b/drivers/media/usb/uvc/uvc_driver.c @@ -2994,6 +2994,15 @@ static const struct usb_device_id uvc_ids[] = { .bInterfaceSubClass = 1, .bInterfaceProtocol = 0, .driver_info = (kernel_ulong_t)&uvc_ctrl_power_line_limited }, + /* Acer EasyCamera */ + { .match_flags = USB_DEVICE_ID_MATCH_DEVICE + | USB_DEVICE_ID_MATCH_INT_INFO, + .idVendor = 0x5986, + .idProduct = 0x1180, + .bInterfaceClass = USB_CLASS_VIDEO, + .bInterfaceSubClass = 1, + .bInterfaceProtocol = 0, + .driver_info = (kernel_ulong_t)&uvc_ctrl_power_line_limited }, /* Intel RealSense D4M */ { .match_flags = USB_DEVICE_ID_MATCH_DEVICE | USB_DEVICE_ID_MATCH_INT_INFO,