From patchwork Thu Jun 16 11:38:22 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 102183 Delivered-To: patch@linaro.org Received: by 10.140.28.4 with SMTP id 4csp212178qgy; Thu, 16 Jun 2016 04:37:36 -0700 (PDT) X-Received: by 10.98.71.15 with SMTP id u15mr4585568pfa.69.1466077056878; Thu, 16 Jun 2016 04:37:36 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w14si5643120pfa.187.2016.06.16.04.37.36; Thu, 16 Jun 2016 04:37:36 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of netdev-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of netdev-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754130AbcFPLhe (ORCPT + 4 others); Thu, 16 Jun 2016 07:37:34 -0400 Received: from mout.kundenserver.de ([217.72.192.73]:60332 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753285AbcFPLhd (ORCPT ); Thu, 16 Jun 2016 07:37:33 -0400 Received: from wuerfel.lan. ([78.42.132.4]) by mrelayeu.kundenserver.de (mreue101) with ESMTPA (Nemesis) id 0Lx70L-1bT9js17ST-016d27; Thu, 16 Jun 2016 13:37:21 +0200 From: Arnd Bergmann To: Dept-GELinuxNICDev@qlogic.com Cc: Arnd Bergmann , "David S. Miller" , Rajesh Borundia , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/5] net: qlcnic: don't set unused function argument Date: Thu, 16 Jun 2016 13:38:22 +0200 Message-Id: <20160616113831.4108439-2-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 In-Reply-To: <20160616113831.4108439-1-arnd@arndb.de> References: <20160616113831.4108439-1-arnd@arndb.de> X-Provags-ID: V03:K0:lhILXNWMJKsYCa2ANUg53jKj0VAvwkH40DF1omAIMafkjKhWRDG lvYEjq45qLgJevVq9zEg9st8QctAcDvSMY+cifuWxpAhIikCVI3YbhX75PR1IU5lG3aYEZt zxDxYaNJ2ZO1TbRasICiZBhYJ8QZhm+eMsjLdNkwSyjCI/dHGpFeEmfGw0XH5I0aBaiAl0p 26Dg37oj0SHt8jtvtQQhw== X-UI-Out-Filterresults: notjunk:1; V01:K0:w+gH8KYE93Q=:tB8esz/QF5AUU99n41c0a2 61rio5wN1WjnL+lqwJHohp9zIk6Rh5WcBfmI1ydC8OjSMoInzUt3BuA/7Z0t3TJDWEJgqMvZC VMzUXS9axfaNmZsVqxCCQ5wn4m1jE4l29j9fOoHF5eZzOj2rXO+2TrWgZrt4HqbF2ZPqnSlQv wyniC+H/zx1HxxJ/rPRbL9iue2uXzbaJcdkAk0JPZcYrA/CSoqMxbDtB0vasYVpO7L8YiGmBG 6VysXVJQPTMl0KsgSXPGBAkFj93kGo4jYUqVX9VkUMdQfkL+I+/09qagqAmSuguIErCDKousv 1lYb33qy886ri/wEFmhrBXRJRn8cTwgM0EqHApJ/w6vUDXyXNtqOBgjGdJqp/7SG/hIy4WX72 aMoxOVoR8EQamkMwXnnE56MJ7Ra7+NSMBq2GSFfVNuHp76wge8UFhnP7IS/IBHCrqUGOCzsv5 xxqg2dKA98QMNAE1IRGJBUmEkotYn48G5JXtwGq8g6PgsolT+cSxrlzSk22j/IkYde91G5CW9 XY3kVPIbLa0qlqAeLKA3vVSbixfeYZecVcs9GByscua06V83j8zJAEptALNu5mnPIVWL5LGDu og6betVkt+686W5WCqzqLO/7FrLOqhxumGpwm/qWjp/UN0aIFnFmJ2woEXwMd/qOfv+eRKSjS DpPpt+H6dQodpAbwEnBpUsGioNMJy7/tk6HqkvuqZy+l19QdVRh2pjKSXDrFgG5DZ250= Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org We get a warning for qlcnic_83xx_get_mac_address when building with "make W=1": drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c: In function 'qlcnic_83xx_get_mac_address': drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c:2156:8: error: parameter 'function' set but not used [-Werror=unused-but-set-parameter] Clearly this is harmless, but there is also no point for setting the variable, so we can simply remove the assignment. Signed-off-by: Arnd Bergmann --- drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c | 1 - 1 file changed, 1 deletion(-) -- 2.9.0 diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c index f9640d5ce6ba..bdbcd2b088a0 100644 --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c @@ -2159,7 +2159,6 @@ int qlcnic_83xx_get_mac_address(struct qlcnic_adapter *adapter, u8 *mac, struct qlcnic_cmd_args cmd; u32 mac_low, mac_high; - function = 0; err = qlcnic_alloc_mbx_args(&cmd, adapter, QLCNIC_CMD_MAC_ADDRESS); if (err) return err; From patchwork Thu Jun 16 11:38:23 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 102182 Delivered-To: patch@linaro.org Received: by 10.140.28.4 with SMTP id 4csp212336qgy; Thu, 16 Jun 2016 04:38:03 -0700 (PDT) X-Received: by 10.67.7.199 with SMTP id de7mr4637074pad.94.1466077080643; Thu, 16 Jun 2016 04:38:00 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 198si5670551pfx.22.2016.06.16.04.38.00; Thu, 16 Jun 2016 04:38:00 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of netdev-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of netdev-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754216AbcFPLhp (ORCPT + 4 others); Thu, 16 Jun 2016 07:37:45 -0400 Received: from mout.kundenserver.de ([217.72.192.73]:60446 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753285AbcFPLhl (ORCPT ); Thu, 16 Jun 2016 07:37:41 -0400 Received: from wuerfel.lan. ([78.42.132.4]) by mrelayeu.kundenserver.de (mreue101) with ESMTPA (Nemesis) id 0LuMNz-1bN5ip2Aid-011fkH; Thu, 16 Jun 2016 13:37:36 +0200 From: Arnd Bergmann To: Samuel Chessman Cc: Arnd Bergmann , "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/5] net: tlan: don't set unused function argument Date: Thu, 16 Jun 2016 13:38:23 +0200 Message-Id: <20160616113831.4108439-3-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 In-Reply-To: <20160616113831.4108439-1-arnd@arndb.de> References: <20160616113831.4108439-1-arnd@arndb.de> X-Provags-ID: V03:K0:KMSw8OYgy/ZqSuM8UInl93U1vDnxRYkOuwGSidmgasbV8PA/wCX w7ReL9F32s3ofUt7BiFX1ZAspy9bUgvLSKQWzLWQuD3LUCQq6+S2ElEGWNBZho1qq0xo+wq 5XsUkFcj9Tg0/FH/493J3lWDmuaMCWojUEpDgWl9y6/AoYTsKtlcBBvTcJEMyXD2CfNn+CI KXei0mDYOCdE6XvWgcmXQ== X-UI-Out-Filterresults: notjunk:1; V01:K0:PlFxtKDAvXw=:saqhUJYnVw2mHFCoX6VvQh fe1GQQxMXf58yrDCCFdJkZEnbWDqdbGETP8ZGmIJ+5mknXhaHkM7KLgA6qRglz2K5VhKG83Au CYmxYj013fp8qq4bQcaibRw6IpTxwqsyUlIbxQhGkeLHrI3CmEfOSZm18faH/kGv0COJ8VxA4 9m1LnOt3QgRNApGH2H+pMSDNPYMxnO82yUIz5uRshRkNvke4Q9pS9+wyAdUpRBfRfhsQ1dDcj pIBsRs88c0n0LnOHo9eW6FJPnKwMb/+ngeNiybFxSwTMMRSuyID5KSTSSwP8rojstYaAtPlQ2 dRe/fbsg61WlK7yrIXCKY7jnz6pvnVR4PhZ5/Ipnzn++swYt079blj9yqL3Wy9UzP4L1k3HST cgw56UEhDKiRfcnNRD09o7DCuLYaX1+yFPqTXAk0yWLVoZm2BBU8eO1RuJgWDKs/OQk9LyuBC uWaFSoOVPLIZMhbM2oq+bBlNsXxDpAEJKF8xkukVPblu//zVgeznjL8qnRNsXsPixuSaGQwPp mCj+jxTZuvrwL6o06vpagpVvMPzMG8w8s1TG1FGpj71S6IhIz+ZNZvMAyqxvb2iqAXXwfZfwY v/unKPY3aI3kyzzKgzRrq5Z1aLJcYVaJdrSJXcw+9hJuV+ouW1D7QeqQcc8Tx4GWmWTONXzoF xBnCY2YZQqP0BvitFIHuPLg8itmZhksOUUQaKFrf9icR7dlcvwCVI8/h6pYTylxJQFWg= Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org We get a warning for tlan_handle_tx_eoc when building with "make W=1" drivers/net/ethernet/ti/tlan.c: In function 'tlan_handle_tx_eoc': drivers/net/ethernet/ti/tlan.c:1647:59: error: parameter 'host_int' set but not used [-Werror=unused-but-set-parameter] static u32 tlan_handle_tx_eoc(struct net_device *dev, u16 host_int) This is harmless, but removing the unused assignment lets us avoid the warning with no downside. Signed-off-by: Arnd Bergmann --- drivers/net/ethernet/ti/tlan.c | 1 - 1 file changed, 1 deletion(-) -- 2.9.0 diff --git a/drivers/net/ethernet/ti/tlan.c b/drivers/net/ethernet/ti/tlan.c index 561703317312..ece0ea0f6b38 100644 --- a/drivers/net/ethernet/ti/tlan.c +++ b/drivers/net/ethernet/ti/tlan.c @@ -1651,7 +1651,6 @@ static u32 tlan_handle_tx_eoc(struct net_device *dev, u16 host_int) dma_addr_t head_list_phys; u32 ack = 1; - host_int = 0; if (priv->tlan_rev < 0x30) { TLAN_DBG(TLAN_DEBUG_TX, "TRANSMIT: handling TX EOC (Head=%d Tail=%d) -- IRQ\n",