From patchwork Mon Mar 25 13:54:30 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 161113 Delivered-To: patch@linaro.org Received: by 2002:a02:c6d8:0:0:0:0:0 with SMTP id r24csp4000693jan; Mon, 25 Mar 2019 06:54:55 -0700 (PDT) X-Google-Smtp-Source: APXvYqwyuonG26DYBITppM7xPB/0k3q4RM+ZSsRdI/L9xSiTKLEgwyoNpUMpmhpYFJzmv7A436Qu X-Received: by 2002:a62:1f86:: with SMTP id l6mr24126380pfj.138.1553522095191; Mon, 25 Mar 2019 06:54:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553522095; cv=none; d=google.com; s=arc-20160816; b=B8/NvELarXECHGK6AqCcDwA6I5OIxkD+b6ZOD9d/4nP3lrnuoA1LKZxrGBpG8PQr62 7t0TWIDJUieM8TQq75lwKxi+anYtEgdieGClnULairfhrbi3aabQys4CTCVtzqT6fWHA tVIqvLEOET3QFDJ1Qm2aqpgJ8nQk8ST3Wy8jptNKaQmLnwUeoxN40R/IMigw4f3F5HjV IKdVPQv+eCHAww/TwyBvOsRUuLSDGoap9YyI/l8vaLx3S7KaCRvDzExXDI0mbtVO+Etg kpxOxrvrIwKN+NSkgICg7C2ntwA/l2KMxCYw/UL6Hgtkr+bYEIneScSaMC4i5X78FIgS yEBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=7LXBfsZKO0SX4doOybCUwMrkVZkNhLaZ3gvc/Xk3eGs=; b=Sc7RmcTnGAcd+xth0bbXsyVxS4Ls4yGAF0GHyrFuM/NFJqTTMtqA+jXl0tUnrZGNjH ZXSrU0VLfSsR6DQr11kc20m5g2Za9NH0zZIQFrCVwgJVXqIATrgHBIGjlcbyCzPsm9oF xliJZt6M/UKX1gfq2v+LKbF/QSreUIExKDrb2wrp/m2kg2e6NP/OavFl7GgoWvi4O6pU IwqVjxARBFydjhjH4LLS6MVfxwNuDUfXY7crMrZJLoL9OXLg+880Sxlh38SKpcVB/Jd1 BiX+eTKcfiVqT+RjYZXAkO9SWVwWXbdNj6dsGcuw/lHogLTJLi4ruCXloSmEl2F3v14I PFaQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b31si14943814plb.351.2019.03.25.06.54.54; Mon, 25 Mar 2019 06:54:55 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729273AbfCYNyw (ORCPT + 31 others); Mon, 25 Mar 2019 09:54:52 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:57297 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726136AbfCYNyw (ORCPT ); Mon, 25 Mar 2019 09:54:52 -0400 Received: from wuerfel.lan ([149.172.19.189]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.129]) with ESMTPA (Nemesis) id 1MEFnR-1hIcf10MWD-00AI1A; Mon, 25 Mar 2019 14:54:42 +0100 From: Arnd Bergmann To: Chunfeng Yun , Greg Kroah-Hartman Cc: Arnd Bergmann , Felipe Balbi , linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] usb: mtu3: fix EXTCON dependency Date: Mon, 25 Mar 2019 14:54:30 +0100 Message-Id: <20190325135440.2166315-1-arnd@arndb.de> X-Mailer: git-send-email 2.20.0 MIME-Version: 1.0 X-Provags-ID: V03:K1:Zbb7MMeGdeb863Dkkf0uRINDNXGjdVZvMW1rsAu4DzSl+dH8DM1 7JmYSZTemXkBoWkf+P81jpmFEFmA76GMyZvvgd3MS70/0DNYHHT37c+I6jpjlrNQyfPSu0K SC800mUXVa4iTiHPWbm4va3Ul7XTkk44GlVwMJypx8yUgP0pm6eJKfPS4zVBeVu/e/fGzKn f/Gl9a9c09yPFKTZQaJyw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1; V03:K0:t13HCCPBbyg=:sa7EMgEwsETT0X2DLSIpNq NaC7Gu7zoO+7XL9dnCo2Uj8/PaaV64CeXaGkSE6mzHXv+He0+bpWYC4+NUX2hwMIHJQdTOlOY 3Zg81F8jeCi1UIgGNiS7NQiJ6En1Wg/GGksM0tw7dg++aBCjXZok8j0Ngt5gDAfxfOvLXmSwE yo5TEdqePTjmNHKo6c+0Bw94R7tIlLv4tprGzoDZERhoGMwGZRZZj3/4Kr/tV9BM2PVOJZDGk 1Sja/l9WpLVgvpcxkF7TrlhWI6P7vjHe3dquYMI6w1EiunjJGjH83ex2UQ0zeWZzP+Y3Tz33G /Fj/rpFFbQ5W1n2jF99j1WF1IFmBk3q28MqgXkNCX5OXULQKV5AlIjVD+3HwTgEUme1NUoML0 sVqg9zvlMxVM76QzOisk8HX3G98Qpeuav1FELap1lncpeGEk9ZsMHSomkdfiN2Q3Hy8CX+SNg KS6M0nQ4yY0p5Iv8lEhWfM3soR3Be1kQrb1w+D3b2adlFMVunquAtjMq95PEFj+aamaG6Yvf/ Nj8IqTOe3CY5l/do59wG969fZCy2En7GlTHCfDW86kCu9aClR4GJx6fKAgvpZYx4mq+ZznZ2U eE2/EY26ylxTZlnMrQzw0rCSxIMN9Z52bLVlYolGVFnF4MJgxDOFvIoruQVYEimrdcRVmCgz7 tAOMh5BYumhNfuIvRoUnk2MfdYVaEzyscp3UfRB2XZaP2bePFyvH/ffQH4UuiWZio7F6E27qT ZFEMAsSaHi/+lKg2vntF+t+rpGMwW5DpbDVRsg== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When EXTCON is a loadable module, mtu3 fails to link as built-in: drivers/usb/mtu3/mtu3_plat.o: In function `mtu3_probe': mtu3_plat.c:(.text+0x690): undefined reference to `extcon_get_edev_by_phandle' Add a Kconfig dependency to force mtu3 also to be a loadable module if extconn is, but still allow it to be built without extcon. Fixes: d0ed062a8b75 ("usb: mtu3: dual-role mode support") Signed-off-by: Arnd Bergmann --- drivers/usb/mtu3/Kconfig | 1 + 1 file changed, 1 insertion(+) -- 2.20.0 Tested-by: Chunfeng Yun diff --git a/drivers/usb/mtu3/Kconfig b/drivers/usb/mtu3/Kconfig index bcc23486c4ed..928c2cd6fc00 100644 --- a/drivers/usb/mtu3/Kconfig +++ b/drivers/usb/mtu3/Kconfig @@ -6,6 +6,7 @@ config USB_MTU3 tristate "MediaTek USB3 Dual Role controller" depends on USB || USB_GADGET depends on ARCH_MEDIATEK || COMPILE_TEST + depends on EXTCON || !EXTCON select USB_XHCI_MTK if USB_SUPPORT && USB_XHCI_HCD help Say Y or M here if your system runs on MediaTek SoCs with