From patchwork Wed Apr 3 07:47:55 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "\(Exiting\) Baolin Wang" X-Patchwork-Id: 161681 Delivered-To: patch@linaro.org Received: by 2002:a02:c6d8:0:0:0:0:0 with SMTP id r24csp13609jan; Wed, 3 Apr 2019 00:48:37 -0700 (PDT) X-Google-Smtp-Source: APXvYqy6tp68uHPX+3K0RX5JZPANbvfHhFLFK/qBJ5HXbcN71OGmKFUb9KY/PtSlhjqxHkl5u6Yq X-Received: by 2002:a17:902:2ba7:: with SMTP id l36mr75816800plb.237.1554277717280; Wed, 03 Apr 2019 00:48:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554277717; cv=none; d=google.com; s=arc-20160816; b=RqLJhxrxhUTc4fVY7hpd2f8wgnGH6qo1e/B+2Zs+PVDqx+v5D8JjkMtbR6ylm1Qo4d ERrG5aAtvNJX8i75F25RTA5Ro368GoRuqNI2qWf2N7OSNP6sZnbO1mbtYGa7fZSmBX44 /vZcwfVYq/ypymDVfpDb4kUU0Xnb8j/0PPHB/ye5IiYtzxZC4jfF6BE3hxzJ36ZV/v5o pueqr5WVHcO4QGN8FfSo8TmE84Ceep93HmmngrtCjduQc96NH/5+7F/Q6Wi3c+MoAULT JOqggr56gl2WAcUf7yYP4DmkuH0+7xwTR519ljRsamLtpoddG1YStpHeNNajdAHzwnfu GrxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature; bh=wIrhdib+AH7V7mv416SXk4Mr89Zd0kNoPOL6hTxLt3Q=; b=08DSWjd28anCXLXkAhPQW92+Y9VjLFhqd7SUDouzMoZIR50f1EPbgNu/yTgMELBJf9 KbNGQlC8nu5uxNehiD07PG02xpTzMAfHzcn/+hd39QqJ8iU0L1GRBeT7wO0lOfpI7bEY O7IB5cMCTYC1Bd5KofXPrAQbCcdfc3ldF5JTCLxPeCH0BlhalqxzD199jW+7QJzhRm4O og94DD0p5Bcj+x8mk8q7tloL5SLPCYUZH/KyafxhidVZULL9yAO6++MEyRNqRIp+CHVR PC2or2d1egq1dD5gYr01IMMsop2OHnlmzNXMRZNr9O9vCJHQ0lv10WZDaCr3xGDXdi8z eUow== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=EjSKI9RY; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a5si12799623pgt.393.2019.04.03.00.48.36; Wed, 03 Apr 2019 00:48:37 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=EjSKI9RY; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728673AbfDCHsg (ORCPT + 31 others); Wed, 3 Apr 2019 03:48:36 -0400 Received: from mail-pl1-f195.google.com ([209.85.214.195]:39228 "EHLO mail-pl1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726330AbfDCHsf (ORCPT ); Wed, 3 Apr 2019 03:48:35 -0400 Received: by mail-pl1-f195.google.com with SMTP id b65so7606852plb.6 for ; Wed, 03 Apr 2019 00:48:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=wIrhdib+AH7V7mv416SXk4Mr89Zd0kNoPOL6hTxLt3Q=; b=EjSKI9RYimvWRM16YkSc6LGvSzO22UKOs2T9S4A67k5/WXdFA988jWsej87Rpeo4fe zaLe/fyZhJpsLtgOyaodeYRv2/HWkv4YPZznsr4jWbmPIM0SigTBmgSUvcQg4GiEWZnL pV0SRXQ8JieuOYuhuAEIfuRaAv17e1Hqv9GFwejXKcub1xEqG/G5BSLZahWZ6enZ1iMB Ms36nG+zTIHIZQ1ApmyboAju1hEiZjq2zoI9U1bYd21A7qTbOAqtd/y1OJpllkF0cVXs GitkKqvIgH2KiV5S1Df0qV6UYKgoTIarAQExoENf48mnLBS+B2iacWm/lHeyQCTdzj2j NOkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=wIrhdib+AH7V7mv416SXk4Mr89Zd0kNoPOL6hTxLt3Q=; b=V95rLlY2USAwgiEYWOf98K8ODgOb7ntZTmWxnYKC1Z2sShmx+mnx91rGFssVw0BD1c PRLpz9dxmdyfbPgKEULI7twtx0KSx7uNd2aMKhOE4uHtXQw+5GKaM7mhs0MDrB1inH8U PcPFDGfQVtFBYRPVW6jp1x6yfWbja5Df+KAwsnnn73QTpDt+q7XPVRqXLsw6P18rGtQL Hmb6mMLD7uwOOROfJ+0fNAanGPj9mB58ttU9YEk/3Fq+Y5afWac2kG5H6Dwc7scP+Ghy msNIOuKHfv4b2d3VQ+Q8io9zkk5snO6tsHaH8Cw9iVAG/a4DCJti61cfaO0+KLHEML8J /zhw== X-Gm-Message-State: APjAAAXpJbb/n/ojfT9/9Ly3aJgmucjKXvNUjqNH2gQ3mteTTQ4W84n8 nLNGYwUthgZ8BpEbBq18kudWGYy0Q4dNkQ== X-Received: by 2002:a17:902:e20e:: with SMTP id ce14mr62067330plb.193.1554277714315; Wed, 03 Apr 2019 00:48:34 -0700 (PDT) Received: from ubuntu.localdomain ([147.50.13.10]) by smtp.gmail.com with ESMTPSA id i31sm30500995pgi.36.2019.04.03.00.48.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 03 Apr 2019 00:48:33 -0700 (PDT) From: Baolin Wang To: broonie@kernel.org, lgirdwood@gmail.com Cc: perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, baolin.wang@linaro.org, dan.carpenter@oracle.com Subject: [PATCH] ASoC: sprd: Fix the smatch warning Date: Wed, 3 Apr 2019 00:47:55 -0700 Message-Id: <811e491489b62624942dabd56f277b08784ef0f9.1554276741.git.baolin.wang@linaro.org> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Remove the unnecessary validation of the 'cstream' variable to fix below smatch warning: sprd_platform_compr_drain_notify() warn: variable dereferenced before check 'cstream' (see line 105) Reported-by: Dan Carpenter Signed-off-by: Baolin Wang --- sound/soc/sprd/sprd-pcm-compress.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) -- 1.9.1 diff --git a/sound/soc/sprd/sprd-pcm-compress.c b/sound/soc/sprd/sprd-pcm-compress.c index dc84257..424e983 100644 --- a/sound/soc/sprd/sprd-pcm-compress.c +++ b/sound/soc/sprd/sprd-pcm-compress.c @@ -107,8 +107,7 @@ static void sprd_platform_compr_drain_notify(void *arg) memset(stream->info_area, 0, sizeof(struct sprd_compr_playinfo)); - if (cstream) - snd_compr_drain_notify(cstream); + snd_compr_drain_notify(cstream); } static void sprd_platform_compr_dma_complete(void *data)