From patchwork Wed Jan 11 11:24:19 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arend van Spriel X-Patchwork-Id: 641638 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E0DDC54EBC for ; Wed, 11 Jan 2023 11:26:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231202AbjAKLZd (ORCPT ); Wed, 11 Jan 2023 06:25:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53906 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232249AbjAKLY0 (ORCPT ); Wed, 11 Jan 2023 06:24:26 -0500 Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7DF2810572 for ; Wed, 11 Jan 2023 03:24:25 -0800 (PST) Received: by mail-wm1-x32d.google.com with SMTP id i17-20020a05600c355100b003d99434b1cfso12389110wmq.1 for ; Wed, 11 Jan 2023 03:24:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=xgi+xV35s1658SXF/wiM9pQWDG1fOzMvKqO8WYCKbGY=; b=bUU2dVwg1a5cmzRPu+Y1FtWj590gynamZToy8ZbA0j2wwvQGCXH/uWxFqgP1ex7/3f aUjOpHSvVnKEtifiKEHePv2DLI5d97rycmKzjJx0azGR1eARC6dYo9CHjhnk0YtYrHVS BFzy5BjyHidL9xtH9ArZoEWANVOiSO0qlbIio= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=xgi+xV35s1658SXF/wiM9pQWDG1fOzMvKqO8WYCKbGY=; b=AmNmQiUn09DYRHQf9QtSLz5kGM/kR/uJtNrQyo6y6SElQ1dkqdyBBO0n1cuPSl2mLB jSsxkcZAjekmLxPdNLwxk55Va2zFdi94DJvySb6oHCWZrDgrNIE60vOZ2JnB90WpWXVM GArEVakNmiB7zX/aU6FfRzST/MOkDQPOb6s4sLslUs9Z/wCGBr17/mIa96EZMX5BqxJn eTfdh/C2QFAUvO638ic83a3vc9q3delU8PGHul6B2CyXTeFzkmzaPebABZ+w3HULLHUl tfHeVwClpDEewBY1kIoeJkA2ThENNuSdeXRO4VlamIQC5BjLRiyWVmsrKeyaHx3k3E4D +3ng== X-Gm-Message-State: AFqh2krr+t2pJtuOAgjrO51YQWJ8FIE9jyKriJJULnKzS1Uok1ficWYS uFLqPFqrR8PlajizoyZUko4yLv89i9gZHmZmZc/rQg== X-Google-Smtp-Source: AMrXdXuoYE+t6jN/hPnv2KBI3Bt389e/rN/0IGfA7cwNaVXGrWHm3MlNA2+Jym8dp12GSct3lJrSLQ== X-Received: by 2002:a05:600c:354a:b0:3d9:74b8:2d05 with SMTP id i10-20020a05600c354a00b003d974b82d05mr43789407wmq.40.1673436264070; Wed, 11 Jan 2023 03:24:24 -0800 (PST) Received: from bld-bun-02.bun.broadcom.com ([192.19.148.250]) by smtp.gmail.com with ESMTPSA id j30-20020a05600c1c1e00b003d9f14e9085sm10467997wms.17.2023.01.11.03.24.23 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 11 Jan 2023 03:24:23 -0800 (PST) From: Arend van Spriel To: Kalle Valo Cc: linux-wireless@vger.kernel.org, Arend van Spriel , chainofflowers , Christian Marillat Subject: [PATCH V2] wifi: brcmfmac: fix regression for Broadcom PCIe wifi devices Date: Wed, 11 Jan 2023 12:24:19 +0100 Message-Id: <20230111112419.24185-1-arend.vanspriel@broadcom.com> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org A sanity check was introduced considering maximum flowrings above 256 as insane and effectively aborting the device probe. This resulted in regression for number of users as the value turns out to be sane after all. Fixes: 2aca4f3734bd ("brcmfmac: return error when getting invalid max_flowrings from dongle") Reported-by: chainofflowers Link: https://lore.kernel.org/all/4781984.GXAFRqVoOG@luna/ Reported-by: Christian Marillat Link: https://bugzilla.kernel.org/show_bug.cgi?id=216894 Signed-off-by: Arend van Spriel --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c index ae57a9a3ab05..b67f6d0810b6 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c @@ -1228,7 +1228,7 @@ static int brcmf_pcie_init_ringbuffers(struct brcmf_pciedev_info *devinfo) BRCMF_NROF_H2D_COMMON_MSGRINGS; max_completionrings = BRCMF_NROF_D2H_COMMON_MSGRINGS; } - if (max_flowrings > 256) { + if (max_flowrings > 512) { brcmf_err(bus, "invalid max_flowrings(%d)\n", max_flowrings); return -EIO; }