From patchwork Tue Apr 16 12:25:32 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 162307 Delivered-To: patch@linaro.org Received: by 2002:a02:c6d8:0:0:0:0:0 with SMTP id r24csp4151422jan; Tue, 16 Apr 2019 05:25:48 -0700 (PDT) X-Google-Smtp-Source: APXvYqxtNm505EowUyEBfimcgrVOQ7O0GPT2EdeJ5bYP6HPlSMZElyu9Z8hEQgrNXhQx7v9CIKzf X-Received: by 2002:a62:1249:: with SMTP id a70mr81797368pfj.160.1555417548762; Tue, 16 Apr 2019 05:25:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555417548; cv=none; d=google.com; s=arc-20160816; b=tFwAUvJb+eWLmAWsjHlG10umj3GCfwZN6MHryC62Ne1SrEddIt9+M0uibQDhg7JN6I Rag5tCIdh/IbrISv2b0QqQN0JuogCOF7XWHeyw6hyRdLKe+X66eM8q6eSmSWAJRNqKul Dl6yBokDup9lwcx1rbt3nZC8hGLZyM2+54c4MhyL0W9T7pql256RTbpxTOJKqpW+pr3K VtDVsmXBCQIcPIhUlXb8bUN50uLxIeVOTvNN2vb6Jst+d7MUf1F9UkQIkkGJKsR8/VK7 BmbgGZGV1Qy3FUy+fOKfrGf0zMW29hmvSK7c1v9eXbMPkXKHusZczA2AVO+qMB4P5dPI mabg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=7nsJaYdyxwfgEFYdt+A75KEVmW5tBQPsHjlpLembhKo=; b=Xvh71tRJuhEY3aJYC5k+ZXk+bLUeTrvHKvkAn7mG0L9DiTN/7ytVRCwt0uiLM3mRP/ hS3nEEqcUI72kJJPZAZXBWLvtW7AFtBJQuH2xU/So5R6ME3GfiVUNdoJ1/u6u2AJeJ6D FMC7ayqo4xF1B9DjRV8zAFTopAfctlhINiBj9sx4faIFstRIiu/6fn1p9DI3JlX0E/6c cPqVVKQWdpFmvJnCEnpw+ipDSl1Mwu6BTymQMtYyti2gwia+I2U2I5fnVjdo8Cb72RR/ qY1gX8dmDcQ31D0uTzY6KCpIHqlRiLxkja3VHRe2P/8p4vkBnzdiFEig5z72SM2rN+tP ceAQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g136si51779286pfb.29.2019.04.16.05.25.48; Tue, 16 Apr 2019 05:25:48 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728630AbfDPMZr (ORCPT + 30 others); Tue, 16 Apr 2019 08:25:47 -0400 Received: from mout.kundenserver.de ([217.72.192.75]:55245 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726241AbfDPMZq (ORCPT ); Tue, 16 Apr 2019 08:25:46 -0400 Received: from threadripper.lan ([149.172.19.189]) by mrelayeu.kundenserver.de (mreue109 [212.227.15.145]) with ESMTPA (Nemesis) id 1MBUuP-1h8ymA11DD-00Cvb6; Tue, 16 Apr 2019 14:25:41 +0200 From: Arnd Bergmann To: Felipe Balbi , Greg Kroah-Hartman Cc: Arnd Bergmann , Dmitry Osipenko , Anders Roxell , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] usb: gadget: fsl: fix link error against usb-gadget module Date: Tue, 16 Apr 2019 14:25:32 +0200 Message-Id: <20190416122540.3222314-1-arnd@arndb.de> X-Mailer: git-send-email 2.20.0 MIME-Version: 1.0 X-Provags-ID: V03:K1:Z4JFO1al4yfSeyJC5wJvaU8oqEG+h5zWrHcjZ9c6Ssu2yjAVBAr ThIugfScLvblwnGiSRGC035AhzKBggc7kSlIl78J21iJCaBy6yH9+qib4NRuoHL0ohjaln9 Yt3IMODEbPE+NjYoHZYf+0EGGUeUIHcVAc6adrvMaw1nceaLXtftb42l2uEpuwtmiarHTgm 0j4inZ97tjJhfgqn1CXUA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1; V03:K0:7jqD/e/gBYQ=:7qJWDYZ662F5UrEt1A33CS 6R37CMcqiVU4ykjOj0GXK4oq4taWNstVQxoS7qwZ68/X8w0+XMfsthgwNWXn+5oOu5r7t/t33 aobcyYCn9n911nDzjEpQ5rh+NRsJNWjz9UtrwXuYJOqxZ+yBkn5uafgHU7zaQe47vsT8DeY3N Tuac9tsfiGklUHDvIn+y1Ccti2W3H8kqSPe6MKXh/4lVuXZLjdrioHmCfqQ6hMdWdaKExsa/V SOQ0VOLPjhXTkGqfy0CP569HW/mYFG6hB82CkPf5QAPl/iewQ7M5oo6/kyM8Fk2JqSq2R8J+u pjd3nIzWRzj8paS1PDxdc3j0m9HYExFpb5tECmmpVYN2OkC5a6nB0mGQjxbu0Nw+tQov3xxk0 JjwDIhpI0I8lHWPANrA9btZksNuJozgZMeuO+yXho5p1rDuQPZ28Vm62YAAjmDMO10OcVmBIV k2j41w3+UsfQZxbJVtqZmzg2ZV1jH5PFW44Js79fUzhFgpggvpfBqyiF+7np8cIGEFYEcYsBo WS9RqHTHBDv0Z5MSk9yzT5nGZefv6wdr2ce0PqlKCfMW8VJrQQeCnQTgzM6AFXQp/9A4y1KFz d6ub3sN5PCC5vDm8lXVlS3odkDuMRn2sdpYf10Y0Sn0cV7aqmNua8HuuJdSAKLzVCFS1FOh05 NAzy6dsDOzwZuv9MXod2yoPuUH+SKWLNqoGXgyVkq5Ac+ws07Svy563v5uUzzWm4Jj+JJQBrB OV1YOw5Btxlkn9+ze5BKRiP88lt9i+oTVbu3ow== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The dependency to ensure this driver links correctly fails since it can not be a loadable module: drivers/usb/phy/phy-fsl-usb.o: In function `fsl_otg_set_peripheral': phy-fsl-usb.c:(.text+0x2224): undefined reference to `usb_gadget_vbus_disconnect' Make the option 'tristate' so it can work correctly. Fixes: 5a8d651a2bde ("usb: gadget: move gadget API functions to udc-core") Signed-off-by: Arnd Bergmann --- drivers/usb/phy/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.20.0 diff --git a/drivers/usb/phy/Kconfig b/drivers/usb/phy/Kconfig index 8c509b060c09..24b4f091acb8 100644 --- a/drivers/usb/phy/Kconfig +++ b/drivers/usb/phy/Kconfig @@ -21,7 +21,7 @@ config AB8500_USB in host mode, low speed. config FSL_USB2_OTG - bool "Freescale USB OTG Transceiver Driver" + tristate "Freescale USB OTG Transceiver Driver" depends on USB_EHCI_FSL && USB_FSL_USB2 && USB_OTG_FSM=y && PM depends on USB_GADGET || !USB_GADGET # if USB_GADGET=m, this can't be 'y' select USB_PHY