From patchwork Tue Jan 24 19:23:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Halaney X-Patchwork-Id: 646734 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50468C25B4E for ; Tue, 24 Jan 2023 19:25:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233821AbjAXTZG (ORCPT ); Tue, 24 Jan 2023 14:25:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56972 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233674AbjAXTZE (ORCPT ); Tue, 24 Jan 2023 14:25:04 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CFF6C4A1D0 for ; Tue, 24 Jan 2023 11:24:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674588256; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=4WB4RVNTtSVsWxg/OWT04rDFXeCGeyIjYVVHkWC7fDo=; b=XsGN5RiZ/LpQKUoZHPh0CGG8so+tauZcJs58fE0nM1ZWmssibnSw1L9whR4uavHOstKwma v/DxlRhW99yOoTRA58pTt+yoC21vElYfqSUgrqvyN8H5AcnV7lWaR4WkKIlCHJDyZP5B8F z/XdvP/hb7Q4FX12EjiVdCtK7kikiC4= Received: from mail-ot1-f72.google.com (mail-ot1-f72.google.com [209.85.210.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-619-95NDrJDiNc2X4NCG5kFKFw-1; Tue, 24 Jan 2023 14:24:15 -0500 X-MC-Unique: 95NDrJDiNc2X4NCG5kFKFw-1 Received: by mail-ot1-f72.google.com with SMTP id y18-20020a9d6352000000b00686b3ef5990so5999042otk.11 for ; Tue, 24 Jan 2023 11:24:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4WB4RVNTtSVsWxg/OWT04rDFXeCGeyIjYVVHkWC7fDo=; b=QdeBVoDh0xXG71XjPsApmHXivjkmmcqpG9Wh+fPWw3EiTTEz/DdDR091n9eleE119M FIOvuS8j6xb8HpUxO7Mk/rzssbgKFIHTF9CNOLf97Xb38L/mrLtVHw0g/86+nON1jTYm 7l8xvFJ3ut9uXwtRETncA3lBSdfEVhQ5/Qsbox+sDU2h66hy64+a01WGlw8OYnthNGPC Qa33Kf7k7LuSztgI210Ibk/HIno78kxZw++WQgsCtr1sq3OlAInY5qz8txxSNoJXJaeJ wesCyi4aeMFbmLGlf4iitsqd6kUqJzdOFvYzuZa1tk2vq9SvjL94ufd+72L0BZT9kBfX 9Ndw== X-Gm-Message-State: AFqh2koJr7OZY2nXczapWKZaFFsTCYUuk6e0UBhW3W5Vl7PfJQv/dudg sHlWh5YDDol4jySLyfGk+9YuJ6sp3a9chHEuAKJt8A2EC0dhq0XjLQ/UfzPoefWEJky+anfHeOC zEY6O87d0dJk4FtyoQ6qvIA== X-Received: by 2002:aca:5c02:0:b0:360:d307:c23c with SMTP id q2-20020aca5c02000000b00360d307c23cmr22861288oib.25.1674588254900; Tue, 24 Jan 2023 11:24:14 -0800 (PST) X-Google-Smtp-Source: AMrXdXsog8kKzcxuE4ReEeDYYDwpVwYcFmeuMgO4j1ffGvei1d7DVnAfGxHfb0us4boOewGQ1yPGEA== X-Received: by 2002:aca:5c02:0:b0:360:d307:c23c with SMTP id q2-20020aca5c02000000b00360d307c23cmr22861275oib.25.1674588254579; Tue, 24 Jan 2023 11:24:14 -0800 (PST) Received: from halaney-x13s.attlocal.net ([2600:1700:1ff0:d0e0::21]) by smtp.gmail.com with ESMTPSA id r21-20020a056808211500b0036e3bb67a20sm1388024oiw.38.2023.01.24.11.24.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Jan 2023 11:24:14 -0800 (PST) From: Andrew Halaney To: andersson@kernel.org Cc: agross@kernel.org, konrad.dybcio@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, bmasney@redhat.com, quic_shazhuss@quicinc.com, Andrew Halaney Subject: [PATCH 1/2] arm64: dts: qcom: sa8540p-ride: Fix some i2c pinctrl settings Date: Tue, 24 Jan 2023 13:23:50 -0600 Message-Id: <20230124192351.695838-1-ahalaney@redhat.com> X-Mailer: git-send-email 2.39.0 MIME-Version: 1.0 Content-type: text/plain Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Some of the pinctrl groups were invalid for the selected pins. Select the proper qup group to fix these warnings: [ 6.523566] sc8280xp-tlmm f100000.pinctrl: invalid group "gpio135" for function "qup15" [ 6.535042] sc8280xp-tlmm f100000.pinctrl: invalid group "gpio136" for function "qup15" [ 6.597536] sc8280xp-tlmm f100000.pinctrl: invalid group "gpio158" for function "qup15" [ 6.597544] sc8280xp-tlmm f100000.pinctrl: invalid group "gpio159" for function "qup15" [ 6.597991] sc8280xp-tlmm f100000.pinctrl: invalid group "gpio0" for function "qup15" [ 6.597996] sc8280xp-tlmm f100000.pinctrl: invalid group "gpio1" for function "qup15" Fixes: e073899ec3e1 ("arm64: dts: qcom: sa8540p-ride: add i2c nodes") Signed-off-by: Andrew Halaney --- arch/arm64/boot/dts/qcom/sa8540p-ride.dts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sa8540p-ride.dts b/arch/arm64/boot/dts/qcom/sa8540p-ride.dts index eacc1764255b..cb9fbdeb5a9e 100644 --- a/arch/arm64/boot/dts/qcom/sa8540p-ride.dts +++ b/arch/arm64/boot/dts/qcom/sa8540p-ride.dts @@ -318,21 +318,21 @@ &xo_board_clk { &tlmm { i2c0_default: i2c0-default-state { pins = "gpio135", "gpio136"; - function = "qup15"; + function = "qup0"; drive-strength = <2>; bias-pull-up; }; i2c1_default: i2c1-default-state { pins = "gpio158", "gpio159"; - function = "qup15"; + function = "qup1"; drive-strength = <2>; bias-pull-up; }; i2c12_default: i2c12-default-state { pins = "gpio0", "gpio1"; - function = "qup15"; + function = "qup12"; drive-strength = <2>; bias-pull-up; }; From patchwork Tue Jan 24 19:23:51 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Halaney X-Patchwork-Id: 646135 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD9D2C25B4E for ; Tue, 24 Jan 2023 19:25:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233900AbjAXTZS (ORCPT ); Tue, 24 Jan 2023 14:25:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57132 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233959AbjAXTZQ (ORCPT ); Tue, 24 Jan 2023 14:25:16 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0DA9349949 for ; Tue, 24 Jan 2023 11:24:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674588264; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cO6b+dBIzWhUJ0Ot0Nn16J8i3J9gyi8QLbDA6Oroy1E=; b=B1NXQj/96QP3d1RKURPicgtZDFE7li6G6jwsydeSDrrKLX8PSkIGgxZp5hVkyhTLRcPTE9 mC6iKU1It6LFFYRo9vA+M7SXWrJU5ZFM7Et62WBdsAR/YRcG+8lD/5cvcEUVIvTcKGWfji LOpz27jHDcu2y5I/uqAc/ongbGWbBEs= Received: from mail-oa1-f69.google.com (mail-oa1-f69.google.com [209.85.160.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-259-8nTXuWj8N6eDabM4oQzxEQ-1; Tue, 24 Jan 2023 14:24:22 -0500 X-MC-Unique: 8nTXuWj8N6eDabM4oQzxEQ-1 Received: by mail-oa1-f69.google.com with SMTP id 586e51a60fabf-15fd4dc0ee3so4608554fac.13 for ; Tue, 24 Jan 2023 11:24:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cO6b+dBIzWhUJ0Ot0Nn16J8i3J9gyi8QLbDA6Oroy1E=; b=29YZjOW/JwGnFzR8Vd+Rtd66rjDIbPbcMVhboTpM1ulVrT2thgkBXez4lP6pUic+OP 2+fFczIlCBrP6XxhhVl3psWRmJQVXIlxu9vmuUOOL4IQNBXib+5Tlc671lLJ/h9asv+2 3BDgU44IIo0m4LO8YyBf8nMNWNdHWPaYXNIDtMyLpCfw2yH1pUvgKzjNwPtGjX7SYO21 qZtsFPw4uMFGlzCs2nHGEiPA7hTYTXWh+l/lk6DodJOQFWF/GZCOTvkyCP+iDeIDK24Z cPQeEPh9C3Cwj/xoOTXW37wM4Tq12U9XQ5xXXnv4hYAvNkx2oLUNT67lJuJCNt7iO/g5 wZ+w== X-Gm-Message-State: AFqh2kooF6d90JjV0U/sfqmCxkBtegUNCGNDS94q8MAFz2G+Ef252pWI 7ovQWn2yzv3ZfYAZ9HtPfZ8bmtPzrCv+AY+UVs26GvT2L3xL1bhbSEDKWNDLODi7GXUbB8dMCw+ fEEOgSSj6v9C1QS0jqp6Hrg== X-Received: by 2002:a05:6808:300e:b0:364:f962:afd1 with SMTP id ay14-20020a056808300e00b00364f962afd1mr15578557oib.56.1674588262026; Tue, 24 Jan 2023 11:24:22 -0800 (PST) X-Google-Smtp-Source: AMrXdXtXJqXdze5ERKsi/TEq4I3Qn8MLneaaxsNGXIqSS/Q8exKfwqcnDFs/GLX78SPVbd3lckA+0A== X-Received: by 2002:a05:6808:300e:b0:364:f962:afd1 with SMTP id ay14-20020a056808300e00b00364f962afd1mr15578541oib.56.1674588261773; Tue, 24 Jan 2023 11:24:21 -0800 (PST) Received: from halaney-x13s.attlocal.net ([2600:1700:1ff0:d0e0::21]) by smtp.gmail.com with ESMTPSA id r21-20020a056808211500b0036e3bb67a20sm1388024oiw.38.2023.01.24.11.24.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Jan 2023 11:24:21 -0800 (PST) From: Andrew Halaney To: andersson@kernel.org Cc: agross@kernel.org, konrad.dybcio@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, bmasney@redhat.com, quic_shazhuss@quicinc.com, Andrew Halaney Subject: [PATCH 2/2] arm64: dts: qcom: sa8540p-ride: Document i2c busses Date: Tue, 24 Jan 2023 13:23:51 -0600 Message-Id: <20230124192351.695838-2-ahalaney@redhat.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230124192351.695838-1-ahalaney@redhat.com> References: <20230124192351.695838-1-ahalaney@redhat.com> MIME-Version: 1.0 Content-type: text/plain Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org It isn't obvious in the current devicetree what is connected. Go ahead and document what's on the other end. Signed-off-by: Andrew Halaney --- Not sure if this sort of patch is actually welcomed or not but I went through this exercise (for the prior patch) and thought it might be useful to document. Shazad, this also highlights (unless I misread things) that i2c12 has no use for us, right? If agreed I can remove it but sorting through the lore links that provided all this it seems like at the time it was desired to be added. Thanks, Andrew arch/arm64/boot/dts/qcom/sa8540p-ride.dts | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sa8540p-ride.dts b/arch/arm64/boot/dts/qcom/sa8540p-ride.dts index cb9fbdeb5a9e..3478ab91fe73 100644 --- a/arch/arm64/boot/dts/qcom/sa8540p-ride.dts +++ b/arch/arm64/boot/dts/qcom/sa8540p-ride.dts @@ -317,6 +317,7 @@ &xo_board_clk { &tlmm { i2c0_default: i2c0-default-state { + /* To USB7002T-I/KDXVA0 USB hub (SIP1 only) */ pins = "gpio135", "gpio136"; function = "qup0"; drive-strength = <2>; @@ -324,6 +325,7 @@ i2c0_default: i2c0-default-state { }; i2c1_default: i2c1-default-state { + /* To PM40028B-F3EI PCIe switch */ pins = "gpio158", "gpio159"; function = "qup1"; drive-strength = <2>; @@ -331,6 +333,7 @@ i2c1_default: i2c1-default-state { }; i2c12_default: i2c12-default-state { + /* Not connected */ pins = "gpio0", "gpio1"; function = "qup12"; drive-strength = <2>; @@ -338,6 +341,7 @@ i2c12_default: i2c12-default-state { }; i2c15_default: i2c15-default-state { + /* To display connector (SIP1 only) */ pins = "gpio36", "gpio37"; function = "qup15"; drive-strength = <2>; @@ -345,6 +349,7 @@ i2c15_default: i2c15-default-state { }; i2c18_default: i2c18-default-state { + /* To ASM330LHH IMU (SIP1 only) */ pins = "gpio66", "gpio67"; function = "qup18"; drive-strength = <2>;