From patchwork Thu Apr 18 08:17:32 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Corentin Labbe X-Patchwork-Id: 162444 Delivered-To: patch@linaro.org Received: by 2002:a02:c6d8:0:0:0:0:0 with SMTP id r24csp448280jan; Thu, 18 Apr 2019 01:17:54 -0700 (PDT) X-Google-Smtp-Source: APXvYqwHi/a52b1+NXWOM062t0o0a9QXlrpPHk26LRdqpT965HAIqhWmNCwphJB3mzk2+RcPxe3/ X-Received: by 2002:a17:902:f08a:: with SMTP id go10mr91036650plb.121.1555575474480; Thu, 18 Apr 2019 01:17:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555575474; cv=none; d=google.com; s=arc-20160816; b=Avjik9LYl+DNbvn+uCETjMhjQWmME2GVp6KsOh5E/hcxpOsgHNzZs+qC5eqhgjiNY7 kfYlbGOkQ0oQQ+nKa2/eisWBrOxjdhY7BGRIy4XglQ/Q5EAABLerRkQE9ma+aqfydC27 BjTir4EPtGmDb7Wm7qIFa2ubAyVUsgmTz6A6jxzG14HzqVbpKxoOeo7zAAK5JUzb2a2C b2cOzRh5oHWSoydavmTtyCwaEgykf3BwxyUZ11CG3WSMUpid5Pp37gGnIt8Lz3MOcUPA qiBqFyVHGmMDQg2SOCQ6PPtFJvo/ISasOS6O73qJO6Q6F0/cH/3sMvVC7RBFZ4X/PfGL vPIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=lbhj8bDRlGdjkw0r97iacsqSjh2r3SUzy01sQ+arMeo=; b=aDxNMNBgm4PDlmk4CO+phSgGGBI9oB5fejNO3GIQvnf8oIfg41UKVs/vfx+zv5U5gl jpyaHYpOPA9PE6fYJULSV5ZSwstiaICNYCmrY01/rodNSqZPkAArJhTMeJaf6ArC3Fc+ xfev8217ciEW5YwSVKNV+SpNO0J/BCu4GhHZpeju0759r6+/9JwEjuzjNAPvoP3UdRC+ l7UGDThJhecb5KVLnbPfYxmfH8iqc/+MI4EWF3gMyfkXL31KlumL9bhYHGB/ytzNsf19 wtZW/vwducImoEtVWoYNExbUZ5D4dB3bE9o5YciC5Hxu6Q7Zwlqja88/pUQe90uc18Ia mYTw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="i/W+vQnM"; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z143si1748036pfc.64.2019.04.18.01.17.54; Thu, 18 Apr 2019 01:17:54 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="i/W+vQnM"; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726162AbfDRIRw (ORCPT + 3 others); Thu, 18 Apr 2019 04:17:52 -0400 Received: from mail-wr1-f68.google.com ([209.85.221.68]:45247 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388219AbfDRIRv (ORCPT ); Thu, 18 Apr 2019 04:17:51 -0400 Received: by mail-wr1-f68.google.com with SMTP id s15so1783623wra.12; Thu, 18 Apr 2019 01:17:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=lbhj8bDRlGdjkw0r97iacsqSjh2r3SUzy01sQ+arMeo=; b=i/W+vQnMNWVRXvSrVDeiwlrhl2QeYwQKlLnhehk28cSRDI5UC48p5HU4zSVczDl/dt hhBlKFMsr6c2h37TdvN3cOvYv+hI9zcIBQugK5oWfr/1R+AxnghN0pXNgSh15aGngAvk uuhKu9VWyA79Yv9fX8x2qITn8jlt0j+MhL/J5Ac81WENb2JphmXnEQq2QXGbajuiTtGS SdB9WGNi59R1qVnjrkbj53M2bCvxczYwC2I9VoNAu1IXagQzIP/KpeyJHCLp57m3Hykk ajim3OiK30xZ+P08Xnd4iDQ2q0BjCxqHAT3sMLpmNDIanPRpIaZbdyObPdoKJ0CetVOH Un4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=lbhj8bDRlGdjkw0r97iacsqSjh2r3SUzy01sQ+arMeo=; b=jbacYlhfLWwAsjgeq8RNhOxqXpOZfuGfYcQW+mfcSqPfqeD4FzhO5CNv3M2v48xfLp Eo/z5D8B29rCtUEeP1e7l+mfBzIUU7u2JxbhyrkztRn+yni7yEwuxgL0VcDBzT2DLV/t alP3ajXsiZzJpbDnb+DZai6QCrEDMwEgN/xCliBz78KhYAR99GZubXVzeKCmA1fKuA1c PLfXXNVEasKHD+ue5ey2l5YxJs6/IWte9I0zdoa1lpsoPP0aTuMVcnjj4xDiYhR/RWtC DfO+h4QetGX3W3qoARuhff8oLz5tHFQCWXyT9KeyUAT9wbOeZZgtVVJisBuGaHUrvOXv rYSQ== X-Gm-Message-State: APjAAAVOQIn4edTkIhADKKRHc/7PF7fuUyq/2UECLYWUjhF9Z0XlC9lX 4DxI/wNqZvZQKvKowsNwCtQ= X-Received: by 2002:adf:b68d:: with SMTP id j13mr63110093wre.50.1555575469910; Thu, 18 Apr 2019 01:17:49 -0700 (PDT) Received: from Red.localdomain ([2a01:cb1d:147:7200:2e56:dcff:fed2:c6d6]) by smtp.googlemail.com with ESMTPSA id w11sm2350619wre.15.2019.04.18.01.17.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 18 Apr 2019 01:17:49 -0700 (PDT) From: Corentin Labbe To: davem@davemloft.net, herbert@gondor.apana.org.au, maxime.ripard@bootlin.com, wens@csie.org Cc: linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com, ebiggers@kernel.org, Corentin Labbe Subject: [PATCH 1/4] crypto: sun4i-ss: Handle better absence/presence of IV Date: Thu, 18 Apr 2019 10:17:32 +0200 Message-Id: <20190418081735.19002-2-clabbe.montjoie@gmail.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190418081735.19002-1-clabbe.montjoie@gmail.com> References: <20190418081735.19002-1-clabbe.montjoie@gmail.com> MIME-Version: 1.0 Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org This patch remove the test against areq->info since sun4i-ss could work without it (ECB). Fixes: 6298e948215f ("crypto: sunxi-ss - Add Allwinner Security System crypto accelerator") Signed-off-by: Corentin Labbe --- drivers/crypto/sunxi-ss/sun4i-ss-cipher.c | 10 ---------- 1 file changed, 10 deletions(-) -- 2.21.0 diff --git a/drivers/crypto/sunxi-ss/sun4i-ss-cipher.c b/drivers/crypto/sunxi-ss/sun4i-ss-cipher.c index 06df336488fb..4b60f8fdd1c8 100644 --- a/drivers/crypto/sunxi-ss/sun4i-ss-cipher.c +++ b/drivers/crypto/sunxi-ss/sun4i-ss-cipher.c @@ -41,11 +41,6 @@ static int sun4i_ss_opti_poll(struct skcipher_request *areq) if (!areq->cryptlen) return 0; - if (!areq->iv) { - dev_err_ratelimited(ss->dev, "ERROR: Empty IV\n"); - return -EINVAL; - } - if (!areq->src || !areq->dst) { dev_err_ratelimited(ss->dev, "ERROR: Some SGs are NULL\n"); return -EINVAL; @@ -157,11 +152,6 @@ static int sun4i_ss_cipher_poll(struct skcipher_request *areq) if (!areq->cryptlen) return 0; - if (!areq->iv) { - dev_err_ratelimited(ss->dev, "ERROR: Empty IV\n"); - return -EINVAL; - } - if (!areq->src || !areq->dst) { dev_err_ratelimited(ss->dev, "ERROR: Some SGs are NULL\n"); return -EINVAL; From patchwork Thu Apr 18 08:17:33 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Corentin Labbe X-Patchwork-Id: 162445 Delivered-To: patch@linaro.org Received: by 2002:a02:c6d8:0:0:0:0:0 with SMTP id r24csp448360jan; Thu, 18 Apr 2019 01:18:00 -0700 (PDT) X-Google-Smtp-Source: APXvYqzCHnbPbqfb3kllz4tPTI0InsYOG1fPwfpwBM9TqVgl4Lf4tqIZ0C8ED+2Nc/X8khYyV6YK X-Received: by 2002:a62:b602:: with SMTP id j2mr95633616pff.68.1555575480296; Thu, 18 Apr 2019 01:18:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555575480; cv=none; d=google.com; s=arc-20160816; b=CN+SxpwWCwZBq+qrxpIk06K8PZP74N+9LtpiV0tHU4EnFtzjYVo7yqJq+2f2BbLaOq ZPxI/odv2CApVyTp8uU+HWmonmWm8iZehvEj0A/8M1grdyONiYbL7pegn1aLUzp0sqxc 9BCKGobe1fM38Z9Gk8Bmn1WtdpVlWH30Sj8N2DEAZm8t5slxvSQs9bCMGtWuIvcrlwxq irV4z5Uvpgx18GetQxIzD2NezQUH1AFQvgwE2iUUKAe2Wo4wc9DF3o6W3cCbTCIIOeMu B/CEzrtSGOv4K697d0rv1bLoz0hDL2GbsOXelVEULBLTaQoapkwdr+gtC8kCTAJiS5Uq Tr/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=2Oa4Mo8b8dqWphkeFQAL0N8F8rFHV+7qiodUTdHFrPA=; b=Mh5vxq825D/cExxnvHwq/GsDtPxNnuNmnduOsTDa7csVB2br7+tO64KxSvaEWV3V3k UiNyyYnYVP7dQ/oTxpSwKDHNi38FNzjNg5KIRaUeBLIHTfCCPQKk9oXrUc2jJ7n8jOIc zA9lqIt6wbppeL2LrYopASrUQEbUdKEk/JHuNpqJgOLeJJW1taAXnl7m4hGyL73MDrQt xDgnDSAC3f7DDOAeC9S7Bu5DnyhMh8+7abgdBEylavK9PAhfkv+bNaFoOmrhTSxUnWuu 70nFX+IowU4yYMWp013uDkBlCDNvca7Yzbil0SKVLLz/EWGAImuzDltKJmtpwurPXQpZ 9ggQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=A9S7ERqP; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w21si1352870pgj.513.2019.04.18.01.18.00; Thu, 18 Apr 2019 01:18:00 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=A9S7ERqP; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388304AbfDRIR7 (ORCPT + 3 others); Thu, 18 Apr 2019 04:17:59 -0400 Received: from mail-wr1-f65.google.com ([209.85.221.65]:39498 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733205AbfDRIRx (ORCPT ); Thu, 18 Apr 2019 04:17:53 -0400 Received: by mail-wr1-f65.google.com with SMTP id j9so1817520wrn.6; Thu, 18 Apr 2019 01:17:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=2Oa4Mo8b8dqWphkeFQAL0N8F8rFHV+7qiodUTdHFrPA=; b=A9S7ERqPxCdpYEOO92/iiqJT0FDISgCqfUojAtdwbZVNI3kDYFplGyNoamMhpzotXd +KB6YmhtdMoB9V+HrBw8kozqvClVqD2zD1nvx1zoNJ3p/7nWdA/M86IACynN2APSX3d1 84t3EYpYiwqCBUxxvku+zmuBnhoz/8Hfpi0c2LDRQ6pddGY58ot5mT4ud/yLtHh+acdz ozW+P11h5X9NFwtUrw1GGrd7fGH1uzoAhk5ELgqgIMJ3MOf33/3FHpdM5XyPuVrPV46i 9JNXdvvTWpJTHLOgCJfW8RLwhzqluP+Ofy3uI/PyU9L/w8jRDTWc741lFzqYxqyUmvik ABdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=2Oa4Mo8b8dqWphkeFQAL0N8F8rFHV+7qiodUTdHFrPA=; b=eQxJc/5lw0wFhNGZVa53yqJFCYwGwVNg7WlEEfBkZ55GkRzYi3U5bEpS16S7ppi/EG Qe4kfXOMwnkQxRsH3N9ZBsMOa1uw9EnOi7muVlJ1L03hvGQvFoFRUCRoS+L1pnvLyQF5 G14O3JrlFFcC/4EZydMxWlmGLqfMC/g5ma1CS6PcjSkbVGbEwAOgs2DYPMSD2YH2Uv5+ GBPy7V2+yBxMByVEMXIFaoosGhE3jTRQTO7e/83LAVZSYVjHEoO0t1FZEb/t1F63YsF1 IB15jKUm4T2na247J2CnhJ+1Nd42oILYNZ5/+9Kn8jBerEHsRhRhZWBbkerYLHxUKsMO 5b9w== X-Gm-Message-State: APjAAAUWL7Vkcmu9NaIqNRhxMOePN3LAS6HKa2Uf9pkiHszeRmEppuxY XIQVDoEPwbISo/LotjQlDvM= X-Received: by 2002:adf:f90c:: with SMTP id b12mr36495886wrr.63.1555575471082; Thu, 18 Apr 2019 01:17:51 -0700 (PDT) Received: from Red.localdomain ([2a01:cb1d:147:7200:2e56:dcff:fed2:c6d6]) by smtp.googlemail.com with ESMTPSA id w11sm2350619wre.15.2019.04.18.01.17.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 18 Apr 2019 01:17:50 -0700 (PDT) From: Corentin Labbe To: davem@davemloft.net, herbert@gondor.apana.org.au, maxime.ripard@bootlin.com, wens@csie.org Cc: linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com, ebiggers@kernel.org, Corentin Labbe Subject: [PATCH 2/4] crypto: sun4i-ss: remove ivsize from ECB Date: Thu, 18 Apr 2019 10:17:33 +0200 Message-Id: <20190418081735.19002-3-clabbe.montjoie@gmail.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190418081735.19002-1-clabbe.montjoie@gmail.com> References: <20190418081735.19002-1-clabbe.montjoie@gmail.com> MIME-Version: 1.0 Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org ECB algos does not need IV. Fixes: 6298e948215f ("crypto: sunxi-ss - Add Allwinner Security System crypto accelerator") Signed-off-by: Corentin Labbe --- drivers/crypto/sunxi-ss/sun4i-ss-core.c | 2 -- 1 file changed, 2 deletions(-) -- 2.21.0 diff --git a/drivers/crypto/sunxi-ss/sun4i-ss-core.c b/drivers/crypto/sunxi-ss/sun4i-ss-core.c index 6b2e186dfa8b..3d9c5ad6cbb8 100644 --- a/drivers/crypto/sunxi-ss/sun4i-ss-core.c +++ b/drivers/crypto/sunxi-ss/sun4i-ss-core.c @@ -107,7 +107,6 @@ static struct sun4i_ss_alg_template ss_algs[] = { .decrypt = sun4i_ss_ecb_aes_decrypt, .min_keysize = AES_MIN_KEY_SIZE, .max_keysize = AES_MAX_KEY_SIZE, - .ivsize = AES_BLOCK_SIZE, .base = { .cra_name = "ecb(aes)", .cra_driver_name = "ecb-aes-sun4i-ss", @@ -190,7 +189,6 @@ static struct sun4i_ss_alg_template ss_algs[] = { .decrypt = sun4i_ss_ecb_des3_decrypt, .min_keysize = DES3_EDE_KEY_SIZE, .max_keysize = DES3_EDE_KEY_SIZE, - .ivsize = DES3_EDE_BLOCK_SIZE, .base = { .cra_name = "ecb(des3_ede)", .cra_driver_name = "ecb-des3-sun4i-ss",